[dovecot-cvs] dovecot/src/master login-process.c,1.26,1.27

cras at procontrol.fi cras at procontrol.fi
Thu Jan 9 14:05:29 EET 2003


Update of /home/cvs/dovecot/src/master
In directory danu:/tmp/cvs-serv32311/master

Modified Files:
	login-process.c 
Log Message:
Don't leak fds in case of errors.



Index: login-process.c
===================================================================
RCS file: /home/cvs/dovecot/src/master/login-process.c,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -d -r1.26 -r1.27
--- login-process.c	8 Jan 2003 21:13:05 -0000	1.26
+++ login-process.c	9 Jan 2003 12:05:26 -0000	1.27
@@ -127,6 +127,11 @@
 			i_error("login: fd_read() failed: %m");
 		}
 
+		if (client_fd != -1) {
+			if (close(client_fd) < 0)
+				i_error("close(imap client) failed: %m");
+		}
+
 		login_process_destroy(p);
 		return;
 	}
@@ -147,6 +152,8 @@
 	   it's not trying to exploit us */
 	if (!VALIDATE_STR(req.login_tag)) {
 		i_error("login: Received corrupted data");
+		if (close(client_fd) < 0)
+			i_error("close(imap client) failed: %m");
 		login_process_destroy(p);
 		return;
 	}




More information about the dovecot-cvs mailing list