[dovecot-cvs] dovecot/src/auth passdb-ldap.c, 1.12, 1.13 passdb-sql.c, 1.6, 1.7

cras at dovecot.org cras at dovecot.org
Mon Nov 1 15:31:03 EET 2004


Update of /var/lib/cvs/dovecot/src/auth
In directory talvi:/tmp/cvs-serv2196

Modified Files:
	passdb-ldap.c passdb-sql.c 
Log Message:
Fixed memory leaks.



Index: passdb-ldap.c
===================================================================
RCS file: /var/lib/cvs/dovecot/src/auth/passdb-ldap.c,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -d -r1.12 -r1.13
--- passdb-ldap.c	21 Oct 2004 02:23:12 -0000	1.12
+++ passdb-ldap.c	1 Nov 2004 13:31:00 -0000	1.13
@@ -121,6 +121,7 @@
 			password, scheme,
 			ldap_request->callback.lookup_credentials,
 			auth_request);
+		i_free(request);
 		return;
 	}
 
@@ -128,6 +129,7 @@
 	if (password == NULL) {
 		ldap_request->callback.verify_plain(PASSDB_RESULT_USER_UNKNOWN,
 						    auth_request);
+		i_free(request);
 		return;
 	}
 
@@ -145,6 +147,7 @@
 	ldap_request->callback.verify_plain(ret > 0 ? PASSDB_RESULT_OK :
 					    PASSDB_RESULT_PASSWORD_MISMATCH,
 					    auth_request);
+	i_free(request);
 }
 
 static void ldap_lookup_pass(struct auth_request *auth_request,

Index: passdb-sql.c
===================================================================
RCS file: /var/lib/cvs/dovecot/src/auth/passdb-sql.c,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -d -r1.6 -r1.7
--- passdb-sql.c	22 Oct 2004 17:47:29 -0000	1.6
+++ passdb-sql.c	1 Nov 2004 13:31:00 -0000	1.7
@@ -105,6 +105,7 @@
 			password, scheme,
 			sql_request->callback.lookup_credentials,
 			auth_request);
+		i_free(sql_request);
 		return;
 	}
 
@@ -112,6 +113,7 @@
 	if (password == NULL) {
 		sql_request->callback.verify_plain(PASSDB_RESULT_USER_UNKNOWN,
 						   auth_request);
+		i_free(sql_request);
 		return;
 	}
 
@@ -129,6 +131,7 @@
 	sql_request->callback.verify_plain(ret > 0 ? PASSDB_RESULT_OK :
 					     PASSDB_RESULT_PASSWORD_MISMATCH,
 					     auth_request);
+	i_free(sql_request);
 }
 
 static void sql_lookup_pass(struct passdb_sql_request *sql_request)



More information about the dovecot-cvs mailing list