dovecot: Don't disable inotify when seeing ESTALE errors.

dovecot at dovecot.org dovecot at dovecot.org
Fri Nov 16 05:20:52 EET 2007


details:   http://hg.dovecot.org/dovecot/rev/f637a8a1aae7
changeset: 6818:f637a8a1aae7
user:      Timo Sirainen <tss at iki.fi>
date:      Fri Nov 16 05:20:48 2007 +0200
description:
Don't disable inotify when seeing ESTALE errors.

diffstat:

1 file changed, 3 insertions(+), 5 deletions(-)
src/lib/ioloop-notify-inotify.c |    8 +++-----

diffs (20 lines):

diff -r 766250fcedd8 -r f637a8a1aae7 src/lib/ioloop-notify-inotify.c
--- a/src/lib/ioloop-notify-inotify.c	Fri Nov 16 05:20:31 2007 +0200
+++ b/src/lib/ioloop-notify-inotify.c	Fri Nov 16 05:20:48 2007 +0200
@@ -101,13 +101,11 @@ enum io_notify_result io_add_notify(cons
 			       IN_CREATE | IN_DELETE | IN_DELETE_SELF |
 			       IN_MOVE | IN_CLOSE | IN_MODIFY);
 	if (wd < 0) {
-		if (errno == ENOENT)
+		/* ESTALE could happen with NFS. Don't bother giving an error
+		   message then. */
+		if (errno == ENOENT || errno == ESTALE)
 			return IO_NOTIFY_NOTFOUND;
 
-		/* ESTALE could happen with NFS. Don't bother giving an error
-		   message then. */
-		if (errno != ESTALE)
-			i_error("inotify_add_watch(%s) failed: %m", path);
 		ctx->disabled = TRUE;
 		return IO_NOTIFY_DISABLED;
 	}


More information about the dovecot-cvs mailing list