dovecot-1.2: imap/pop3: Don't open /dev/urandom at startup. Noth...

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot-1.2/rev/b6aea17ce21e
changeset: 7992:b6aea17ce21e
user:      Timo Sirainen <tss at iki.fi>
date:      Sat Jul 12 01:40:33 2008 +0300
description:
imap/pop3: Don't open /dev/urandom at startup. Nothing needs it.

diffstat:

2 files changed, 12 deletions(-)
src/imap/main.c |    6 ------
src/pop3/main.c |    6 ------

diffs (60 lines):

diff -r b6c6070a38ac -r b6aea17ce21e src/imap/main.c
--- a/src/imap/main.c	Sat Jul 12 00:28:17 2008 +0300
+++ b/src/imap/main.c	Sat Jul 12 01:40:33 2008 +0300
@@ -11,7 +11,6 @@
 #include "restrict-access.h"
 #include "fd-close-on-exec.h"
 #include "process-title.h"
-#include "randgen.h"
 #include "module-dir.h"
 #include "dict-client.h"
 #include "mail-storage.h"
@@ -144,10 +143,6 @@ static void drop_privileges(void)
 
 	/* Log file or syslog opening probably requires roots */
 	open_logfile();
-
-	/* Most likely needed. Have to open /dev/urandom before possible
-	   chrooting. */
-	random_init();
 
 	/* Load the plugins before chrooting. Their init() is called later. */
 	if (getenv("MAIL_PLUGINS") != NULL) {
@@ -281,7 +276,6 @@ static void main_deinit(void)
 	commands_deinit();
         mail_storage_deinit();
 	dict_driver_unregister(&dict_driver_client);
-	random_deinit();
 	pool_unref(&namespace_pool);
 
 	str_free(&capability_string);
diff -r b6c6070a38ac -r b6aea17ce21e src/pop3/main.c
--- a/src/pop3/main.c	Sat Jul 12 00:28:17 2008 +0300
+++ b/src/pop3/main.c	Sat Jul 12 01:40:33 2008 +0300
@@ -11,7 +11,6 @@
 #include "buffer.h"
 #include "istream.h"
 #include "process-title.h"
-#include "randgen.h"
 #include "module-dir.h"
 #include "var-expand.h"
 #include "dict-client.h"
@@ -165,10 +164,6 @@ static void drop_privileges(void)
 
 	/* Log file or syslog opening probably requires roots */
 	open_logfile();
-
-	/* Most likely needed. Have to open /dev/urandom before possible
-	   chrooting. */
-	random_init();
 
 	/* Load the plugins before chrooting. Their init() is called later. */
 	if (getenv("MAIL_PLUGINS") != NULL) {
@@ -267,7 +262,6 @@ static void main_deinit(void)
 	module_dir_unload(&modules);
 	mail_storage_deinit();
 	dict_driver_unregister(&dict_driver_client);
-	random_deinit();
 
 	lib_signals_deinit();
 	closelog();