dovecot-2.0: mail_storage_service_next() didn't always set error...

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot-2.0/rev/03b679cd8d1f
changeset: 10931:03b679cd8d1f
user:      Timo Sirainen <tss at iki.fi>
date:      Tue Mar 16 20:33:18 2010 +0200
description:
mail_storage_service_next() didn't always set error string.

diffstat:

 src/lib-storage/mail-storage-service.c |  8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diffs (25 lines):

diff -r 15860795f158 -r 03b679cd8d1f src/lib-storage/mail-storage-service.c
--- a/src/lib-storage/mail-storage-service.c	Tue Mar 16 20:21:48 2010 +0200
+++ b/src/lib-storage/mail-storage-service.c	Tue Mar 16 20:33:18 2010 +0200
@@ -847,8 +847,9 @@
 				    user_set->mail_chroot);
 
 	if (*home != '/' && *home != '\0') {
-		i_error("user %s: Relative home directory paths not supported: "
-			"%s", user->input.username, home);
+		*error_r = t_strdup_printf("user %s: "
+			"Relative home directory paths not supported: %s",
+			user->input.username, home);
 		return -1;
 	}
 
@@ -859,7 +860,8 @@
 		if (service_drop_privileges(user_set, user->system_groups_user,
 					    home, chroot, disallow_root,
 					    temp_priv_drop, FALSE, &error) < 0) {
-			i_error("Couldn't drop privileges: %s", error);
+			*error_r = t_strdup_printf(
+				"Couldn't drop privileges: %s", error);
 			return -1;
 		}
 		if (!temp_priv_drop ||