dovecot-2.2: imap: Allow fetching [x.MIME] for message/rfc822 ag...

dovecot at dovecot.org dovecot at dovecot.org
Mon Aug 20 10:01:14 EEST 2012


details:   http://hg.dovecot.org/dovecot-2.2/rev/6c55e57c98a1
changeset: 14924:6c55e57c98a1
user:      Timo Sirainen <tss at iki.fi>
date:      Mon Aug 20 10:01:03 2012 +0300
description:
imap: Allow fetching [x.MIME] for message/rfc822 again.
It's not clear which is the correct behavior.

diffstat:

 src/lib-imap-storage/imap-msgpart.c |  13 ++++++-------
 1 files changed, 6 insertions(+), 7 deletions(-)

diffs (23 lines):

diff -r 96fd2c3bf932 -r 6c55e57c98a1 src/lib-imap-storage/imap-msgpart.c
--- a/src/lib-imap-storage/imap-msgpart.c	Mon Aug 20 09:47:28 2012 +0300
+++ b/src/lib-imap-storage/imap-msgpart.c	Mon Aug 20 10:01:03 2012 +0300
@@ -528,13 +528,12 @@
 
 	switch (msgpart->fetch_type) {
 	case FETCH_MIME:
-		if (part->parent == NULL ||
-		    (part->parent->flags & MESSAGE_PART_FLAG_MESSAGE_RFC822) != 0) {
-			/* message/rfc822 itself has no MIME headers */
-			*part_r = NULL;
-			return 0;
-		}
-		break;
+		/* What to do if this is a message/rfc822? Does it have
+		   MIME headers or not? Possibilities are: a) no, return
+		   empty string (UW-IMAP does this), b) return the same as
+		   HEADER. Dovecot has done b) for a long time and it's not
+		   very clear which one is correct, so we'll just continue
+		   with b) */
 	case FETCH_FULL:
 	case FETCH_MIME_BODY:
 		break;


More information about the dovecot-cvs mailing list