dovecot-2.2: dbox: Don't try to finish saving attachments if sav...

dovecot at dovecot.org dovecot at dovecot.org
Wed Aug 29 17:15:40 EEST 2012


details:   http://hg.dovecot.org/dovecot-2.2/rev/8ee60c857513
changeset: 14970:8ee60c857513
user:      Timo Sirainen <tss at iki.fi>
date:      Wed Aug 29 17:15:34 2012 +0300
description:
dbox: Don't try to finish saving attachments if saving has already failed.
Fixes an assert crash with failed CATENATE.

diffstat:

 src/lib-storage/index/dbox-common/dbox-save.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diffs (12 lines):

diff -r bce550bb2b23 -r 8ee60c857513 src/lib-storage/index/dbox-common/dbox-save.c
--- a/src/lib-storage/index/dbox-common/dbox-save.c	Wed Aug 29 16:55:33 2012 +0300
+++ b/src/lib-storage/index/dbox-common/dbox-save.c	Wed Aug 29 17:15:34 2012 +0300
@@ -102,7 +102,7 @@
 	struct mail_save_data *mdata = &ctx->ctx.data;
 	struct ostream *dbox_output = ctx->dbox_output;
 
-	if (mdata->attach != NULL) {
+	if (mdata->attach != NULL && !ctx->failed) {
 		if (index_attachment_save_finish(&ctx->ctx) < 0)
 			ctx->failed = TRUE;
 	}


More information about the dovecot-cvs mailing list