dovecot-2.2: lib-storage: Error logging fixes.

dovecot at dovecot.org dovecot at dovecot.org
Thu Nov 1 12:32:42 EET 2012


details:   http://hg.dovecot.org/dovecot-2.2/rev/d7239a4554e4
changeset: 15366:d7239a4554e4
user:      Timo Sirainen <tss at iki.fi>
date:      Thu Nov 01 12:32:30 2012 +0200
description:
lib-storage: Error logging fixes.

diffstat:

 src/lib-storage/index/index-storage.c  |  8 ++------
 src/lib-storage/index/index-sync-pvt.c |  4 +---
 2 files changed, 3 insertions(+), 9 deletions(-)

diffs (42 lines):

diff -r 626a9df21e62 -r d7239a4554e4 src/lib-storage/index/index-storage.c
--- a/src/lib-storage/index/index-storage.c	Wed Oct 31 14:44:24 2012 +0200
+++ b/src/lib-storage/index/index-storage.c	Thu Nov 01 12:32:30 2012 +0200
@@ -202,10 +202,8 @@
 	if (box->index != NULL)
 		return 0;
 
-	if (mailbox_create_missing_dir(box, MAILBOX_LIST_PATH_TYPE_INDEX) < 0) {
-		mail_storage_set_internal_error(box->storage);
+	if (mailbox_create_missing_dir(box, MAILBOX_LIST_PATH_TYPE_INDEX) < 0)
 		return -1;
-	}
 
 	if (index_mailbox_alloc_index(box, &box->index) < 0)
 		return -1;
@@ -502,10 +500,8 @@
 		path = t_strdup_until(path, p);
 	}
 
-	if ((ret = mailbox_mkdir(box, path, type)) < 0) {
-		mail_storage_copy_list_error(box->storage, box->list);
+	if ((ret = mailbox_mkdir(box, path, type)) < 0)
 		return -1;
-	}
 	mailbox_refresh_permissions(box);
 	if (ret == 0) {
 		/* directory already exists */
diff -r 626a9df21e62 -r d7239a4554e4 src/lib-storage/index/index-sync-pvt.c
--- a/src/lib-storage/index/index-sync-pvt.c	Wed Oct 31 14:44:24 2012 +0200
+++ b/src/lib-storage/index/index-sync-pvt.c	Thu Nov 01 12:32:30 2012 +0200
@@ -18,10 +18,8 @@
 	if (ret <= 0)
 		return ret; /* error / no private indexes */
 
-	if (mailbox_create_missing_dir(box, MAILBOX_LIST_PATH_TYPE_INDEX_PRIVATE) < 0) {
-		mail_storage_set_internal_error(box->storage);
+	if (mailbox_create_missing_dir(box, MAILBOX_LIST_PATH_TYPE_INDEX_PRIVATE) < 0)
 		return -1;
-	}
 
 	box->index_pvt = mail_index_alloc_cache_get(NULL, index_dir,
 		t_strconcat(box->index_prefix, ".pvt", NULL));


More information about the dovecot-cvs mailing list