dovecot-2.2: lib-index: MAIL_INDEX_TRANSACTION_FLAG_AVOID_FLAG_U...

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot-2.2/rev/1a3348e3892f
changeset: 15263:1a3348e3892f
user:      Timo Sirainen <tss at iki.fi>
date:      Mon Oct 29 12:44:43 2012 +0200
description:
lib-index: MAIL_INDEX_TRANSACTION_FLAG_AVOID_FLAG_UPDATES didn't work well enough for keywords.
Removed the code that attempted to optimize some CPU usage at the cost of
writing too many changes.

diffstat:

 src/lib-index/mail-index-transaction-update.c |  11 -----------
 1 files changed, 0 insertions(+), 11 deletions(-)

diffs (28 lines):

diff -r b0a6fe3aa61f -r 1a3348e3892f src/lib-index/mail-index-transaction-update.c
--- a/src/lib-index/mail-index-transaction-update.c	Mon Oct 29 12:43:29 2012 +0200
+++ b/src/lib-index/mail-index-transaction-update.c	Mon Oct 29 12:44:43 2012 +0200
@@ -963,7 +963,6 @@
 			   enum modify_type modify_type,
 			   struct mail_keywords *keywords)
 {
-	struct mail_index_transaction_keyword_update *u;
 	ARRAY_TYPE(keyword_indexes) existing;
 	const unsigned int *existing_idx;
 	unsigned int i, j, existing_count;
@@ -978,16 +977,6 @@
 		return TRUE;
 
 	for (i = 0; i < keywords->count; i++) {
-		u = array_idx_modifiable(&t->keyword_updates,
-					 keywords->idx[i]);
-		if (array_is_created(&u->add_seq) ||
-		    array_is_created(&u->remove_seq)) {
-			/* we've already modified this keyword in the
-			   transaction. don't bother checking it further,
-			   because we can't avoid the changes anyway. */
-			return TRUE;
-		}
-
 		found = FALSE;
 		for (j = 0; j < existing_count; j++) {
 			if (existing_idx[j] == keywords->idx[i]) {