dovecot-2.2: lib-imap-urlauth: Fixed URLAUTH fetch reference cou...

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot-2.2/rev/8f09509323cd
changeset: 16421:8f09509323cd
user:      Stephan Bosch <stephan at rename-it.nl>
date:      Thu May 30 18:03:53 2013 +0300
description:
lib-imap-urlauth: Fixed URLAUTH fetch reference counting for when requests are aborted at deinit.

diffstat:

 src/lib-imap-urlauth/imap-urlauth-fetch.c |  5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diffs (19 lines):

diff -r bb221f236d4f -r 8f09509323cd src/lib-imap-urlauth/imap-urlauth-fetch.c
--- a/src/lib-imap-urlauth/imap-urlauth-fetch.c	Thu May 30 18:03:46 2013 +0300
+++ b/src/lib-imap-urlauth/imap-urlauth-fetch.c	Thu May 30 18:03:53 2013 +0300
@@ -121,11 +121,14 @@
 	i_assert(ufetch->refcount > 0);
 
 	*_ufetch = NULL;
-	if (--ufetch->refcount > 0)
+	if (ufetch->refcount-1 > 0)
 		return;
 
 	imap_urlauth_fetch_abort(ufetch);
 
+	ufetch->refcount--;
+	i_assert(ufetch->refcount == 0);
+
 	/* dont leave the connection in limbo; make sure resume is called */
 	if (ufetch->waiting_service)
 		imap_urlauth_connection_continue(ufetch->uctx->conn);