dovecot-2.2: imap-zlib: Removed check for disallowing COMPRESS t...

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot-2.2/rev/e3b9cd19c33d
changeset: 17957:e3b9cd19c33d
user:      Timo Sirainen <tss at iki.fi>
date:      Tue Oct 14 16:57:13 2014 -0700
description:
imap-zlib: Removed check for disallowing COMPRESS to be used with TLS compression.
Clients shouldn't be doing this in any case, and this check doesn't work
properly with proxies.

We could solve the check properly for Dovecot proxies by having them send
the TLS compression state to backends, but it would still leave non-Dovecot
proxies broken. Although we could just not advertise COMPRESS=DEFLATE
extension if TLS compression is enabled and non-Dovecot proxies at least
wouldn't cause failures. Still, overall seems like a lot of work for such a
small and probably unnecessary extra check.

diffstat:

 src/plugins/imap-zlib/imap-zlib-plugin.c |  5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diffs (15 lines):

diff -r 9ce9e00cc997 -r e3b9cd19c33d src/plugins/imap-zlib/imap-zlib-plugin.c
--- a/src/plugins/imap-zlib/imap-zlib-plugin.c	Tue Oct 14 12:17:36 2014 -0700
+++ b/src/plugins/imap-zlib/imap-zlib-plugin.c	Tue Oct 14 16:57:13 2014 -0700
@@ -87,11 +87,6 @@
 			t_str_ucase(zclient->handler->name)));
 		return TRUE;
 	}
-	if (client->tls_compression) {
-		client_send_tagline(cmd,
-			"NO [COMPRESSIONACTIVE] TLS compression already enabled.");
-		return TRUE;
-	}
 
 	handler = compression_lookup_handler(t_str_lcase(mechanism));
 	if (handler == NULL || handler->create_istream == NULL) {