dovecot-2.2: lib-storage: Removed unnecessary code - nnode is ne...

dovecot at dovecot.org dovecot at dovecot.org
Sun Sep 27 18:51:03 UTC 2015


details:   http://hg.dovecot.org/dovecot-2.2/rev/5af9b91c38c0
changeset: 19229:5af9b91c38c0
user:      Timo Sirainen <tss at iki.fi>
date:      Sun Sep 27 21:34:48 2015 +0300
description:
lib-storage: Removed unnecessary code - nnode is never NULL at this point.
Found by Coverity.

diffstat:

 src/lib-storage/list/mailbox-list-index-notify.c |  12 +++++-------
 1 files changed, 5 insertions(+), 7 deletions(-)

diffs (22 lines):

diff -r 83ccad730ea3 -r 5af9b91c38c0 src/lib-storage/list/mailbox-list-index-notify.c
--- a/src/lib-storage/list/mailbox-list-index-notify.c	Sun Sep 27 21:33:30 2015 +0300
+++ b/src/lib-storage/list/mailbox-list-index-notify.c	Sun Sep 27 21:34:48 2015 +0300
@@ -722,13 +722,11 @@
 	}
 
 	/* update internal state */
-	if (nnode != NULL) {
-		nnode->uidvalidity = status.uidvalidity;
-		nnode->uidnext = status.uidnext;
-		nnode->messages = status.messages;
-		nnode->unseen = status.unseen;
-		nnode->highest_modseq = status.highest_modseq;
-	}
+	nnode->uidvalidity = status.uidvalidity;
+	nnode->uidnext = status.uidnext;
+	nnode->messages = status.messages;
+	nnode->unseen = status.unseen;
+	nnode->highest_modseq = status.highest_modseq;
 	return TRUE;
 }
 


More information about the dovecot-cvs mailing list