From noreply at github.com Thu Dec 1 10:00:09 2016 From: noreply at github.com (GitHub) Date: Thu, 01 Dec 2016 02:00:09 -0800 Subject: [dovecot/core] fb13df: config: Match multiple names in local_name Message-ID: <583ff4a9e2e8f_161cb3fe200d5b138945a5@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: fb13dfaa903c5efb492e993888aa444138001e8e https://github.com/dovecot/core/commit/fb13dfaa903c5efb492e993888aa444138001e8e Author: J. Nick Koston Date: 2016-12-01 (Thu, 01 Dec 2016) Changed paths: M src/config/config-filter.c Log Message: ----------- config: Match multiple names in local_name This can significantly reduce memory usage when using a UCC certificate with multiple names by only loading the certificate and key once. From noreply at github.com Fri Dec 2 21:00:11 2016 From: noreply at github.com (GitHub) Date: Fri, 02 Dec 2016 13:00:11 -0800 Subject: [dovecot/core] 4f7951: dsync: When logging "Mailbox changed caused a desy... Message-ID: <5841e0dbab8ef_1bf53ffc30839138822cd@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 4f7951e71128c120d8a502d6406cc603fcc8eb0b https://github.com/dovecot/core/commit/4f7951e71128c120d8a502d6406cc603fcc8eb0b Author: Timo Sirainen Date: 2016-12-01 (Thu, 01 Dec 2016) Changed paths: M src/doveadm/doveadm-dsync.c M src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c M src/doveadm/dsync/dsync-brain-mailbox.c M src/doveadm/dsync/dsync-brain-mails.c M src/doveadm/dsync/dsync-brain-private.h M src/doveadm/dsync/dsync-brain.c M src/doveadm/dsync/dsync-brain.h M src/doveadm/dsync/dsync-mailbox-import.c M src/doveadm/dsync/dsync-mailbox-import.h Log Message: ----------- dsync: When logging "Mailbox changed caused a desync", log also the reason. The reason is usually somewhere in the debug logs, but it's difficult to find from there. Commit: cabf98de0145c8e233e41073fe3f8c1cc85ed1eb https://github.com/dovecot/core/commit/cabf98de0145c8e233e41073fe3f8c1cc85ed1eb Author: Timo Sirainen Date: 2016-12-02 (Fri, 02 Dec 2016) Changed paths: M src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c Log Message: ----------- dsync: Add mailbox names as well as GUIDs to log messages. Commit: d640b628f27c9bbcbf6fe902b257002a3f0da57b https://github.com/dovecot/core/commit/d640b628f27c9bbcbf6fe902b257002a3f0da57b Author: Timo Sirainen Date: 2016-12-02 (Fri, 02 Dec 2016) Changed paths: M src/lib-dict/dict-client.c Log Message: ----------- dict-client: Don't timeout lookups without waiting 1sec in dict ioloop. What could have happened was: - dict-client sends a request to dict-server - dict-client process starts doing something else - dict-server answers - dict-client process continues doing something else for over 30 seconds, not reading the dict-server answer - dict-client process gets back to dict ioloop, which runs the timeout before checking if there is anything available for reading. Now we'll wait for 1 second in the last dict ioloop before assuming that there's a timeout. Commit: 44e07ea4de493626c862e98516decb8dfa22ab1d https://github.com/dovecot/core/commit/44e07ea4de493626c862e98516decb8dfa22ab1d Author: Timo Sirainen Date: 2016-12-02 (Fri, 02 Dec 2016) Changed paths: M src/lib-storage/list/mailbox-list-index-status.c Log Message: ----------- lib-storage: Return vsize=0 from mailbox list index for empty mailboxes. If it's known that the mailbox has no mails, there's no reason to open the mailbox to see that its size is 0. Commit: c8bac7666cdc780a3390110e420350fffb62b909 https://github.com/dovecot/core/commit/c8bac7666cdc780a3390110e420350fffb62b909 Author: Timo Sirainen Date: 2016-12-02 (Fri, 02 Dec 2016) Changed paths: M src/lib/seq-range-array.c M src/lib/test-seq-range-array.c Log Message: ----------- lib: seq_range_array_*(): Fix seq2=2^32-1 handling Adding/merging it when it already existed added duplicated seq_range. Commit: df8046c9a4f6bc2a478ad1e74504d50f3110c906 https://github.com/dovecot/core/commit/df8046c9a4f6bc2a478ad1e74504d50f3110c906 Author: Timo Sirainen Date: 2016-12-02 (Fri, 02 Dec 2016) Changed paths: M src/lib-storage/mail-search-args-simplify.c M src/lib-storage/test-mail-search-args-simplify.c Log Message: ----------- lib-storage: Fix simplifying sequence sets and UID sets. They were being handled completely wrong. The unit tests testing them were also completely wrong. Commit: b1533bd0dd0787b9c0d879c2d7398b1ff7964570 https://github.com/dovecot/core/commit/b1533bd0dd0787b9c0d879c2d7398b1ff7964570 Author: Timo Sirainen Date: 2016-12-02 (Fri, 02 Dec 2016) Changed paths: M src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c Log Message: ----------- dsync: Fix log format string broken by earlier change Compare: https://github.com/dovecot/core/compare/fb13dfaa903c...b1533bd0dd07 From noreply at github.com Sat Dec 3 17:00:13 2016 From: noreply at github.com (GitHub) Date: Sat, 03 Dec 2016 09:00:13 -0800 Subject: [dovecot/core] cda8cd: config: Match multiple names in local_name Message-ID: <5842fa1d618ec_1eefe3fb132dc11307285b@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: cda8cd74dd121b7d58e5d9f35da776f8ce8bbd96 https://github.com/dovecot/core/commit/cda8cd74dd121b7d58e5d9f35da776f8ce8bbd96 Author: J. Nick Koston Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/config/config-filter.c Log Message: ----------- config: Match multiple names in local_name This can significantly reduce memory usage when using a UCC certificate with multiple names by only loading the certificate and key once. Commit: 19ae8a2420c27858c712fbd045dc3b339dbe4c1d https://github.com/dovecot/core/commit/19ae8a2420c27858c712fbd045dc3b339dbe4c1d Author: Timo Sirainen Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/doveadm/doveadm-dsync.c M src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c M src/doveadm/dsync/dsync-brain-mailbox.c M src/doveadm/dsync/dsync-brain-mails.c M src/doveadm/dsync/dsync-brain-private.h M src/doveadm/dsync/dsync-brain.c M src/doveadm/dsync/dsync-brain.h M src/doveadm/dsync/dsync-mailbox-import.c M src/doveadm/dsync/dsync-mailbox-import.h Log Message: ----------- dsync: When logging "Mailbox changed caused a desync", log also the reason. The reason is usually somewhere in the debug logs, but it's difficult to find from there. Commit: 2d259b5d4062d97b643324477531d184df817388 https://github.com/dovecot/core/commit/2d259b5d4062d97b643324477531d184df817388 Author: Timo Sirainen Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/lib-dict/dict-client.c Log Message: ----------- dict-client: Don't timeout lookups without waiting 1sec in dict ioloop. What could have happened was: - dict-client sends a request to dict-server - dict-client process starts doing something else - dict-server answers - dict-client process continues doing something else for over 30 seconds, not reading the dict-server answer - dict-client process gets back to dict ioloop, which runs the timeout before checking if there is anything available for reading. Now we'll wait for 1 second in the last dict ioloop before assuming that there's a timeout. Commit: 05278eda7d2e2b8835cdedcf5a41829ba8493381 https://github.com/dovecot/core/commit/05278eda7d2e2b8835cdedcf5a41829ba8493381 Author: Timo Sirainen Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/lib-storage/list/mailbox-list-index-status.c Log Message: ----------- lib-storage: Return vsize=0 from mailbox list index for empty mailboxes. If it's known that the mailbox has no mails, there's no reason to open the mailbox to see that its size is 0. Commit: 5cafce31fdf7e2d2a926526fa0186b10af195313 https://github.com/dovecot/core/commit/5cafce31fdf7e2d2a926526fa0186b10af195313 Author: Timo Sirainen Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/lib/seq-range-array.c M src/lib/test-seq-range-array.c Log Message: ----------- lib: seq_range_array_*(): Fix seq2=2^32-1 handling Adding/merging it when it already existed added duplicated seq_range. Commit: 41eb9998bea06394a9279c57cff6db2f13af91db https://github.com/dovecot/core/commit/41eb9998bea06394a9279c57cff6db2f13af91db Author: Timo Sirainen Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/lib-storage/mail-search-args-simplify.c M src/lib-storage/test-mail-search-args-simplify.c Log Message: ----------- lib-storage: Fix simplifying sequence sets and UID sets. They were being handled completely wrong. The unit tests testing them were also completely wrong. Commit: ffee2008d9b0fc9d25a628a2c190d8e226a9c98f https://github.com/dovecot/core/commit/ffee2008d9b0fc9d25a628a2c190d8e226a9c98f Author: Timo Sirainen Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c Log Message: ----------- dsync: Add mailbox names as well as GUIDs to log messages. Commit: aeb41edae809e60174411ae80836aae51acac979 https://github.com/dovecot/core/commit/aeb41edae809e60174411ae80836aae51acac979 Author: Timo Sirainen Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c Log Message: ----------- dsync: Fix log format string broken by earlier change Commit: 8adcf3d0bd0a940b05a8c89d04b5327a478da1b5 https://github.com/dovecot/core/commit/8adcf3d0bd0a940b05a8c89d04b5327a478da1b5 Author: Stephan Bosch Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/lib-http/http-client-queue.c M src/lib-http/test-http-client-errors.c Log Message: ----------- lib-http: client: Fixed assert failure occurring when a new connection fails for a peer that has active connections. Fixes: Panic: file http-client-queue.c: line 481 (http_client_queue_connection_failure): assertion failed: (queue->cur_peer == NULL) Commit: b2b9e928cb0b0b8dfcc7e4a00af208dab71dfc1d https://github.com/dovecot/core/commit/b2b9e928cb0b0b8dfcc7e4a00af208dab71dfc1d Author: Stephan Bosch Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/auth/auth-policy.c M src/auth/mech-plain-common.c M src/auth/mycrypt.c M src/auth/password-scheme-rpa.c M src/doveadm/doveadm-print-formatted.c M src/doveadm/doveadm-print-json.c M src/lib-dcrypt/dcrypt-gnutls.c M src/lib-dcrypt/dcrypt-openssl.c M src/lib-dcrypt/dcrypt.c M src/lib-dcrypt/istream-decrypt.c M src/lib-dcrypt/test-crypto.c M src/lib-dcrypt/test-stream.c M src/lib-dns/test-dns-util.c M src/lib-fts/fts-library.c M src/lib-fts/fts-tokenizer-common.c M src/lib-http/http-request.c M src/lib-http/http-response.c M src/lib/pkcs5.c Log Message: ----------- global: Added missing copyright notices. Commit: 4add20e6573ce9dc4f061ef9d992695d9be4d596 https://github.com/dovecot/core/commit/4add20e6573ce9dc4f061ef9d992695d9be4d596 Author: Timo Sirainen Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/lib-storage/index/dbox-single/sdbox-sync-rebuild.c M src/lib-storage/index/dbox-single/sdbox-sync.c Log Message: ----------- sdbox: Rebuild index after it's been fsck'd Commit: 0da9c83bcf9bf51f8ade5db72148c19d75f987b7 https://github.com/dovecot/core/commit/0da9c83bcf9bf51f8ade5db72148c19d75f987b7 Author: Aki Tuomi Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/lib/hmac.c M src/lib/hmac.h Log Message: ----------- lib: Add hmac helpers These run hmac for given data with given parameters and returns stack allocated buffer. They are helpful when doing lots of HMACs, such as the AWS4 signing protocol. Compare: https://github.com/dovecot/core/compare/3002d944bff8...0da9c83bcf9b From noreply at github.com Sat Dec 3 17:46:29 2016 From: noreply at github.com (GitHub) Date: Sat, 03 Dec 2016 09:46:29 -0800 Subject: [dovecot/core] d3426e: lib-storage: If mailbox_create() fails, don't leav... Message-ID: <584304f571a62_62f93fb532faf13c14247@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/release-2.2.27 Home: https://github.com/dovecot/core Commit: d3426e98463517232a2cf3d571247d25f32333c5 https://github.com/dovecot/core/commit/d3426e98463517232a2cf3d571247d25f32333c5 Author: Timo Sirainen Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/lib-storage/mail-storage.c Log Message: ----------- lib-storage: If mailbox_create() fails, don't leave box in partially opened state. For example with sdbox it may have opened the indexes, but not set mailbox's GUID. A following MAILBOX_METADATA_GUID would then assert-crash because GUID is empty. Commit: 8f0b35db36cf399fd343ef26cc20f89886a4c6ef https://github.com/dovecot/core/commit/8f0b35db36cf399fd343ef26cc20f89886a4c6ef Author: Timo Sirainen Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M doc/man/doveadm-director.1.in Log Message: ----------- man: Update doveadm director flush description Commit: 9d86be5b636bcbf6297c2d00bce672ea6e8e4bc3 https://github.com/dovecot/core/commit/9d86be5b636bcbf6297c2d00bce672ea6e8e4bc3 Author: Timo Sirainen Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/lib-storage/mail-storage-private.h M src/lib-storage/mail-storage.c Log Message: ----------- lib-storage: Add struct mail_save_context.copy_src_mail Commit: 80249bd4180a1cc915d2e9a72f47b1525d1ce5c6 https://github.com/dovecot/core/commit/80249bd4180a1cc915d2e9a72f47b1525d1ce5c6 Author: Timo Sirainen Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/plugins/quota/quota-storage.c Log Message: ----------- quota: Don't skip quota checks when moving mails between different quota roots. Commit: b998db8adb80da954832a60faa1c3cb3725af3b5 https://github.com/dovecot/core/commit/b998db8adb80da954832a60faa1c3cb3725af3b5 Author: J. Nick Koston Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/config/config-filter.c Log Message: ----------- config: Match multiple names in local_name This can significantly reduce memory usage when using a UCC certificate with multiple names by only loading the certificate and key once. Commit: 059c6552faf31d61b9934a27d3620a5964a91ee9 https://github.com/dovecot/core/commit/059c6552faf31d61b9934a27d3620a5964a91ee9 Author: Timo Sirainen Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/doveadm/doveadm-dsync.c M src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c M src/doveadm/dsync/dsync-brain-mailbox.c M src/doveadm/dsync/dsync-brain-mails.c M src/doveadm/dsync/dsync-brain-private.h M src/doveadm/dsync/dsync-brain.c M src/doveadm/dsync/dsync-brain.h M src/doveadm/dsync/dsync-mailbox-import.c M src/doveadm/dsync/dsync-mailbox-import.h Log Message: ----------- dsync: When logging "Mailbox changed caused a desync", log also the reason. The reason is usually somewhere in the debug logs, but it's difficult to find from there. Commit: f416497dac986782be864710837e9bfee18c0041 https://github.com/dovecot/core/commit/f416497dac986782be864710837e9bfee18c0041 Author: Timo Sirainen Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/lib-dict/dict-client.c Log Message: ----------- dict-client: Don't timeout lookups without waiting 1sec in dict ioloop. What could have happened was: - dict-client sends a request to dict-server - dict-client process starts doing something else - dict-server answers - dict-client process continues doing something else for over 30 seconds, not reading the dict-server answer - dict-client process gets back to dict ioloop, which runs the timeout before checking if there is anything available for reading. Now we'll wait for 1 second in the last dict ioloop before assuming that there's a timeout. Commit: ec4fad7c297dcacb906895b0ec30ef6f4ab0bb22 https://github.com/dovecot/core/commit/ec4fad7c297dcacb906895b0ec30ef6f4ab0bb22 Author: Timo Sirainen Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/lib-storage/list/mailbox-list-index-status.c Log Message: ----------- lib-storage: Return vsize=0 from mailbox list index for empty mailboxes. If it's known that the mailbox has no mails, there's no reason to open the mailbox to see that its size is 0. Commit: e7ffdd7c4855b0a649930346d528ee48322b3abd https://github.com/dovecot/core/commit/e7ffdd7c4855b0a649930346d528ee48322b3abd Author: Timo Sirainen Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/lib/seq-range-array.c M src/lib/test-seq-range-array.c Log Message: ----------- lib: seq_range_array_*(): Fix seq2=2^32-1 handling Adding/merging it when it already existed added duplicated seq_range. Commit: d6258c424a53063fc743dd3f0e2b6580a491f344 https://github.com/dovecot/core/commit/d6258c424a53063fc743dd3f0e2b6580a491f344 Author: Timo Sirainen Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/lib-storage/mail-search-args-simplify.c M src/lib-storage/test-mail-search-args-simplify.c Log Message: ----------- lib-storage: Fix simplifying sequence sets and UID sets. They were being handled completely wrong. The unit tests testing them were also completely wrong. Commit: 3fa668a0816a37bfe7125d3cee218fd37af08b2a https://github.com/dovecot/core/commit/3fa668a0816a37bfe7125d3cee218fd37af08b2a Author: Timo Sirainen Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c Log Message: ----------- dsync: Add mailbox names as well as GUIDs to log messages. Commit: 958a8fc280f721eb44f7ca053e3f63d2855568e5 https://github.com/dovecot/core/commit/958a8fc280f721eb44f7ca053e3f63d2855568e5 Author: Timo Sirainen Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c Log Message: ----------- dsync: Fix log format string broken by earlier change Commit: f2609d35b3bfd7f73f62ca9c87c5dcc4e737d567 https://github.com/dovecot/core/commit/f2609d35b3bfd7f73f62ca9c87c5dcc4e737d567 Author: Stephan Bosch Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/lib-http/http-client-queue.c M src/lib-http/test-http-client-errors.c Log Message: ----------- lib-http: client: Fixed assert failure occurring when a new connection fails for a peer that has active connections. Fixes: Panic: file http-client-queue.c: line 481 (http_client_queue_connection_failure): assertion failed: (queue->cur_peer == NULL) Commit: aa235f897525150b204bb22c8e7247489e17e307 https://github.com/dovecot/core/commit/aa235f897525150b204bb22c8e7247489e17e307 Author: Stephan Bosch Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/auth/auth-policy.c M src/auth/mech-plain-common.c M src/auth/mycrypt.c M src/auth/password-scheme-rpa.c M src/doveadm/doveadm-print-formatted.c M src/doveadm/doveadm-print-json.c M src/lib-dcrypt/dcrypt-gnutls.c M src/lib-dcrypt/dcrypt-openssl.c M src/lib-dcrypt/dcrypt.c M src/lib-dcrypt/istream-decrypt.c M src/lib-dcrypt/test-crypto.c M src/lib-dcrypt/test-stream.c M src/lib-dns/test-dns-util.c M src/lib-fts/fts-library.c M src/lib-fts/fts-tokenizer-common.c M src/lib-http/http-request.c M src/lib-http/http-response.c M src/lib/pkcs5.c Log Message: ----------- global: Added missing copyright notices. Commit: d7062405ea52f4f2c05fc4a2469af64c80143d06 https://github.com/dovecot/core/commit/d7062405ea52f4f2c05fc4a2469af64c80143d06 Author: Timo Sirainen Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/lib-storage/index/dbox-single/sdbox-sync-rebuild.c M src/lib-storage/index/dbox-single/sdbox-sync.c Log Message: ----------- sdbox: Rebuild index after it's been fsck'd Commit: 1163a576f2521ee913cf5ff967ea248b3ebe6487 https://github.com/dovecot/core/commit/1163a576f2521ee913cf5ff967ea248b3ebe6487 Author: Aki Tuomi Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/lib/hmac.c M src/lib/hmac.h Log Message: ----------- lib: Add hmac helpers These run hmac for given data with given parameters and returns stack allocated buffer. They are helpful when doing lots of HMACs, such as the AWS4 signing protocol. Commit: c0f36b02966d9a5d8b4c8c034044b3b9f277a0b7 https://github.com/dovecot/core/commit/c0f36b02966d9a5d8b4c8c034044b3b9f277a0b7 Author: Timo Sirainen Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M NEWS M configure.ac Log Message: ----------- Released v2.2.27. Compare: https://github.com/dovecot/core/compare/81cbf87d0cce...c0f36b02966d From noreply at github.com Sat Dec 3 20:30:11 2016 From: noreply at github.com (GitHub) Date: Sat, 03 Dec 2016 12:30:11 -0800 Subject: [dovecot/core] 486542: dsync: Fixed boolean expression in dsync_mailbox_i... Message-ID: <58432b53b592c_1e61c3f7f66b3113422472@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 48654229ff9a179209c23174a6f4cbaa679e8725 https://github.com/dovecot/core/commit/48654229ff9a179209c23174a6f4cbaa679e8725 Author: Stephan Bosch Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/doveadm/dsync/dsync-mailbox-import.c Log Message: ----------- dsync: Fixed boolean expression in dsync_mailbox_import_deinit(). Found with Clang -Wstrict-bool. From noreply at github.com Sat Dec 3 20:30:08 2016 From: noreply at github.com (GitHub) Date: Sat, 03 Dec 2016 12:30:08 -0800 Subject: [dovecot/core] db40a9: dsync: Fixed boolean expression in dsync_mailbox_i... Message-ID: <58432b5054b2d_63923faaad267130854a6@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: db40a9dd97fdd03b12bd6f793768a634e086f93c https://github.com/dovecot/core/commit/db40a9dd97fdd03b12bd6f793768a634e086f93c Author: Stephan Bosch Date: 2016-12-03 (Sat, 03 Dec 2016) Changed paths: M src/doveadm/dsync/dsync-mailbox-import.c Log Message: ----------- dsync: Fixed boolean expression in dsync_mailbox_import_deinit(). Found with Clang -Wstrict-bool. From noreply at github.com Sat Dec 3 23:10:48 2016 From: noreply at github.com (GitHub) Date: Sat, 03 Dec 2016 15:10:48 -0800 Subject: [dovecot/core] 3694f0: WIP: lib-imap: imap-bodystructure: Created body st... Message-ID: <584350f82ff8b_65b23fef1e10b13c882e5@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/tags/dovecot-ee-2.2.26.1-10 Home: https://github.com/dovecot/core Commit: 3694f08bacc0c0e9f89f96d67e98ba343197485f https://github.com/dovecot/core/commit/3694f08bacc0c0e9f89f96d67e98ba343197485f Author: Stephan Bosch Date: 2016-10-31 (Mon, 31 Oct 2016) Changed paths: M src/lib-imap/imap-bodystructure.c M src/lib-imap/imap-bodystructure.h Log Message: ----------- WIP: lib-imap: imap-bodystructure: Created body structure parser that decodes all data and does not need a pre-existing message_part structure. Commit: b57b0f6b905c9fdd67a9bcb60533dc86a4b6b390 https://github.com/dovecot/core/commit/b57b0f6b905c9fdd67a9bcb60533dc86a4b6b390 Author: Stephan Bosch Date: 2016-10-31 (Mon, 31 Oct 2016) Changed paths: M src/lib-storage/Makefile.am M src/lib-storage/index/Makefile.am M src/lib-storage/index/imapc/imapc-search.c A src/lib-storage/index/index-search-mime.c M src/lib-storage/index/index-search-private.h M src/lib-storage/index/index-search.c M src/lib-storage/mail-search-args-cmdline.c M src/lib-storage/mail-search-args-imap.c A src/lib-storage/mail-search-mime-build.c A src/lib-storage/mail-search-mime-build.h A src/lib-storage/mail-search-mime-register.c A src/lib-storage/mail-search-mime-register.h A src/lib-storage/mail-search-mime.c A src/lib-storage/mail-search-mime.h M src/lib-storage/mail-search-register-imap.c M src/lib-storage/mail-search.c M src/lib-storage/mail-search.h M src/lib-storage/mail-storage.c Log Message: ----------- WIP: Implemented IMAP SEARCH=MIMEPART capability. Commit: 8feb0e164a537cf9eea8192e90eb2e0bf41a5285 https://github.com/dovecot/core/commit/8feb0e164a537cf9eea8192e90eb2e0bf41a5285 Author: Timo Sirainen Date: 2016-10-31 (Mon, 31 Oct 2016) Changed paths: M configure.ac Log Message: ----------- v2.2.26.1 released Compare: https://github.com/dovecot/core/compare/3694f08bacc0^...8feb0e164a53 From noreply at github.com Sun Dec 4 02:00:07 2016 From: noreply at github.com (GitHub) Date: Sat, 03 Dec 2016 18:00:07 -0800 Subject: [dovecot/core] 18535e: configure: Fix building without OpenSSL Message-ID: <584378a7981dc_692a3fca7443d1309000@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 18535eaa6c3bfd8bb5f5612baee01ddfb5645625 https://github.com/dovecot/core/commit/18535eaa6c3bfd8bb5f5612baee01ddfb5645625 Author: Timo Sirainen Date: 2016-12-04 (Sun, 04 Dec 2016) Changed paths: M m4/ssl.m4 Log Message: ----------- configure: Fix building without OpenSSL AM_CONDITIONAL() needs to be part of the code path that is always run, or it fails with: configure: error: conditional "SSL_VERSION_GE_102" was never defined. From noreply at github.com Sun Dec 4 02:00:12 2016 From: noreply at github.com (GitHub) Date: Sat, 03 Dec 2016 18:00:12 -0800 Subject: [dovecot/core] f7f4b6: configure: Fix building without OpenSSL Message-ID: <584378ac9a0f2_5f453feafd5a11308288e@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: f7f4b657ceb3572b89268ee660aeb77df95674ef https://github.com/dovecot/core/commit/f7f4b657ceb3572b89268ee660aeb77df95674ef Author: Timo Sirainen Date: 2016-12-04 (Sun, 04 Dec 2016) Changed paths: M configure.ac Log Message: ----------- configure: Fix building without OpenSSL AM_CONDITIONAL() needs to be part of the code path that is always run, or it fails with: configure: error: conditional "SSL_VERSION_GE_102" was never defined. From noreply at github.com Tue Dec 6 18:30:08 2016 From: noreply at github.com (GitHub) Date: Tue, 06 Dec 2016 10:30:08 -0800 Subject: [dovecot/core] dc38a5: lib/macros.h - protect old compilers from use of m... Message-ID: <584703b0d0355_29eb3fd57f7c9130109021@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: dc38a5b101102ec57da9e25e6b80561ead3f54f8 https://github.com/dovecot/core/commit/dc38a5b101102ec57da9e25e6b80561ead3f54f8 Author: Phil Carmody Date: 2016-12-05 (Mon, 05 Dec 2016) Changed paths: M src/lib/macros.h Log Message: ----------- lib/macros.h - protect old compilers from use of modern features no_sanitize(integer) is not in 3.5 (debian stable's version), but is documented in 3.9. Exactly when it appeared isn't immediately obvious. Signed-off-by: Phil Carmody Commit: 0c75bec6f78ef541a8426905ab4dd9a5d06fb505 https://github.com/dovecot/core/commit/0c75bec6f78ef541a8426905ab4dd9a5d06fb505 Author: Phil Carmody Date: 2016-12-06 (Tue, 06 Dec 2016) Changed paths: M src/plugins/mail-crypt/doveadm-mail-crypt.c Log Message: ----------- plugins: mail-crypt - fix static analysis pedantry Clang cannot see that ret is -1, 0, or 1 upon assigment, and therefore -1 or 0 upon entry into the if block. Therefore it considers ret==0 not to be a tautology if ret!=-1, and thus falsifiable. It concludes that bad things can later happen. The easiest way to persuade it otherwise and make it clear to a human that things are sane is to make the first error check to be for any negative ret value, which forces the else path to explicitly imply ret==0, which means that clause can also be removed. Just removing the ret==0 doesn't make it so clear to the human that there's no third case. The final change is simply to mimic the ret==-1 to ret<0 change earlier. clang's error message: doveadm-mail-crypt.c:290:14: error: variable 'pubid' is used uninitialized whenever '&&' condition is false [-Werror,-Wsometimes-uninitialized] } else if (ret == 0 && ^~~~~~~~ doveadm-mail-crypt.c:304:35: note: uninitialized use occurs here res->id = p_strdup(_ctx->pool, pubid); ^~~~~ doveadm-mail-crypt.c:290:14: note: remove the '&&' if its condition is always true } else if (ret == 0 && ^~~~~~~~~~~ Signed-off-by: Phil Carmody Compare: https://github.com/dovecot/core/compare/18535eaa6c3b...0c75bec6f78e From noreply at github.com Tue Dec 6 23:00:09 2016 From: noreply at github.com (GitHub) Date: Tue, 06 Dec 2016 15:00:09 -0800 Subject: [dovecot/core] b363b9: configure: Fix HAVE_MYSQL_SSL_CIPHER check Message-ID: <584742f9f03dd_2d453fa652d6b13023432@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: b363b993619a9b506a94240f8540bc4b9697c675 https://github.com/dovecot/core/commit/b363b993619a9b506a94240f8540bc4b9697c675 Author: Paul Howarth Date: 2016-12-07 (Wed, 07 Dec 2016) Changed paths: M m4/want_mysql.m4 Log Message: ----------- configure: Fix HAVE_MYSQL_SSL_CIPHER check From noreply at github.com Wed Dec 7 23:00:09 2016 From: noreply at github.com (GitHub) Date: Wed, 07 Dec 2016 15:00:09 -0800 Subject: [dovecot/core] b8eb32: cassandra: Treat "Request timed out" also as SQL_R... Message-ID: <58489479a7123_15693ffa95c0b14088397@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: b8eb3211af2987d6e8f0d416156171fbd74f0737 https://github.com/dovecot/core/commit/b8eb3211af2987d6e8f0d416156171fbd74f0737 Author: Timo Sirainen Date: 2016-12-08 (Thu, 08 Dec 2016) Changed paths: M src/lib-sql/driver-cassandra.c Log Message: ----------- cassandra: Treat "Request timed out" also as SQL_RESULT_ERROR_TYPE_WRITE_UNCERTAIN CASS_ERROR_SERVER_WRITE_TIMEOUT is "Write timeout" as reported by Cassandra server, while CASS_ERROR_LIB_REQUEST_TIMED_OUT is timeout as reported by the Cassandra library. From noreply at github.com Thu Dec 8 18:00:13 2016 From: noreply at github.com (GitHub) Date: Thu, 08 Dec 2016 10:00:13 -0800 Subject: [dovecot/core] ec8dc9: lib/macros.h - protect old compilers from use of m... Message-ID: <58499fad68ffc_4ef83fcb4a3671301923e@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: ec8dc91f846ee3be7927761b66fcf8fcc7d8cb91 https://github.com/dovecot/core/commit/ec8dc91f846ee3be7927761b66fcf8fcc7d8cb91 Author: Phil Carmody Date: 2016-12-08 (Thu, 08 Dec 2016) Changed paths: M src/lib/macros.h Log Message: ----------- lib/macros.h - protect old compilers from use of modern features no_sanitize(integer) is not in 3.5 (debian stable's version), but is documented in 3.9. Exactly when it appeared isn't immediately obvious. Signed-off-by: Phil Carmody Commit: 66cbd09b78f9e63b06ec8048c4611972d3899456 https://github.com/dovecot/core/commit/66cbd09b78f9e63b06ec8048c4611972d3899456 Author: Phil Carmody Date: 2016-12-08 (Thu, 08 Dec 2016) Changed paths: M src/plugins/mail-crypt/doveadm-mail-crypt.c Log Message: ----------- plugins: mail-crypt - fix static analysis pedantry Clang cannot see that ret is -1, 0, or 1 upon assigment, and therefore -1 or 0 upon entry into the if block. Therefore it considers ret==0 not to be a tautology if ret!=-1, and thus falsifiable. It concludes that bad things can later happen. The easiest way to persuade it otherwise and make it clear to a human that things are sane is to make the first error check to be for any negative ret value, which forces the else path to explicitly imply ret==0, which means that clause can also be removed. Just removing the ret==0 doesn't make it so clear to the human that there's no third case. The final change is simply to mimic the ret==-1 to ret<0 change earlier. clang's error message: doveadm-mail-crypt.c:290:14: error: variable 'pubid' is used uninitialized whenever '&&' condition is false [-Werror,-Wsometimes-uninitialized] } else if (ret == 0 && ^~~~~~~~ doveadm-mail-crypt.c:304:35: note: uninitialized use occurs here res->id = p_strdup(_ctx->pool, pubid); ^~~~~ doveadm-mail-crypt.c:290:14: note: remove the '&&' if its condition is always true } else if (ret == 0 && ^~~~~~~~~~~ Signed-off-by: Phil Carmody Commit: 6ea072d979b3acd6725874e1c5e658847c831fb8 https://github.com/dovecot/core/commit/6ea072d979b3acd6725874e1c5e658847c831fb8 Author: Paul Howarth Date: 2016-12-08 (Thu, 08 Dec 2016) Changed paths: M configure.ac Log Message: ----------- configure: Fix HAVE_MYSQL_SSL_CIPHER check Commit: a2e65fe08b86c507ec25d8a0addfba1d51aca0d0 https://github.com/dovecot/core/commit/a2e65fe08b86c507ec25d8a0addfba1d51aca0d0 Author: Timo Sirainen Date: 2016-12-08 (Thu, 08 Dec 2016) Changed paths: M src/lib-sql/driver-cassandra.c Log Message: ----------- cassandra: Treat "Request timed out" also as SQL_RESULT_ERROR_TYPE_WRITE_UNCERTAIN CASS_ERROR_SERVER_WRITE_TIMEOUT is "Write timeout" as reported by Cassandra server, while CASS_ERROR_LIB_REQUEST_TIMED_OUT is timeout as reported by the Cassandra library. Commit: b7a0844fb8dffbf7f1dd0b5c6d30c22ff8cb6bec https://github.com/dovecot/core/commit/b7a0844fb8dffbf7f1dd0b5c6d30c22ff8cb6bec Author: Timo Sirainen Date: 2016-12-08 (Thu, 08 Dec 2016) Changed paths: M src/lib/seq-range-array.c M src/lib/test-seq-range-array.c Log Message: ----------- lib: Fix seq_range_array_invert() when input contains 2^32-1 This caused next_min_seq to be wrapped to 0, which was handled wrong later on. Fixes: Panic: file mail-index-map.c: line 549 (mail_index_map_lookup_seq_range): assertion failed: (first_uid > 0) Commit: 27128a3faaaf4de27a64eba233490fb9f45827ff https://github.com/dovecot/core/commit/27128a3faaaf4de27a64eba233490fb9f45827ff Author: Timo Sirainen Date: 2016-12-08 (Thu, 08 Dec 2016) Changed paths: M src/lib/seq-range-array.h Log Message: ----------- lib: Comment seq_range_array_invert() that its values must be within min_seq..max_seq Commit: 98ac5eeade92dafee0bd2b186fafa868474976af https://github.com/dovecot/core/commit/98ac5eeade92dafee0bd2b186fafa868474976af Author: Aki Tuomi Date: 2016-12-08 (Thu, 08 Dec 2016) Changed paths: M src/lib-storage/mail-search-args-simplify.c Log Message: ----------- lib-storage: Fix typo in function name Commit: 93d5beb772c26002b3b80e886a47de5c521868a5 https://github.com/dovecot/core/commit/93d5beb772c26002b3b80e886a47de5c521868a5 Author: Aki Tuomi Date: 2016-12-08 (Thu, 08 Dec 2016) Changed paths: M src/lib-storage/test-mail-search-args-simplify.c Log Message: ----------- lib-storage: Add test for inversion of n->max In mail-search-simplify-args, ensure that ALL NOT UID 3:* becomes UID 1:2 Commit: 7951e22895109a93ff9784d60659bed4cb22fef4 https://github.com/dovecot/core/commit/7951e22895109a93ff9784d60659bed4cb22fef4 Author: Timo Sirainen Date: 2016-12-08 (Thu, 08 Dec 2016) Changed paths: M src/lib/test-seq-range-array.c Log Message: ----------- lib: Improve seq_range_array_invert() unit tests Try all possible combinations for seq=0..7 and seq=4294967288..4294967295 and make sure they're inverted correctly. Compare: https://github.com/dovecot/core/compare/f7f4b657ceb3...7951e2289510 From noreply at github.com Thu Dec 8 18:00:11 2016 From: noreply at github.com (GitHub) Date: Thu, 08 Dec 2016 10:00:11 -0800 Subject: [dovecot/core] 97745d: configure: Moved pandoc check to m4/dovecot.m4 Message-ID: <58499fab2a7f9_4c903f80ba92313010043@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 97745d12bd9e2b7ba4003ae747f3bd1e030ac357 https://github.com/dovecot/core/commit/97745d12bd9e2b7ba4003ae747f3bd1e030ac357 Author: Timo Sirainen Date: 2016-12-08 (Thu, 08 Dec 2016) Changed paths: M configure.ac M m4/dovecot.m4 Log Message: ----------- configure: Moved pandoc check to m4/dovecot.m4 Commit: 369764cc0856a4c5e9b4081de8c4e29e90f11ccd https://github.com/dovecot/core/commit/369764cc0856a4c5e9b4081de8c4e29e90f11ccd Author: Timo Sirainen Date: 2016-12-08 (Thu, 08 Dec 2016) Changed paths: M src/lib/seq-range-array.c M src/lib/test-seq-range-array.c Log Message: ----------- lib: Fix seq_range_array_invert() when input contains 2^32-1 This caused next_min_seq to be wrapped to 0, which was handled wrong later on. Fixes: Panic: file mail-index-map.c: line 549 (mail_index_map_lookup_seq_range): assertion failed: (first_uid > 0) Commit: 8927ce341a9f075798d36107c2eafbf7499b4ad6 https://github.com/dovecot/core/commit/8927ce341a9f075798d36107c2eafbf7499b4ad6 Author: Timo Sirainen Date: 2016-12-08 (Thu, 08 Dec 2016) Changed paths: M src/lib/seq-range-array.h Log Message: ----------- lib: Comment seq_range_array_invert() that its values must be within min_seq..max_seq Commit: 9432496e6b190b839622a391a15788c41e5d95d3 https://github.com/dovecot/core/commit/9432496e6b190b839622a391a15788c41e5d95d3 Author: Aki Tuomi Date: 2016-12-08 (Thu, 08 Dec 2016) Changed paths: M src/lib-storage/mail-search-args-simplify.c Log Message: ----------- lib-storage: Fix typo in function name Commit: 2aee623fcad4b931c27435ceaa495c3d3edd69b6 https://github.com/dovecot/core/commit/2aee623fcad4b931c27435ceaa495c3d3edd69b6 Author: Aki Tuomi Date: 2016-12-08 (Thu, 08 Dec 2016) Changed paths: M src/lib-storage/test-mail-search-args-simplify.c Log Message: ----------- lib-storage: Add test for inversion of n->max In mail-search-simplify-args, ensure that ALL NOT UID 3:* becomes UID 1:2 Commit: f7bd22354fb9311dfbf3e340a69c15d8b00facc1 https://github.com/dovecot/core/commit/f7bd22354fb9311dfbf3e340a69c15d8b00facc1 Author: Timo Sirainen Date: 2016-12-08 (Thu, 08 Dec 2016) Changed paths: M src/lib/test-seq-range-array.c Log Message: ----------- lib: Improve seq_range_array_invert() unit tests Try all possible combinations for seq=0..7 and seq=4294967288..4294967295 and make sure they're inverted correctly. Compare: https://github.com/dovecot/core/compare/b8eb3211af29...f7bd22354fb9 From noreply at github.com Fri Dec 9 08:00:09 2016 From: noreply at github.com (GitHub) Date: Fri, 09 Dec 2016 00:00:09 -0800 Subject: [dovecot/core] 9983cb: lib: add t_strfgmtime and t_strftime Message-ID: <584a64894240f_27f63fabb27531347707b@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 9983cbb4cef92d68ffde87dcc91913cc2fed3da5 https://github.com/dovecot/core/commit/9983cbb4cef92d68ffde87dcc91913cc2fed3da5 Author: Martti Rannanj?rvi Date: 2016-12-08 (Thu, 08 Dec 2016) Changed paths: M src/lib/test-time-util.c M src/lib/time-util.c M src/lib/time-util.h Log Message: ----------- lib: add t_strfgmtime and t_strftime From noreply at github.com Fri Dec 9 09:30:10 2016 From: noreply at github.com (GitHub) Date: Fri, 09 Dec 2016 01:30:10 -0800 Subject: [dovecot/core] 5ee3c7: doveadm-server: http: Fixed temp_path_prefix for i... Message-ID: <584a79a21af53_17e03f9b6023513c52917@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 5ee3c7784cd954ef4d1e8ad43f7d155fbb8f5c14 https://github.com/dovecot/core/commit/5ee3c7784cd954ef4d1e8ad43f7d155fbb8f5c14 Author: Stephan Bosch Date: 2016-12-09 (Fri, 09 Dec 2016) Changed paths: M src/doveadm/client-connection-http.c Log Message: ----------- doveadm-server: http: Fixed temp_path_prefix for iostream-temp. The temp_path_prefix was "/tmp", which is extended to "/tmp.." by safe_mkstemp. Obviously, mortal users cannot create a file like that, causing this error: doveadm: Error: safe_mkstemp(/tmp) failed: Permission denied The temp_path_prefix should have been "/tmp/doveadm.", as it is elsewhere as well. From noreply at github.com Fri Dec 9 13:30:08 2016 From: noreply at github.com (GitHub) Date: Fri, 09 Dec 2016 05:30:08 -0800 Subject: [dovecot/core] b6188d: config: Avoid excessive data stack usage when matc... Message-ID: <584ab1e0496ce_e973fd74a7bd13848281@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: b6188d7d62ef9ab46f9f074d88b26caea0e15f6a https://github.com/dovecot/core/commit/b6188d7d62ef9ab46f9f074d88b26caea0e15f6a Author: Timo Sirainen Date: 2016-12-09 (Fri, 09 Dec 2016) Changed paths: M src/config/config-filter.c Log Message: ----------- config: Avoid excessive data stack usage when matching local_name Moved config_filter_match_local_name() to its own function to make adding the data stack frame easier. Based on patch by J. Nick Koston From noreply at github.com Fri Dec 9 14:00:11 2016 From: noreply at github.com (GitHub) Date: Fri, 09 Dec 2016 06:00:11 -0800 Subject: [dovecot/core] ee22a4: imapc: Don't send NOOP immediately after SELECT Message-ID: <584ab8eb13318_24513faaaf84d13852129@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: ee22a48c8ab37aad0bf5534b8d4131e6639f9454 https://github.com/dovecot/core/commit/ee22a48c8ab37aad0bf5534b8d4131e6639f9454 Author: Timo Sirainen Date: 2016-12-09 (Fri, 09 Dec 2016) Changed paths: M src/lib-storage/index/imapc/imapc-sync.c Log Message: ----------- imapc: Don't send NOOP immediately after SELECT NOOP is normally used by mailbox syncing to check if there are any changes done by other concurrent IMAP sessions. But doing it immediately after SELECT is unnecessary, because nothing could have changed. Commit: e823661ef75e798ed18dc2bf0a46ed66ffc27c24 https://github.com/dovecot/core/commit/e823661ef75e798ed18dc2bf0a46ed66ffc27c24 Author: manuel Date: 2016-12-09 (Fri, 09 Dec 2016) Changed paths: M src/lib-ssl-iostream/iostream-openssl.c M src/login-common/ssl-proxy-openssl.c Log Message: ----------- openssl: Clear error queue after an incomplete SSL_shutdown If the SSL_shutdown-call fails (e.g. because the underlaying socket has already been closed) OpenSSL puts the corresponding error into the queue. We don't care about details so we need to clear the queue. Otherwise the error will be pulled while error checking the next OpenSSL call of an unrelated connection. Commit: b405360288783b2e947263465f7fc48ae475485a https://github.com/dovecot/core/commit/b405360288783b2e947263465f7fc48ae475485a Author: Paul Howarth Date: 2016-12-09 (Fri, 09 Dec 2016) Changed paths: M m4/mmap_write.m4 M m4/size_t_signed.m4 M m4/time_t_signed.m4 M m4/vararg.m4 Log Message: ----------- configure: Fix some implicit function declarations Some configure tests fail unexpectedly if the compiler flag -Werror=implicit-function-declarations is enabled, which can result in the wrong implementations being used. This compiler flag is now enabled by default in Fedora Rawhide: https://fedoraproject.org/wiki/Changes/Fedora26CFlags is needed for exit() is needed for strcpy() Compare: https://github.com/dovecot/core/compare/b6188d7d62ef...b40536028878 From noreply at github.com Mon Dec 12 09:30:11 2016 From: noreply at github.com (GitHub) Date: Mon, 12 Dec 2016 01:30:11 -0800 Subject: [dovecot/core] 271b81: lib-storage: Do not try to recover missing list in... Message-ID: <584e6e2368a1d_7f643ff834d1713c9418b@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 271b8142d96d496e1ef5872d9680af60ebc356d0 https://github.com/dovecot/core/commit/271b8142d96d496e1ef5872d9680af60ebc356d0 Author: Aki Tuomi Date: 2016-12-12 (Mon, 12 Dec 2016) Changed paths: M src/lib-storage/list/mailbox-list-index.c Log Message: ----------- lib-storage: Do not try to recover missing list index Fixes Panic: file mailbox-list-index.c: line 342 (mailbox_list_index_parse_records): assertion failed: (node != NULL) From noreply at github.com Mon Dec 12 11:30:09 2016 From: noreply at github.com (GitHub) Date: Mon, 12 Dec 2016 03:30:09 -0800 Subject: [dovecot/core] 530b59: doveadm: When connecting to doveadm-server via TCP... Message-ID: <584e8a419a8ad_7ab3fbae37951341051a3@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 530b5909a99e7575156496f1b8e4d1ff5b058484 https://github.com/dovecot/core/commit/530b5909a99e7575156496f1b8e4d1ff5b058484 Author: Timo Sirainen Date: 2016-12-12 (Mon, 12 Dec 2016) Changed paths: M src/doveadm/doveadm-util.c Log Message: ----------- doveadm: When connecting to doveadm-server via TCP, use 30s timeout Should be enough, and better than the kernel's default, which might be a lot more. Commit: 6c40413c6e64fde2d977cd6076afa97fa57b67fc https://github.com/dovecot/core/commit/6c40413c6e64fde2d977cd6076afa97fa57b67fc Author: Timo Sirainen Date: 2016-12-12 (Mon, 12 Dec 2016) Changed paths: M src/doveadm/doveadm.c Log Message: ----------- doveadm: Add global doveadm_verbose_proctitle setting. This previously existed only for doveadm-server, but adding it to doveadm CLI makes it easier to do process title updates for it as well. Commit: 6af4e592a0939a839d54a49c6f59179a55ac0b70 https://github.com/dovecot/core/commit/6af4e592a0939a839d54a49c6f59179a55ac0b70 Author: Timo Sirainen Date: 2016-12-12 (Mon, 12 Dec 2016) Changed paths: M src/doveadm/client-connection.c Log Message: ----------- doveadm-server: Show UNIX socket connections as in process title Earlier they were shown as empty string. Commit: 0eb3485b45b0233eb089c0337858a195cb341f0b https://github.com/dovecot/core/commit/0eb3485b45b0233eb089c0337858a195cb341f0b Author: Timo Sirainen Date: 2016-12-12 (Mon, 12 Dec 2016) Changed paths: M src/doveadm/doveadm-dsync.c M src/doveadm/dsync/dsync-brain.c Log Message: ----------- dsync: Improve process title during initialization If something is hanging, this should make it clear what exactly it is. Compare: https://github.com/dovecot/core/compare/271b8142d96d...0eb3485b45b0 From noreply at github.com Mon Dec 12 12:30:10 2016 From: noreply at github.com (GitHub) Date: Mon, 12 Dec 2016 04:30:10 -0800 Subject: [dovecot/core] 69a993: dsync: Fix .dovecot-sync.lock timeout checking Message-ID: <584e985227442_7dba3f9163767134319ee@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 69a9934b56438719c9eed2ca876b08a4ff445dd7 https://github.com/dovecot/core/commit/69a9934b56438719c9eed2ca876b08a4ff445dd7 Author: Timo Sirainen Date: 2016-12-12 (Mon, 12 Dec 2016) Changed paths: M src/doveadm/dsync/dsync-brain.c Log Message: ----------- dsync: Fix .dovecot-sync.lock timeout checking Whenever the lock file was recreated, the lock timeout was reset. Switched to using file_create_locked(), which already solves this problem and has compatible locking. From noreply at github.com Tue Dec 13 08:00:09 2016 From: noreply at github.com (GitHub) Date: Tue, 13 Dec 2016 00:00:09 -0800 Subject: [dovecot/core] f15376: imap: Fix assert when waiting for input on SEARCH/... Message-ID: <584faa892a602_5f73fa92867514021662@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f153764d47dcb3b500f65238ac531100a338b397 https://github.com/dovecot/core/commit/f153764d47dcb3b500f65238ac531100a338b397 Author: Aki Tuomi Date: 2016-12-12 (Mon, 12 Dec 2016) Changed paths: M src/imap/imap-search.c Log Message: ----------- imap: Fix assert when waiting for input on SEARCH/SORT Set cmd->state to CLIENT_COMMAND_STATE_WAIT_EXTERNAL because we are not expecting input or output. Fixes Panic: file imap-client.c: line 854 (client_check_command_hangs): assertion failed: (client->io != NULL || (client->output_cmd_lock != NULL && client->output_cmd_lock != client->input_lock)) From noreply at github.com Wed Dec 14 08:00:10 2016 From: noreply at github.com (GitHub) Date: Wed, 14 Dec 2016 00:00:10 -0800 Subject: [dovecot/core] 02c286: acl: Don't set acl_defaults_from_inbox=yes as defa... Message-ID: <5850fc0adc86c_2e963ff9c7c3b13495895@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 02c28668f01219ae17e112cd4d3cdd3a0af539a1 https://github.com/dovecot/core/commit/02c28668f01219ae17e112cd4d3cdd3a0af539a1 Author: Timo Sirainen Date: 2016-12-13 (Tue, 13 Dec 2016) Changed paths: M src/plugins/acl/acl-backend.c Log Message: ----------- acl: Don't set acl_defaults_from_inbox=yes as default after all. Reverts b56d462fff46511b7efa0ccf254ba93d72322920 and removes the FIXME. Some people might actually want to give someone else access to their INBOX but not to all the other mailboxes. We should make it possible to use the "" mailbox name as the default ACL instead. From noreply at github.com Wed Dec 14 15:30:12 2016 From: noreply at github.com (GitHub) Date: Wed, 14 Dec 2016 07:30:12 -0800 Subject: [dovecot/core] 5898bb: doveadm-director: Show tag field from response Message-ID: <5851658487116_6fc43f97d30ff140983bb@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 5898bb384d351ea32f1714da072485c71ca909ad https://github.com/dovecot/core/commit/5898bb384d351ea32f1714da072485c71ca909ad Author: Aki Tuomi Date: 2016-12-14 (Wed, 14 Dec 2016) Changed paths: M src/doveadm/doveadm-director.c Log Message: ----------- doveadm-director: Show tag field from response Fix off-by-one in doveadm director dump Commit: e41e5d5456fb6c78693a385239ef5b0cbbd57408 https://github.com/dovecot/core/commit/e41e5d5456fb6c78693a385239ef5b0cbbd57408 Author: Aki Tuomi Date: 2016-12-14 (Wed, 14 Dec 2016) Changed paths: M src/plugins/mail-crypt/mail-crypt-global-key.c M src/plugins/mail-crypt/test-mail-global-key.c Log Message: ----------- mail-crypt: Ensure array is created before accessing it Fixes segmentation fault on fs-crypt when keys are not configured. Commit: d0ed540d897d62713ac74523af11dac204874b5d https://github.com/dovecot/core/commit/d0ed540d897d62713ac74523af11dac204874b5d Author: Timo Sirainen Date: 2016-12-14 (Wed, 14 Dec 2016) Changed paths: M src/lib-index/mail-index-transaction-update.c M src/lib-index/mail-index.h Log Message: ----------- lib-index: Add mail_index_revert_changes() This can be used to revert changes done in a transaction to the specified existing mail. Compare: https://github.com/dovecot/core/compare/02c28668f012...d0ed540d897d From noreply at github.com Wed Dec 14 16:00:10 2016 From: noreply at github.com (GitHub) Date: Wed, 14 Dec 2016 08:00:10 -0800 Subject: [dovecot/core] f549b4: lib-imap: imap-bodystructure: Prevent writing erro... Message-ID: <58516c8a126a8_57393fc282069134571d1@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f549b400d50935754cbeb6ceabd922ab777b4d77 https://github.com/dovecot/core/commit/f549b400d50935754cbeb6ceabd922ab777b4d77 Author: Stephan Bosch Date: 2016-12-14 (Wed, 14 Dec 2016) Changed paths: M src/lib-imap/imap-bodystructure.c M src/lib-imap/test-imap-bodystructure.c Log Message: ----------- lib-imap: imap-bodystructure: Prevent writing erroneous whitespace between items in an envelope address list. Both imap_bodystructure_write() and imap_body_parse_from_bodystructure() produced such invalid output. This caused an RFC 3501 violation in IMAP FETCH BODY and BODYSTRUCTURE responses. Test suite is amended to test this situation. Commit: 60bea13e11a4e95e915c64112783d86204697b19 https://github.com/dovecot/core/commit/60bea13e11a4e95e915c64112783d86204697b19 Author: Aki Tuomi Date: 2016-12-14 (Wed, 14 Dec 2016) Changed paths: M src/doveadm/doveadm-mail-save.c Log Message: ----------- doveadm-save: Set exit code to EX_TEMPFAIL on open error Prevents potential crash on doveadm_mail_next_user Commit: b0e6a65a4b3971c6e00c97c8be19222165899cb7 https://github.com/dovecot/core/commit/b0e6a65a4b3971c6e00c97c8be19222165899cb7 Author: Aki Tuomi Date: 2016-12-14 (Wed, 14 Dec 2016) Changed paths: M src/doveadm/doveadm-mail.c Log Message: ----------- doveadm-mail: Set exit code to EX_TEMPFAIL on timeout When running `doveadm save` command on proxy/director and the remote command execution times out, exit code must be set to EX_TEMPFAIL. Fixes Panic: file doveadm-mail.c: line 405 (doveadm_mail_next_user): assertion failed: (ctx->exit_code != 0) Commit: ec8e55a73623e40dfce9bfb5a60abf047788b222 https://github.com/dovecot/core/commit/ec8e55a73623e40dfce9bfb5a60abf047788b222 Author: Martti Rannanj?rvi Date: 2016-12-14 (Wed, 14 Dec 2016) Changed paths: M src/auth/db-ldap.c Log Message: ----------- auth: silence var_expand_with_funcs in db-ldap This needs to be silenced since it's logging errors of variable expansions that are not meant to be successful. The function is used here just for filling the attr_names array in ldap_field_find_context and the resulting string is not used. Commit: 76d4cc8e7aea32e91a48c83dabcccb196ea8019b https://github.com/dovecot/core/commit/76d4cc8e7aea32e91a48c83dabcccb196ea8019b Author: Timo Sirainen Date: 2016-12-14 (Wed, 14 Dec 2016) Changed paths: M src/lib-test/test-common.c M src/lib-test/test-common.h Log Message: ----------- lib-test: Introduce test_fatal_func_t as typedef and comment how it works. Commit: bc15567c91fb9d3915b04013ee0cc744c7a18eab https://github.com/dovecot/core/commit/bc15567c91fb9d3915b04013ee0cc744c7a18eab Author: Timo Sirainen Date: 2016-12-14 (Wed, 14 Dec 2016) Changed paths: M src/lib-test/test-common.c M src/lib-test/test-common.h Log Message: ----------- lib-test: test_run_with_fatals() now takes a const array Commit: 957d34edbe3599fbb4e7c0bcf3785bd7fd4862c4 https://github.com/dovecot/core/commit/957d34edbe3599fbb4e7c0bcf3785bd7fd4862c4 Author: Timo Sirainen Date: 2016-12-14 (Wed, 14 Dec 2016) Changed paths: M src/lib-test/test-common.c M src/lib-test/test-common.h M src/lib/test-array.c M src/lib/test-data-stack.c M src/lib/test-mempool-alloconly.c M src/lib/test-printf-format-fix.c Log Message: ----------- lib-test: Change test_fatal_func_t to take unsigned int stage as parameter. It could never be -1, so this makes it clearer. It also removes annoying casts when comparing stage to e.g. N_ELEMENTS(). Commit: 182093c9a4e02a1c6672597da45767625c6b970e https://github.com/dovecot/core/commit/182093c9a4e02a1c6672597da45767625c6b970e Author: Aki Tuomi Date: 2016-12-14 (Wed, 14 Dec 2016) Changed paths: M src/lib/sha3.c Log Message: ----------- sha3: Fix typo in ifdef The code was supposed to be used with big endian machines. Reported by than at redhat.com Commit: 5afa9b93dad70209afe9340f036a65d3da978f8f https://github.com/dovecot/core/commit/5afa9b93dad70209afe9340f036a65d3da978f8f Author: Aki Tuomi Date: 2016-12-14 (Wed, 14 Dec 2016) Changed paths: M src/auth/auth-policy.c Log Message: ----------- auth-policy: Allow unsupported attributes in response Do not choke if we receive unsupported attributes in response. This allows better interoperability with different systems that are getting signals from auth policy server that are not (yet) supported by dovecot. Commit: beec8b0a6a3ece557c9acec524e82542a9641662 https://github.com/dovecot/core/commit/beec8b0a6a3ece557c9acec524e82542a9641662 Author: Aki Tuomi Date: 2016-12-14 (Wed, 14 Dec 2016) Changed paths: M src/plugins/mail-crypt/test-mail-global-key.c M src/plugins/mail-crypt/test-mail-key.c Log Message: ----------- mail-crypt: Skip tests if dcrypt cannot be initialized Avoids breaking tests on system without working ECC keys. Compare: https://github.com/dovecot/core/compare/d0ed540d897d...beec8b0a6a3e From noreply at github.com Wed Dec 14 16:30:09 2016 From: noreply at github.com (GitHub) Date: Wed, 14 Dec 2016 08:30:09 -0800 Subject: [dovecot/core] 05546c: mail-crypt: Treat empty values correctly Message-ID: <58517391b8e5e_1d443fd8600a913c532cb@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 05546ccd35d68867beb3d24d1ddce3816d330a2c https://github.com/dovecot/core/commit/05546ccd35d68867beb3d24d1ddce3816d330a2c Author: Aki Tuomi Date: 2016-12-14 (Wed, 14 Dec 2016) Changed paths: M src/plugins/mail-crypt/mail-crypt-plugin.c Log Message: ----------- mail-crypt: Treat empty values correctly If mail_crypt_curve or mail_crypt_save_version is left empty, disable the plugin. Don't error out. From noreply at github.com Wed Dec 14 17:30:09 2016 From: noreply at github.com (GitHub) Date: Wed, 14 Dec 2016 09:30:09 -0800 Subject: [dovecot/core] 9c7760: auth: Don't log errors when cache_key expansion fi... Message-ID: <585181a11f0b9_6d533faa3e10f13063278@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 9c77606aef2dadad72e1a97f6d820dadb05d1d44 https://github.com/dovecot/core/commit/9c77606aef2dadad72e1a97f6d820dadb05d1d44 Author: Timo Sirainen Date: 2016-12-14 (Wed, 14 Dec 2016) Changed paths: M src/auth/auth-cache.c Log Message: ----------- auth: Don't log errors when cache_key expansion finds unknown %variables From noreply at github.com Wed Dec 14 18:00:09 2016 From: noreply at github.com (GitHub) Date: Wed, 14 Dec 2016 10:00:09 -0800 Subject: [dovecot/core] 9a8217: lib-storage: Fix crash in obox's dsync-merge Message-ID: <585188a9a061c_242e3ff1a31b513c256bf@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 9a8217a728581b4787ab65eb6d1b06681945803d https://github.com/dovecot/core/commit/9a8217a728581b4787ab65eb6d1b06681945803d Author: Timo Sirainen Date: 2016-12-14 (Wed, 14 Dec 2016) Changed paths: M src/lib-storage/list/mailbox-list-index-backend.c Log Message: ----------- lib-storage: Fix crash in obox's dsync-merge From noreply at github.com Thu Dec 15 12:00:11 2016 From: noreply at github.com (GitHub) Date: Thu, 15 Dec 2016 04:00:11 -0800 Subject: [dovecot/core] dc5168: driver-mysql: Do not hex-encode again Message-ID: <585285cbaa866_2c133fcbe2fa3140991b7@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: dc5168232608d74ca56412044280ff0155ffe231 https://github.com/dovecot/core/commit/dc5168232608d74ca56412044280ff0155ffe231 Author: Aki Tuomi Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/lib-sql/driver-mysql.c Log Message: ----------- driver-mysql: Do not hex-encode again Use correct syntax to provide data to mysql in hex format, without recoding it in hex format again. Commit: c18dcef4da347b735861aa35fc6518c6c2e97755 https://github.com/dovecot/core/commit/c18dcef4da347b735861aa35fc6518c6c2e97755 Author: Timo Sirainen Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/lib/file-cache.c M src/lib/file-cache.h Log Message: ----------- lib: Add file_cache_new_path() to include path in error messages. Commit: 17018da24e7dbb419c5047c316caadcb2fc5364a https://github.com/dovecot/core/commit/17018da24e7dbb419c5047c316caadcb2fc5364a Author: Timo Sirainen Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/lib-index/mail-cache.c Log Message: ----------- lib-index: Use file_cache_new_path() for dovecot.index.cache Commit: 78b806afb68cf1fed9dda6b45cbf7f8f2e08260d https://github.com/dovecot/core/commit/78b806afb68cf1fed9dda6b45cbf7f8f2e08260d Author: Timo Sirainen Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/plugins/fts-squat/squat-trie.c M src/plugins/fts-squat/squat-uidlist.c Log Message: ----------- fts-squat: Use file_cache_new_path() for squat indexes Compare: https://github.com/dovecot/core/compare/9a8217a72858...78b806afb68c From noreply at github.com Thu Dec 15 13:30:10 2016 From: noreply at github.com (GitHub) Date: Thu, 15 Dec 2016 05:30:10 -0800 Subject: [dovecot/core] f2c3ab: imapc: Don't allow "*" in SEARCH replies Message-ID: <58529ae21e098_22d63fef1f9ab1382679a@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f2c3abe802df6fdbe7d0cd456e13817f44ca23c2 https://github.com/dovecot/core/commit/f2c3abe802df6fdbe7d0cd456e13817f44ca23c2 Author: Timo Sirainen Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/lib-storage/index/imapc/imapc-mailbox.c M src/lib-storage/index/imapc/imapc-search.c Log Message: ----------- imapc: Don't allow "*" in SEARCH replies Doesn't fix anything, but makes the parsing a bit more correct. From noreply at github.com Thu Dec 15 14:30:09 2016 From: noreply at github.com (GitHub) Date: Thu, 15 Dec 2016 06:30:09 -0800 Subject: [dovecot/core] abb5d2: lib-storage: Fix "*" in SEARCH seqset/uidset Message-ID: <5852a8f112386_24ea3fc764f9b13450724@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: abb5d20d3155db02a1afec4066d52707ba9d4e52 https://github.com/dovecot/core/commit/abb5d20d3155db02a1afec4066d52707ba9d4e52 Author: Timo Sirainen Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/lib-storage/mail-search-args-simplify.c M src/lib-storage/test-mail-search-args-simplify.c Log Message: ----------- lib-storage: Fix "*" in SEARCH seqset/uidset 4294967295 is used for "*", which matches the last existing message. Which we don't know what it is at the time of search args simplification, so avoid making any assumptions about it. It's a bit ugly that 4294967295 can't be used as a valid UID, but this restriction has already existed since the beginning of Dovecot. A future alternative might be to add MAIL_SEARCH_ARG_FLAG_SEQSET_WITH_STAR, but that's a bit complicated change. From noreply at github.com Thu Dec 15 14:30:14 2016 From: noreply at github.com (GitHub) Date: Thu, 15 Dec 2016 06:30:14 -0800 Subject: [dovecot/core] 1f6c70: lib: add t_strfgmtime and t_strftime Message-ID: <5852a8f698a33_95573f87bb3311342417d@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 1f6c70b7d4929e2d90777bcfba35df5500f66fdb https://github.com/dovecot/core/commit/1f6c70b7d4929e2d90777bcfba35df5500f66fdb Author: Martti Rannanj?rvi Date: 2016-12-13 (Tue, 13 Dec 2016) Changed paths: M src/lib/test-time-util.c M src/lib/time-util.c M src/lib/time-util.h Log Message: ----------- lib: add t_strfgmtime and t_strftime Commit: 41d538d5d87870d64b78d2d2bd8f8ffdf8496c45 https://github.com/dovecot/core/commit/41d538d5d87870d64b78d2d2bd8f8ffdf8496c45 Author: Stephan Bosch Date: 2016-12-13 (Tue, 13 Dec 2016) Changed paths: M src/doveadm/client-connection-http.c Log Message: ----------- doveadm-server: http: Fixed temp_path_prefix for iostream-temp. The temp_path_prefix was "/tmp", which is extended to "/tmp.." by safe_mkstemp. Obviously, mortal users cannot create a file like that, causing this error: doveadm: Error: safe_mkstemp(/tmp) failed: Permission denied The temp_path_prefix should have been "/tmp/doveadm.", as it is elsewhere as well. Commit: 634c8fdf936e1348fe6c55dc9633fc21a8e6c560 https://github.com/dovecot/core/commit/634c8fdf936e1348fe6c55dc9633fc21a8e6c560 Author: Timo Sirainen Date: 2016-12-13 (Tue, 13 Dec 2016) Changed paths: M src/config/config-filter.c Log Message: ----------- config: Avoid excessive data stack usage when matching local_name Moved config_filter_match_local_name() to its own function to make adding the data stack frame easier. Based on patch by J. Nick Koston Commit: 3f4d68e195ac14ab4c6fe6570659172700599343 https://github.com/dovecot/core/commit/3f4d68e195ac14ab4c6fe6570659172700599343 Author: Timo Sirainen Date: 2016-12-13 (Tue, 13 Dec 2016) Changed paths: M src/lib-storage/index/imapc/imapc-sync.c Log Message: ----------- imapc: Don't send NOOP immediately after SELECT NOOP is normally used by mailbox syncing to check if there are any changes done by other concurrent IMAP sessions. But doing it immediately after SELECT is unnecessary, because nothing could have changed. Commit: c927f013b17df637831eda48d200ccfdb4e0588a https://github.com/dovecot/core/commit/c927f013b17df637831eda48d200ccfdb4e0588a Author: manuel Date: 2016-12-13 (Tue, 13 Dec 2016) Changed paths: M src/lib-ssl-iostream/iostream-openssl.c M src/login-common/ssl-proxy-openssl.c Log Message: ----------- openssl: Clear error queue after an incomplete SSL_shutdown If the SSL_shutdown-call fails (e.g. because the underlaying socket has already been closed) OpenSSL puts the corresponding error into the queue. We don't care about details so we need to clear the queue. Otherwise the error will be pulled while error checking the next OpenSSL call of an unrelated connection. Commit: a42f612e815de8192e507d1e99c7d50f6eccc1a4 https://github.com/dovecot/core/commit/a42f612e815de8192e507d1e99c7d50f6eccc1a4 Author: Paul Howarth Date: 2016-12-13 (Tue, 13 Dec 2016) Changed paths: M configure.ac Log Message: ----------- configure: Fix some implicit function declarations Some configure tests fail unexpectedly if the compiler flag -Werror=implicit-function-declarations is enabled, which can result in the wrong implementations being used. This compiler flag is now enabled by default in Fedora Rawhide: https://fedoraproject.org/wiki/Changes/Fedora26CFlags is needed for exit() is needed for strcpy() Commit: de8d17ac9d6765311c1d611b7c72761e13086ec6 https://github.com/dovecot/core/commit/de8d17ac9d6765311c1d611b7c72761e13086ec6 Author: Aki Tuomi Date: 2016-12-13 (Tue, 13 Dec 2016) Changed paths: M src/lib-storage/list/mailbox-list-index.c Log Message: ----------- lib-storage: Do not try to recover missing list index Fixes Panic: file mailbox-list-index.c: line 342 (mailbox_list_index_parse_records): assertion failed: (node != NULL) Commit: 46c6c7a6b64c2d615dc1d072e269ba9eca7c4522 https://github.com/dovecot/core/commit/46c6c7a6b64c2d615dc1d072e269ba9eca7c4522 Author: Timo Sirainen Date: 2016-12-13 (Tue, 13 Dec 2016) Changed paths: M src/doveadm/doveadm-util.c Log Message: ----------- doveadm: When connecting to doveadm-server via TCP, use 30s timeout Should be enough, and better than the kernel's default, which might be a lot more. Commit: 731eee95835c41cfc8fc8096dc0b14e31d578ee1 https://github.com/dovecot/core/commit/731eee95835c41cfc8fc8096dc0b14e31d578ee1 Author: Timo Sirainen Date: 2016-12-13 (Tue, 13 Dec 2016) Changed paths: M src/doveadm/doveadm.c Log Message: ----------- doveadm: Add global doveadm_verbose_proctitle setting. This previously existed only for doveadm-server, but adding it to doveadm CLI makes it easier to do process title updates for it as well. Commit: d48b82df7b75285613bf502c3f52e3c09150ac47 https://github.com/dovecot/core/commit/d48b82df7b75285613bf502c3f52e3c09150ac47 Author: Timo Sirainen Date: 2016-12-13 (Tue, 13 Dec 2016) Changed paths: M src/doveadm/client-connection.c Log Message: ----------- doveadm-server: Show UNIX socket connections as in process title Earlier they were shown as empty string. Commit: ec6eabda015d7cd3cf753355482151bb167e14a5 https://github.com/dovecot/core/commit/ec6eabda015d7cd3cf753355482151bb167e14a5 Author: Timo Sirainen Date: 2016-12-13 (Tue, 13 Dec 2016) Changed paths: M src/doveadm/doveadm-dsync.c M src/doveadm/dsync/dsync-brain.c Log Message: ----------- dsync: Improve process title during initialization If something is hanging, this should make it clear what exactly it is. Commit: 364aa4716d65070dc423cb64df1f4dc219c20dfe https://github.com/dovecot/core/commit/364aa4716d65070dc423cb64df1f4dc219c20dfe Author: Timo Sirainen Date: 2016-12-13 (Tue, 13 Dec 2016) Changed paths: M src/doveadm/dsync/dsync-brain.c Log Message: ----------- dsync: Fix .dovecot-sync.lock timeout checking Whenever the lock file was recreated, the lock timeout was reset. Switched to using file_create_locked(), which already solves this problem and has compatible locking. Commit: 891b344591292e3660e8a65b14321aa91e2b1cbf https://github.com/dovecot/core/commit/891b344591292e3660e8a65b14321aa91e2b1cbf Author: Aki Tuomi Date: 2016-12-13 (Tue, 13 Dec 2016) Changed paths: M src/imap/imap-search.c Log Message: ----------- imap: Fix assert when waiting for input on SEARCH/SORT Set cmd->state to CLIENT_COMMAND_STATE_WAIT_EXTERNAL because we are not expecting input or output. Fixes Panic: file imap-client.c: line 854 (client_check_command_hangs): assertion failed: (client->io != NULL || (client->output_cmd_lock != NULL && client->output_cmd_lock != client->input_lock)) Commit: 98fdeba00c8404ce00c77f896b1afd95ce5cf42c https://github.com/dovecot/core/commit/98fdeba00c8404ce00c77f896b1afd95ce5cf42c Author: Aki Tuomi Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/doveadm/doveadm-director.c Log Message: ----------- doveadm-director: Show tag field from response Fix off-by-one in doveadm director dump Commit: 2277ba5fcff3b8e0e86f5f8fcb2d32f50a3e2fc8 https://github.com/dovecot/core/commit/2277ba5fcff3b8e0e86f5f8fcb2d32f50a3e2fc8 Author: Aki Tuomi Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/plugins/mail-crypt/mail-crypt-global-key.c M src/plugins/mail-crypt/test-mail-global-key.c Log Message: ----------- mail-crypt: Ensure array is created before accessing it Fixes segmentation fault on fs-crypt when keys are not configured. Commit: 619d00ad9da106652dec9c6425ebcef0360d87f4 https://github.com/dovecot/core/commit/619d00ad9da106652dec9c6425ebcef0360d87f4 Author: Timo Sirainen Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/lib-index/mail-index-transaction-update.c M src/lib-index/mail-index.h Log Message: ----------- lib-index: Add mail_index_revert_changes() This can be used to revert changes done in a transaction to the specified existing mail. Commit: 29ddc0769bc97a9692b0a66ec246f23219711986 https://github.com/dovecot/core/commit/29ddc0769bc97a9692b0a66ec246f23219711986 Author: Stephan Bosch Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/lib-imap/imap-bodystructure.c M src/lib-imap/test-imap-bodystructure.c Log Message: ----------- lib-imap: imap-bodystructure: Prevent writing erroneous whitespace between items in an envelope address list. Both imap_bodystructure_write() and imap_body_parse_from_bodystructure() produced such invalid output. This caused an RFC 3501 violation in IMAP FETCH BODY and BODYSTRUCTURE responses. Test suite is amended to test this situation. Commit: e78960f08f9bb77ef228dface94b9a11386c7d66 https://github.com/dovecot/core/commit/e78960f08f9bb77ef228dface94b9a11386c7d66 Author: Aki Tuomi Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/doveadm/doveadm-mail-save.c Log Message: ----------- doveadm-save: Set exit code to EX_TEMPFAIL on open error Prevents potential crash on doveadm_mail_next_user Commit: b127fb24b55ce538dbe22132443a387c047c3a4a https://github.com/dovecot/core/commit/b127fb24b55ce538dbe22132443a387c047c3a4a Author: Aki Tuomi Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/doveadm/doveadm-mail.c Log Message: ----------- doveadm-mail: Set exit code to EX_TEMPFAIL on timeout When running `doveadm save` command on proxy/director and the remote command execution times out, exit code must be set to EX_TEMPFAIL. Fixes Panic: file doveadm-mail.c: line 405 (doveadm_mail_next_user): assertion failed: (ctx->exit_code != 0) Commit: 333ccb2c51e76fc029af0327bd2def71459a57b4 https://github.com/dovecot/core/commit/333ccb2c51e76fc029af0327bd2def71459a57b4 Author: Timo Sirainen Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/lib-test/test-common.c M src/lib-test/test-common.h Log Message: ----------- lib-test: Introduce test_fatal_func_t as typedef and comment how it works. Commit: 200176aaa1bbb0b3d4ecc51ca7f5f00651ab0774 https://github.com/dovecot/core/commit/200176aaa1bbb0b3d4ecc51ca7f5f00651ab0774 Author: Timo Sirainen Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/lib-test/test-common.c M src/lib-test/test-common.h Log Message: ----------- lib-test: test_run_with_fatals() now takes a const array Commit: 1007f76fad711bd263acd510a0eb5cc78cca2d0e https://github.com/dovecot/core/commit/1007f76fad711bd263acd510a0eb5cc78cca2d0e Author: Timo Sirainen Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/lib-test/test-common.c M src/lib-test/test-common.h M src/lib/test-array.c M src/lib/test-data-stack.c M src/lib/test-lib.c M src/lib/test-lib.h M src/lib/test-mempool-alloconly.c M src/lib/test-printf-format-fix.c Log Message: ----------- lib-test: Change test_fatal_func_t to take unsigned int stage as parameter. It could never be -1, so this makes it clearer. It also removes annoying casts when comparing stage to e.g. N_ELEMENTS(). Commit: 008b46a1d3e3a1a9459590be86a4c0014e333976 https://github.com/dovecot/core/commit/008b46a1d3e3a1a9459590be86a4c0014e333976 Author: Aki Tuomi Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/lib/sha3.c Log Message: ----------- sha3: Fix typo in ifdef The code was supposed to be used with big endian machines. Reported by than at redhat.com Commit: cc94fec395fb4ba5df48a76044b4ca9cfe1b3bcb https://github.com/dovecot/core/commit/cc94fec395fb4ba5df48a76044b4ca9cfe1b3bcb Author: Aki Tuomi Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/auth/auth-policy.c Log Message: ----------- auth-policy: Allow unsupported attributes in response Do not choke if we receive unsupported attributes in response. This allows better interoperability with different systems that are getting signals from auth policy server that are not (yet) supported by dovecot. Commit: 299e2ee7101aa70e8f05e77df12832198c6f588c https://github.com/dovecot/core/commit/299e2ee7101aa70e8f05e77df12832198c6f588c Author: Aki Tuomi Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/plugins/mail-crypt/test-mail-global-key.c M src/plugins/mail-crypt/test-mail-key.c Log Message: ----------- mail-crypt: Skip tests if dcrypt cannot be initialized Avoids breaking tests on system without working ECC keys. Commit: ddc3de0b24a4d5ac1cbb0a89ed68f449ffcaa8b3 https://github.com/dovecot/core/commit/ddc3de0b24a4d5ac1cbb0a89ed68f449ffcaa8b3 Author: Aki Tuomi Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/plugins/mail-crypt/mail-crypt-plugin.c Log Message: ----------- mail-crypt: Treat empty values correctly If mail_crypt_curve or mail_crypt_save_version is left empty, disable the plugin. Don't error out. Commit: bfb24d8490fbd5f94fbbc07ea789b99aef5a697f https://github.com/dovecot/core/commit/bfb24d8490fbd5f94fbbc07ea789b99aef5a697f Author: Timo Sirainen Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/lib-storage/list/mailbox-list-index-backend.c Log Message: ----------- lib-storage: Fix crash in obox's dsync-merge Commit: db6e8f1abf8a6f626fedd3021b8adabc5caed2d9 https://github.com/dovecot/core/commit/db6e8f1abf8a6f626fedd3021b8adabc5caed2d9 Author: Aki Tuomi Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/lib-sql/driver-mysql.c Log Message: ----------- driver-mysql: Do not hex-encode again Use correct syntax to provide data to mysql in hex format, without recoding it in hex format again. Commit: 897f17c5ac0870479d2505c2eccdfeaa3ed9c7e8 https://github.com/dovecot/core/commit/897f17c5ac0870479d2505c2eccdfeaa3ed9c7e8 Author: Timo Sirainen Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/lib/file-cache.c M src/lib/file-cache.h Log Message: ----------- lib: Add file_cache_new_path() to include path in error messages. Commit: e430554859d92b631c681bbe952e8e644abc6b80 https://github.com/dovecot/core/commit/e430554859d92b631c681bbe952e8e644abc6b80 Author: Timo Sirainen Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/lib-index/mail-cache.c Log Message: ----------- lib-index: Use file_cache_new_path() for dovecot.index.cache Commit: e847976fdbfd5fd651c32f67e56294d028bd9648 https://github.com/dovecot/core/commit/e847976fdbfd5fd651c32f67e56294d028bd9648 Author: Timo Sirainen Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/plugins/fts-squat/squat-trie.c M src/plugins/fts-squat/squat-uidlist.c Log Message: ----------- fts-squat: Use file_cache_new_path() for squat indexes Commit: d677fd49ffe9ffb51b2e623085f40ac6e5d38dd7 https://github.com/dovecot/core/commit/d677fd49ffe9ffb51b2e623085f40ac6e5d38dd7 Author: Timo Sirainen Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/lib-storage/index/imapc/imapc-mailbox.c M src/lib-storage/index/imapc/imapc-search.c Log Message: ----------- imapc: Don't allow "*" in SEARCH replies Doesn't fix anything, but makes the parsing a bit more correct. Commit: cac30e45782649dd77a43304e3b1c09c23430a0e https://github.com/dovecot/core/commit/cac30e45782649dd77a43304e3b1c09c23430a0e Author: Timo Sirainen Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/lib-storage/mail-search-args-simplify.c M src/lib-storage/test-mail-search-args-simplify.c Log Message: ----------- lib-storage: Fix "*" in SEARCH seqset/uidset 4294967295 is used for "*", which matches the last existing message. Which we don't know what it is at the time of search args simplification, so avoid making any assumptions about it. It's a bit ugly that 4294967295 can't be used as a valid UID, but this restriction has already existed since the beginning of Dovecot. A future alternative might be to add MAIL_SEARCH_ARG_FLAG_SEQSET_WITH_STAR, but that's a bit complicated change. Compare: https://github.com/dovecot/core/compare/7951e2289510...cac30e457826 From noreply at github.com Thu Dec 15 15:00:14 2016 From: noreply at github.com (GitHub) Date: Thu, 15 Dec 2016 07:00:14 -0800 Subject: [dovecot/core] 783710: imap: Fix STORE UNCHANGEDSINCE to work with >32bit... Message-ID: <5852affea22e_2a803fd84b06913c6723f@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 78371091c487a22d4387d61bd977d98dc3cacb5e https://github.com/dovecot/core/commit/78371091c487a22d4387d61bd977d98dc3cacb5e Author: Timo Sirainen Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/imap/cmd-store.c Log Message: ----------- imap: Fix STORE UNCHANGEDSINCE to work with >32bit modseqs. From noreply at github.com Thu Dec 15 15:00:12 2016 From: noreply at github.com (GitHub) Date: Thu, 15 Dec 2016 07:00:12 -0800 Subject: [dovecot/core] 415796: imap: Fix STORE UNCHANGEDSINCE to work with >32bit... Message-ID: <5852affc95e2_76f23fdeea73f13c677ec@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 41579643ee25655f5bbb9b6a3533f0bb4a69fd85 https://github.com/dovecot/core/commit/41579643ee25655f5bbb9b6a3533f0bb4a69fd85 Author: Timo Sirainen Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/imap/cmd-store.c Log Message: ----------- imap: Fix STORE UNCHANGEDSINCE to work with >32bit modseqs. From noreply at github.com Thu Dec 15 22:00:10 2016 From: noreply at github.com (GitHub) Date: Thu, 15 Dec 2016 14:00:10 -0800 Subject: [dovecot/core] 365b5a: director: doveadm command handling was missing USE... Message-ID: <5853126ab72e2_f3d23f875395913c90329@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 365b5a495ae7f6fd20f6a0b0517f6aa3ad4fe1a7 https://github.com/dovecot/core/commit/365b5a495ae7f6fd20f6a0b0517f6aa3ad4fe1a7 Author: Timo Sirainen Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/director/doveadm-connection.c Log Message: ----------- director: doveadm command handling was missing USER-KICK-ALT Commit: 6460420c3843322b3e725d83288a098cbd0edee2 https://github.com/dovecot/core/commit/6460420c3843322b3e725d83288a098cbd0edee2 Author: Timo Sirainen Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/director/director.c Log Message: ----------- director: Fix USER-KICK and USER-KICK-ALT forwarding The internal IPC command was prefixed, which caused the remote director to reject the commands and disconnect: director(...): Command proxy: Unknown command proxy director(...): Remote sent invalid protocol data recently, waiting 57 secs before allowing further communication Compare: https://github.com/dovecot/core/compare/41579643ee25...6460420c3843 From noreply at github.com Thu Dec 15 22:00:13 2016 From: noreply at github.com (GitHub) Date: Thu, 15 Dec 2016 14:00:13 -0800 Subject: [dovecot/core] 21df6c: director: doveadm command handling was missing USE... Message-ID: <5853126de2491_2ab3fc451d4d12c34674@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 21df6cf4ff106b1ac31c1a80d3a27bfb420f5a8c https://github.com/dovecot/core/commit/21df6cf4ff106b1ac31c1a80d3a27bfb420f5a8c Author: Timo Sirainen Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/director/doveadm-connection.c Log Message: ----------- director: doveadm command handling was missing USER-KICK-ALT Commit: 7cf33aca1802874cd8cf98e24e9815ab86affe9c https://github.com/dovecot/core/commit/7cf33aca1802874cd8cf98e24e9815ab86affe9c Author: Timo Sirainen Date: 2016-12-15 (Thu, 15 Dec 2016) Changed paths: M src/director/director.c Log Message: ----------- director: Fix USER-KICK and USER-KICK-ALT forwarding The internal IPC command was prefixed, which caused the remote director to reject the commands and disconnect: director(...): Command proxy: Unknown command proxy director(...): Remote sent invalid protocol data recently, waiting 57 secs before allowing further communication Compare: https://github.com/dovecot/core/compare/78371091c487...7cf33aca1802 From noreply at github.com Fri Dec 16 21:30:13 2016 From: noreply at github.com (GitHub) Date: Fri, 16 Dec 2016 13:30:13 -0800 Subject: [dovecot/core] ab6166: director: Fix crash when using director_flush_sock... Message-ID: <58545ce5372c2_7ec3fa6fd5c713043294@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: ab6166287ed5539ac646e2726655a5f62de424f5 https://github.com/dovecot/core/commit/ab6166287ed5539ac646e2726655a5f62de424f5 Author: Timo Sirainen Date: 2016-12-16 (Fri, 16 Dec 2016) Changed paths: M src/director/director.c Log Message: ----------- director: Fix crash when using director_flush_socket Broken accidentally when merging b44033e45e9f48f8a6e1ac5905234fec5de6d6cc From noreply at github.com Fri Dec 16 21:30:09 2016 From: noreply at github.com (GitHub) Date: Fri, 16 Dec 2016 13:30:09 -0800 Subject: [dovecot/core] 08b70f: director: Fix crash when using director_flush_sock... Message-ID: <58545ce11d364_4e3c3f9f0534f13c21277@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 08b70fe1d49da710db3b924727c9575303374fad https://github.com/dovecot/core/commit/08b70fe1d49da710db3b924727c9575303374fad Author: Timo Sirainen Date: 2016-12-16 (Fri, 16 Dec 2016) Changed paths: M src/director/director.c Log Message: ----------- director: Fix crash when using director_flush_socket Broken accidentally when merging b44033e45e9f48f8a6e1ac5905234fec5de6d6cc From noreply at github.com Fri Dec 16 22:00:11 2016 From: noreply at github.com (GitHub) Date: Fri, 16 Dec 2016 14:00:11 -0800 Subject: [dovecot/core] 335253: lib-storage: Deduplicate code into mailbox_list_se... Message-ID: <585463ebeff0d_3eb13f9849f8f1303019e@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 33525312d3f45995686aa0b538dea1cd6eb936e2 https://github.com/dovecot/core/commit/33525312d3f45995686aa0b538dea1cd6eb936e2 Author: Timo Sirainen Date: 2016-12-16 (Fri, 16 Dec 2016) Changed paths: M src/lib-storage/index/imapc/imapc-list.c M src/lib-storage/mail-storage.c M src/lib-storage/mailbox-list-private.h M src/lib-storage/mailbox-list.c Log Message: ----------- lib-storage: Deduplicate code into mailbox_list_settings_init_defaults() Commit: fa780a18c41881036af582f7a3473d6399e9d34d https://github.com/dovecot/core/commit/fa780a18c41881036af582f7a3473d6399e9d34d Author: Timo Sirainen Date: 2016-12-16 (Fri, 16 Dec 2016) Changed paths: M src/lib-storage/list/mailbox-list-index.c M src/lib-storage/list/mailbox-list-index.h M src/lib-storage/mailbox-list-private.h M src/lib-storage/mailbox-list.c M src/lib-storage/mailbox-list.h Log Message: ----------- lib-storage: Make dovecot.list.index's filename configurable. This is useful when there are multiple namespaces pointing to the same mail root directory. For example mdbox with lazy-expunge: namespace { prefix = Expunged/ location = mdbox:~/mdbox:MAILBOXDIR=expunged:LISTINDEX=expunged.list.index .. } Compare: https://github.com/dovecot/core/compare/08b70fe1d49d...fa780a18c418 From noreply at github.com Fri Dec 16 23:30:10 2016 From: noreply at github.com (GitHub) Date: Fri, 16 Dec 2016 15:30:10 -0800 Subject: [dovecot/core] e8df5c: master: Removed unused process_exec(extra_args) pa... Message-ID: <58547902210a6_31263fb7a4dbb140102274@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: e8df5cfa65521933fa16a9487b427bfdae92c9ca https://github.com/dovecot/core/commit/e8df5cfa65521933fa16a9487b427bfdae92c9ca Author: Timo Sirainen Date: 2016-12-16 (Fri, 16 Dec 2016) Changed paths: M src/master/common.h M src/master/main.c M src/master/service-process.c Log Message: ----------- master: Removed unused process_exec(extra_args) parameter Removes unnecessarily complicated code marked with @UNSAFE. Commit: 618262376e4a087f2047e627baf008884a4085b9 https://github.com/dovecot/core/commit/618262376e4a087f2047e627baf008884a4085b9 Author: Timo Sirainen Date: 2016-12-16 (Fri, 16 Dec 2016) Changed paths: M src/lib/data-stack.h M src/lib/test-data-stack.c Log Message: ----------- lib: Remove t_buffer_*_type() The t_buffer_*() shouldn't normally be used anyway except in some low-level string/buffer manipulation code, so there's not much point in trying to make easier to use versions of them. Commit: b716136fc47efd434d60be5db262b4013e375fa9 https://github.com/dovecot/core/commit/b716136fc47efd434d60be5db262b4013e375fa9 Author: Timo Sirainen Date: 2016-12-16 (Fri, 16 Dec 2016) Changed paths: M src/lib/Makefile.am M src/lib/lib.h A src/lib/malloc-overflow.h M src/lib/test-lib.inc A src/lib/test-malloc-overflow.c Log Message: ----------- lib: Add MALLOC_MULTIPLY() and MALLOC_ADD() These can be used for calculating memory allocation sizes. If there's an overflow, the macro panics. Commit: 7e90e9424489b06ebe17a019f56eb3624ca091b2 https://github.com/dovecot/core/commit/7e90e9424489b06ebe17a019f56eb3624ca091b2 Author: Timo Sirainen Date: 2016-12-16 (Fri, 16 Dec 2016) Changed paths: M src/lib/data-stack.h M src/lib/mempool.h Log Message: ----------- lib: *_new(): Use the new MALLOC_MULTIPLY() macro to avoid overflows Cast the sizeof() result to unsigned int, because it's definitely always enough and in many cases this allows optimizing away the wrap-check. Commit: 19b9eb5baaf89c2cccce41a71191b1e7ca9283cf https://github.com/dovecot/core/commit/19b9eb5baaf89c2cccce41a71191b1e7ca9283cf Author: Timo Sirainen Date: 2016-12-16 (Fri, 16 Dec 2016) Changed paths: M src/lib/strfuncs.c Log Message: ----------- lib: Optimization - p_strconcat() doesn't need to allocate from data stack Various other parts of the code already rely on p_malloc() not overwriting t_buffer_get()'ed data. p_strconcat() can do that as well. Commit: 2ac5f36aa7c2e7a07ba8815d43a6d7483f62e74c https://github.com/dovecot/core/commit/2ac5f36aa7c2e7a07ba8815d43a6d7483f62e74c Author: Timo Sirainen Date: 2016-12-16 (Fri, 16 Dec 2016) Changed paths: M src/auth/auth-cache.c M src/auth/auth-request.c M src/auth/auth-request.h M src/auth/db-checkpassword.c M src/auth/db-ldap.c M src/auth/mech-gssapi.c M src/auth/mech-scram-sha1.c M src/auth/password-scheme.c M src/auth/userdb-dict.c M src/config/config-parser-private.h M src/config/config-parser.c M src/config/config-request.c M src/config/doveconf.c M src/config/old-set-parser.c M src/director/director-connection.c M src/doveadm/doveadm-auth-server.c M src/doveadm/doveadm-auth.c M src/doveadm/doveadm-cmd.c M src/doveadm/doveadm-fs.c M src/doveadm/doveadm-log.c M src/doveadm/doveadm-mail-mailbox.c M src/doveadm/doveadm-mail.c M src/doveadm/doveadm-print-table.c M src/doveadm/doveadm-sis.c M src/doveadm/doveadm-util.c M src/doveadm/doveadm.c M src/doveadm/dsync/dsync-brain-mailbox-tree.c M src/doveadm/dsync/dsync-mailbox-tree-sync.c M src/doveadm/dsync/dsync-mailbox-tree.c M src/imap/cmd-list.c M src/imap/cmd-notify.c M src/imap/cmd-rename.c M src/imap/cmd-subscribe.c M src/imap/imap-list.c M src/imap/imap-notify.c M src/imap/imap-status.c M src/imap/main.c M src/ipc/main.c M src/lib-compression/compression.c M src/lib-compression/ostream-bzlib.c M src/lib-compression/ostream-lzma.c M src/lib-compression/ostream-zlib.c M src/lib-dict/dict-db.c M src/lib-dict/dict-file.c M src/lib-dict/dict-memcached.c M src/lib-dict/dict-sql-settings.c M src/lib-dict/dict-sql.c M src/lib-fs/fs-dict.c M src/lib-fs/fs-posix.c M src/lib-fs/fs-test.c M src/lib-fts/fts-filter-english-possessive.c M src/lib-fts/fts-icu.c M src/lib-fts/fts-tokenizer-address.c M src/lib-fts/test-fts-tokenizer.c M src/lib-http/http-client-request.c M src/lib-imap-client/imapc-connection.c M src/lib-imap/imap-match.c M src/lib-imap/imap-parser.c M src/lib-imap/imap-quote.c M src/lib-imap/imap-utf7.c M src/lib-lda/lmtp-client.c M src/lib-mail/istream-binary-converter.c M src/lib-mail/message-decoder.c M src/lib-mail/message-header-decode.c M src/lib-mail/test-istream-attachment.c M src/lib-mail/test-istream-dot.c M src/lib-mail/test-istream-header-filter.c M src/lib-mail/test-istream-qp-decoder.c M src/lib-mail/test-mbox-from.c M src/lib-mail/test-message-header-parser.c M src/lib-master/master-login.c M src/lib-master/master-service.c M src/lib-storage/index/cydir/cydir-save.c M src/lib-storage/index/cydir/cydir-sync.h M src/lib-storage/index/dbox-common/dbox-file-fix.c M src/lib-storage/index/dbox-multi/mdbox-map.c M src/lib-storage/index/dbox-multi/mdbox-purge.c M src/lib-storage/index/imapc/imapc-list.c M src/lib-storage/index/imapc/imapc-search.c M src/lib-storage/index/imapc/imapc-storage.c M src/lib-storage/index/index-attribute.c M src/lib-storage/index/index-mail-headers.c M src/lib-storage/index/index-search.c M src/lib-storage/index/index-sort.c M src/lib-storage/index/maildir/maildir-filename-flags.c M src/lib-storage/index/maildir/maildir-save.c M src/lib-storage/index/maildir/maildir-uidlist.c M src/lib-storage/index/mbox/mbox-storage.c M src/lib-storage/index/shared/shared-list.c M src/lib-storage/list/mailbox-list-delete.c M src/lib-storage/list/mailbox-list-fs-iter.c M src/lib-storage/list/mailbox-list-index-backend.c M src/lib-storage/list/mailbox-list-index.h M src/lib-storage/list/mailbox-list-iter.c M src/lib-storage/list/mailbox-list-maildir-iter.c M src/lib-storage/list/mailbox-list-maildir.c M src/lib-storage/list/mailbox-list-notify-tree.c M src/lib-storage/list/mailbox-list-subscriptions.c M src/lib-storage/mail-namespace.c M src/lib-storage/mail-storage-service.c M src/lib-storage/mail-storage.c M src/lib-storage/mail-user.c M src/lib-storage/mailbox-list.c M src/lib-storage/mailbox-tree.c M src/lib-storage/mailbox-uidvalidity.c M src/lib/array.c M src/lib/env-util.c M src/lib/failures.c M src/lib/istream-base64-encoder.c M src/lib/json-parser.c M src/lib/module-dir.c M src/lib/net.c M src/lib/ostream-file.c M src/lib/printf-format-fix.c M src/lib/printf-format-fix.h M src/lib/str-find.c M src/lib/str-sanitize.c M src/lib/str.c M src/lib/strfuncs.c M src/lib/test-printf-format-fix.c M src/lib/unlink-old-files.c M src/lib/var-expand.c M src/lmtp/commands.c M src/log/log-error-buffer.c M src/login-common/client-common-auth.c M src/login-common/client-common.c M src/login-common/login-proxy-state.c M src/master/master-settings.c M src/master/service-process.c M src/plugins/acl/acl-lookup-dict.c M src/plugins/acl/acl-mailbox-list.c M src/plugins/dict-ldap/dict-ldap.c M src/plugins/fts-solr/fts-backend-solr-old.c M src/plugins/fts-solr/fts-backend-solr.c M src/plugins/fts-squat/squat-test.c M src/plugins/fts/fts-api.c M src/plugins/fts/fts-search-args.c M src/plugins/imap-acl/imap-acl-plugin.c M src/plugins/imap-stats/imap-stats-plugin.c M src/plugins/mail-crypt/mail-crypt-pluginenv.c M src/plugins/mail-crypt/mail-crypt-userenv.c M src/plugins/quota/quota-dirsize.c M src/replication/aggregator/replicator-connection.c Log Message: ----------- global: Change string position/length from unsigned int to size_t Mainly to avoid truncating >4GB strings, which might potentially cause some security holes. Normally there are other limits, which prevent such excessive strings from being created in the first place. I'm sure this didn't find everything. Maybe everything could be found with compiler warnings. -Wconversion kind of does it, but it gives way too many unnecessary warnings. These were mainly found with: grep " = strlen" egrep "unsigned int.*(size|len)" Commit: e7d0bea63a08b08c47c4b5c187d2cb7127859657 https://github.com/dovecot/core/commit/e7d0bea63a08b08c47c4b5c187d2cb7127859657 Author: Timo Sirainen Date: 2016-12-16 (Fri, 16 Dec 2016) Changed paths: M src/auth/auth-request-var-expand.c M src/doveadm/doveadm-dump-index.c M src/lib-imap/imap-utf7.c M src/lib-index/mail-index-transaction-view.c M src/lib-index/mail-index.c M src/lib-master/master-login.c M src/lib-program-client/program-client-local.c M src/lib-storage/index/maildir/maildir-save.c M src/lib-storage/index/pop3c/pop3c-sync.c M src/lib-storage/mailbox-list.c M src/lib/data-stack.c M src/lib/hex-binary.c M src/lib/str-find.c M src/lib/strfuncs.c M src/log/log-error-buffer.c M src/plugins/acl/acl-cache.c M src/plugins/acl/acl-cache.h M src/pop3/pop3-client.h M src/pop3/pop3-commands.c M src/stats/mail-command.c M src/stats/mail-domain.c M src/stats/mail-ip.c M src/stats/mail-session.c M src/stats/mail-user.c Log Message: ----------- global: Make sure *_malloc() calculations won't cause integer overflows. Compare: https://github.com/dovecot/core/compare/fa780a18c418...e7d0bea63a08 From noreply at github.com Sat Dec 17 09:00:10 2016 From: noreply at github.com (GitHub) Date: Sat, 17 Dec 2016 01:00:10 -0800 Subject: [dovecot/core] ad5ece: lib: Compiler warning fix for 32bit systems Message-ID: <5854fe9a1541_69cf3fbeff96113c666e2@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: ad5ece2a07cca5fa033287f70bafdd312e2338a5 https://github.com/dovecot/core/commit/ad5ece2a07cca5fa033287f70bafdd312e2338a5 Author: Timo Sirainen Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/lib/test-malloc-overflow.c Log Message: ----------- lib: Compiler warning fix for 32bit systems From noreply at github.com Sat Dec 17 09:30:10 2016 From: noreply at github.com (GitHub) Date: Sat, 17 Dec 2016 01:30:10 -0800 Subject: [dovecot/core] af577c: imapc: Fix infinite reconnect loop to remote serve... Message-ID: <585505a28155_76673fd4b69ad13c837ba@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: af577c113808263cb7a9b8121e1c91ecaedacb59 https://github.com/dovecot/core/commit/af577c113808263cb7a9b8121e1c91ecaedacb59 Author: Timo Sirainen Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/lib-imap-client/imapc-connection.c Log Message: ----------- imapc: Fix infinite reconnect loop to remote server that is down This happened only in some situations. Usually there would have bene some command in the queue, which would cause the reconnect-check to fail. Commit: bc6b363c7b1b284ddbb5e2774e53b3da123d630e https://github.com/dovecot/core/commit/bc6b363c7b1b284ddbb5e2774e53b3da123d630e Author: Timo Sirainen Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/lib-imap-client/imapc-connection.c Log Message: ----------- imapc: Don't retry a failed reconnection before 10 secs have passed This mainly avoids a lot of unnecessary connect attempts within a short time period, for example if the caller attempts to perform some work for all the mailboxes. Commit: 5c0d3b064bd0107e062de40732bdc0250e4d9d57 https://github.com/dovecot/core/commit/5c0d3b064bd0107e062de40732bdc0250e4d9d57 Author: Timo Sirainen Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/lib-imap-client/imapc-connection.c Log Message: ----------- imapc: Minor debug logging improvement Commit: b80e0097ab96ca62d1b9ddf4b2d7b7c77c745307 https://github.com/dovecot/core/commit/b80e0097ab96ca62d1b9ddf4b2d7b7c77c745307 Author: Timo Sirainen Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/lib-storage/index/imapc/imapc-list.c M src/lib-storage/index/imapc/imapc-search.c M src/lib-storage/index/imapc/imapc-storage.c Log Message: ----------- imapc: Log server disconnection error only once. Compare: https://github.com/dovecot/core/compare/ad5ece2a07cc...b80e0097ab96 From noreply at github.com Sat Dec 17 10:00:09 2016 From: noreply at github.com (GitHub) Date: Sat, 17 Dec 2016 02:00:09 -0800 Subject: [dovecot/core] 637ea1: master: PROCESS-STATUS output was duplicated many ... Message-ID: <58550ca953274_50663f819a5eb130103099@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 637ea12c037d177741eb5acaa4a1fcfa382355c6 https://github.com/dovecot/core/commit/637ea12c037d177741eb5acaa4a1fcfa382355c6 Author: Timo Sirainen Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/master/master-client.c Log Message: ----------- master: PROCESS-STATUS output was duplicated many times From noreply at github.com Sat Dec 17 10:00:14 2016 From: noreply at github.com (GitHub) Date: Sat, 17 Dec 2016 02:00:14 -0800 Subject: [dovecot/core] a6c326: lib-storage: Deduplicate code into mailbox_list_se... Message-ID: <58550cae2483b_327d3f88c323112c770a8@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: a6c32606655cf7fa370f19a2ae5fdf1e2a992549 https://github.com/dovecot/core/commit/a6c32606655cf7fa370f19a2ae5fdf1e2a992549 Author: Timo Sirainen Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/lib-storage/index/imapc/imapc-list.c M src/lib-storage/mail-storage.c M src/lib-storage/mailbox-list-private.h M src/lib-storage/mailbox-list.c Log Message: ----------- lib-storage: Deduplicate code into mailbox_list_settings_init_defaults() Commit: ff6dc2d92f84eb4ead6da33ff254653969f70079 https://github.com/dovecot/core/commit/ff6dc2d92f84eb4ead6da33ff254653969f70079 Author: Timo Sirainen Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/lib-storage/list/mailbox-list-index.c M src/lib-storage/list/mailbox-list-index.h M src/lib-storage/mailbox-list-private.h M src/lib-storage/mailbox-list.c M src/lib-storage/mailbox-list.h Log Message: ----------- lib-storage: Make dovecot.list.index's filename configurable. This is useful when there are multiple namespaces pointing to the same mail root directory. For example mdbox with lazy-expunge: namespace { prefix = Expunged/ location = mdbox:~/mdbox:MAILBOXDIR=expunged:LISTINDEX=expunged.list.index .. } Commit: 201c1ef337be3bfbff680dc0216233b708fbd9e6 https://github.com/dovecot/core/commit/201c1ef337be3bfbff680dc0216233b708fbd9e6 Author: Timo Sirainen Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/master/common.h M src/master/main.c M src/master/service-process.c Log Message: ----------- master: Removed unused process_exec(extra_args) parameter Removes unnecessarily complicated code marked with @UNSAFE. Commit: d75ed2777ab9ab1e0049dc3a07fef76fffcf7bee https://github.com/dovecot/core/commit/d75ed2777ab9ab1e0049dc3a07fef76fffcf7bee Author: Timo Sirainen Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/lib/data-stack.h M src/lib/test-data-stack.c Log Message: ----------- lib: Remove t_buffer_*_type() The t_buffer_*() shouldn't normally be used anyway except in some low-level string/buffer manipulation code, so there's not much point in trying to make easier to use versions of them. Commit: bbc11b4a44233cfbc8ba66bfde78d044f0cc37c1 https://github.com/dovecot/core/commit/bbc11b4a44233cfbc8ba66bfde78d044f0cc37c1 Author: Timo Sirainen Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/lib/Makefile.am M src/lib/lib.h A src/lib/malloc-overflow.h M src/lib/test-lib.c M src/lib/test-lib.h A src/lib/test-malloc-overflow.c Log Message: ----------- lib: Add MALLOC_MULTIPLY() and MALLOC_ADD() These can be used for calculating memory allocation sizes. If there's an overflow, the macro panics. Commit: 95ed21ee318c0c948d27c129dd0594154a92bb5e https://github.com/dovecot/core/commit/95ed21ee318c0c948d27c129dd0594154a92bb5e Author: Timo Sirainen Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/lib/data-stack.h M src/lib/mempool.h Log Message: ----------- lib: *_new(): Use the new MALLOC_MULTIPLY() macro to avoid overflows Cast the sizeof() result to unsigned int, because it's definitely always enough and in many cases this allows optimizing away the wrap-check. Commit: 94a510926a97ae9065c22d4724035ceab4b3f870 https://github.com/dovecot/core/commit/94a510926a97ae9065c22d4724035ceab4b3f870 Author: Timo Sirainen Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/lib/strfuncs.c Log Message: ----------- lib: Optimization - p_strconcat() doesn't need to allocate from data stack Various other parts of the code already rely on p_malloc() not overwriting t_buffer_get()'ed data. p_strconcat() can do that as well. Commit: 3391c9ec14cb663f5b264b1d7c709d3a08a7a85c https://github.com/dovecot/core/commit/3391c9ec14cb663f5b264b1d7c709d3a08a7a85c Author: Timo Sirainen Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/auth/auth-cache.c M src/auth/auth-request.c M src/auth/auth-request.h M src/auth/db-checkpassword.c M src/auth/db-ldap.c M src/auth/mech-gssapi.c M src/auth/mech-scram-sha1.c M src/auth/password-scheme.c M src/auth/userdb-dict.c M src/config/config-parser-private.h M src/config/config-parser.c M src/config/config-request.c M src/config/doveconf.c M src/config/old-set-parser.c M src/director/director-connection.c M src/doveadm/doveadm-auth-server.c M src/doveadm/doveadm-auth.c M src/doveadm/doveadm-cmd.c M src/doveadm/doveadm-fs.c M src/doveadm/doveadm-log.c M src/doveadm/doveadm-mail-mailbox.c M src/doveadm/doveadm-mail.c M src/doveadm/doveadm-print-table.c M src/doveadm/doveadm-sis.c M src/doveadm/doveadm-util.c M src/doveadm/doveadm.c M src/doveadm/dsync/dsync-brain-mailbox-tree.c M src/doveadm/dsync/dsync-mailbox-tree-sync.c M src/doveadm/dsync/dsync-mailbox-tree.c M src/imap/cmd-list.c M src/imap/cmd-notify.c M src/imap/cmd-rename.c M src/imap/cmd-subscribe.c M src/imap/imap-list.c M src/imap/imap-notify.c M src/imap/imap-status.c M src/imap/main.c M src/ipc/main.c M src/lib-compression/compression.c M src/lib-compression/ostream-bzlib.c M src/lib-compression/ostream-lzma.c M src/lib-compression/ostream-zlib.c M src/lib-dict/dict-db.c M src/lib-dict/dict-file.c M src/lib-dict/dict-memcached.c M src/lib-dict/dict-sql-settings.c M src/lib-dict/dict-sql.c M src/lib-fs/fs-dict.c M src/lib-fs/fs-posix.c M src/lib-fs/fs-test.c M src/lib-fts/fts-filter-english-possessive.c M src/lib-fts/fts-icu.c M src/lib-fts/fts-tokenizer-address.c M src/lib-fts/test-fts-tokenizer.c M src/lib-http/http-client-request.c M src/lib-imap-client/imapc-connection.c M src/lib-imap/imap-match.c M src/lib-imap/imap-parser.c M src/lib-imap/imap-quote.c M src/lib-imap/imap-utf7.c M src/lib-lda/lmtp-client.c M src/lib-mail/istream-binary-converter.c M src/lib-mail/message-decoder.c M src/lib-mail/message-header-decode.c M src/lib-mail/test-istream-attachment.c M src/lib-mail/test-istream-dot.c M src/lib-mail/test-istream-header-filter.c M src/lib-mail/test-istream-qp-decoder.c M src/lib-mail/test-mbox-from.c M src/lib-mail/test-message-header-parser.c M src/lib-master/master-login.c M src/lib-master/master-service.c M src/lib-storage/index/cydir/cydir-save.c M src/lib-storage/index/cydir/cydir-sync.h M src/lib-storage/index/dbox-common/dbox-file-fix.c M src/lib-storage/index/dbox-multi/mdbox-map.c M src/lib-storage/index/dbox-multi/mdbox-purge.c M src/lib-storage/index/imapc/imapc-list.c M src/lib-storage/index/imapc/imapc-search.c M src/lib-storage/index/imapc/imapc-storage.c M src/lib-storage/index/index-attribute.c M src/lib-storage/index/index-mail-headers.c M src/lib-storage/index/index-search.c M src/lib-storage/index/index-sort.c M src/lib-storage/index/maildir/maildir-filename-flags.c M src/lib-storage/index/maildir/maildir-save.c M src/lib-storage/index/maildir/maildir-uidlist.c M src/lib-storage/index/mbox/mbox-storage.c M src/lib-storage/index/shared/shared-list.c M src/lib-storage/list/mailbox-list-delete.c M src/lib-storage/list/mailbox-list-fs-iter.c M src/lib-storage/list/mailbox-list-index-backend.c M src/lib-storage/list/mailbox-list-index.h M src/lib-storage/list/mailbox-list-iter.c M src/lib-storage/list/mailbox-list-maildir-iter.c M src/lib-storage/list/mailbox-list-maildir.c M src/lib-storage/list/mailbox-list-notify-tree.c M src/lib-storage/list/mailbox-list-subscriptions.c M src/lib-storage/mail-namespace.c M src/lib-storage/mail-storage-service.c M src/lib-storage/mail-storage.c M src/lib-storage/mail-user.c M src/lib-storage/mailbox-list.c M src/lib-storage/mailbox-tree.c M src/lib-storage/mailbox-uidvalidity.c M src/lib/array.c M src/lib/env-util.c M src/lib/failures.c M src/lib/istream-base64-encoder.c M src/lib/json-parser.c M src/lib/module-dir.c M src/lib/net.c M src/lib/ostream-file.c M src/lib/printf-format-fix.c M src/lib/printf-format-fix.h M src/lib/str-find.c M src/lib/str-sanitize.c M src/lib/str.c M src/lib/strfuncs.c M src/lib/test-printf-format-fix.c M src/lib/unlink-old-files.c M src/lib/var-expand.c M src/lmtp/commands.c M src/log/log-error-buffer.c M src/login-common/client-common-auth.c M src/login-common/client-common.c M src/login-common/login-proxy-state.c M src/master/master-settings.c M src/master/service-process.c M src/plugins/acl/acl-lookup-dict.c M src/plugins/acl/acl-mailbox-list.c M src/plugins/dict-ldap/dict-ldap.c M src/plugins/fts-solr/fts-backend-solr-old.c M src/plugins/fts-solr/fts-backend-solr.c M src/plugins/fts-squat/squat-test.c M src/plugins/fts/fts-api.c M src/plugins/fts/fts-search-args.c M src/plugins/imap-acl/imap-acl-plugin.c M src/plugins/imap-stats/imap-stats-plugin.c M src/plugins/mail-crypt/mail-crypt-pluginenv.c M src/plugins/mail-crypt/mail-crypt-userenv.c M src/plugins/quota/quota-dirsize.c M src/replication/aggregator/replicator-connection.c Log Message: ----------- global: Change string position/length from unsigned int to size_t Mainly to avoid truncating >4GB strings, which might potentially cause some security holes. Normally there are other limits, which prevent such excessive strings from being created in the first place. I'm sure this didn't find everything. Maybe everything could be found with compiler warnings. -Wconversion kind of does it, but it gives way too many unnecessary warnings. These were mainly found with: grep " = strlen" egrep "unsigned int.*(size|len)" Commit: 4fcb886f42905880ce673fe070405b199373c14c https://github.com/dovecot/core/commit/4fcb886f42905880ce673fe070405b199373c14c Author: Timo Sirainen Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/auth/auth-request-var-expand.c M src/doveadm/doveadm-dump-index.c M src/lib-imap/imap-utf7.c M src/lib-index/mail-index-transaction-view.c M src/lib-index/mail-index.c M src/lib-master/master-login.c M src/lib-program-client/program-client-local.c M src/lib-storage/index/maildir/maildir-save.c M src/lib-storage/index/pop3c/pop3c-sync.c M src/lib-storage/mailbox-list.c M src/lib/data-stack.c M src/lib/hex-binary.c M src/lib/str-find.c M src/lib/strfuncs.c M src/log/log-error-buffer.c M src/plugins/acl/acl-cache.c M src/plugins/acl/acl-cache.h M src/pop3/pop3-client.h M src/pop3/pop3-commands.c M src/stats/mail-command.c M src/stats/mail-domain.c M src/stats/mail-ip.c M src/stats/mail-session.c M src/stats/mail-user.c Log Message: ----------- global: Make sure *_malloc() calculations won't cause integer overflows. Commit: 4dd1b4885668ab9eebdd5349e490262f868552db https://github.com/dovecot/core/commit/4dd1b4885668ab9eebdd5349e490262f868552db Author: Timo Sirainen Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/lib/test-malloc-overflow.c Log Message: ----------- lib: Compiler warning fix for 32bit systems Commit: fd2be97ae75bc25983877c65caadfd413ba0a9c5 https://github.com/dovecot/core/commit/fd2be97ae75bc25983877c65caadfd413ba0a9c5 Author: Timo Sirainen Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/lib-imap-client/imapc-connection.c Log Message: ----------- imapc: Fix infinite reconnect loop to remote server that is down This happened only in some situations. Usually there would have bene some command in the queue, which would cause the reconnect-check to fail. Commit: eb2df28ed4a1daa11437c4f6b99004c64211097f https://github.com/dovecot/core/commit/eb2df28ed4a1daa11437c4f6b99004c64211097f Author: Timo Sirainen Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/lib-imap-client/imapc-connection.c Log Message: ----------- imapc: Don't retry a failed reconnection before 10 secs have passed This mainly avoids a lot of unnecessary connect attempts within a short time period, for example if the caller attempts to perform some work for all the mailboxes. Commit: 7bebbde574bcf7bc722fec90dddcc43d0a2e4ca1 https://github.com/dovecot/core/commit/7bebbde574bcf7bc722fec90dddcc43d0a2e4ca1 Author: Timo Sirainen Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/lib-imap-client/imapc-connection.c Log Message: ----------- imapc: Minor debug logging improvement Commit: 613ab472b6adf9934c9192770ef90e864561f692 https://github.com/dovecot/core/commit/613ab472b6adf9934c9192770ef90e864561f692 Author: Timo Sirainen Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/lib-storage/index/imapc/imapc-list.c M src/lib-storage/index/imapc/imapc-search.c M src/lib-storage/index/imapc/imapc-storage.c Log Message: ----------- imapc: Log server disconnection error only once. Commit: eed2ab4b426f435b0c8520e212200223c8b78c66 https://github.com/dovecot/core/commit/eed2ab4b426f435b0c8520e212200223c8b78c66 Author: Timo Sirainen Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/master/master-client.c Log Message: ----------- master: PROCESS-STATUS output was duplicated many times Compare: https://github.com/dovecot/core/compare/ab6166287ed5...eed2ab4b426f From noreply at github.com Sun Dec 18 10:30:08 2016 From: noreply at github.com (GitHub) Date: Sun, 18 Dec 2016 02:30:08 -0800 Subject: [dovecot/core] fc0b23: lib-http: client: Prevent infinite event loop invo... Message-ID: <58566530d8948_3e963ff1fa8fd1402399e@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: fc0b239ad1dd884d7137734e22ab758060b40e2e https://github.com/dovecot/core/commit/fc0b239ad1dd884d7137734e22ab758060b40e2e Author: Stephan Bosch Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/lib-http/http-client-peer.c Log Message: ----------- lib-http: client: Prevent infinite event loop involving the request handler. Could happen when a backoff time is active. Commit: 50188cf3548e718e5ed0150d29e9aa2d31979440 https://github.com/dovecot/core/commit/50188cf3548e718e5ed0150d29e9aa2d31979440 Author: Stephan Bosch Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/lib-http/http-client-peer.c Log Message: ----------- lib-http: client: Moved connection backoff timer management to separate functions. Commit: bad9931efd293ea9a676ce99e82c539e9d215e0d https://github.com/dovecot/core/commit/bad9931efd293ea9a676ce99e82c539e9d215e0d Author: Stephan Bosch Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/lib-http/http-client-connection.c M src/lib-http/http-client-private.h Log Message: ----------- lib-http: client: Consolidated connection loss handling into a single function. Commit: f17ac27e5989d6b3b3e4f4fb249bef4b06833ab7 https://github.com/dovecot/core/commit/f17ac27e5989d6b3b3e4f4fb249bef4b06833ab7 Author: Stephan Bosch Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/lib-http/http-client-connection.c M src/lib-http/http-client-peer.c M src/lib-http/http-client-private.h Log Message: ----------- lib-http: client: Treat connections that get disconnected prematurely as connection failures. This means that the backoff time is increased when this happens. A premature disconnection happens when the connection is disconnected before any data is received from the server. Commit: fd54a8a6c420c61db635e45129203c7ee645d999 https://github.com/dovecot/core/commit/fd54a8a6c420c61db635e45129203c7ee645d999 Author: Stephan Bosch Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/lib-http/test-http-client-errors.c Log Message: ----------- lib-http: client: Added test for normal connection backoff behavior to test-http-client-errors. Commit: 166fc8ba3be22456f849175d2f677c2f10ecc528 https://github.com/dovecot/core/commit/166fc8ba3be22456f849175d2f677c2f10ecc528 Author: Stephan Bosch Date: 2016-12-17 (Sat, 17 Dec 2016) Changed paths: M src/lib-http/test-http-client-errors.c Log Message: ----------- lib-http: client: Added test for premature connection loss to test-http-client-errors. Commit: 4584794477433c420554f70094dbf56c85986982 https://github.com/dovecot/core/commit/4584794477433c420554f70094dbf56c85986982 Author: Stephan Bosch Date: 2016-12-18 (Sun, 18 Dec 2016) Changed paths: M src/lib-imap-client/imapc-connection.c Log Message: ----------- lib-imap-client: Fixed boolean vs integer mixup in debug message format argument. Found with Clang -Wstrict-bool. Compare: https://github.com/dovecot/core/compare/637ea12c037d...458479447743 From noreply at github.com Sun Dec 18 11:00:09 2016 From: noreply at github.com (GitHub) Date: Sun, 18 Dec 2016 03:00:09 -0800 Subject: [dovecot/core] 51292e: lib: Optimize printf_format_fix_noalloc() Message-ID: <58566c39707da_16ef3fdea1879140590d5@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 51292e327a91a257b8baea83560b3a8323cac8c5 https://github.com/dovecot/core/commit/51292e327a91a257b8baea83560b3a8323cac8c5 Author: Timo Sirainen Date: 2016-12-18 (Sun, 18 Dec 2016) Changed paths: M src/lib/printf-format-fix.c Log Message: ----------- lib: Optimize printf_format_fix_noalloc() Using strchr() is faster than looping through the characters manually. Since this function is being called a lot, it's worth optimizing. Commit: 4baf980b75800ad3595c39dc3b8d913f2686affd https://github.com/dovecot/core/commit/4baf980b75800ad3595c39dc3b8d913f2686affd Author: Timo Sirainen Date: 2016-12-18 (Sun, 18 Dec 2016) Changed paths: M src/lib/printf-format-fix.c M src/lib/test-printf-format-fix.c Log Message: ----------- lib: Fix %n detection in printf_format_fix_noalloc() It's undefined how flags, precision or length modifiers are handled with %n, so make sure we catch all of them to detect an unwanted %n. Commit: ebe00087d3c7f9706d4acb9017eaad912404516c https://github.com/dovecot/core/commit/ebe00087d3c7f9706d4acb9017eaad912404516c Author: Timo Sirainen Date: 2016-12-18 (Sun, 18 Dec 2016) Changed paths: M src/lib/printf-format-fix.c Log Message: ----------- lib: Allow only known %chars in printf_format_fix_noalloc() Otherwise if some libc adds a new unsupported character, our %n check might break. Commit: b48648a49c41b18dd8ea8761e48e4c64e105adec https://github.com/dovecot/core/commit/b48648a49c41b18dd8ea8761e48e4c64e105adec Author: Timo Sirainen Date: 2016-12-18 (Sun, 18 Dec 2016) Changed paths: M src/lib/test-malloc-overflow.c Log Message: ----------- lib: Remove dead code from unit test Compare: https://github.com/dovecot/core/compare/458479447743...b48648a49c41 From noreply at github.com Mon Dec 19 12:00:11 2016 From: noreply at github.com (GitHub) Date: Mon, 19 Dec 2016 04:00:11 -0800 Subject: [dovecot/core] 55cdf2: master: Update assert to make sure optind != 0 Message-ID: <5857cbcbbce6e_466b3fb79ff8d130337a7@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 55cdf2ed53584247aab18d2689ba24264211ccf6 https://github.com/dovecot/core/commit/55cdf2ed53584247aab18d2689ba24264211ccf6 Author: Timo Sirainen Date: 2016-12-18 (Sun, 18 Dec 2016) Changed paths: M src/master/main.c Log Message: ----------- master: Update assert to make sure optind != 0 Hopefully prevents Coverity warning about "doubleops[optind]" access being uninitialized. Commit: f59ff04ef90e50d0bf52d264ae5d879387bf051d https://github.com/dovecot/core/commit/f59ff04ef90e50d0bf52d264ae5d879387bf051d Author: Timo Sirainen Date: 2016-12-19 (Mon, 19 Dec 2016) Changed paths: M configure.ac Log Message: ----------- configure: Define __STDC_LIMIT_MACROS for CXXFLAGS Fixes SIZE_MAX being undefined when building fts-lucene. Commit: 261c0ffe765bcd5c654f7c85f5874baea870a8a5 https://github.com/dovecot/core/commit/261c0ffe765bcd5c654f7c85f5874baea870a8a5 Author: Aki Tuomi Date: 2016-12-19 (Mon, 19 Dec 2016) Changed paths: M src/lib-index/mail-transaction-log-file.c Log Message: ----------- lib-index: Make sure buffer is not null before freeing Fixes signal 11 crash under stress. Compare: https://github.com/dovecot/core/compare/b48648a49c41...261c0ffe765b From noreply at github.com Mon Dec 19 12:00:13 2016 From: noreply at github.com (GitHub) Date: Mon, 19 Dec 2016 04:00:13 -0800 Subject: [dovecot/core] 9bc8d9: auth: do NOT feed p_strconcat() with NULL Message-ID: <5857cbcdb5505_70cc3fdac2ccd134676a8@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 9bc8d9b2047f9685a098e26c0f84c9ea75ea1cee https://github.com/dovecot/core/commit/9bc8d9b2047f9685a098e26c0f84c9ea75ea1cee Author: Baofeng Date: 2016-12-19 (Mon, 19 Dec 2016) Changed paths: M src/auth/auth.c Log Message: ----------- auth: do NOT feed p_strconcat() with NULL p_strconcat will never take NULL as an valid argument. Check possible NULL string before calling it. From noreply at github.com Tue Dec 20 08:00:14 2016 From: noreply at github.com (GitHub) Date: Tue, 20 Dec 2016 00:00:14 -0800 Subject: [dovecot/core] 2cf7f1: lib-http: client: Prevent infinite event loop invo... Message-ID: <5858e50eddf27_883d3ff748ac913811168f@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 2cf7f1b1de7e7a46a5658d8a415a904f00d4493b https://github.com/dovecot/core/commit/2cf7f1b1de7e7a46a5658d8a415a904f00d4493b Author: Stephan Bosch Date: 2016-12-20 (Tue, 20 Dec 2016) Changed paths: M src/lib-http/http-client-peer.c Log Message: ----------- lib-http: client: Prevent infinite event loop involving the request handler. Could happen when a backoff time is active. Commit: adbc1f7242a684a933ae291e4f1e1b104a1e38cb https://github.com/dovecot/core/commit/adbc1f7242a684a933ae291e4f1e1b104a1e38cb Author: Stephan Bosch Date: 2016-12-20 (Tue, 20 Dec 2016) Changed paths: M src/lib-http/http-client-peer.c Log Message: ----------- lib-http: client: Moved connection backoff timer management to separate functions. Commit: bee4ea836522b5ba644810d75608cae8c8d7a16f https://github.com/dovecot/core/commit/bee4ea836522b5ba644810d75608cae8c8d7a16f Author: Stephan Bosch Date: 2016-12-20 (Tue, 20 Dec 2016) Changed paths: M src/lib-http/http-client-connection.c M src/lib-http/http-client-private.h Log Message: ----------- lib-http: client: Consolidated connection loss handling into a single function. Commit: 4710cc0b19fe0fa604d586cd3825c34af0c114a0 https://github.com/dovecot/core/commit/4710cc0b19fe0fa604d586cd3825c34af0c114a0 Author: Stephan Bosch Date: 2016-12-20 (Tue, 20 Dec 2016) Changed paths: M src/lib-http/http-client-connection.c M src/lib-http/http-client-peer.c M src/lib-http/http-client-private.h Log Message: ----------- lib-http: client: Treat connections that get disconnected prematurely as connection failures. This means that the backoff time is increased when this happens. A premature disconnection happens when the connection is disconnected before any data is received from the server. Commit: 6650976aa15aeaf3994dd13577b0a03035c319e5 https://github.com/dovecot/core/commit/6650976aa15aeaf3994dd13577b0a03035c319e5 Author: Stephan Bosch Date: 2016-12-20 (Tue, 20 Dec 2016) Changed paths: M src/lib-http/test-http-client-errors.c Log Message: ----------- lib-http: client: Added test for normal connection backoff behavior to test-http-client-errors. Commit: 4ba0369a50476b2b1055f636f0386dff5e864a7d https://github.com/dovecot/core/commit/4ba0369a50476b2b1055f636f0386dff5e864a7d Author: Stephan Bosch Date: 2016-12-20 (Tue, 20 Dec 2016) Changed paths: M src/lib-http/test-http-client-errors.c Log Message: ----------- lib-http: client: Added test for premature connection loss to test-http-client-errors. Commit: 28f5ddb56a78d68ec25de4cf55ea846ae87bfa8a https://github.com/dovecot/core/commit/28f5ddb56a78d68ec25de4cf55ea846ae87bfa8a Author: Stephan Bosch Date: 2016-12-20 (Tue, 20 Dec 2016) Changed paths: M src/lib-imap-client/imapc-connection.c Log Message: ----------- lib-imap-client: Fixed boolean vs integer mixup in debug message format argument. Found with Clang -Wstrict-bool. Commit: c38f69924b6fd2ff697ee87a3371ade4fd66ae15 https://github.com/dovecot/core/commit/c38f69924b6fd2ff697ee87a3371ade4fd66ae15 Author: Timo Sirainen Date: 2016-12-20 (Tue, 20 Dec 2016) Changed paths: M src/lib/printf-format-fix.c Log Message: ----------- lib: Optimize printf_format_fix_noalloc() Using strchr() is faster than looping through the characters manually. Since this function is being called a lot, it's worth optimizing. Commit: 966ae459220d45a8b7c56efed4916ac18137c8cf https://github.com/dovecot/core/commit/966ae459220d45a8b7c56efed4916ac18137c8cf Author: Timo Sirainen Date: 2016-12-20 (Tue, 20 Dec 2016) Changed paths: M src/lib/printf-format-fix.c M src/lib/test-printf-format-fix.c Log Message: ----------- lib: Fix %n detection in printf_format_fix_noalloc() It's undefined how flags, precision or length modifiers are handled with %n, so make sure we catch all of them to detect an unwanted %n. Commit: 92f2c8bf45ce2de930393fca3dfd43d039807128 https://github.com/dovecot/core/commit/92f2c8bf45ce2de930393fca3dfd43d039807128 Author: Timo Sirainen Date: 2016-12-20 (Tue, 20 Dec 2016) Changed paths: M src/lib/printf-format-fix.c Log Message: ----------- lib: Allow only known %chars in printf_format_fix_noalloc() Otherwise if some libc adds a new unsupported character, our %n check might break. Commit: 2d53d80b9274eb0b616f42842bd8577dcbba14d4 https://github.com/dovecot/core/commit/2d53d80b9274eb0b616f42842bd8577dcbba14d4 Author: Timo Sirainen Date: 2016-12-20 (Tue, 20 Dec 2016) Changed paths: M src/lib/test-malloc-overflow.c Log Message: ----------- lib: Remove dead code from unit test Commit: a9f1d66140724e7db0264b3ff2e2bcf364464f43 https://github.com/dovecot/core/commit/a9f1d66140724e7db0264b3ff2e2bcf364464f43 Author: Timo Sirainen Date: 2016-12-20 (Tue, 20 Dec 2016) Changed paths: M src/master/main.c Log Message: ----------- master: Update assert to make sure optind != 0 Hopefully prevents Coverity warning about "doubleops[optind]" access being uninitialized. Commit: 88f7ecdbd88f18da6a0ed22f3f03fba89efece1c https://github.com/dovecot/core/commit/88f7ecdbd88f18da6a0ed22f3f03fba89efece1c Author: Timo Sirainen Date: 2016-12-20 (Tue, 20 Dec 2016) Changed paths: M configure.ac Log Message: ----------- configure: Define __STDC_LIMIT_MACROS for CXXFLAGS Fixes SIZE_MAX being undefined when building fts-lucene. Commit: eb0308e25bb81c691b21d8036b9c5f77eca9ca76 https://github.com/dovecot/core/commit/eb0308e25bb81c691b21d8036b9c5f77eca9ca76 Author: Aki Tuomi Date: 2016-12-20 (Tue, 20 Dec 2016) Changed paths: M src/lib-index/mail-transaction-log-file.c Log Message: ----------- lib-index: Make sure buffer is not null before freeing Fixes signal 11 crash under stress. Compare: https://github.com/dovecot/core/compare/9bc8d9b2047f...eb0308e25bb8 From noreply at github.com Fri Dec 23 13:30:10 2016 From: noreply at github.com (GitHub) Date: Fri, 23 Dec 2016 05:30:10 -0800 Subject: [dovecot/core] 00a15f: Fix compiling when compiler doesn't support typeof... Message-ID: <585d26e27abc6_77b73fa6b101113812341c@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 00a15fe7ccadda399a86fe67ad2ed22488ff0c05 https://github.com/dovecot/core/commit/00a15fe7ccadda399a86fe67ad2ed22488ff0c05 Author: Timo Sirainen Date: 2016-12-21 (Wed, 21 Dec 2016) Changed paths: M src/lib-dns/test-dns-util.c M src/plugins/dict-ldap/dict-ldap.c Log Message: ----------- Fix compiling when compiler doesn't support typeof() Commit: dcb783533ad1d6944db7c227cde46414a575d81c https://github.com/dovecot/core/commit/dcb783533ad1d6944db7c227cde46414a575d81c Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib-fts/fts-filter-normalizer-icu.c M src/lib-fts/fts-icu.c M src/lib-fts/fts-icu.h M src/lib-fts/test-fts-icu.c Log Message: ----------- lib-fts: Change fts_icu_*() to use ARRAY_TYPE(icu_utf16) for UTF16 input. This makes it clearer how the API is intended to be used. Commit: a669d351502e15802b121e1a0bd83f27d1d95f01 https://github.com/dovecot/core/commit/a669d351502e15802b121e1a0bd83f27d1d95f01 Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib-sasl/dsasl-client-private.h M src/lib-sasl/dsasl-client.c M src/lib-sasl/dsasl-client.h M src/lib-sasl/mech-external.c M src/lib-sasl/mech-login.c M src/lib-sasl/mech-plain.c Log Message: ----------- lib-sasl: API change - use size_t type for input/output lengths It's highly unlikely that the length is ever >4GB, but this avoids any potential problems with integer truncation. Commit: 1fa1180b97d7164a656f8c0b8a29553c160f1e8b https://github.com/dovecot/core/commit/1fa1180b97d7164a656f8c0b8a29553c160f1e8b Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/plugins/replication/replication-plugin.c Log Message: ----------- replication plugin: Error handling code cleanup The old code happened to work in all cases, but it was more of an accident. Commit: 43294747701bc261834d88d6c040831f03ae8935 https://github.com/dovecot/core/commit/43294747701bc261834d88d6c040831f03ae8935 Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M dovecot.service.in Log Message: ----------- dovecot.service.in: Improve [service] examples Move them inside [service] section so that simply uncommenting them works. Also give a better example of how Environment might be used. Commit: 266fcf2ad538b4ef612c2df3cca9bcb50a2d1a31 https://github.com/dovecot/core/commit/266fcf2ad538b4ef612c2df3cca9bcb50a2d1a31 Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib-mail/message-binary-part.c Log Message: ----------- lib-mail: message_binary_part_deserialize(): Return error if body line count is too large The input was unsigned int, so output must also fit into unsigned int. Commit: ac63c3ce5a04f762286513f8aea90fbe8f84d80c https://github.com/dovecot/core/commit/ac63c3ce5a04f762286513f8aea90fbe8f84d80c Author: Martti Rannanj?rvi Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/replication/replicator/doveadm-connection.c Log Message: ----------- replication: ignore o_stream_send errors in doveadm-connection Compare: https://github.com/dovecot/core/compare/261c0ffe765b...ac63c3ce5a04 From noreply at github.com Fri Dec 23 14:00:12 2016 From: noreply at github.com (GitHub) Date: Fri, 23 Dec 2016 06:00:12 -0800 Subject: [dovecot/core] 6d0e6c: imap: use o_stream_nsend when not checking failure Message-ID: <585d2dec4c265_4e843f96811fd1301105c5@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 6d0e6c57cf45ad517748cfbb5f3aa3b53e42e3d0 https://github.com/dovecot/core/commit/6d0e6c57cf45ad517748cfbb5f3aa3b53e42e3d0 Author: Martti Rannanj?rvi Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/imap/cmd-getmetadata.c M src/imap/cmd-thread.c M src/imap/imap-master-client.c Log Message: ----------- imap: use o_stream_nsend when not checking failure Commit: 044b0557e92ae0bb3b25af49d5468bad3d17db43 https://github.com/dovecot/core/commit/044b0557e92ae0bb3b25af49d5468bad3d17db43 Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib-index/mail-cache.c Log Message: ----------- lib-index: Fix checking if cache file becomes >4GB Commit: d7ff3c153fdf39acd70b6883482a0fdbf9d7917f https://github.com/dovecot/core/commit/d7ff3c153fdf39acd70b6883482a0fdbf9d7917f Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib-fs/fs-randomfail.c Log Message: ----------- fs-randomfail: Fix failure handling for fs_read() Commit: 405fc7c0f97c04658ccd15202da4b2004ebc082d https://github.com/dovecot/core/commit/405fc7c0f97c04658ccd15202da4b2004ebc082d Author: Martti Rannanj?rvi Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/stats/client-export.c Log Message: ----------- stats: use o_stream_nsend in client-export Commit: ce2312763f6b5fd2da8bfb20847b87f29b063fa8 https://github.com/dovecot/core/commit/ce2312763f6b5fd2da8bfb20847b87f29b063fa8 Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib-index/mail-transaction-log-file.c Log Message: ----------- lib-index: Fix assert-crash if .log creation unexpectedly fails at the end Pretty much the only reason for this to happen is if the index directory was deleted while another process still had the index open. Even this doesn't normally trigger this crash, because there are other checks earlier that usually catch it. So it crashes only in some race conditions. Fixes: Error: rename(.../dovecot.index.log.newlock, .../dovecot.index.log) failed: No such file or directory Panic: file mail-transaction-log-file.c: line 105 (mail_transaction_log_file_free): assertion failed: (!file->locked) Compare: https://github.com/dovecot/core/compare/ac63c3ce5a04...ce2312763f6b From noreply at github.com Fri Dec 23 14:00:16 2016 From: noreply at github.com (GitHub) Date: Fri, 23 Dec 2016 06:00:16 -0800 Subject: [dovecot/core] 80d514: Fix compiling when compiler doesn't support typeof... Message-ID: <585d2df0bbffe_3ea03fb932edf14090284@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 80d514f8b71b9bd7c892433efa761716b90f7075 https://github.com/dovecot/core/commit/80d514f8b71b9bd7c892433efa761716b90f7075 Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib-dns/test-dns-util.c M src/plugins/dict-ldap/dict-ldap.c Log Message: ----------- Fix compiling when compiler doesn't support typeof() Commit: 14a866d54c8208a7fbeee27c6b031f33ab98ebf9 https://github.com/dovecot/core/commit/14a866d54c8208a7fbeee27c6b031f33ab98ebf9 Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/plugins/replication/replication-plugin.c Log Message: ----------- replication plugin: Error handling code cleanup The old code happened to work in all cases, but it was more of an accident. Commit: c12b91e3471f54e3e70e322970e389bdeb0ef445 https://github.com/dovecot/core/commit/c12b91e3471f54e3e70e322970e389bdeb0ef445 Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M dovecot.service.in Log Message: ----------- dovecot.service.in: Improve [service] examples Move them inside [service] section so that simply uncommenting them works. Also give a better example of how Environment might be used. Commit: 50593e2292db081cd9ef4d8ac7cc7e125a3a7178 https://github.com/dovecot/core/commit/50593e2292db081cd9ef4d8ac7cc7e125a3a7178 Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib-mail/message-binary-part.c Log Message: ----------- lib-mail: message_binary_part_deserialize(): Return error if body line count is too large The input was unsigned int, so output must also fit into unsigned int. Commit: 68a71b355f91ea5d73b65d1d856b0ec0b925e091 https://github.com/dovecot/core/commit/68a71b355f91ea5d73b65d1d856b0ec0b925e091 Author: Martti Rannanj?rvi Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/replication/replicator/doveadm-connection.c Log Message: ----------- replication: ignore o_stream_send errors in doveadm-connection Commit: 9f6ad59ac3a882df7fd9501918c7d2ff38fa3886 https://github.com/dovecot/core/commit/9f6ad59ac3a882df7fd9501918c7d2ff38fa3886 Author: Martti Rannanj?rvi Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/imap/cmd-getmetadata.c M src/imap/cmd-thread.c M src/imap/imap-master-client.c Log Message: ----------- imap: use o_stream_nsend when not checking failure Commit: 2422b561f338c29627e854683ccd6909015d76f0 https://github.com/dovecot/core/commit/2422b561f338c29627e854683ccd6909015d76f0 Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib-index/mail-cache.c Log Message: ----------- lib-index: Fix checking if cache file becomes >4GB Commit: 2068fde31114a2755ecadf151ce0b0747f9b534c https://github.com/dovecot/core/commit/2068fde31114a2755ecadf151ce0b0747f9b534c Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib-fs/fs-randomfail.c Log Message: ----------- fs-randomfail: Fix failure handling for fs_read() Commit: 7686697853a6a42207b110184cbe8e745a81e95a https://github.com/dovecot/core/commit/7686697853a6a42207b110184cbe8e745a81e95a Author: Martti Rannanj?rvi Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/stats/client-export.c Log Message: ----------- stats: use o_stream_nsend in client-export Commit: 1997fe1cea2d0ec389919469f5a6f14b2d5443f5 https://github.com/dovecot/core/commit/1997fe1cea2d0ec389919469f5a6f14b2d5443f5 Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib-index/mail-transaction-log-file.c Log Message: ----------- lib-index: Fix assert-crash if .log creation unexpectedly fails at the end Pretty much the only reason for this to happen is if the index directory was deleted while another process still had the index open. Even this doesn't normally trigger this crash, because there are other checks earlier that usually catch it. So it crashes only in some race conditions. Fixes: Error: rename(.../dovecot.index.log.newlock, .../dovecot.index.log) failed: No such file or directory Panic: file mail-transaction-log-file.c: line 105 (mail_transaction_log_file_free): assertion failed: (!file->locked) Compare: https://github.com/dovecot/core/compare/eb0308e25bb8...1997fe1cea2d From noreply at github.com Fri Dec 23 16:00:10 2016 From: noreply at github.com (GitHub) Date: Fri, 23 Dec 2016 08:00:10 -0800 Subject: [dovecot/core] 2c5c29: *-login, imapc: Fix new lib-sasl API usage Message-ID: <585d4a0a9dea7_33643ff65e6b51407150@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 2c5c293940fd6c7e020e1d58dae77a9d01f9059b https://github.com/dovecot/core/commit/2c5c293940fd6c7e020e1d58dae77a9d01f9059b Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/imap-login/imap-proxy.c M src/lib-imap-client/imapc-connection.c M src/pop3-login/pop3-proxy.c Log Message: ----------- *-login, imapc: Fix new lib-sasl API usage Forgot to include these in a669d351502e15802b121e1a0bd83f27d1d95f01 From noreply at github.com Fri Dec 23 17:00:11 2016 From: noreply at github.com (GitHub) Date: Fri, 23 Dec 2016 09:00:11 -0800 Subject: [dovecot/core] b7a607: lib-test: test_run_named*() - use const for tests[... Message-ID: <585d581bee68a_1f7313f9ce238313c73d5@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: b7a60785a9ed8a1afef479ccc30bc23a9c46feef https://github.com/dovecot/core/commit/b7a60785a9ed8a1afef479ccc30bc23a9c46feef Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib-test/test-common.c M src/lib-test/test-common.h Log Message: ----------- lib-test: test_run_named*() - use const for tests[] array Commit: b7324e421e2132cbbf753e6fdbe675bbaecdf929 https://github.com/dovecot/core/commit/b7324e421e2132cbbf753e6fdbe675bbaecdf929 Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/auth/test-auth-cache.c M src/lib-charset/test-charset.c M src/lib-dcrypt/test-crypto.c M src/lib-dns/test-dns-util.c M src/lib-fts/test-fts-filter.c M src/lib-fts/test-fts-tokenizer.c M src/lib-imap/test-imap-quote.c M src/lib-imap/test-imap-utf7.c M src/lib-index/test-mail-index-modseq.c M src/lib-mail/test-istream-header-filter.c M src/lib-mail/test-mail-html2text.c M src/lib-mail/test-message-snippet.c M src/lib-mail/test-rfc822-parser.c M src/lib-settings/test-settings-parser.c M src/lib-storage/test-mail-search-args-imap.c M src/lib-storage/test-mail-search-args-simplify.c M src/lib/test-hash-format.c M src/lib/test-ioloop.c M src/lib/test-istream-base64-decoder.c M src/lib/test-istream-base64-encoder.c M src/lib/test-json-parser.c M src/lib/test-lib.c M src/lib/test-malloc-overflow.c M src/lib/test-net.c M src/lib/test-numpack.c M src/lib/test-seq-range-array.c M src/lib/test-str-sanitize.c M src/lib/test-strescape.c M src/lib/test-strfuncs.c M src/lib/test-time-util.c M src/lib/test-utc-mktime.c M src/lib/test-var-expand.c M src/lib/test-wildcard-match.c M src/plugins/pop3-migration/test-pop3-migration-plugin.c Log Message: ----------- global: Use "static const" for all struct tests[] arrays Commit: 440f9bf580c42860f741560cbc3789be959cf777 https://github.com/dovecot/core/commit/440f9bf580c42860f741560cbc3789be959cf777 Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib-test/test-common.c M src/lib-test/test-common.h Log Message: ----------- lib-test: test_run*() - use const for test_functions[] array Commit: baf3e87e186453fda13bd21f7cbcb2efc8492e8b https://github.com/dovecot/core/commit/baf3e87e186453fda13bd21f7cbcb2efc8492e8b Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/anvil/test-penalty.c M src/auth/test-auth-cache.c M src/auth/test-auth-request-var-expand.c M src/auth/test-db-dict.c M src/director/test-user-directory.c M src/doveadm/dsync/test-dsync-mailbox-tree-sync.c M src/doveadm/test-doveadm-util.c M src/lib-charset/test-charset.c M src/lib-compression/test-compression.c M src/lib-dcrypt/test-crypto.c M src/lib-dcrypt/test-stream.c M src/lib-dict/test-dict.c M src/lib-dns/test-dns-util.c M src/lib-fs/test-fs-metawrap.c M src/lib-fts/test-fts-filter.c M src/lib-fts/test-fts-icu.c M src/lib-fts/test-fts-language.c M src/lib-fts/test-fts-tokenizer.c M src/lib-http/test-http-auth.c M src/lib-http/test-http-client-errors.c M src/lib-http/test-http-date.c M src/lib-http/test-http-header-parser.c M src/lib-http/test-http-payload.c M src/lib-http/test-http-request-parser.c M src/lib-http/test-http-response-parser.c M src/lib-http/test-http-server-errors.c M src/lib-http/test-http-transfer.c M src/lib-http/test-http-url.c M src/lib-imap/test-imap-bodystructure.c M src/lib-imap/test-imap-match.c M src/lib-imap/test-imap-parser.c M src/lib-imap/test-imap-quote.c M src/lib-imap/test-imap-url.c M src/lib-imap/test-imap-utf7.c M src/lib-imap/test-imap-util.c M src/lib-index/test-mail-index-map.c M src/lib-index/test-mail-index-modseq.c M src/lib-index/test-mail-index-sync-ext.c M src/lib-index/test-mail-index-transaction-finish.c M src/lib-index/test-mail-index-transaction-update.c M src/lib-index/test-mail-transaction-log-append.c M src/lib-index/test-mail-transaction-log-view.c M src/lib-mail/test-istream-attachment.c M src/lib-mail/test-istream-binary-converter.c M src/lib-mail/test-istream-dot.c M src/lib-mail/test-istream-header-filter.c M src/lib-mail/test-istream-qp-decoder.c M src/lib-mail/test-mail-html2text.c M src/lib-mail/test-mbox-from.c M src/lib-mail/test-message-address.c M src/lib-mail/test-message-date.c M src/lib-mail/test-message-decoder.c M src/lib-mail/test-message-header-decode.c M src/lib-mail/test-message-header-encode.c M src/lib-mail/test-message-header-hash.c M src/lib-mail/test-message-header-parser.c M src/lib-mail/test-message-id.c M src/lib-mail/test-message-parser.c M src/lib-mail/test-message-part.c M src/lib-mail/test-message-search.c M src/lib-mail/test-message-snippet.c M src/lib-mail/test-ostream-dot.c M src/lib-mail/test-qp-decoder.c M src/lib-mail/test-quoted-printable.c M src/lib-mail/test-rfc2231-parser.c M src/lib-mail/test-rfc822-parser.c M src/lib-master/test-master-service-settings-cache.c M src/lib-settings/test-settings-parser.c M src/lib-storage/test-mail-search-args-imap.c M src/lib-storage/test-mail-search-args-simplify.c M src/lib-storage/test-mailbox-get.c M src/plugins/pop3-migration/test-pop3-migration-plugin.c M src/plugins/quota/test-quota-util.c Log Message: ----------- global: Use const for all test_functions[] arrays Compare: https://github.com/dovecot/core/compare/2c5c293940fd...baf3e87e1864 From noreply at github.com Fri Dec 23 18:30:11 2016 From: noreply at github.com (GitHub) Date: Fri, 23 Dec 2016 10:30:11 -0800 Subject: [dovecot/core] e0bd5e: lib: istream-base64-decoder - use stream_errno=EPI... Message-ID: <585d6d3357082_193f3fe0f04ab134686c2@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: e0bd5e662367e8c53c65ee3ad1252dd9469784cf https://github.com/dovecot/core/commit/e0bd5e662367e8c53c65ee3ad1252dd9469784cf Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib/istream-base64-decoder.c M src/lib/test-istream-base64-decoder.c Log Message: ----------- lib: istream-base64-decoder - use stream_errno=EPIPE for unexpected EOF Commit: 076c46c6513161e2c7bbe53d421b0830e9975fb1 https://github.com/dovecot/core/commit/076c46c6513161e2c7bbe53d421b0830e9975fb1 Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib/istream-jsonstr.c Log Message: ----------- lib: istream-jsonstr - minor code cleanup If ret==0 here, it means dest wasn't changed, which must mean that i==0. Make it clear to avoid confusion. Commit: ddf9529d37056f8817825f6265c27d8070123013 https://github.com/dovecot/core/commit/ddf9529d37056f8817825f6265c27d8070123013 Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib/Makefile.am A src/lib/test-istream-jsonstr.c M src/lib/test-lib.inc Log Message: ----------- lib: Add istream-jsonstr unit test. Commit: 1547bafeb11368eb80168fe2899283e8bdcb8528 https://github.com/dovecot/core/commit/1547bafeb11368eb80168fe2899283e8bdcb8528 Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib/istream-jsonstr.c M src/lib/test-istream-jsonstr.c Log Message: ----------- lib: istream-jsonstr - return EPIPE if end-of-string quote isn't seen Compare: https://github.com/dovecot/core/compare/baf3e87e1864...1547bafeb113 From noreply at github.com Fri Dec 23 19:00:11 2016 From: noreply at github.com (GitHub) Date: Fri, 23 Dec 2016 11:00:11 -0800 Subject: [dovecot/core] cd0fe9: lib-mail: istream-attachment-extractor - remove un... Message-ID: <585d743b4b0bc_1bfc3f9df512d1301055d0@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: cd0fe951e5f5f158201d1c13096b2ac0796f377f https://github.com/dovecot/core/commit/cd0fe951e5f5f158201d1c13096b2ac0796f377f Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib-mail/istream-attachment-extractor.c Log Message: ----------- lib-mail: istream-attachment-extractor - remove unnecessary code It's enough to set the stream_errno. Commit: 3979d59aa4e45a49f101eb8a1301e4c2e1eee727 https://github.com/dovecot/core/commit/3979d59aa4e45a49f101eb8a1301e4c2e1eee727 Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib-mail/istream-attachment-extractor.c Log Message: ----------- lib-mail: istream-attachment-extractor - use EIO for internal errors These happen only if the attachment writing failed for some reason. The input stream itself can't have any errors, so EINVAL isn't proper. Commit: 9d0be57bcc352f776a327d7e2a6c6232137f4a04 https://github.com/dovecot/core/commit/9d0be57bcc352f776a327d7e2a6c6232137f4a04 Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib-mail/test-istream-attachment.c Log Message: ----------- lib-mail: Improve istream-attachment-extractor unit test for EIO errors Commit: aba4cdf6d9de7d0a900933f390df8a822bbdc08c https://github.com/dovecot/core/commit/aba4cdf6d9de7d0a900933f390df8a822bbdc08c Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib-storage/index/istream-mail.c Log Message: ----------- lib-storage: istream-mail - Use EPIPE if istream is too small Commit: 25463ef4c130177c9c0c11e77270fc5561b12ba2 https://github.com/dovecot/core/commit/25463ef4c130177c9c0c11e77270fc5561b12ba2 Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib-fs/istream-metawrap.c Log Message: ----------- lib-fs: istream-metawrap - set stream_errno=EPIPE on unexpected EOF Commit: a4883ee9daf4e3a463faf43b304fd44b21aa73ee https://github.com/dovecot/core/commit/a4883ee9daf4e3a463faf43b304fd44b21aa73ee Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib-mail/istream-qp-decoder.c M src/lib-mail/test-istream-qp-decoder.c Log Message: ----------- lib-mail: istream-qp-decoder: set stream_errno=EPIPE on unexpected EOF Commit: b7cabbb8fd1d662008faf20d2ec93e4be51f1e96 https://github.com/dovecot/core/commit/b7cabbb8fd1d662008faf20d2ec93e4be51f1e96 Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib-compression/istream-bzlib.c M src/lib-compression/istream-lz4.c Log Message: ----------- lib-compression: istream-{bzlib|lz4} - set stream_errno=EPIPE on unexpected EOF Compare: https://github.com/dovecot/core/compare/1547bafeb113...b7cabbb8fd1d From noreply at github.com Fri Dec 23 19:30:11 2016 From: noreply at github.com (GitHub) Date: Fri, 23 Dec 2016 11:30:11 -0800 Subject: [dovecot/core] 4f2278: lib: istream-sized - remove explicit i_error() log... Message-ID: <585d7b43beccd_6a193f7fdc70713c7332e@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 4f22781ec4cd5bc1bfdfe856cbaed40b2ab137f6 https://github.com/dovecot/core/commit/4f22781ec4cd5bc1bfdfe856cbaed40b2ab137f6 Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib/istream-sized.c Log Message: ----------- lib: istream-sized - remove explicit i_error() logging The stream_errno is set, so it's the caller's responsibility to log the error. There's no need to log it twice. Commit: 574d36db88f15662529fb65da6fc8c5e4c8f12fa https://github.com/dovecot/core/commit/574d36db88f15662529fb65da6fc8c5e4c8f12fa Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib/istream-sized.c M src/lib/istream-sized.h A src/lib/test-istream-sized.c Log Message: ----------- lib: istream-sized - set stream_errno=EPIPE if stream is too small Commit: c328d220858bc7cf7e67987e7862eb0b7bf8671d https://github.com/dovecot/core/commit/c328d220858bc7cf7e67987e7862eb0b7bf8671d Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib/istream-sized.c Log Message: ----------- lib: istream-sized - consistently set stream_errno=EINVAL if stream is too large Earlier it was sometimes done and sometimes not, depending on whether the parent istream happened to stop at the expected boundary. Commit: c81ec7de302a1c38f4ea27a82dad3b2f631701d9 https://github.com/dovecot/core/commit/c81ec7de302a1c38f4ea27a82dad3b2f631701d9 Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib/Makefile.am M src/lib/test-lib.inc Log Message: ----------- lib: Add unit test for istream-sized Compare: https://github.com/dovecot/core/compare/b7cabbb8fd1d...c81ec7de302a From noreply at github.com Fri Dec 23 20:00:10 2016 From: noreply at github.com (GitHub) Date: Fri, 23 Dec 2016 12:00:10 -0800 Subject: [dovecot/core] aab570: lib-mail: Fix memory leak in test-istream-attachme... Message-ID: <585d824add4c6_1ffbc3fd91cf0b13c119577@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: aab5704d21173f9f825c016812c8099d16ea5b9f https://github.com/dovecot/core/commit/aab5704d21173f9f825c016812c8099d16ea5b9f Author: Timo Sirainen Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib-mail/test-istream-attachment.c Log Message: ----------- lib-mail: Fix memory leak in test-istream-attachment From noreply at github.com Fri Dec 23 22:36:18 2016 From: noreply at github.com (GitHub) Date: Fri, 23 Dec 2016 14:36:18 -0800 Subject: [dovecot/core] 96de40: Fix link failure against libressl. Message-ID: <585da6e21c56_2da663ff2229731381499b4@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 96de40971a8915de0840a6ecb00ad94e40c7366a https://github.com/dovecot/core/commit/96de40971a8915de0840a6ecb00ad94e40c7366a Author: Nick Wallingford Date: 2016-12-23 (Fri, 23 Dec 2016) Changed paths: M src/lib-ssl-iostream/dovecot-openssl-common.c Log Message: ----------- Fix link failure against libressl. From noreply at github.com Sat Dec 24 01:30:12 2016 From: noreply at github.com (GitHub) Date: Fri, 23 Dec 2016 17:30:12 -0800 Subject: [dovecot/core] 707460: global: Made all struct initialization using memse... Message-ID: <585dcfa4efedb_ab843fbaaa82f13c2192c@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 707460082809119f71d1ecffc29af83f2e12eac0 https://github.com/dovecot/core/commit/707460082809119f71d1ecffc29af83f2e12eac0 Author: Stephan Bosch Date: 2016-12-24 (Sat, 24 Dec 2016) Changed paths: M src/lib-dcrypt/dcrypt-openssl.c M src/lib-dict/dict-cdb.c M src/lib-dict/dict-db.c M src/lib-http/http-url.c M src/lib-imap/imap-date.c M src/lib-imap/imap-url.c M src/lib/net.c Log Message: ----------- global: Made all struct initialization using memset() use the same style. Commit: 08cb8e0ae115be975be66fffe7a4c0ffaee8223e https://github.com/dovecot/core/commit/08cb8e0ae115be975be66fffe7a4c0ffaee8223e Author: Stephan Bosch Date: 2016-12-24 (Sat, 24 Dec 2016) Changed paths: M src/lib/macros.h Log Message: ----------- lib: Created i_zero() wrapper for memset(p, 0, sizeof(*p)). Also creates an i_zero_safe() version for safe_memset(). Commit: efe78d3ba24fc866af1c79b9223dc0809ba26cad https://github.com/dovecot/core/commit/efe78d3ba24fc866af1c79b9223dc0809ba26cad Author: Stephan Bosch Date: 2016-12-24 (Sat, 24 Dec 2016) Changed paths: M src/auth/auth-request-var-expand.c M src/auth/auth-request.c M src/auth/auth-settings.c M src/auth/db-dict.c M src/auth/db-ldap.c M src/auth/main.c M src/auth/passdb-pam.c M src/config/config-connection.c M src/config/config-filter.c M src/config/config-parser.c M src/config/doveconf.c M src/config/old-set-parser.c M src/dict/dict-connection.c M src/dict/main.c M src/director/login-connection.c M src/doveadm/client-connection-http.c M src/doveadm/client-connection.c M src/doveadm/doveadm-auth-server.c M src/doveadm/doveadm-auth.c M src/doveadm/doveadm-cmd.c M src/doveadm/doveadm-dict.c M src/doveadm/doveadm-dsync.c M src/doveadm/doveadm-fs.c M src/doveadm/doveadm-kick.c M src/doveadm/doveadm-log.c M src/doveadm/doveadm-mail-batch.c M src/doveadm/doveadm-mail-fetch.c M src/doveadm/doveadm-mail-import.c M src/doveadm/doveadm-mail-mailbox-status.c M src/doveadm/doveadm-mail-server.c M src/doveadm/doveadm-mail.c M src/doveadm/doveadm-penalty.c M src/doveadm/doveadm-print-formatted.c M src/doveadm/doveadm-print-json.c M src/doveadm/doveadm-print.c M src/doveadm/doveadm-pw.c M src/doveadm/doveadm-stats.c M src/doveadm/doveadm-util.c M src/doveadm/doveadm-who.c M src/doveadm/doveadm-zlib.c M src/doveadm/doveadm.c M src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c M src/doveadm/dsync/dsync-brain-mailbox.c M src/doveadm/dsync/dsync-brain-mails.c M src/doveadm/dsync/dsync-brain.c M src/doveadm/dsync/dsync-ibc-stream.c M src/doveadm/dsync/dsync-mail.c M src/doveadm/dsync/dsync-mailbox-export.c M src/doveadm/dsync/dsync-mailbox-import.c M src/doveadm/dsync/dsync-mailbox-tree-fill.c M src/doveadm/dsync/dsync-transaction-log-scan.c M src/doveadm/main.c M src/doveadm/server-connection.c M src/imap-hibernate/imap-hibernate-client.c M src/imap-login/client-authenticate.c M src/imap-login/imap-proxy.c M src/imap-urlauth/imap-urlauth-worker.c M src/imap-urlauth/imap-urlauth.c M src/imap/cmd-fetch.c M src/imap/cmd-notify.c M src/imap/cmd-select.c M src/imap/cmd-setmetadata.c M src/imap/cmd-store.c M src/imap/imap-client.c M src/imap/imap-commands-util.c M src/imap/imap-commands.c M src/imap/imap-fetch.c M src/imap/imap-master-client.c M src/imap/imap-notify.c M src/imap/imap-state.c M src/imap/imap-status.c M src/imap/main.c M src/indexer/indexer-worker.c M src/indexer/master-connection.c M src/lda/main.c M src/lib-auth/auth-master.c M src/lib-auth/auth-server-connection.c M src/lib-dcrypt/dcrypt-gnutls.c M src/lib-dcrypt/dcrypt-openssl.c M src/lib-dcrypt/dcrypt.c M src/lib-dcrypt/test-crypto.c M src/lib-dict-extra/dict-fs.c M src/lib-dict/dict-cdb.c M src/lib-dict/dict-client.c M src/lib-dict/dict-db.c M src/lib-dict/dict-file.c M src/lib-dict/dict-memcached-ascii.c M src/lib-dict/dict-memcached.c M src/lib-dict/dict-sql-settings.c M src/lib-dict/dict-sql.c M src/lib-dict/dict.c M src/lib-dict/test-dict-client.c M src/lib-dns/dns-lookup.c M src/lib-fs/fs-api.c M src/lib-fs/fs-dict.c M src/lib-fs/fs-posix.c M src/lib-fs/fs-test-async.c M src/lib-fs/fs-test.c M src/lib-fts/fts-icu.c M src/lib-http/http-auth.c M src/lib-http/http-client-connection.c M src/lib-http/http-client-host.c M src/lib-http/http-client-request.c M src/lib-http/http-date.c M src/lib-http/http-message-parser.c M src/lib-http/http-parser.c M src/lib-http/http-request-parser.c M src/lib-http/http-response-parser.c M src/lib-http/http-response.c M src/lib-http/http-server-connection.c M src/lib-http/http-server-response.c M src/lib-http/http-url.c M src/lib-http/test-http-auth.c M src/lib-http/test-http-client-errors.c M src/lib-http/test-http-client.c M src/lib-http/test-http-payload.c M src/lib-http/test-http-response-parser.c M src/lib-http/test-http-server-errors.c M src/lib-http/test-http-server.c M src/lib-imap-client/imapc-client.c M src/lib-imap-client/imapc-connection.c M src/lib-imap-storage/imap-metadata.c M src/lib-imap-storage/imap-msgpart-url.c M src/lib-imap-storage/imap-msgpart.c M src/lib-imap-urlauth/imap-urlauth-backend.c M src/lib-imap-urlauth/imap-urlauth-connection.c M src/lib-imap-urlauth/imap-urlauth-fetch.c M src/lib-imap/imap-bodystructure.c M src/lib-imap/imap-date.c M src/lib-imap/imap-id.c M src/lib-imap/imap-url.c M src/lib-index/mail-cache-compress.c M src/lib-index/mail-cache-fields.c M src/lib-index/mail-cache-lookup.c M src/lib-index/mail-cache-transaction.c M src/lib-index/mail-index-alloc-cache.c M src/lib-index/mail-index-fsck.c M src/lib-index/mail-index-map-read.c M src/lib-index/mail-index-map.c M src/lib-index/mail-index-modseq.c M src/lib-index/mail-index-strmap.c M src/lib-index/mail-index-sync-ext.c M src/lib-index/mail-index-sync-keywords.c M src/lib-index/mail-index-sync-update.c M src/lib-index/mail-index-sync.c M src/lib-index/mail-index-transaction-export.c M src/lib-index/mail-index-transaction-update.c M src/lib-index/mail-index-transaction-view.c M src/lib-index/mail-index-transaction.c M src/lib-index/mail-index-view-sync.c M src/lib-index/mail-index-view.c M src/lib-index/mail-index.c M src/lib-index/mail-transaction-log-append.c M src/lib-index/mail-transaction-log-file.c M src/lib-index/mail-transaction-log.c M src/lib-index/test-mail-index-map.c M src/lib-index/test-mail-index-sync-ext.c M src/lib-index/test-mail-index-transaction-finish.c M src/lib-index/test-mail-transaction-log-view.c M src/lib-lda/duplicate.c M src/lib-lda/lmtp-client.c M src/lib-lda/mail-deliver.c M src/lib-lda/smtp-client.c M src/lib-ldap/ldap-compare.c M src/lib-ldap/ldap-connection.c M src/lib-mail/istream-attachment-extractor.c M src/lib-mail/mbox-from.c M src/lib-mail/message-address.c M src/lib-mail/message-date.c M src/lib-mail/message-header-decode.c M src/lib-mail/message-header-parser.c M src/lib-mail/message-parser.c M src/lib-mail/message-part-serialize.c M src/lib-mail/message-search.c M src/lib-mail/message-snippet.c M src/lib-mail/rfc2231-parser.c M src/lib-mail/rfc822-parser.c M src/lib-mail/test-istream-attachment.c M src/lib-mail/test-message-decoder.c M src/lib-mail/test-message-header-hash.c M src/lib-mail/test-message-search.c M src/lib-master/master-auth.c M src/lib-master/master-login.c M src/lib-master/master-service-settings.c M src/lib-master/master-service-ssl.c M src/lib-master/master-service.c M src/lib-master/test-master-service-settings-cache.c M src/lib-ntlm/ntlm-message.c M src/lib-settings/settings-parser.c M src/lib-settings/settings.c M src/lib-sql/driver-cassandra.c M src/lib-sql/driver-mysql.c M src/lib-sql/driver-pgsql.c M src/lib-sql/driver-sqlite.c M src/lib-ssl-iostream/iostream-ssl.c M src/lib-storage/index/dbox-common/dbox-save.c M src/lib-storage/index/dbox-multi/mdbox-deleted-storage.c M src/lib-storage/index/dbox-multi/mdbox-map.c M src/lib-storage/index/dbox-multi/mdbox-save.c M src/lib-storage/index/dbox-multi/mdbox-storage-rebuild.c M src/lib-storage/index/dbox-multi/mdbox-storage.c M src/lib-storage/index/dbox-single/sdbox-storage.c M src/lib-storage/index/dbox-single/sdbox-sync-rebuild.c M src/lib-storage/index/imapc/imapc-list.c M src/lib-storage/index/imapc/imapc-storage.c M src/lib-storage/index/index-attachment.c M src/lib-storage/index/index-attribute.c M src/lib-storage/index/index-mail-binary.c M src/lib-storage/index/index-mail-headers.c M src/lib-storage/index/index-mail.c M src/lib-storage/index/index-mailbox-size.c M src/lib-storage/index/index-pop3-uidl.c M src/lib-storage/index/index-rebuild.c M src/lib-storage/index/index-search-result.c M src/lib-storage/index/index-search.c M src/lib-storage/index/index-sort-string.c M src/lib-storage/index/index-sort.c M src/lib-storage/index/index-storage.c M src/lib-storage/index/index-sync-changes.c M src/lib-storage/index/index-sync.c M src/lib-storage/index/index-thread-finish.c M src/lib-storage/index/index-thread.c M src/lib-storage/index/index-transaction.c M src/lib-storage/index/maildir/maildir-copy.c M src/lib-storage/index/maildir/maildir-mail.c M src/lib-storage/index/maildir/maildir-sync-index.c M src/lib-storage/index/maildir/maildir-uidlist.c M src/lib-storage/index/mbox/mbox-lock.c M src/lib-storage/index/mbox/mbox-save.c M src/lib-storage/index/mbox/mbox-sync-list-index.c M src/lib-storage/index/mbox/mbox-sync-parse.c M src/lib-storage/index/mbox/mbox-sync-rewrite.c M src/lib-storage/index/mbox/mbox-sync.c M src/lib-storage/index/pop3c/pop3c-client.c M src/lib-storage/index/pop3c/pop3c-storage.c M src/lib-storage/index/pop3c/pop3c-sync.c M src/lib-storage/list/mailbox-list-index-backend.c M src/lib-storage/list/mailbox-list-index-notify.c M src/lib-storage/list/mailbox-list-index-status.c M src/lib-storage/list/mailbox-list-index-sync.c M src/lib-storage/list/mailbox-list-iter.c M src/lib-storage/list/mailbox-list-notify-tree.c M src/lib-storage/list/mailbox-list-subscriptions.c M src/lib-storage/list/subscription-file.c M src/lib-storage/mail-search-args-simplify.c M src/lib-storage/mail-search-build.c M src/lib-storage/mail-storage-hooks.c M src/lib-storage/mail-storage-service.c M src/lib-storage/mail-storage.c M src/lib-storage/mail-user.c M src/lib-storage/mailbox-attribute.c M src/lib-storage/mailbox-list.c M src/lib/buffer.c M src/lib/connection.c M src/lib/failures.c M src/lib/fd-close-on-exec.c M src/lib/file-dotlock.c M src/lib/file-lock.c M src/lib/file-set-size.c M src/lib/ioloop-epoll.c M src/lib/ioloop.c M src/lib/iso8601-date.c M src/lib/istream-sized.c M src/lib/istream.c M src/lib/lib-signals.c M src/lib/md4.c M src/lib/md5.c M src/lib/mempool-alloconly.c M src/lib/mountpoint.c M src/lib/net.c M src/lib/ostream.c M src/lib/restrict-access.c M src/lib/sendfile-util.c M src/lib/seq-range-array.c M src/lib/sha3.c M src/lib/test-ioloop.c M src/lib/test-utc-mktime.c M src/lib/timing.c M src/lib/uri-util.c M src/lib/var-expand.c M src/lmtp/client.c M src/lmtp/commands.c M src/lmtp/lmtp-proxy.c M src/lmtp/main.c M src/log/log-connection.c M src/login-common/client-common-auth.c M src/login-common/login-proxy-state.c M src/login-common/login-settings.c M src/login-common/main.c M src/login-common/sasl-server.c M src/login-common/ssl-proxy-openssl.c M src/master/main.c M src/master/sd-daemon.c M src/master/service-listen.c M src/master/service-log.c M src/master/service-monitor.c M src/plugins/acl/acl-api.c M src/plugins/acl/acl-attributes.c M src/plugins/acl/acl-backend-vfile-update.c M src/plugins/acl/acl-backend-vfile.c M src/plugins/acl/acl-global-file.c M src/plugins/acl/acl-lookup-dict.c M src/plugins/acl/acl-mailbox-list.c M src/plugins/acl/acl-mailbox.c M src/plugins/acl/doveadm-acl.c M src/plugins/dict-ldap/dict-ldap-settings.c M src/plugins/dict-ldap/dict-ldap.c M src/plugins/expire/doveadm-expire.c M src/plugins/expire/expire-plugin.c M src/plugins/fts-lucene/doveadm-fts-lucene.c M src/plugins/fts-solr/fts-backend-solr.c M src/plugins/fts-solr/solr-connection.c M src/plugins/fts-squat/squat-trie.c M src/plugins/fts-squat/squat-uidlist.c M src/plugins/fts/doveadm-fts.c M src/plugins/fts/fts-api.c M src/plugins/fts/fts-build-mail.c M src/plugins/fts/fts-parser-tika.c M src/plugins/fts/fts-search.c M src/plugins/fts/xml2text.c M src/plugins/imap-acl/imap-acl-plugin.c M src/plugins/last-login/last-login-plugin.c M src/plugins/mail-crypt/doveadm-mail-crypt.c M src/plugins/mail-crypt/mail-crypt-acl-plugin.c M src/plugins/mail-crypt/mail-crypt-global-key.c M src/plugins/mail-crypt/mail-crypt-plugin.c M src/plugins/mail-crypt/mail-crypt-pluginenv.c M src/plugins/mail-crypt/test-mail-global-key.c M src/plugins/mail-crypt/test-mail-key.c M src/plugins/pop3-migration/pop3-migration-plugin.c M src/plugins/push-notification/push-notification-driver-ox.c M src/plugins/push-notification/push-notification-event-flagsclear.c M src/plugins/push-notification/push-notification-event-flagsset.c M src/plugins/push-notification/push-notification-event-messageappend.c M src/plugins/push-notification/push-notification-event-messagenew.c M src/plugins/quota-clone/quota-clone-plugin.c M src/plugins/quota/doveadm-quota.c M src/plugins/quota/quota-count.c M src/plugins/quota/quota-dict.c M src/plugins/quota/quota-status.c M src/plugins/quota/quota-util.c M src/plugins/quota/quota.c M src/plugins/quota/test-quota-util.c M src/plugins/stats/mail-stats-fill.c M src/plugins/virtual/virtual-config.c M src/plugins/virtual/virtual-mail.c M src/plugins/virtual/virtual-search.c M src/plugins/virtual/virtual-sync.c M src/plugins/zlib/zlib-plugin.c M src/pop3-login/pop3-proxy.c M src/pop3/main.c M src/replication/replicator/replicator-queue-auth.c M src/replication/replicator/replicator-queue.c M src/stats/client-export.c M src/stats/client-reset.c M src/stats/main.c M src/util/script-login.c Log Message: ----------- global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done Commit: 771cb02c252db8d8c50a2f94e79a649a502cd817 https://github.com/dovecot/core/commit/771cb02c252db8d8c50a2f94e79a649a502cd817 Author: Timo Sirainen Date: 2016-12-24 (Sat, 24 Dec 2016) Changed paths: M src/lib-storage/mail-storage.h Log Message: ----------- lib-storage: Update mail_get_headers() API comment The API was changed by 990d55ce3fc461eeacce3ef830b1c5dde5c3f150 Compare: https://github.com/dovecot/core/compare/96de40971a89...771cb02c252d From noreply at github.com Sun Dec 25 15:30:12 2016 From: noreply at github.com (GitHub) Date: Sun, 25 Dec 2016 07:30:12 -0800 Subject: [dovecot/core] cf3612: storage: do NOT feed p_strconcat() with NULL. Message-ID: <585fe604ce02d_1fcf3fdf1f1391401156e9@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: cf36129638112c7c9db98f05d4d181c69e40b182 https://github.com/dovecot/core/commit/cf36129638112c7c9db98f05d4d181c69e40b182 Author: Baofeng Date: 2016-12-25 (Sun, 25 Dec 2016) Changed paths: M src/lib-storage/index/dbox-multi/mdbox-storage.c Log Message: ----------- storage: do NOT feed p_strconcat() with NULL. p_strconcat will never take NULL as an valid argument. So ns->list->set.alt_dir has to be checked NULL. From noreply at github.com Tue Dec 27 13:30:10 2016 From: noreply at github.com (GitHub) Date: Tue, 27 Dec 2016 05:30:10 -0800 Subject: [dovecot/core] d31a40: lib-compression: use LZ4_compress_default if can Message-ID: <58626ce270cd8_723f3f9a529e114c4762f@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: d31a407872fb93f907fc2587daaa780ffa9a6f56 https://github.com/dovecot/core/commit/d31a407872fb93f907fc2587daaa780ffa9a6f56 Author: Martti Rannanj?rvi Date: 2016-12-27 (Tue, 27 Dec 2016) Changed paths: M m4/want_lz4.m4 M src/lib-compression/ostream-lz4.c Log Message: ----------- lib-compression: use LZ4_compress_default if can LZ4_compress is deprecated. From noreply at github.com Tue Dec 27 14:00:10 2016 From: noreply at github.com (GitHub) Date: Tue, 27 Dec 2016 06:00:10 -0800 Subject: [dovecot/core] 16bb1a: lib: add separator also if arr[0] is empty in stri... Message-ID: <586273eaa89f2_9113fb51841d130536dd@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 16bb1ac73aed6e30be610a2dc4eb9d1719f28559 https://github.com/dovecot/core/commit/16bb1ac73aed6e30be610a2dc4eb9d1719f28559 Author: Martti Rannanj?rvi Date: 2016-12-27 (Tue, 27 Dec 2016) Changed paths: M src/lib/strfuncs.c M src/lib/test-strfuncs.c Log Message: ----------- lib: add separator also if arr[0] is empty in string array joins Also add a couple test cases. From noreply at github.com Tue Dec 27 14:30:10 2016 From: noreply at github.com (GitHub) Date: Tue, 27 Dec 2016 06:30:10 -0800 Subject: [dovecot/core] 27de85: master: revert i_zero change on sd-daemon.c Message-ID: <58627af2d9096_3a4a3fcbe303513059318@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 27de85bc0361f267b500640e7092987be10daae5 https://github.com/dovecot/core/commit/27de85bc0361f267b500640e7092987be10daae5 Author: Martti Rannanj?rvi Date: 2016-12-27 (Tue, 27 Dec 2016) Changed paths: M src/master/sd-daemon.c Log Message: ----------- master: revert i_zero change on sd-daemon.c From noreply at github.com Wed Dec 28 14:30:13 2016 From: noreply at github.com (GitHub) Date: Wed, 28 Dec 2016 06:30:13 -0800 Subject: [dovecot/core] 15964b: Fix link failure against libressl. Message-ID: <5863cc754628b_63833fb54c50b13012776b@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 15964b74c01d28907de3b2d9e5b5b6e5ebc04b08 https://github.com/dovecot/core/commit/15964b74c01d28907de3b2d9e5b5b6e5ebc04b08 Author: Nick Wallingford Date: 2016-12-28 (Wed, 28 Dec 2016) Changed paths: M src/lib-ssl-iostream/dovecot-openssl-common.c Log Message: ----------- Fix link failure against libressl. Commit: 365096bcd90cd5b50f413035f2a1f16237b365c1 https://github.com/dovecot/core/commit/365096bcd90cd5b50f413035f2a1f16237b365c1 Author: Stephan Bosch Date: 2016-12-28 (Wed, 28 Dec 2016) Changed paths: M src/lib/macros.h Log Message: ----------- lib: Created i_zero() wrapper for memset(p, 0, sizeof(*p)). Also creates an i_zero_safe() version for safe_memset(). Commit: 963da01fa575291c341ddbf4b9198a38636a9d2a https://github.com/dovecot/core/commit/963da01fa575291c341ddbf4b9198a38636a9d2a Author: Timo Sirainen Date: 2016-12-28 (Wed, 28 Dec 2016) Changed paths: M src/lib-storage/mail-storage.h Log Message: ----------- lib-storage: Update mail_get_headers() API comment The API was changed by 990d55ce3fc461eeacce3ef830b1c5dde5c3f150 Commit: c8a0f015ffbe427060a06bdf3e12e8feb0dfdc07 https://github.com/dovecot/core/commit/c8a0f015ffbe427060a06bdf3e12e8feb0dfdc07 Author: Martti Rannanj?rvi Date: 2016-12-28 (Wed, 28 Dec 2016) Changed paths: M configure.ac M src/lib-compression/ostream-lz4.c Log Message: ----------- lib-compression: use LZ4_compress_default if can LZ4_compress is deprecated. Compare: https://github.com/dovecot/core/compare/cf3612963811...c8a0f015ffbe From noreply at github.com Thu Dec 29 15:30:16 2016 From: noreply at github.com (GitHub) Date: Thu, 29 Dec 2016 07:30:16 -0800 Subject: [dovecot/core] e41845: lib-mail: refactor header filter test code Message-ID: <58652c084b4d9_19b83f961a05513c11737b@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: e41845d13acfc356aaaac83091c810c8609446db https://github.com/dovecot/core/commit/e41845d13acfc356aaaac83091c810c8609446db Author: Josef 'Jeff' Sipek Date: 2016-12-29 (Thu, 29 Dec 2016) Changed paths: M src/lib-mail/test-istream-header-filter.c Log Message: ----------- lib-mail: refactor header filter test code Commit: 34f7cc3df6371ac386848e730f16a072fb7ad673 https://github.com/dovecot/core/commit/34f7cc3df6371ac386848e730f16a072fb7ad673 Author: Josef 'Jeff' Sipek Date: 2016-12-29 (Thu, 29 Dec 2016) Changed paths: M src/lib-mail/istream-header-filter.c M src/lib-mail/test-istream-header-filter.c Log Message: ----------- lib-mail: header filter should call callback for added EOH If we add a EOH because there wasn't one and HEADER_FILTER_ADD_MISSING_EOH was specified, we should invoke the callback for it. Otherwise, it is unnecessarily difficult for consumers to add a header since there is no way to know if EOH will be present ahead of time. Compare: https://github.com/dovecot/core/compare/c8a0f015ffbe...34f7cc3df637 From noreply at github.com Thu Dec 29 15:30:12 2016 From: noreply at github.com (GitHub) Date: Thu, 29 Dec 2016 07:30:12 -0800 Subject: [dovecot/core] 75891a: lib-mail: refactor header filter test code Message-ID: <58652c047a825_636b3f87b81a9134556e6@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 75891a354ed229a4e56bbb0eceab75a0d1278687 https://github.com/dovecot/core/commit/75891a354ed229a4e56bbb0eceab75a0d1278687 Author: Josef 'Jeff' Sipek Date: 2016-12-28 (Wed, 28 Dec 2016) Changed paths: M src/lib-mail/test-istream-header-filter.c Log Message: ----------- lib-mail: refactor header filter test code Commit: 69eb1a17f443454e0b3025f86f428671ace06e89 https://github.com/dovecot/core/commit/69eb1a17f443454e0b3025f86f428671ace06e89 Author: Josef 'Jeff' Sipek Date: 2016-12-28 (Wed, 28 Dec 2016) Changed paths: M src/lib-mail/istream-header-filter.c M src/lib-mail/test-istream-header-filter.c Log Message: ----------- lib-mail: header filter should call callback for added EOH If we add a EOH because there wasn't one and HEADER_FILTER_ADD_MISSING_EOH was specified, we should invoke the callback for it. Otherwise, it is unnecessarily difficult for consumers to add a header since there is no way to know if EOH will be present ahead of time. Compare: https://github.com/dovecot/core/compare/27de85bc0361...69eb1a17f443