[dovecot/core] b7b25e: imap: Removed special EXPUNGE callback for an Outl...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: b7b25e0ae0277930b8197e5fa04dd567ce243ca4
      https://github.com/dovecot/core/commit/b7b25e0ae0277930b8197e5fa04dd567ce243ca4
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-01 (Mon, 01 Feb 2016)

  Changed paths:
    M src/imap/cmd-expunge.c

  Log Message:
  -----------
  imap: Removed special EXPUNGE callback for an Outlook workaround.

As the comment mentions, this workaround isn't needed if index files are
used.  Hopefully also the Outlook bug itself is gone nowadays.. In any case
the current callback code didn't work, because it was returning FALSE and
causing an assert in a pipelined EXPUNGE+APPEND combination after 6e9454f:

Panic: file imap-client.c: line 862 (client_check_command_hangs): assertion
failed: (!have_wait_unfinished || unfinished_count > 0)

It would probably be possible to fix this, but it would complicate the code
even further, so it's easier just to get rid of this feature. It was easily
triggered by running imaptest stress testing.


  Commit: 71caf493c651b8eab5adb170db0237f293928e92
      https://github.com/dovecot/core/commit/71caf493c651b8eab5adb170db0237f293928e92
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-01 (Mon, 01 Feb 2016)

  Changed paths:
    M src/imap/imap-sync.c
    M src/imap/imap-sync.h

  Log Message:
  -----------
  imap: Removed now-unused cmd_sync_callback(), which doesn't work very well.

See commit message in b7b25e0 for more details.


Compare: https://github.com/dovecot/core/compare/a58963a8bdac...71caf493c651