[dovecot/core] d68a02: lib-index: If mail_transaction_log_lock_head() loc...

Mon Feb 22 20:29:07 UTC 2016

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: d68a021c2755318e4480befc65b43ed8886932ca
      https://github.com/dovecot/core/commit/d68a021c2755318e4480befc65b43ed8886932ca
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/lib-index/mail-transaction-log.c

  Log Message:
  -----------
  lib-index: If mail_transaction_log_lock_head() locking took long, include reason string in warning

  Commit: 676d5601a8e087b25eb4dd5509079ab832e66831
      https://github.com/dovecot/core/commit/676d5601a8e087b25eb4dd5509079ab832e66831
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/doveadm/doveadm-cmd.c
    M src/doveadm/doveadm-cmd.h
    M src/doveadm/doveadm-stats.c
    M src/doveadm/doveadm.c

  Log Message:
  -----------
  doveadm-stats: Use ver2 structures

  Commit: 778087c26fc528b58ef28c97d2941e599a20cf83
      https://github.com/dovecot/core/commit/778087c26fc528b58ef28c97d2941e599a20cf83
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/doveadm/doveadm-mail.c

  Log Message:
  -----------
  doveadm: Add kludge to support field array to fieldstr conversion

  Commit: 89d31290dab6e4bde08b8a118121f008154772e9
      https://github.com/dovecot/core/commit/89d31290dab6e4bde08b8a118121f008154772e9
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/doveadm/doveadm-mail-fetch.c
    M src/doveadm/doveadm-mail.c
    M src/doveadm/doveadm-mail.h

  Log Message:
  -----------
  doveadm-fetch: Use ver2 structures

  Commit: 13607902e5899698826a777f165d0afa8f766ac1
      https://github.com/dovecot/core/commit/13607902e5899698826a777f165d0afa8f766ac1
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/doveadm/doveadm-mail.c

  Log Message:
  -----------
  doveadm-mail: Fixed common parameters to use correct names as in DOVEADM_CMD_MAIL_COMMON

  Commit: f8e3a08ae260b8b18acdd80bf8e68f19361b4a27
      https://github.com/dovecot/core/commit/f8e3a08ae260b8b18acdd80bf8e68f19361b4a27
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/doveadm/doveadm-mail.c

  Log Message:
  -----------
  doveadm: Fixed memory leaks when ver2 command parsing fails with invalid parameter.

  Commit: bce90a4f190198d487ba686fbffd96c29954f2f8
      https://github.com/dovecot/core/commit/bce90a4f190198d487ba686fbffd96c29954f2f8
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/doveadm/doveadm-mail.c

  Log Message:
  -----------
  doveadm: Fixed double-free when using -F parameter

  Commit: 368ec06f20b95d29d0bbd5655030048d060a2582
      https://github.com/dovecot/core/commit/368ec06f20b95d29d0bbd5655030048d060a2582
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/doveadm/doveadm-cmd.c

  Log Message:
  -----------
  doveadm: Fixed memory leak at deinit

  Commit: 0d55fdfbc174e9393f9ecf86b9111f8a031e8750
      https://github.com/dovecot/core/commit/0d55fdfbc174e9393f9ecf86b9111f8a031e8750
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/doveadm/doveadm-mail.c

  Log Message:
  -----------
  doveadm: Added support for "file" parameters

  Commit: 5ba6009f4e5493c4e6be9ffb3134525004a7975c
      https://github.com/dovecot/core/commit/5ba6009f4e5493c4e6be9ffb3134525004a7975c
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/doveadm/doveadm-mail-save.c
    M src/doveadm/doveadm-mail.c
    M src/doveadm/doveadm-mail.h

  Log Message:
  -----------
  doveadm-save: Use ver2 command structure

  Commit: 394a8734060604a6389affe6fd2d456640341fa4
      https://github.com/dovecot/core/commit/394a8734060604a6389affe6fd2d456640341fa4
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-http: Handle istreams correctly

Based on patch by Aki Tuomi

  Commit: 9cd71e2cb9e8bb6de26d2cec99f7c6804dce4e40
      https://github.com/dovecot/core/commit/9cd71e2cb9e8bb6de26d2cec99f7c6804dce4e40
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-http: Handle invalid input better for arrays.

  Commit: 346ce9e82d31012b8640cad6369e66417ca8c782
      https://github.com/dovecot/core/commit/346ce9e82d31012b8640cad6369e66417ca8c782
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm-http: Return HTTP failure on unexpected JSON input

  Commit: 331d2de16c64fc40d7df16c2f955e8a381415673
      https://github.com/dovecot/core/commit/331d2de16c64fc40d7df16c2f955e8a381415673
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/doveadm/client-connection-http.c
    M src/doveadm/client-connection.c

  Log Message:
  -----------
  doveadm-http: Close client input correctly

  Commit: 1dead6eacb9302a8419bfc8f4b571ea9a3c00296
      https://github.com/dovecot/core/commit/1dead6eacb9302a8419bfc8f4b571ea9a3c00296
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/lib-http/http-client-connection.c
    M src/lib-http/http-client-private.h

  Log Message:
  -----------
  lib-http: http_client_connection_unref() now always sets *conn=NULL

This makes its behavior consistent with other APIs in Dovecot.

  Commit: d1f964d3f1dd9c5868b134c4f44dd63f3722eef7
      https://github.com/dovecot/core/commit/d1f964d3f1dd9c5868b134c4f44dd63f3722eef7
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/lib-http/http-client-connection.c
    M src/lib-http/http-client-private.h
    M src/lib-http/http-client-request.c

  Log Message:
  -----------
  lib-http: http_client_request_unref() now always sets *req=NULL

This makes its behavior consistent with other APIs in Dovecot.

Also http_client_request_finish() no longer sets req=NULL, because all of
its callers already keep a reference. Instead added an assert to make sure
the reference is there.

  Commit: c3a4c931e95737a52e1cebeeb109a2e1cc4d47d6
      https://github.com/dovecot/core/commit/c3a4c931e95737a52e1cebeeb109a2e1cc4d47d6
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/lib-http/http-client-request.c
    M src/lib-http/http-client.h
    M src/plugins/fts-solr/solr-connection.c

  Log Message:
  -----------
  lib-http: Clarify http_client_request_*_payload() API and minor change to it

The earlier behavior was pretty confusing, and potentially could have caused
double-freeing memory in some situations. Now it's clear that req is set to NULL
always when the request is finished, regardless of whether it has any references left.

Changed http_client_request_finish_payload() to return 0 on success instead of 1.
This could have been left alone, but it's unlikely that there is any code outside
Dovecot core that calls it and this way is cleaner.

  Commit: 903f0b38884375179cea63b9d0821e295c38764a
      https://github.com/dovecot/core/commit/903f0b38884375179cea63b9d0821e295c38764a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/lib-http/http-server-request.c
    M src/lib-http/http-server-response.c

  Log Message:
  -----------
  lib-http: http_server_request_unref() now always sets *req=NULL

This makes its behavior consistent with other APIs in Dovecot.

  Commit: 8d33944ab2274f215fb80013c12f283dcde74715
      https://github.com/dovecot/core/commit/8d33944ab2274f215fb80013c12f283dcde74715
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/lib-http/http-server-response.c
    M src/lib-http/http-server.h

  Log Message:
  -----------
  lib-http: Clarify http_server_response_*_payload() API and minor change to it

Similar to the change in c3a4c93. Nothing used this API yet.

  Commit: 702ebfdbd78702e3464b5804c8a7c83c9990ae96
      https://github.com/dovecot/core/commit/702ebfdbd78702e3464b5804c8a7c83c9990ae96
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/lib-http/http-server-connection.c
    M src/lib-http/http-server.h

  Log Message:
  -----------
  lib-http: http_server_connection_unref() now always sets *conn=NULL

This makes its behavior consistent with other APIs in Dovecot.

  Commit: f9d2a1f21ad65262bc630f0834d7eead06a1bac3
      https://github.com/dovecot/core/commit/f9d2a1f21ad65262bc630f0834d7eead06a1bac3
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/lib-http/http-client-peer.c
    M src/lib-http/http-client.c
    M src/lib-http/http-header-parser.c
    M src/lib-http/http-request-parser.c
    M src/lib-http/http-response-parser.c
    M src/lib-http/http-server-response.c
    M src/lib-http/http-server.c

  Log Message:
  -----------
  lib-http: Always set *_obj=NULL first in deinit functions (mainly for consistency)

This doesn't usually matter, but in case deinit calls some callback they may
be trying to access the partially destroyed object.

  Commit: 3d27e1102558215203b73c58a2cba84dccf0dd1a
      https://github.com/dovecot/core/commit/3d27e1102558215203b73c58a2cba84dccf0dd1a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/doveadm/client-connection-http.c
    M src/doveadm/doveadm-cmd.c

  Log Message:
  -----------
  doveadm: Code cleanup - remove unnecessary NULL sets and checks

  Commit: 7d500ecf27acc5b65615ee9e72d6da6bacf799d2
      https://github.com/dovecot/core/commit/7d500ecf27acc5b65615ee9e72d6da6bacf799d2
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/doveadm/client-connection.c
    M src/doveadm/doveadm-cmd.c
    M src/doveadm/doveadm-cmd.h
    M src/doveadm/doveadm.c

  Log Message:
  -----------
  doveadm: Minor code cleanup - rename doveadm_cmd_find*() to doveadm_cmd_find_with_args*()

  Commit: e6e5687226dc976061bffac9e7410ff14244e54f
      https://github.com/dovecot/core/commit/e6e5687226dc976061bffac9e7410ff14244e54f
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/plugins/quota/doveadm-quota.c

  Log Message:
  -----------
  quota: Use doveadm ver2 structures

  Commit: 1e8a6a8708b612eee65f83ef6874aab94b15eb50
      https://github.com/dovecot/core/commit/1e8a6a8708b612eee65f83ef6874aab94b15eb50
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/doveadm/client-connection-http.c
    M src/doveadm/doveadm-cmd.c
    M src/doveadm/doveadm-cmd.h

  Log Message:
  -----------
  doveadm: Free istream parameters everywhere

Based on patch by Aki Tuomi

  Commit: 3fd8086f71f25a68e33993e24123b10b671dac67
      https://github.com/dovecot/core/commit/3fd8086f71f25a68e33993e24123b10b671dac67
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/doveadm/doveadm-cmd.h

  Log Message:
  -----------
  doveadm-cmd: Add command flags

  Commit: 71f4549303dc1691382748a096c2ada9d2a1a9fe
      https://github.com/dovecot/core/commit/71f4549303dc1691382748a096c2ada9d2a1a9fe
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/doveadm/doveadm-mail-index.c
    M src/doveadm/doveadm-mail.c
    M src/doveadm/doveadm-mail.h

  Log Message:
  -----------
  doveadm-index: Use ver2 structures

  Commit: 7a8ef11587fd50d5888223fc3d91911775a21ba5
      https://github.com/dovecot/core/commit/7a8ef11587fd50d5888223fc3d91911775a21ba5
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/doveadm/doveadm-cmd.c
    M src/doveadm/doveadm-cmd.h

  Log Message:
  -----------
  doveadm: Added doveadm_cmd_get_ver2() helper

  Commit: c45a841bee3f42ec6524b8f62c3fd457115c3f97
      https://github.com/dovecot/core/commit/c45a841bee3f42ec6524b8f62c3fd457115c3f97
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/doveadm/doveadm-mail-fetch.c
    M src/doveadm/doveadm-mail-index.c
    M src/doveadm/doveadm-mail-mailbox-metadata.c
    M src/doveadm/doveadm-mail-mailbox-status.c
    M src/doveadm/doveadm-mail-mailbox.c
    M src/doveadm/doveadm-mail-save.c
    M src/doveadm/doveadm-mail.c
    M src/doveadm/doveadm-mail.h

  Log Message:
  -----------
  doveadm: Define DOVEADM_CMD_MAIL_USAGE_PREFIX, which v2 commands use as their usage prefix.

This allows implementing the next changeset without kludging.

  Commit: bef3447d29acf374bbae54bc7d6bba2583c6d5ea
      https://github.com/dovecot/core/commit/bef3447d29acf374bbae54bc7d6bba2583c6d5ea
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/doveadm/doveadm-mail.c
    M src/doveadm/doveadm.c

  Log Message:
  -----------
  doveadm: Fixed usage printing for ver2 commands

  Commit: 17bfcf534dc30994a3940c2727d8b3691e85610b
      https://github.com/dovecot/core/commit/17bfcf534dc30994a3940c2727d8b3691e85610b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm: Code cleanup - remove duplicate code

Compare: https://github.com/dovecot/core/compare/62958c5eefcd...17bfcf534dc3