[dovecot/core] cd1832: fts: Empty "fts" setting should be same as nonexis...

Fri Jul 1 00:25:09 UTC 2016

  Branch: refs/tags/2.2.24.1
  Home:   https://github.com/dovecot/core
  Commit: cd1832e6fe79ea408be8e85dd197fe3f974c3ac0
      https://github.com/dovecot/core/commit/cd1832e6fe79ea408be8e85dd197fe3f974c3ac0
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/plugins/fts/fts-storage.c

  Log Message:
  -----------
  fts: Empty "fts" setting should be same as nonexistent.

  Commit: 75f1cfaae0fe6cd632d04e60a9c85e68338d79eb
      https://github.com/dovecot/core/commit/75f1cfaae0fe6cd632d04e60a9c85e68338d79eb
  Author: Michael Slusarz <michael.slusarz at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M doc/man/doveadm-sync.1.in

  Log Message:
  -----------
  man: Add more complete description of one-way sync

  Commit: a3523574b2388628f1254eec12deac97f1a36f0e
      https://github.com/dovecot/core/commit/a3523574b2388628f1254eec12deac97f1a36f0e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/plugins/lazy-expunge/lazy-expunge-plugin.c

  Log Message:
  -----------
  lazy-expunge: Open mailbox with MAILBOX_FLAG_SAVEONLY flag.

  Commit: f9a0fa9c2396bc5e88d7d354f1b8f99d2ad992d7
      https://github.com/dovecot/core/commit/f9a0fa9c2396bc5e88d7d354f1b8f99d2ad992d7
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/plugins/lazy-expunge/lazy-expunge-plugin.c

  Log Message:
  -----------
  lazy-expunge: Open the mailbox with ACLs ignored.

  Commit: 784cfb4b0056da96d4332ca8e9d09d16baced70c
      https://github.com/dovecot/core/commit/784cfb4b0056da96d4332ca8e9d09d16baced70c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/doveadm/doveadm-dump-index.c

  Log Message:
  -----------
  doveadm dump: Added more index ext records.

"msgs" and "vsize" are now expanded.

  Commit: 23c0a4a69621c9559cc2ceddacf2f29f36ac1291
      https://github.com/dovecot/core/commit/23c0a4a69621c9559cc2ceddacf2f29f36ac1291
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/lib-storage/index/index-storage.h
    M src/lib-storage/index/index-sync.c

  Log Message:
  -----------
  lib-storage: Added index_storage_list_index_has_changed_full()

This allows the caller to use it to implement a slightly different
mailbox.list_index_has_changed()

  Commit: 0b704695b741f01893f2bedfd07daf50e3b1372b
      https://github.com/dovecot/core/commit/0b704695b741f01893f2bedfd07daf50e3b1372b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/lib-storage/mail-storage.c

  Log Message:
  -----------
  lib-storage: mailbox_set_subscribed() ignores duplicate changes now.

  Commit: 664b1a68a2f284a553d33a7efc4d7d222af2814b
      https://github.com/dovecot/core/commit/664b1a68a2f284a553d33a7efc4d7d222af2814b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/plugins/fts-lucene/lucene-wrapper.cc

  Log Message:
  -----------
  fts-lucene: Fixed crash on rescan

Broken by af2564c7f9e05ad245a032efdfbc5abbb9b70f1e - rescan_ctx can be NULL.

  Commit: cf1a916dac4e9eca563bf2b1a772a48e4b713472
      https://github.com/dovecot/core/commit/cf1a916dac4e9eca563bf2b1a772a48e4b713472
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  configure: Fixed (again) --with-ldap=plugin

  Commit: 7a23a1cf6aabc98283852bfeacd15e6b4d9afe31
      https://github.com/dovecot/core/commit/7a23a1cf6aabc98283852bfeacd15e6b4d9afe31
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/lib-index/mail-index-map.c

  Log Message:
  -----------
  lib-index: Memory allocation optimization

  Commit: 7dc03589d4b0e8fe51fe0bed03fbfb248a0a7608
      https://github.com/dovecot/core/commit/7dc03589d4b0e8fe51fe0bed03fbfb248a0a7608
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/lib/mempool-system.c

  Log Message:
  -----------
  lib: Implement i_realloc(mem==NULL) more efficiently

Various parts of code use this to allocate the initial buffer. We can
do this more efficiently by using calloc().

  Commit: 7e571d3895409011bfa4144fc912693bc2fec51b
      https://github.com/dovecot/core/commit/7e571d3895409011bfa4144fc912693bc2fec51b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/lib/buffer.c

  Log Message:
  -----------
  lib: Use p_malloc() explicitly in first buffer_alloc()

Although there is now code in p_realloc() that it should be just as
efficient, this makes profiling somewhat nicer since it can better
distinguish between actual reallocs and initial allocs.

  Commit: 7af8149bd661bbdf64fc4403b6ff89c321a9e7a4
      https://github.com/dovecot/core/commit/7af8149bd661bbdf64fc4403b6ff89c321a9e7a4
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/lib/buffer.c

  Log Message:
  -----------
  lib: buffer_create_dynamic() now adds +1 to init_size

  Commit: bc5f5fc939e17e43712337b544d865801dbcb550
      https://github.com/dovecot/core/commit/bc5f5fc939e17e43712337b544d865801dbcb550
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/lib-index/mail-index-map.c

  Log Message:
  -----------
  lib-index: Use a bit larger initial records buffer size

For example with a mailbox having 160k messages the buffer size is around
10MB. Adding just 1% more space to it allows a lot more appends before the
buffer needs to be realloced. This reduces CPU usage quite a lot.

  Commit: 7347c1a2fc8fe2f771eb1e21c60764d9c03cc413
      https://github.com/dovecot/core/commit/7347c1a2fc8fe2f771eb1e21c60764d9c03cc413
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-mailbox.c

  Log Message:
  -----------
  imapc: Fixed EXPUNGE handling when imapc_features didn't have modseq

  Commit: 78c088912670cd6dfc34108f2344fcd04b18099d
      https://github.com/dovecot/core/commit/78c088912670cd6dfc34108f2344fcd04b18099d
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/lib-ldap/ldap-connection.c

  Log Message:
  -----------
  lib-ldap: Set minimum protocol if supported by library

  Commit: 6f5085dfb3d48e20d59a21e83625f5dc1eba953f
      https://github.com/dovecot/core/commit/6f5085dfb3d48e20d59a21e83625f5dc1eba953f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/plugins/quota/quota-storage.c

  Log Message:
  -----------
  quota: Optimize handling a large number of expunges.

This assumes that the mail_expunge() was called in the same order as
sync_notify(), which practically means that they were both done in
ascending uid order. This is usually true.

  Commit: 8e216f83bdde9f133ee3d8f6019f88df3387f4a9
      https://github.com/dovecot/core/commit/8e216f83bdde9f133ee3d8f6019f88df3387f4a9
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/lib-fts/test-fts-icu.c
    M src/lib-ssl-iostream/ostream-openssl.c
    M src/lib/aqueue.c
    M src/lib/str.c

  Log Message:
  -----------
  global: Use buffer_get_writable_size() where possible

With 09539f3db increasing buffer's init_size with +1 some fts-icu unit tests
started failing. And in general it's better to use the writable size since
that provides the true size that can be used.

  Commit: 19f2751b5427b717ff2bff9c6799a2a0f0bf9744
      https://github.com/dovecot/core/commit/19f2751b5427b717ff2bff9c6799a2a0f0bf9744
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/plugins/quota/quota-count.c

  Log Message:
  -----------
  quota-count: Code cleanup - give consistent return value

Although the callers didn't care if it returned 0 or 1.

  Commit: 5f9785d80ae3f89977bb1beb9575c4f709d7e560
      https://github.com/dovecot/core/commit/5f9785d80ae3f89977bb1beb9575c4f709d7e560
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/plugins/quota/quota-count.c

  Log Message:
  -----------
  quota-count: Cache quota usage within the same ioloop run.

This mainly means that when both STORAGE and MESSAGES quota is looked up we
don't need to calculate them twice.

  Commit: da751b6faa13d9904f7e81f0990cfe616d1055ca
      https://github.com/dovecot/core/commit/da751b6faa13d9904f7e81f0990cfe616d1055ca
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/plugins/quota/quota.c

  Log Message:
  -----------
  quota: Fixed quota_over_flag handling when quota usage==limit

It couldn't really work correctly otherwise. If we've reached the quota, we
want to start rejecting new mails.

  Commit: e3ccaa932cfd6198ffb0d6cada607ac564b182ee
      https://github.com/dovecot/core/commit/e3ccaa932cfd6198ffb0d6cada607ac564b182ee
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/plugins/quota/quota.c

  Log Message:
  -----------
  quota: Fixed debug logging for quota_over_flag

  Commit: 379fdb5baeae225a8241cbf6c596ee528a6171d2
      https://github.com/dovecot/core/commit/379fdb5baeae225a8241cbf6c596ee528a6171d2
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/plugins/quota/quota-private.h
    M src/plugins/quota/quota-storage.c
    M src/plugins/quota/quota.c
    M src/plugins/quota/quota.h

  Log Message:
  -----------
  quota: Cleanup - split quota_over_flag to init & run parts

In preparation for the next change.

  Commit: 008767162721bafe2fa4210b0767ee182920d3ca
      https://github.com/dovecot/core/commit/008767162721bafe2fa4210b0767ee182920d3ca
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/plugins/quota/quota-count.c

  Log Message:
  -----------
  quota: dict-quota was broken by 464db6d9d

We can't assume that the quota_root given to quota_count() is
count_quota_root, because dict_quota_root also calls it.

  Commit: a09f01e994d7e1448bc84aaa4a8a214055677313
      https://github.com/dovecot/core/commit/a09f01e994d7e1448bc84aaa4a8a214055677313
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/plugins/quota/quota-private.h
    M src/plugins/quota/quota-storage.c
    M src/plugins/quota/quota.c
    M src/plugins/quota/quota.h

  Log Message:
  -----------
  quota: Added quota_over_flag_lazy_check flag.

By default the quota_over_flag is checked immediately at startup. With this
option the check is done only at a time when the quota is anyway being read.

  Commit: 7509192564c2c59666c8c86e5ee186c700036f3d
      https://github.com/dovecot/core/commit/7509192564c2c59666c8c86e5ee186c700036f3d
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/auth/auth-request.c

  Log Message:
  -----------
  auth: Session ID wasn't exported to auth workers.

Most importantly this means that log messages didn't contain them.

  Commit: 969fb66064469e4dfc407f4f0a8d80b8fb833b33
      https://github.com/dovecot/core/commit/969fb66064469e4dfc407f4f0a8d80b8fb833b33
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/auth/auth-request.c

  Log Message:
  -----------
  auth: Fixed final result in multiple userdbs

We don't want to return the last result's success/failure, but
the entire userdb chain's success/failure.

  Commit: 841b05480d55766f5b0c49d2004ce2c8a42562df
      https://github.com/dovecot/core/commit/841b05480d55766f5b0c49d2004ce2c8a42562df
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/lib-ldap/ldap-search.c

  Log Message:
  -----------
  lib-ldap: Make static analyzer happier

Remove dead assignment.

  Commit: 5865912c50a78f575603009401b32beee2b18f77
      https://github.com/dovecot/core/commit/5865912c50a78f575603009401b32beee2b18f77
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/lib/guid.c

  Log Message:
  -----------
  lib: Set timestamp part more accurately in guid_128_generate()

Previously a long-running process would keep the timestamp close to its
original start time. This doesn't really matter as long as GUIDs are treated
opaque, but some pieces of code prefer to try to use the timestamp fields
since they're already there. This makes such code work more nicely.

  Commit: 591a977d11a45dadc7b30d1133ae5d5d419d63dc
      https://github.com/dovecot/core/commit/591a977d11a45dadc7b30d1133ae5d5d419d63dc
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-29 (Fri, 29 Apr 2016)

  Changed paths:
    M src/lmtp/commands.c

  Log Message:
  -----------
  lmtp: Connect to anvil earlier while still running as root

This was a problem only with lmtp_rcpt_check_quota=yes.

  Commit: 45290c680e3c5322721809ef3e5ed4d459556d2b
      https://github.com/dovecot/core/commit/45290c680e3c5322721809ef3e5ed4d459556d2b
  Author: Michael Slusarz <michael.slusarz at dovecot.fi>
  Date:   2016-04-30 (Sat, 30 Apr 2016)

  Changed paths:
    M .gitignore
    M doc/man/Makefile.am
    A doc/man/doveadm-fs.1.in

  Log Message:
  -----------
  man: Add stub for doveadm-fs command

  Commit: 5ceee21a9d98818eee38e15ba0078e4b61e9d784
      https://github.com/dovecot/core/commit/5ceee21a9d98818eee38e15ba0078e4b61e9d784
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-30 (Sat, 30 Apr 2016)

  Changed paths:
    M src/lib-fs/fs-metawrap.c

  Log Message:
  -----------
  lib-fs: Fixed fs_get_metadata() with fs-metawrap

If mail was already read to EOF.

  Commit: 9098417750b3d49295a3317858882b6974903ec6
      https://github.com/dovecot/core/commit/9098417750b3d49295a3317858882b6974903ec6
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-30 (Sat, 30 Apr 2016)

  Changed paths:
    M src/plugins/quota/quota-storage.c

  Log Message:
  -----------
  quota: Fix to earlier commit 62f2f6baf

expunge_uids may become empty with prev_idx > 0

  Commit: 5601ee858f9c5d654edcabf3f85c875fb4bd895e
      https://github.com/dovecot/core/commit/5601ee858f9c5d654edcabf3f85c875fb4bd895e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-30 (Sat, 30 Apr 2016)

  Changed paths:
    M src/lib-mail/message-parser.c
    M src/lib-mail/test-message-parser.c

  Log Message:
  -----------
  lib-mail: message-parser assert-crashfix

Crashes when multipart MIME header is missing end-of-headers line and the
boundary begins with the same prefix as one of the parent boundaries.
Broken by 7a12331c6

  Commit: d12abd7b96f8334a9039282429c221fa4c21a7b3
      https://github.com/dovecot/core/commit/d12abd7b96f8334a9039282429c221fa4c21a7b3
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-30 (Sat, 30 Apr 2016)

  Changed paths:
    M src/lib-storage/mailbox-list.c

  Log Message:
  -----------
  lib-storage: Clear list error before mailbox_list_get_hierarchy_sep()

With ACL plugin enabled the call could have triggered dovecot-acl-list
rebuild, which in turn could have set list errors if it didn't have
permissions to all the mailboxes. This caused IMAP logins to fail.

  Commit: ce3f527491d3ce99177f71d09cd08e2a728a3f30
      https://github.com/dovecot/core/commit/ce3f527491d3ce99177f71d09cd08e2a728a3f30
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-02 (Mon, 02 May 2016)

  Changed paths:
    M src/auth/auth-request-var-expand.c
    M src/auth/auth-request-var-expand.h

  Log Message:
  -----------
  auth: Added %{auth_user/username/domain} variables

  Commit: 80aac210c088ae496c9e443edd1b39bb76335e71
      https://github.com/dovecot/core/commit/80aac210c088ae496c9e443edd1b39bb76335e71
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-02 (Mon, 02 May 2016)

  Changed paths:
    M src/imap/imap-client.c
    M src/imap/imap-client.h

  Log Message:
  -----------
  imap: Added struct client_command_context.tagline_reply

Can be used by plugins.

  Commit: 8a038299358bdeb84e086835bb38292cb888abe1
      https://github.com/dovecot/core/commit/8a038299358bdeb84e086835bb38292cb888abe1
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-02 (Mon, 02 May 2016)

  Changed paths:
    M src/lib-dict-extra/dict-ldap.c

  Log Message:
  -----------
  dict-ldap: Don't reuse dict for different usernames.

Fixes doing priv/* lookups for multiple usernames.

This currently also means that each username will create a separate LDAP
connection, which isn't ideal. But this is probably better fixed in
lib-ldap code similar to how lib-sql does connection pooling.

  Commit: aa33c0e32335c36f92676f6f465e5a8d71a6537a
      https://github.com/dovecot/core/commit/aa33c0e32335c36f92676f6f465e5a8d71a6537a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-02 (Mon, 02 May 2016)

  Changed paths:
    M src/lib-dict-extra/dict-ldap.c

  Log Message:
  -----------
  dict-ldap: Removed caching of ldap-clients

With the previous per-username caching there could be a huge number of
dict-ldaps.

  Commit: 0adca4fa566f7191ccfeffaa920b55e7b4d1a4f3
      https://github.com/dovecot/core/commit/0adca4fa566f7191ccfeffaa920b55e7b4d1a4f3
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-02 (Mon, 02 May 2016)

  Changed paths:
    M src/lib-dict-extra/dict-ldap.c
    M src/lib-ldap/Makefile.am
    M src/lib-ldap/ldap-client.c
    M src/lib-ldap/ldap-client.h
    A src/lib-ldap/ldap-connection-pool.c
    A src/lib-ldap/ldap-connection-pool.h
    M src/lib-ldap/ldap-connection.c
    M src/lib-ldap/ldap-private.h

  Log Message:
  -----------
  lib-ldap: Added initial connection pooling code.

This is mainly about allowing multiple dict-ldaps to use the same
ldap-connection. In future we could support load balancing with multiple
concurrent LDAP connections.

Compare: https://github.com/dovecot/core/compare/cd1832e6fe79^...0adca4fa566f