[dovecot/core] ea125b: plugins: fts - replace i_assert under _expunge_log...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: ea125b1c394cb6a281c6120f5396faa11fcb268b
      https://github.com/dovecot/core/commit/ea125b1c394cb6a281c6120f5396faa11fcb268b
  Author: Phil Carmody <phil at dovecot.fi>
  Date:   2016-09-12 (Mon, 12 Sep 2016)

  Changed paths:
    M src/plugins/fts/fts-expunge-log.c
    M src/plugins/fts/fts-expunge-log.h

  Log Message:
  -----------
  plugins: fts - replace i_assert under _expunge_log_subtract with warning (API change)

The helper whose interface is changing currently has no other known
clients (there's little need for it to be exposed at all).

This should never happen, but if it does, just tally the number of times
it happened, and squirt out a warning message after the whole subtract.
If it happens at all, there's no reason not to expect a lot, so only
warn once per file.

In particular - do not assert crash when this is seen - it has been seen
on live test systems where file corruption seems to have occured. As
this can only be associated with corrupt fts indexes, seeing this error
implies that the whole FTS index should be rebuilt for that user.

Signed-off-by: Phil Carmody <phil at dovecot.fi>