[dovecot/core] e90a0e: imap, pop3: Added rawlog_dir setting to store IMAP...

[GitHub]

  Branch: refs/heads/master-2.2
  Home:   https://github.com/dovecot/core
  Commit: e90a0ed00032388ffe15b10c2ebf115355d553d5
      https://github.com/dovecot/core/commit/e90a0ed00032388ffe15b10c2ebf115355d553d5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-09-15 (Thu, 15 Sep 2016)

  Changed paths:
    M src/imap/imap-client.c
    M src/imap/imap-settings.c
    M src/imap/imap-settings.h
    M src/pop3/pop3-client.c
    M src/pop3/pop3-settings.c
    M src/pop3/pop3-settings.h

  Log Message:
  -----------
  imap, pop3: Added rawlog_dir setting to store IMAP/POP3 traffic logs.

This at least partially replaces the "rawlog" post-login binary. For now
the "rawlog" binary supports some parameters, which aren't configurable
for rawlog_dir.


  Commit: 7ee368a94f5e2d56c07a35755bc4b16e4a56f5ee
      https://github.com/dovecot/core/commit/7ee368a94f5e2d56c07a35755bc4b16e4a56f5ee
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-09-15 (Thu, 15 Sep 2016)

  Changed paths:
    M src/lib-imap-urlauth/imap-urlauth-connection.c

  Log Message:
  -----------
  lib-imap-urlauth: Don't access freed memory on errors.


  Commit: d464010001899d48b5e1848ffd9807681c5f9b1e
      https://github.com/dovecot/core/commit/d464010001899d48b5e1848ffd9807681c5f9b1e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-09-15 (Thu, 15 Sep 2016)

  Changed paths:
    M src/lib-storage/mail-storage-service.c

  Log Message:
  -----------
  lib-storage: Fix potential crash when userdb-returns "key+=value" for a nonexistent setting.

type would have also happened to be initialized to SET_STR for the crash to
happen.


  Commit: 0ee86a8ebf9b65aab40fcfe95382ef0108ae9df6
      https://github.com/dovecot/core/commit/0ee86a8ebf9b65aab40fcfe95382ef0108ae9df6
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-09-15 (Thu, 15 Sep 2016)

  Changed paths:
    M src/lib-dcrypt/dcrypt-openssl.c
    M src/lib-storage/index/dbox-common/dbox-save.c
    M src/lib-storage/list/mailbox-list-iter.c
    M src/lib-storage/mail-storage.c
    M src/plugins/fts-squat/squat-trie.c

  Log Message:
  -----------
  Removed dead code to make static analyzer happier.


  Commit: 83ad90e5d8a37ba652e5b32557c989b725ffd9d4
      https://github.com/dovecot/core/commit/83ad90e5d8a37ba652e5b32557c989b725ffd9d4
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-09-15 (Thu, 15 Sep 2016)

  Changed paths:
    M src/lib-fs/fs-posix.c
    M src/lib-index/mailbox-log.c
    M src/lib-stats/stats-connection.c
    M src/lib-storage/index/imapc/imapc-mail.c
    M src/lib/istream-file.c
    M src/login-common/login-proxy-state.c
    M src/plugins/fts/fts-api.c
    M src/plugins/virtual/virtual-mail.c

  Log Message:
  -----------
  Added asserts to make static analyzer happier.


  Commit: abea9d7b6be179628f4911e3314274e3950d09e6
      https://github.com/dovecot/core/commit/abea9d7b6be179628f4911e3314274e3950d09e6
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-09-15 (Thu, 15 Sep 2016)

  Changed paths:
    M src/auth/auth-policy.c

  Log Message:
  -----------
  auth: Explicitly ignore return value to make static analyzer happier.


  Commit: 88eab5220d312cb3aea1e7edb9aa3758ed0cf336
      https://github.com/dovecot/core/commit/88eab5220d312cb3aea1e7edb9aa3758ed0cf336
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-09-15 (Thu, 15 Sep 2016)

  Changed paths:
    M src/auth/auth-request.c

  Log Message:
  -----------
  auth: Make sure auth_request_log_info() doesn't crash when there are no passdbs

auth_request_is_disabled_master_user() could have caused such crash.


  Commit: b49ca324eadb397bdfe08753e6d755f447259a6e
      https://github.com/dovecot/core/commit/b49ca324eadb397bdfe08753e6d755f447259a6e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-09-15 (Thu, 15 Sep 2016)

  Changed paths:
    M src/lib-dict/dict-client.c

  Log Message:
  -----------
  dict-client: Don't crash if dict-server returns broken reply.

Just treat missing <tab>value as empty value.


  Commit: 41d91454ba0338113ec6fef3ae96e94af0138b5e
      https://github.com/dovecot/core/commit/41d91454ba0338113ec6fef3ae96e94af0138b5e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-09-15 (Thu, 15 Sep 2016)

  Changed paths:
    M src/lib-master/ipc-server.c

  Log Message:
  -----------
  lib-master: Fixed memory leak when IPC server is handling commands.

This mainly meant that when login processes responded to doveadm proxy
list/kick commands memory was leaked.


  Commit: 6f94745813906563ffe2488e09cfcea63e3862b0
      https://github.com/dovecot/core/commit/6f94745813906563ffe2488e09cfcea63e3862b0
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-09-15 (Thu, 15 Sep 2016)

  Changed paths:
    M src/lib-lda/lmtp-client.c

  Log Message:
  -----------
  lib-lda: Cleanup error handling in LMTP client code.

If there are no successful recipients, we'll need to deinit the client.
But at that point we've already called all the callbacks, so the line
parameter to lmtp_client_fail_full() isn't actually used anywhere.
This was confusing static analyzer because global_fail_string was used
as parameter, which could have been NULL and wouldn't have been valid
for the callbacks.


  Commit: ecdabaf86ff25b01b0b25df647334a12bcd6e642
      https://github.com/dovecot/core/commit/ecdabaf86ff25b01b0b25df647334a12bcd6e642
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-09-15 (Thu, 15 Sep 2016)

  Changed paths:
    M src/doveadm/doveadm-auth.c

  Log Message:
  -----------
  doveadm-auth: Handle unexpected auth "continue" request without crashing.


  Commit: 9d0e2470e0b0fdd8bd71b90c89b77935306b2f56
      https://github.com/dovecot/core/commit/9d0e2470e0b0fdd8bd71b90c89b77935306b2f56
  Author: Stephan Bosch <stephan at dovecot.fi>
  Date:   2016-09-15 (Thu, 15 Sep 2016)

  Changed paths:
    M src/lib-http/http-client-connection.c

  Log Message:
  -----------
  lib-http: client: Fixed hang occurring when nested ioloops are used in response callbacks.

To prevent missing disconnect events, i_stream_read() is called once a change in ioloop is detected.
However, if something was actually read into the stream, the input handler was never called.
So, a response could linger in the stream buffer, without being handled, thereby causing the connection to hang indefinitely.
An additional input event could end the hang, but sometimes this doesn't happen before the request times out.

This problem was seen in test-http-payload once in about 10 invocations.
Obox uses nested ioloops, to this applies there.


  Commit: f75889f56c6c1d52c032f3f0beaa93f724d0908d
      https://github.com/dovecot/core/commit/f75889f56c6c1d52c032f3f0beaa93f724d0908d
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-09-15 (Thu, 15 Sep 2016)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-mail.c

  Log Message:
  -----------
  imapc: mail_get_stream() shouldn't return cached hdr_size


  Commit: c06590cb3d4d49747322da128f8153c847fd1c84
      https://github.com/dovecot/core/commit/c06590cb3d4d49747322da128f8153c847fd1c84
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-09-15 (Thu, 15 Sep 2016)

  Changed paths:
    M src/plugins/pop3-migration/pop3-migration-plugin.c
    M src/plugins/pop3-migration/pop3-migration-plugin.h
    M src/plugins/pop3-migration/test-pop3-migration-plugin.c

  Log Message:
  -----------
  pop3-migration: Avoid unnecessarily using stream's hdr_size.

Shouldn't change any behavior, except reduce CPU usage a little bit.


Compare: https://github.com/dovecot/core/compare/9c96b04f26fa...c06590cb3d4d