From noreply at github.com Wed Feb 1 10:00:12 2017 From: noreply at github.com (GitHub) Date: Wed, 01 Feb 2017 02:00:12 -0800 Subject: [dovecot/core] f46f53: imap: Fix panic on FETCH X-MAILBOX in virtual mail... Message-ID: <5891b1acaed29_4ffb3fbc285d112c25283@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f46f53badf6082e289ac38807e701305c521f11d https://github.com/dovecot/core/commit/f46f53badf6082e289ac38807e701305c521f11d Author: Timo Sirainen Date: 2017-01-31 (Tue, 31 Jan 2017) Changed paths: M src/imap/imap-fetch.c Log Message: ----------- imap: Fix panic on FETCH X-MAILBOX in virtual mailbox when mail is expunged From noreply at github.com Wed Feb 1 10:30:17 2017 From: noreply at github.com (GitHub) Date: Wed, 01 Feb 2017 02:30:17 -0800 Subject: [dovecot/core] 544cbb: imap: Fix panic on FETCH X-MAILBOX in virtual mail... Message-ID: <5891b8b99f83f_57613ff03bdeb12c473c1@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 544cbb96c17678a3283f92ad54e8b4cb518da11e https://github.com/dovecot/core/commit/544cbb96c17678a3283f92ad54e8b4cb518da11e Author: Timo Sirainen Date: 2017-02-01 (Wed, 01 Feb 2017) Changed paths: M src/imap/imap-fetch.c Log Message: ----------- imap: Fix panic on FETCH X-MAILBOX in virtual mailbox when mail is expunged From noreply at github.com Wed Feb 1 14:00:13 2017 From: noreply at github.com (GitHub) Date: Wed, 01 Feb 2017 06:00:13 -0800 Subject: [dovecot/core] 000e7c: lib-master: Ignore t_readlink ENOENT error on upda... Message-ID: <5891e9ed3b5ed_265d3fcfba3d713c66571@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 000e7cdebabb7a4a6845996eaa348dfcb0c72969 https://github.com/dovecot/core/commit/000e7cdebabb7a4a6845996eaa348dfcb0c72969 Author: Martti Rannanj?rvi Date: 2017-02-01 (Wed, 01 Feb 2017) Changed paths: M src/lib-master/master-instance.c Log Message: ----------- lib-master: Ignore t_readlink ENOENT error on updating instances list The list may contain paths that don't exist anymore. From noreply at github.com Thu Feb 2 10:00:13 2017 From: noreply at github.com (GitHub) Date: Thu, 02 Feb 2017 02:00:13 -0800 Subject: [dovecot/core] eb4f49: dict-sql: Add missing USING TIMESTAMP for DELETE q... Message-ID: <5893032d7666c_28aa3f98138d3c3c406cf@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: eb4f49379143767eb13ecf37b1632646734ff31c https://github.com/dovecot/core/commit/eb4f49379143767eb13ecf37b1632646734ff31c Author: Timo Sirainen Date: 2017-02-02 (Thu, 02 Feb 2017) Changed paths: M src/lib-dict/dict-sql.c Log Message: ----------- dict-sql: Add missing USING TIMESTAMP for DELETE queries From noreply at github.com Thu Feb 2 17:00:11 2017 From: noreply at github.com (GitHub) Date: Thu, 02 Feb 2017 09:00:11 -0800 Subject: [dovecot/core] 18c01c: dict: Fix error logging if TIMESTAMP parameters ar... Message-ID: <5893659b690e5_76fb3f83903f9c3011978@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 18c01c2573243be3eaaf3c584236d865ae3390fd https://github.com/dovecot/core/commit/18c01c2573243be3eaaf3c584236d865ae3390fd Author: Timo Sirainen Date: 2017-02-02 (Thu, 02 Feb 2017) Changed paths: M src/dict/dict-commands.c Log Message: ----------- dict: Fix error logging if TIMESTAMP parameters are wrong. From noreply at github.com Thu Feb 2 17:30:11 2017 From: noreply at github.com (GitHub) Date: Thu, 02 Feb 2017 09:30:11 -0800 Subject: [dovecot/core] aa881f: lib-http: client: Respect the connection idle time... Message-ID: <58936ca3dede7_72b83f97fbe8bc3c349f1@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: aa881f8f1465b2a8920c884e24b1b9a31a2a3666 https://github.com/dovecot/core/commit/aa881f8f1465b2a8920c884e24b1b9a31a2a3666 Author: Stephan Bosch Date: 2017-02-02 (Thu, 02 Feb 2017) Changed paths: M src/lib-http/http-client-peer.c Log Message: ----------- lib-http: client: Respect the connection idle timeout, even when all queues have unlinked from a peer. Otherwise, the DNS TTL timeout dictates the connection idle timeout in some situations. Commit: b3df4be577af79d93f39e099e5e0b226ab7fd775 https://github.com/dovecot/core/commit/b3df4be577af79d93f39e099e5e0b226ab7fd775 Author: Stephan Bosch Date: 2017-02-02 (Thu, 02 Feb 2017) Changed paths: M src/lib-http/http-client-queue.c M src/lib-http/test-http-client-errors.c Log Message: ----------- lib-http: client: Fixed peer reconnection failure handling. The addressed problem occurs in a very specific situation in which the original successful connection is dropped, yet a new connection fails. It manifests as an assertion failure or panic: Panic: file ioloop-epoll.c: line 189 (io_loop_handler_run_internal): assertion failed: (msecs >= 0) Panic: BUG: No IOs or timeouts set. Not waiting for infinity. The timing is very critical. However, this doesn't mean that the occurrence of this problem is very unlikely; it can happen frequently under high load. Compare: https://github.com/dovecot/core/compare/18c01c257324...b3df4be577af From noreply at github.com Fri Feb 3 08:30:10 2017 From: noreply at github.com (GitHub) Date: Fri, 03 Feb 2017 00:30:10 -0800 Subject: [dovecot/core] 093d5c: lib-storage: Add assert to make sure header parsin... Message-ID: <58943f928e48b_40a3fe615813c341122d3@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 093d5c0cdf04c9190b6377e624206cdf85fe665a https://github.com/dovecot/core/commit/093d5c0cdf04c9190b6377e624206cdf85fe665a Author: Timo Sirainen Date: 2017-02-03 (Fri, 03 Feb 2017) Changed paths: M src/lib-storage/index/index-mail-headers.c Log Message: ----------- lib-storage: Add assert to make sure header parsing isn't recursed From noreply at github.com Fri Feb 3 10:00:15 2017 From: noreply at github.com (GitHub) Date: Fri, 03 Feb 2017 02:00:15 -0800 Subject: [dovecot/core] 89b020: dict: Fix error logging if TIMESTAMP parameters ar... Message-ID: <589454af54b4f_14cce3fbe8a845c3c867da@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 89b0207307899cdc69a7a287aaf667dea3ad7217 https://github.com/dovecot/core/commit/89b0207307899cdc69a7a287aaf667dea3ad7217 Author: Timo Sirainen Date: 2017-02-03 (Fri, 03 Feb 2017) Changed paths: M src/dict/dict-commands.c Log Message: ----------- dict: Fix error logging if TIMESTAMP parameters are wrong. Commit: 504701e3a4fab2aa22da153c11f7461e7f705778 https://github.com/dovecot/core/commit/504701e3a4fab2aa22da153c11f7461e7f705778 Author: Stephan Bosch Date: 2017-02-03 (Fri, 03 Feb 2017) Changed paths: M src/lib-http/http-client-peer.c Log Message: ----------- lib-http: client: Respect the connection idle timeout, even when all queues have unlinked from a peer. Otherwise, the DNS TTL timeout dictates the connection idle timeout in some situations. Commit: 2444e6039fa17e1cec42f5b874a88fa0eb638f60 https://github.com/dovecot/core/commit/2444e6039fa17e1cec42f5b874a88fa0eb638f60 Author: Stephan Bosch Date: 2017-02-03 (Fri, 03 Feb 2017) Changed paths: M src/lib-http/http-client-queue.c M src/lib-http/test-http-client-errors.c Log Message: ----------- lib-http: client: Fixed peer reconnection failure handling. The addressed problem occurs in a very specific situation in which the original successful connection is dropped, yet a new connection fails. It manifests as an assertion failure or panic: Panic: file ioloop-epoll.c: line 189 (io_loop_handler_run_internal): assertion failed: (msecs >= 0) Panic: BUG: No IOs or timeouts set. Not waiting for infinity. The timing is very critical. However, this doesn't mean that the occurrence of this problem is very unlikely; it can happen frequently under high load. Commit: 3145333a5bde75c9d5b43c85661046fff2959aeb https://github.com/dovecot/core/commit/3145333a5bde75c9d5b43c85661046fff2959aeb Author: Timo Sirainen Date: 2017-02-03 (Fri, 03 Feb 2017) Changed paths: M src/lib-storage/index/index-mail-headers.c Log Message: ----------- lib-storage: Add assert to make sure header parsing isn't recursed Compare: https://github.com/dovecot/core/compare/eb4f49379143...3145333a5bde From noreply at github.com Fri Feb 3 15:00:11 2017 From: noreply at github.com (GitHub) Date: Fri, 03 Feb 2017 07:00:11 -0800 Subject: [dovecot/core] f32382: lib-storage: Once hooks have run, set vlast to NUL... Message-ID: <58949afb3dc32_14d7b3ff8dd6cbc34918bd@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f32382d2da479a4371e08c443679528db37ea988 https://github.com/dovecot/core/commit/f32382d2da479a4371e08c443679528db37ea988 Author: Timo Sirainen Date: 2017-02-03 (Fri, 03 Feb 2017) Changed paths: M src/lib-storage/mail-storage-hooks.c Log Message: ----------- lib-storage: Once hooks have run, set vlast to NULL to make sure it's not used The functions can't be correctly overridden outside their own specific hooks. It would work only if hook_build_update() is called afterwards and currently there's no public API for that. From noreply at github.com Fri Feb 3 15:30:10 2017 From: noreply at github.com (GitHub) Date: Fri, 03 Feb 2017 07:30:10 -0800 Subject: [dovecot/core] 791954: fts: Use mailbox_list_created hook Message-ID: <5894a202a0021_7273ff928215c441105d5@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 79195413c349af7f9ce26871bf79c70af07ea7ce https://github.com/dovecot/core/commit/79195413c349af7f9ce26871bf79c70af07ea7ce Author: Aki Tuomi Date: 2017-02-03 (Fri, 03 Feb 2017) Changed paths: M src/plugins/fts/fts-plugin.c M src/plugins/fts/fts-storage.c M src/plugins/fts/fts-storage.h Log Message: ----------- fts: Use mailbox_list_created hook Otherwise the deinit hook might get lost and fts would not be deinitialized. Reverts 11f12ca1c97583b551a4286fa6cd1ab33aa67680 which seems to have been unnecessary Fixes indexer-worker signal 11 crash From noreply at github.com Sat Feb 4 09:30:12 2017 From: noreply at github.com (GitHub) Date: Sat, 04 Feb 2017 01:30:12 -0800 Subject: [dovecot/core] f977ec: lib-storage: Put vsize in index only if it's not t... Message-ID: <58959f247a953_14c43fa867d9dc2c53818@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f977ec781fca91e320535f1562382433a9e63177 https://github.com/dovecot/core/commit/f977ec781fca91e320535f1562382433a9e63177 Author: Aki Tuomi Date: 2017-02-04 (Sat, 04 Feb 2017) Changed paths: M src/lib-storage/index/index-mail.c Log Message: ----------- lib-storage: Put vsize in index only if it's not there From noreply at github.com Sat Feb 4 09:30:19 2017 From: noreply at github.com (GitHub) Date: Sat, 04 Feb 2017 01:30:19 -0800 Subject: [dovecot/core] 795401: lib-storage: Put vsize in index only if it's not t... Message-ID: <58959f2b61887_10983fd75ca59c2c7878f@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 7954017659a3c50c3dcf7a235dc9680e2cc6df81 https://github.com/dovecot/core/commit/7954017659a3c50c3dcf7a235dc9680e2cc6df81 Author: Aki Tuomi Date: 2017-02-04 (Sat, 04 Feb 2017) Changed paths: M src/lib-storage/index/index-mail.c Log Message: ----------- lib-storage: Put vsize in index only if it's not there From noreply at github.com Sat Feb 4 13:30:10 2017 From: noreply at github.com (GitHub) Date: Sat, 04 Feb 2017 05:30:10 -0800 Subject: [dovecot/core] f5ddf3: lib-storage: Fix autoexpunge locking to actually w... Message-ID: <5895d7628574c_7b683fb9a3c09c3834860@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f5ddf3762f7fa7a389b91a6b8f5732a5d4a1b382 https://github.com/dovecot/core/commit/f5ddf3762f7fa7a389b91a6b8f5732a5d4a1b382 Author: Timo Sirainen Date: 2017-02-04 (Sat, 04 Feb 2017) Changed paths: M src/lib-storage/mail-autoexpunge.c Log Message: ----------- lib-storage: Fix autoexpunge locking to actually work correctly. It wasn't actually skipping the autoexpunging if the lock already existed. It autoexpunged anyway. From noreply at github.com Sat Feb 4 14:00:13 2017 From: noreply at github.com (GitHub) Date: Sat, 04 Feb 2017 06:00:13 -0800 Subject: [dovecot/core] c7378b: lib-storage: Expunging now uses GUID only if it's ... Message-ID: <5895de6d5e9a_1a43f99e419fc2c117913@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: c7378b542c872eb2fd5aae2080507ec1b312c8e8 https://github.com/dovecot/core/commit/c7378b542c872eb2fd5aae2080507ec1b312c8e8 Author: Timo Sirainen Date: 2017-02-04 (Sat, 04 Feb 2017) Changed paths: M src/lib-storage/index/index-mail.c Log Message: ----------- lib-storage: Expunging now uses GUID only if it's in cache. Otherwise the GUID lookup may be expensive, which is especially bad when deleting a large number of mails. From noreply at github.com Sat Feb 4 14:00:15 2017 From: noreply at github.com (GitHub) Date: Sat, 04 Feb 2017 06:00:15 -0800 Subject: [dovecot/core] 24ffb6: lib-storage: Once hooks have run, set vlast to NUL... Message-ID: <5895de6fd4284_8b13fb0406a3c24141880@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 24ffb6a442870267281e469fbf1aab545f98caf6 https://github.com/dovecot/core/commit/24ffb6a442870267281e469fbf1aab545f98caf6 Author: Timo Sirainen Date: 2017-02-04 (Sat, 04 Feb 2017) Changed paths: M src/lib-storage/mail-storage-hooks.c Log Message: ----------- lib-storage: Once hooks have run, set vlast to NULL to make sure it's not used The functions can't be correctly overridden outside their own specific hooks. It would work only if hook_build_update() is called afterwards and currently there's no public API for that. Commit: 921f061651619d9f1cd056926ad0c32ce508bcfc https://github.com/dovecot/core/commit/921f061651619d9f1cd056926ad0c32ce508bcfc Author: Aki Tuomi Date: 2017-02-04 (Sat, 04 Feb 2017) Changed paths: M src/plugins/fts/fts-plugin.c M src/plugins/fts/fts-storage.c M src/plugins/fts/fts-storage.h Log Message: ----------- fts: Use mailbox_list_created hook Otherwise the deinit hook might get lost and fts would not be deinitialized. Reverts 11f12ca1c97583b551a4286fa6cd1ab33aa67680 which seems to have been unnecessary Fixes indexer-worker signal 11 crash Commit: ab14fa88a5c447f94eb4f9e6eb737e47704162f6 https://github.com/dovecot/core/commit/ab14fa88a5c447f94eb4f9e6eb737e47704162f6 Author: Timo Sirainen Date: 2017-02-04 (Sat, 04 Feb 2017) Changed paths: M src/lib-storage/mail-autoexpunge.c Log Message: ----------- lib-storage: Fix autoexpunge locking to actually work correctly. It wasn't actually skipping the autoexpunging if the lock already existed. It autoexpunged anyway. Commit: 9c65e8699036ff6d25de740043c752d7c1a991f2 https://github.com/dovecot/core/commit/9c65e8699036ff6d25de740043c752d7c1a991f2 Author: Timo Sirainen Date: 2017-02-04 (Sat, 04 Feb 2017) Changed paths: M src/lib-storage/index/index-mail.c Log Message: ----------- lib-storage: Expunging now uses GUID only if it's in cache. Otherwise the GUID lookup may be expensive, which is especially bad when deleting a large number of mails. Compare: https://github.com/dovecot/core/compare/7954017659a3...9c65e8699036 From noreply at github.com Sun Feb 5 18:30:10 2017 From: noreply at github.com (GitHub) Date: Sun, 05 Feb 2017 10:30:10 -0800 Subject: [dovecot/core] da61fd: lib: Fix compiler warning with non-Linux Message-ID: <58976f32510a0_26f3ff40625bc34129957@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: da61fd89fa06b557c5955d70281fb20c0c0636b1 https://github.com/dovecot/core/commit/da61fd89fa06b557c5955d70281fb20c0c0636b1 Author: Timo Sirainen Date: 2017-02-05 (Sun, 05 Feb 2017) Changed paths: M src/lib/nfs-workarounds.c Log Message: ----------- lib: Fix compiler warning with non-Linux From noreply at github.com Mon Feb 6 08:30:11 2017 From: noreply at github.com (GitHub) Date: Mon, 06 Feb 2017 00:30:11 -0800 Subject: [dovecot/core] 90e417: auth: Code cleanup - Move userdb extra fields expo... Message-ID: <58983413991d2_9813fd9011efc34538ca@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 90e417d32e964691781c9b6423ab2966f4e48cf5 https://github.com/dovecot/core/commit/90e417d32e964691781c9b6423ab2966f4e48cf5 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/auth/auth-request.c Log Message: ----------- auth: Code cleanup - Move userdb extra fields exporting to its own function Commit: ea7f7e1a7f428aff99404d68f989b8accc5d7c8a https://github.com/dovecot/core/commit/ea7f7e1a7f428aff99404d68f989b8accc5d7c8a Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/auth/auth-request.c Log Message: ----------- auth: Pass through passdb extra fields to auth-worker requests Commit: f6fd135d156e8af8178599e56744d0ab763749b1 https://github.com/dovecot/core/commit/f6fd135d156e8af8178599e56744d0ab763749b1 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib-dict/dict-sql.c Log Message: ----------- dict-sql: Move USING TIMESTAMP to correct location for INSERTs Commit: 74feb39854e50b644a070b27e952037353722932 https://github.com/dovecot/core/commit/74feb39854e50b644a070b27e952037353722932 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M m4/ssl.m4 M src/lib-ssl-iostream/iostream-openssl-context.c Log Message: ----------- lib-ssl-iostream: Use RSA_generate_key_ex() if it exists This avoids deprecation warnings about RSA_generate_key() in OpenSSL v1.1. Commit: 13479101da29577f7789d6f61faa1da3e2f7434a https://github.com/dovecot/core/commit/13479101da29577f7789d6f61faa1da3e2f7434a Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M m4/ssl.m4 M src/lib-ssl-iostream/iostream-openssl-common.c M src/lib-ssl-iostream/iostream-openssl.h Log Message: ----------- lib-ssl-iostream: Use ASN1_STRING_get0_data() if it exists This avoids deprecation warnings about ASN1_STRING_data() in OpenSSL v1.1. Commit: 803d5e00922fd90af4bb5d529eed7af37ea8174a https://github.com/dovecot/core/commit/803d5e00922fd90af4bb5d529eed7af37ea8174a Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M m4/ssl.m4 M src/lib-ssl-iostream/dovecot-openssl-common.c Log Message: ----------- lib-ssl-iostream: Detect OpenSSL memory functions' parameters via configure The version number check doesn't work correctly for LibreSSL. Commit: b91659702c83b8f144e369ad5fa82724242c210c https://github.com/dovecot/core/commit/b91659702c83b8f144e369ad5fa82724242c210c Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M m4/ssl.m4 M src/lib-ssl-iostream/dovecot-openssl-common.c Log Message: ----------- lib-ssl-iostream: Detect OPENSSL_cleanup() via configure It's ugly to have both OpenSSL version number check and a special LibreSSL check. Commit: 04b6c66afd1aa12ff9bded2747a543dde39d6f9c https://github.com/dovecot/core/commit/04b6c66afd1aa12ff9bded2747a543dde39d6f9c Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib-ssl-iostream/dovecot-openssl-common.c Log Message: ----------- lib-ssl-iostream: Call OBJ_cleanup() for all OpenSSL versions Just to reduce the #if checks that uglify the code. Commit: e93dc99f2b89533c4bc6af9d0d2852f83f0d5b9a https://github.com/dovecot/core/commit/e93dc99f2b89533c4bc6af9d0d2852f83f0d5b9a Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M m4/ssl.m4 M src/lib-ssl-iostream/dovecot-openssl-common.c Log Message: ----------- lib-ssl-iostream: Detect whether to call ERR_remove_[thread_]state() via configure Commit: 5fc85eac8aa8b5663e62e3321c6617c27d670630 https://github.com/dovecot/core/commit/5fc85eac8aa8b5663e62e3321c6617c27d670630 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib-dcrypt/test-crypto.c M src/lib-dcrypt/test-stream.c Log Message: ----------- lib-dcrypt: If dcrypt can't be initialized, log also the reason. This is very helpful when debugging linking issues. Commit: d7d1fec9fa3799aaa4c3339d26c610c043d59360 https://github.com/dovecot/core/commit/d7d1fec9fa3799aaa4c3339d26c610c043d59360 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib-dcrypt/Makefile.am Log Message: ----------- lib-dcrypt: Don't link liblib.la to libdcrypt_openssl.so At best this does nothing, at worst (like with OSX) it duplicates the entire liblib and creates split state between the two instances. Commit: fb8e12a317f617ebb5085c641b4b8025689274ab https://github.com/dovecot/core/commit/fb8e12a317f617ebb5085c641b4b8025689274ab Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib-dcrypt/Makefile.am Log Message: ----------- lib-dcrypt: Remove unnecessary -shared link flag Not sure if this is harmful, but since no other plugin uses this it's not needed either. Commit: f089a10e4816e772992346c9837ec10db3894c65 https://github.com/dovecot/core/commit/f089a10e4816e772992346c9837ec10db3894c65 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib-dcrypt/Makefile.am Log Message: ----------- lib-dcrypt: Link unit tests with libssl_iostream.la libssl_iostream_openssl.so requires this, and it doesn't get added from anywhere automatically. Commit: 84e69f2ae895e8eaaee436fcdb82dfa5b67a88f8 https://github.com/dovecot/core/commit/84e69f2ae895e8eaaee436fcdb82dfa5b67a88f8 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib-ssl-iostream/Makefile.am Log Message: ----------- lib-ssl-iostream: Remove empty $(ssl_sources) from Makefile Commit: c6108c1bfa10d5fcd1def9c6a23ebcd5204d1775 https://github.com/dovecot/core/commit/c6108c1bfa10d5fcd1def9c6a23ebcd5204d1775 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib-dcrypt/Makefile.am M src/lib-ssl-iostream/Makefile.am Log Message: ----------- lib-ssl-iostream: Remove libdovecot_openssl_common.la Using such a library results in the same code being duplicated (in OSX) in both libssl_iostream_openssl.so and libdcrypt_openssl.so. This breaks the idea of openssl_init_refcount, because each one will have their own one. libdcrypt_openssl.so now links to libssl_iostream_openssl.so, which shouldn't really be a problem, because lib-ssl-iostream is part of the core libdovecot.so already. It would have been possible to also install libdovecot_openssl_common.so and link it to both libssl_iostream_openssl.so and libdcrypt_openssl.so, but that seems unnecessarily complicated. Commit: 3c2e763ab035567b2081a805648537b27e7cbbcf https://github.com/dovecot/core/commit/3c2e763ab035567b2081a805648537b27e7cbbcf Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib-storage/mail-user.c Log Message: ----------- lib-storage: Don't unnecessarily duplicate user's all setting strings user->unexpanded_set and user->set have the same life-time, so they can point to same strings. Commit: 34512eaad8b1b2f929e6d6e3a2f7252c29fba97b https://github.com/dovecot/core/commit/34512eaad8b1b2f929e6d6e3a2f7252c29fba97b Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib-storage/mail-storage-service.c M src/lib-storage/mail-user.c M src/lib-storage/mail-user.h Log Message: ----------- lib-storage: Don't duplicate service user's settings into mail_user The mail_storage_service_user.user_set isn't used afterwards, so it can be directly used to avoid wasting memory. Compare: https://github.com/dovecot/core/compare/da61fd89fa06...34512eaad8b1 From noreply at github.com Mon Feb 6 10:00:11 2017 From: noreply at github.com (GitHub) Date: Mon, 06 Feb 2017 02:00:11 -0800 Subject: [dovecot/core] dd6043: lib: Make sure NULL is defined to be ((void *)0) Message-ID: <5898492bf08ea_8c93ffa8fe2bc3c323de@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: dd6043c05e32a8e8db1233ed711a2c74d1477a89 https://github.com/dovecot/core/commit/dd6043c05e32a8e8db1233ed711a2c74d1477a89 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib/compat.h Log Message: ----------- lib: Make sure NULL is defined to be ((void *)0) This avoids us having to do explicit (void *)NULL casts in e.g. io_add(..., NULL) context parameter. Commit: 2f2b1b725860bfef7c796b0aaa1a647ac538124f https://github.com/dovecot/core/commit/2f2b1b725860bfef7c796b0aaa1a647ac538124f Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/auth/auth-request.c Log Message: ----------- auth: Handle delayed credentials identically in auth-workers Compare: https://github.com/dovecot/core/compare/34512eaad8b1...2f2b1b725860 From noreply at github.com Mon Feb 6 10:30:10 2017 From: noreply at github.com (GitHub) Date: Mon, 06 Feb 2017 02:30:10 -0800 Subject: [dovecot/core] 2b8c40: lib-ssl-iostream: Fix memory leak in RSA_generate_... Message-ID: <589850322678b_4b753f8d7ad9bc2c11848e@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 2b8c4027ae956a4a99216a0e541d670aec43f7a5 https://github.com/dovecot/core/commit/2b8c4027ae956a4a99216a0e541d670aec43f7a5 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib-ssl-iostream/iostream-openssl-context.c Log Message: ----------- lib-ssl-iostream: Fix memory leak in RSA_generate_key_ex() usage From noreply at github.com Mon Feb 6 12:30:10 2017 From: noreply at github.com (GitHub) Date: Mon, 06 Feb 2017 04:30:10 -0800 Subject: [dovecot/core] b748f9: imap: Don't send empty FETCH () on failure Message-ID: <58986c5213e84_40b3fbbef505c2c6137c@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: b748f91d0677fffaa2208b39ebb6db3aeb2e937b https://github.com/dovecot/core/commit/b748f91d0677fffaa2208b39ebb6db3aeb2e937b Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/imap/imap-fetch.c Log Message: ----------- imap: Don't send empty FETCH () on failure It violates IMAP RFC. Send FETCH (UID n) instead. Commit: 9aa91e371b05dc9b38bfc5b4ad5fe41bcf03a362 https://github.com/dovecot/core/commit/9aa91e371b05dc9b38bfc5b4ad5fe41bcf03a362 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/imap/cmd-close.c Log Message: ----------- imap: Free search updates on CLOSE Commit: 287a58f11ad8421dd3c959c1f2a6ef26fbb0afa8 https://github.com/dovecot/core/commit/287a58f11ad8421dd3c959c1f2a6ef26fbb0afa8 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/imap/cmd-close.c M src/imap/cmd-logout.c M src/imap/cmd-select.c M src/imap/cmd-unselect.c M src/imap/imap-client.c M src/imap/imap-commands-util.c M src/imap/imap-commands-util.h Log Message: ----------- imap: Share mailbox closing code in SELECT/UNSELECT/CLOSE/LOGOUT/deinit Commit: 704a96fa677763eef7ae62466e14e83a2f535427 https://github.com/dovecot/core/commit/704a96fa677763eef7ae62466e14e83a2f535427 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/imap/cmd-fetch.c M src/imap/imap-client.h M src/imap/imap-commands-util.c M src/imap/imap-fetch.c M src/imap/imap-fetch.h M src/imap/imap-settings.c M src/imap/imap-settings.h Log Message: ----------- imap: Add imap_fetch_failure setting This controls what happens when FETCH fails for some mails. The possible values are: disconnect-immediately: This is the original behavior. Whenever FETCH fails for a mail, the FETCH is aborted and client is disconnected. disconnect-after: The FETCH runs for all the requested mails, skipping any mails that returned failures, but at the end the client is still disconnected. no-after: The FETCH runs for all the requested mails, skipping any mails that returned failures. At the end tagged NO reply is returned. If the client attempts to FETCH the same failed mail more than once, the client is disconnected. This is to avoid clients from going into infinite loops trying to FETCH a broken mail. Compare: https://github.com/dovecot/core/compare/2b8c4027ae95...704a96fa6777 From noreply at github.com Mon Feb 6 14:00:12 2017 From: noreply at github.com (GitHub) Date: Mon, 06 Feb 2017 06:00:12 -0800 Subject: [dovecot/core] e4109f: indexer: Don't send more requests directly from wo... Message-ID: <5898816c993bf_3c93fd99f46dc24124017@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: e4109fe523db23973c6fbfccf370b5dd3d754372 https://github.com/dovecot/core/commit/e4109fe523db23973c6fbfccf370b5dd3d754372 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/indexer/indexer.c Log Message: ----------- indexer: Don't send more requests directly from worker status callback This causes assert-crashes when workers disconnect while having multiple requests: indexer: Error: Indexer worker disconnected, discarding 2 requests for user at domain indexer: Panic: file indexer.c: line 69 (queue_try_send_more): assertion failed: (worker_connection_is_connected(conn)) From noreply at github.com Mon Feb 6 15:00:33 2017 From: noreply at github.com (GitHub) Date: Mon, 06 Feb 2017 07:00:33 -0800 Subject: [dovecot/core] d906a0: auth: Code cleanup - Move userdb extra fields expo... Message-ID: <58988f91271d0_11903fca2f413c30974fa@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: d906a02a99427769ce1e683b575a19961dec9656 https://github.com/dovecot/core/commit/d906a02a99427769ce1e683b575a19961dec9656 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/auth/auth-request.c Log Message: ----------- auth: Code cleanup - Move userdb extra fields exporting to its own function Commit: 8e89229c35af286aa91ae0d92b09ac07fc0f1473 https://github.com/dovecot/core/commit/8e89229c35af286aa91ae0d92b09ac07fc0f1473 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/auth/auth-request.c Log Message: ----------- auth: Pass through passdb extra fields to auth-worker requests Commit: d03fb40329c6531cae42b9ba252863ab2c849614 https://github.com/dovecot/core/commit/d03fb40329c6531cae42b9ba252863ab2c849614 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib-dict/dict-sql.c Log Message: ----------- dict-sql: Move USING TIMESTAMP to correct location for INSERTs Commit: 8adfdb0f446941dad4c23c6db34c2a42705930be https://github.com/dovecot/core/commit/8adfdb0f446941dad4c23c6db34c2a42705930be Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M configure.ac M src/lib-ssl-iostream/iostream-openssl-context.c Log Message: ----------- lib-ssl-iostream: Use RSA_generate_key_ex() if it exists This avoids deprecation warnings about RSA_generate_key() in OpenSSL v1.1. Commit: 905553cf20f81b4a90ba3f027e40f053cc21fbbd https://github.com/dovecot/core/commit/905553cf20f81b4a90ba3f027e40f053cc21fbbd Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M configure.ac M src/lib-ssl-iostream/iostream-openssl-common.c M src/lib-ssl-iostream/iostream-openssl.h Log Message: ----------- lib-ssl-iostream: Use ASN1_STRING_get0_data() if it exists This avoids deprecation warnings about ASN1_STRING_data() in OpenSSL v1.1. Commit: 6c7487039ce73d7229fb5f28ec372cde67b274b6 https://github.com/dovecot/core/commit/6c7487039ce73d7229fb5f28ec372cde67b274b6 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M configure.ac M src/lib-ssl-iostream/dovecot-openssl-common.c Log Message: ----------- lib-ssl-iostream: Detect OpenSSL memory functions' parameters via configure The version number check doesn't work correctly for LibreSSL. Commit: 92ae85d6afda5d148e86bfbbbeac7164c4ab2c3d https://github.com/dovecot/core/commit/92ae85d6afda5d148e86bfbbbeac7164c4ab2c3d Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M configure.ac M src/lib-ssl-iostream/dovecot-openssl-common.c Log Message: ----------- lib-ssl-iostream: Detect OPENSSL_cleanup() via configure It's ugly to have both OpenSSL version number check and a special LibreSSL check. Commit: 5cc5edff30959d11888b9e04ba8204ddf27cc8e4 https://github.com/dovecot/core/commit/5cc5edff30959d11888b9e04ba8204ddf27cc8e4 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib-ssl-iostream/dovecot-openssl-common.c Log Message: ----------- lib-ssl-iostream: Call OBJ_cleanup() for all OpenSSL versions Just to reduce the #if checks that uglify the code. Commit: 5f07a069f3913c27af6d5d6849f7b633bccb7a87 https://github.com/dovecot/core/commit/5f07a069f3913c27af6d5d6849f7b633bccb7a87 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M configure.ac M src/lib-ssl-iostream/dovecot-openssl-common.c Log Message: ----------- lib-ssl-iostream: Detect whether to call ERR_remove_[thread_]state() via configure Commit: 9483ccd557a1c22555c9823312920b2905e72ab9 https://github.com/dovecot/core/commit/9483ccd557a1c22555c9823312920b2905e72ab9 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib-dcrypt/test-crypto.c M src/lib-dcrypt/test-stream.c Log Message: ----------- lib-dcrypt: If dcrypt can't be initialized, log also the reason. This is very helpful when debugging linking issues. Commit: 25bc04eaef7d4a1fc5d6456d5162ce37b1909ddb https://github.com/dovecot/core/commit/25bc04eaef7d4a1fc5d6456d5162ce37b1909ddb Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib-dcrypt/Makefile.am Log Message: ----------- lib-dcrypt: Don't link liblib.la to libdcrypt_openssl.so At best this does nothing, at worst (like with OSX) it duplicates the entire liblib and creates split state between the two instances. Commit: 6ceb8107900005b1c777bcc56fb914ef1e8254fc https://github.com/dovecot/core/commit/6ceb8107900005b1c777bcc56fb914ef1e8254fc Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib-dcrypt/Makefile.am Log Message: ----------- lib-dcrypt: Remove unnecessary -shared link flag Not sure if this is harmful, but since no other plugin uses this it's not needed either. Commit: 0f3542d848014670fe51275657773e2f36f27b1f https://github.com/dovecot/core/commit/0f3542d848014670fe51275657773e2f36f27b1f Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib-dcrypt/Makefile.am Log Message: ----------- lib-dcrypt: Link unit tests with libssl_iostream.la libssl_iostream_openssl.so requires this, and it doesn't get added from anywhere automatically. Commit: f82283cadae5f6b0630353936ee518e566429cee https://github.com/dovecot/core/commit/f82283cadae5f6b0630353936ee518e566429cee Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib-ssl-iostream/Makefile.am Log Message: ----------- lib-ssl-iostream: Remove empty $(ssl_sources) from Makefile Commit: 313edff9feaef4199fcfa74fad87189ec7ccfba7 https://github.com/dovecot/core/commit/313edff9feaef4199fcfa74fad87189ec7ccfba7 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib-dcrypt/Makefile.am M src/lib-ssl-iostream/Makefile.am Log Message: ----------- lib-ssl-iostream: Remove libdovecot_openssl_common.la Using such a library results in the same code being duplicated (in OSX) in both libssl_iostream_openssl.so and libdcrypt_openssl.so. This breaks the idea of openssl_init_refcount, because each one will have their own one. libdcrypt_openssl.so now links to libssl_iostream_openssl.so, which shouldn't really be a problem, because lib-ssl-iostream is part of the core libdovecot.so already. It would have been possible to also install libdovecot_openssl_common.so and link it to both libssl_iostream_openssl.so and libdcrypt_openssl.so, but that seems unnecessarily complicated. Commit: 518b81bfe00a4217c68cb6426e15d74f7fea270d https://github.com/dovecot/core/commit/518b81bfe00a4217c68cb6426e15d74f7fea270d Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib-storage/mail-user.c Log Message: ----------- lib-storage: Don't unnecessarily duplicate user's all setting strings user->unexpanded_set and user->set have the same life-time, so they can point to same strings. Commit: b5e88b7efc276645485fa8b95250ad439607fca8 https://github.com/dovecot/core/commit/b5e88b7efc276645485fa8b95250ad439607fca8 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib-storage/mail-storage-service.c M src/lib-storage/mail-user.c M src/lib-storage/mail-user.h Log Message: ----------- lib-storage: Don't duplicate service user's settings into mail_user The mail_storage_service_user.user_set isn't used afterwards, so it can be directly used to avoid wasting memory. Commit: 2c4a553a7fde3af1d406df9b6eaa29ec4d2e07f6 https://github.com/dovecot/core/commit/2c4a553a7fde3af1d406df9b6eaa29ec4d2e07f6 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib/compat.h Log Message: ----------- lib: Make sure NULL is defined to be ((void *)0) This avoids us having to do explicit (void *)NULL casts in e.g. io_add(..., NULL) context parameter. Commit: 48fde2a7136d61f173d9d509150519c61d7c629a https://github.com/dovecot/core/commit/48fde2a7136d61f173d9d509150519c61d7c629a Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/auth/auth-request.c Log Message: ----------- auth: Handle delayed credentials identically in auth-workers Commit: 9b1bec856f8b2c33f1190fde169b67e489802530 https://github.com/dovecot/core/commit/9b1bec856f8b2c33f1190fde169b67e489802530 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/lib-ssl-iostream/iostream-openssl-context.c Log Message: ----------- lib-ssl-iostream: Fix memory leak in RSA_generate_key_ex() usage Commit: 17b83d9d34957145ad1b4f22c106a612c8948ee8 https://github.com/dovecot/core/commit/17b83d9d34957145ad1b4f22c106a612c8948ee8 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/imap/imap-fetch.c Log Message: ----------- imap: Don't send empty FETCH () on failure It violates IMAP RFC. Send FETCH (UID n) instead. Commit: 7b87f615282780e3bcd3f16188455d639da75f89 https://github.com/dovecot/core/commit/7b87f615282780e3bcd3f16188455d639da75f89 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/imap/cmd-close.c Log Message: ----------- imap: Free search updates on CLOSE Commit: e1997d40e25a493415ff574d1d09ee30ba06430d https://github.com/dovecot/core/commit/e1997d40e25a493415ff574d1d09ee30ba06430d Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/imap/cmd-close.c M src/imap/cmd-logout.c M src/imap/cmd-select.c M src/imap/cmd-unselect.c M src/imap/imap-client.c M src/imap/imap-commands-util.c M src/imap/imap-commands-util.h Log Message: ----------- imap: Share mailbox closing code in SELECT/UNSELECT/CLOSE/LOGOUT/deinit Commit: 8fe64e2af5b6ce7b6ffa6453beaf569dca089e59 https://github.com/dovecot/core/commit/8fe64e2af5b6ce7b6ffa6453beaf569dca089e59 Author: Martti Rannanj?rvi Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/imap/cmd-fetch.c M src/lib-imap/imap-resp-code.h Log Message: ----------- lib-imap, imap: BINARY [UNKNOWNCTE] to [PARSE] Commit: f6170729cebfa2e998b4578924c60b9affb29258 https://github.com/dovecot/core/commit/f6170729cebfa2e998b4578924c60b9affb29258 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/imap/cmd-fetch.c M src/imap/imap-client.h M src/imap/imap-commands-util.c M src/imap/imap-fetch.c M src/imap/imap-fetch.h M src/imap/imap-settings.c M src/imap/imap-settings.h Log Message: ----------- imap: Add imap_fetch_failure setting This controls what happens when FETCH fails for some mails. The possible values are: disconnect-immediately: This is the original behavior. Whenever FETCH fails for a mail, the FETCH is aborted and client is disconnected. disconnect-after: The FETCH runs for all the requested mails, skipping any mails that returned failures, but at the end the client is still disconnected. no-after: The FETCH runs for all the requested mails, skipping any mails that returned failures. At the end tagged NO reply is returned. If the client attempts to FETCH the same failed mail more than once, the client is disconnected. This is to avoid clients from going into infinite loops trying to FETCH a broken mail. Commit: 3b1a82eed8708d63ac5869d35a847dbaf0d54221 https://github.com/dovecot/core/commit/3b1a82eed8708d63ac5869d35a847dbaf0d54221 Author: Timo Sirainen Date: 2017-02-06 (Mon, 06 Feb 2017) Changed paths: M src/indexer/indexer.c Log Message: ----------- indexer: Don't send more requests directly from worker status callback This causes assert-crashes when workers disconnect while having multiple requests: indexer: Error: Indexer worker disconnected, discarding 2 requests for user at domain indexer: Panic: file indexer.c: line 69 (queue_try_send_more): assertion failed: (worker_connection_is_connected(conn)) Compare: https://github.com/dovecot/core/compare/9c65e8699036...3b1a82eed870 From noreply at github.com Tue Feb 7 09:00:11 2017 From: noreply at github.com (GitHub) Date: Tue, 07 Feb 2017 01:00:11 -0800 Subject: [dovecot/core] f817e9: fts-solr: Allow username/password for solr conncti... Message-ID: <58998c9b2955f_150533fdb74a79c2c142897@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f817e98f79893a17b09214081f51834c3d733919 https://github.com/dovecot/core/commit/f817e98f79893a17b09214081f51834c3d733919 Author: J. Nick Koston Date: 2017-02-07 (Tue, 07 Feb 2017) Changed paths: M src/plugins/fts-solr/solr-connection.c Log Message: ----------- fts-solr: Allow username/password for solr connction Solr comes open to the world by default. For better security, we protect our solr installs with a user and password. This change allows dovecot to connect to these instances. Example usage in a fts.conf (permissions 0600) fts_solr = url=http://nick:pass at 127.0.0.1:8983/solr/dovecot/ From noreply at github.com Tue Feb 7 10:00:11 2017 From: noreply at github.com (GitHub) Date: Tue, 07 Feb 2017 02:00:11 -0800 Subject: [dovecot/core] dce400: lib-ldap: Remove extra return Message-ID: <58999aabab249_24373ff25cb2dc3c126431@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: dce4003a35804d2b94a76fb574b0886b09787d01 https://github.com/dovecot/core/commit/dce4003a35804d2b94a76fb574b0886b09787d01 Author: johnkwoods Date: 2017-02-07 (Tue, 07 Feb 2017) Changed paths: M src/lib-ldap/ldap-compare.c Log Message: ----------- lib-ldap: Remove extra return The ldap_connection_queue_request() function returns void. Trying to "return" something from a void function caused compiling issues on Solaris (Oracle Developer Studio 12.5). From noreply at github.com Tue Feb 7 11:00:10 2017 From: noreply at github.com (GitHub) Date: Tue, 07 Feb 2017 03:00:10 -0800 Subject: [dovecot/core] 26bdbf: lib-storage: Added mail_user_init_ssl_client_setti... Message-ID: <5899a8baa31bc_16ea3fa1185c1c34112948@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 26bdbffc35ee46779f15a537a757ed937a4d1c91 https://github.com/dovecot/core/commit/26bdbffc35ee46779f15a537a757ed937a4d1c91 Author: Stephan Bosch Date: 2017-02-07 (Tue, 07 Feb 2017) Changed paths: M src/lib-storage/mail-user.c M src/lib-storage/mail-user.h Log Message: ----------- lib-storage: Added mail_user_init_ssl_client_settings(). Commit: 526631052ca3175357302af8fa7dcbf763b40c53 https://github.com/dovecot/core/commit/526631052ca3175357302af8fa7dcbf763b40c53 Author: Stephan Bosch Date: 2017-02-07 (Tue, 07 Feb 2017) Changed paths: M src/plugins/fts-solr/Makefile.am M src/plugins/fts-solr/fts-backend-solr-old.c M src/plugins/fts-solr/fts-backend-solr.c M src/plugins/fts-solr/solr-connection.c M src/plugins/fts-solr/solr-connection.h Log Message: ----------- fts-solr: Fixed HTTPS support by properly propagating SSL client settings from mail_user. Commit: 2a5682a643b36c162aaf5dba4b2cdb1464b8a3a8 https://github.com/dovecot/core/commit/2a5682a643b36c162aaf5dba4b2cdb1464b8a3a8 Author: Stephan Bosch Date: 2017-02-07 (Tue, 07 Feb 2017) Changed paths: M src/plugins/fts/Makefile.am M src/plugins/fts/fts-parser-tika.c Log Message: ----------- fts-tika: Fixed HTTPS support by properly propagating SSL client settings from mail_user. Compare: https://github.com/dovecot/core/compare/dce4003a3580...2a5682a643b3 From noreply at github.com Tue Feb 7 11:30:10 2017 From: noreply at github.com (GitHub) Date: Tue, 07 Feb 2017 03:30:10 -0800 Subject: [dovecot/core] 3e675d: lib: Check that output max size is non-zero when v... Message-ID: <5899afc230cd0_4c5d3fc534047c281451a1@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 3e675de58a30e18fc973d4f0203ed3a4175c8ac5 https://github.com/dovecot/core/commit/3e675de58a30e18fc973d4f0203ed3a4175c8ac5 Author: Aki Tuomi Date: 2017-02-07 (Tue, 07 Feb 2017) Changed paths: M src/lib/connection.c Log Message: ----------- lib: Check that output max size is non-zero when version specified Otherwise we try to send version to non-existent output stream. Commit: 2eeea57b495fe2965a8bff5cc1cd47d7b8969b58 https://github.com/dovecot/core/commit/2eeea57b495fe2965a8bff5cc1cd47d7b8969b58 Author: Martti Rannanj?rvi Date: 2017-02-07 (Tue, 07 Feb 2017) Changed paths: M src/lib-storage/mail-storage-settings.c M src/lib-storage/mail-storage-settings.h Log Message: ----------- lib-storage: remove mail_storage_get_driver_settings It has been marked obsolete. Compare: https://github.com/dovecot/core/compare/2a5682a643b3...2eeea57b495f From noreply at github.com Wed Feb 8 01:13:02 2017 From: noreply at github.com (GitHub) Date: Tue, 07 Feb 2017 17:13:02 -0800 Subject: [dovecot/pigeonhole] 51e4ff: lib-sieve: file storage: Improve listing permissio... Message-ID: <589a709ea5556_ac63f932a717c38139395@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/pigeonhole Commit: 51e4ff296987781e1ce93cb1c0ccc14e863bf8d6 https://github.com/dovecot/pigeonhole/commit/51e4ff296987781e1ce93cb1c0ccc14e863bf8d6 Author: Stephan Bosch Date: 2017-02-08 (Wed, 08 Feb 2017) Changed paths: M src/lib-sieve/storage/file/sieve-file-storage-list.c Log Message: ----------- lib-sieve: file storage: Improve listing permission error. Use eacces_error_get(), rather than just printing "Permission denied". From noreply at github.com Wed Feb 8 11:00:11 2017 From: noreply at github.com (GitHub) Date: Wed, 08 Feb 2017 03:00:11 -0800 Subject: [dovecot/core] f97866: quota: When executing quota_warning/over_flag scri... Message-ID: <589afa3bd28d7_40a3fe615813c34194026@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f97866381675fe12cdab0f2d56a059fe7b88457a https://github.com/dovecot/core/commit/f97866381675fe12cdab0f2d56a059fe7b88457a Author: Timo Sirainen Date: 2017-02-07 (Tue, 07 Feb 2017) Changed paths: M src/plugins/quota/quota-private.h M src/plugins/quota/quota-util.c M src/plugins/quota/quota.c Log Message: ----------- quota: When executing quota_warning/over_flag script, log the reason why. Commit: cd337e465bf8bf33d556fc397787d1519d1cef07 https://github.com/dovecot/core/commit/cd337e465bf8bf33d556fc397787d1519d1cef07 Author: Timo Sirainen Date: 2017-02-07 (Tue, 07 Feb 2017) Changed paths: M src/plugins/quota/quota.c Log Message: ----------- quota: Make sure quota_warning doesn't wrap "quota before" value. This could happen in some race conditions (and with bugs). Commit: 92c671c1667ea1bea90030a2b69298bf8c541623 https://github.com/dovecot/core/commit/92c671c1667ea1bea90030a2b69298bf8c541623 Author: Timo Sirainen Date: 2017-02-07 (Tue, 07 Feb 2017) Changed paths: M src/plugins/quota/quota-count.c M src/plugins/quota/quota-private.h Log Message: ----------- quota: Clarify quota_count() return value. Commit: c72fbbe6328ceb0919b5146ecd43817dc294c314 https://github.com/dovecot/core/commit/c72fbbe6328ceb0919b5146ecd43817dc294c314 Author: Timo Sirainen Date: 2017-02-08 (Wed, 08 Feb 2017) Changed paths: M src/lib-storage/index/dbox-single/sdbox-storage.c Log Message: ----------- sdbox: Fix assert-crash on mailbox create race If another process created the mailbox at the same time, the mailbox_guid wasn't set and opening the mailbox assert-crashed: Panic: file mail-storage.c: line 1744 (mailbox_get_metadata): assertion failed: ((items & MAILBOX_METADATA_GUID) == 0 || !guid_128_is_empty(metadata_r->guid)) Compare: https://github.com/dovecot/core/compare/2eeea57b495f...c72fbbe6328c From noreply at github.com Wed Feb 8 21:30:11 2017 From: noreply at github.com (GitHub) Date: Wed, 08 Feb 2017 13:30:11 -0800 Subject: [dovecot/core] 84cccc: pop3c: Increase timeout for PASS to 5 minutes. Message-ID: <589b8de369eb1_5e2f3f9d012cbc3488175@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 84cccc6b54d8f92fdee75fe96c63bb67b097eeb3 https://github.com/dovecot/core/commit/84cccc6b54d8f92fdee75fe96c63bb67b097eeb3 Author: Timo Sirainen Date: 2017-02-08 (Wed, 08 Feb 2017) Changed paths: M src/lib-storage/index/pop3c/pop3c-client.c Log Message: ----------- pop3c: Increase timeout for PASS to 5 minutes. From noreply at github.com Wed Feb 8 21:30:16 2017 From: noreply at github.com (GitHub) Date: Wed, 08 Feb 2017 13:30:16 -0800 Subject: [dovecot/core] 53a4f7: pop3c: Increase timeout for PASS to 5 minutes. Message-ID: <589b8de847f12_58883fd77458fc3813938@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 53a4f7fffc6de1a114b2aa165143b3e6db3a04bf https://github.com/dovecot/core/commit/53a4f7fffc6de1a114b2aa165143b3e6db3a04bf Author: Timo Sirainen Date: 2017-02-08 (Wed, 08 Feb 2017) Changed paths: M src/lib-storage/index/pop3c/pop3c-client.c Log Message: ----------- pop3c: Increase timeout for PASS to 5 minutes. From noreply at github.com Thu Feb 9 17:30:10 2017 From: noreply at github.com (GitHub) Date: Thu, 09 Feb 2017 09:30:10 -0800 Subject: [dovecot/core] ee92a5: TODO: Remove some of the implemented features Message-ID: <589ca722f3acb_5c983f7facd3fc3c70a7@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: ee92a55764fb94c9800114dac0b9689bca2f4a6e https://github.com/dovecot/core/commit/ee92a55764fb94c9800114dac0b9689bca2f4a6e Author: Timo Sirainen Date: 2017-02-09 (Thu, 09 Feb 2017) Changed paths: M TODO Log Message: ----------- TODO: Remove some of the implemented features From noreply at github.com Fri Feb 10 12:00:11 2017 From: noreply at github.com (GitHub) Date: Fri, 10 Feb 2017 04:00:11 -0800 Subject: [dovecot/core] ae9c5d: lib: Avoid unnecessary Coverity warnings in MALLOC... Message-ID: <589dab4bcb28d_6ad43f8afe2e9c309724e@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: ae9c5dd897013aa8a3cab4fb356718f9a2bf47f5 https://github.com/dovecot/core/commit/ae9c5dd897013aa8a3cab4fb356718f9a2bf47f5 Author: Timo Sirainen Date: 2017-02-10 (Fri, 10 Feb 2017) Changed paths: M src/lib/malloc-overflow.h Log Message: ----------- lib: Avoid unnecessary Coverity warnings in MALLOC_*() There doesn't seem to be any other nice way of avoiding these without separately marking every instance. From noreply at github.com Sun Feb 12 11:06:39 2017 From: noreply at github.com (GitHub) Date: Sun, 12 Feb 2017 03:06:39 -0800 Subject: [dovecot/pigeonhole] 34d44f: lib-sieve: file storage: Improve save permission e... Message-ID: <58a041bf42039_d813fa43018fc2c84135@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/pigeonhole Commit: 34d44f7ad9e872dec6ffa62de2642cb91ad5f6fc https://github.com/dovecot/pigeonhole/commit/34d44f7ad9e872dec6ffa62de2642cb91ad5f6fc Author: Stephan Bosch Date: 2017-02-12 (Sun, 12 Feb 2017) Changed paths: M src/lib-sieve/storage/file/sieve-file-storage-save.c Log Message: ----------- lib-sieve: file storage: Improve save permission error. Use eacces_error_get(), rather than just printing "Permission denied". From noreply at github.com Sun Feb 12 13:07:42 2017 From: noreply at github.com (GitHub) Date: Sun, 12 Feb 2017 05:07:42 -0800 Subject: [dovecot/pigeonhole] 014df5: imapsieve plugin: Make sure "INBOX" is upper case ... Message-ID: <58a05e1ec0c5_28e7f3fb8c2135c44660c5@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/pigeonhole Commit: 014df56e1efe7efbd39691b585fcd6360ac9ed9e https://github.com/dovecot/pigeonhole/commit/014df56e1efe7efbd39691b585fcd6360ac9ed9e Author: Stephan Bosch Date: 2017-02-12 (Sun, 12 Feb 2017) Changed paths: M src/plugins/imapsieve/imap-sieve-storage.c Log Message: ----------- imapsieve plugin: Make sure "INBOX" is upper case in static mailbox rules. Otherwise, the mailbox name would never match, since matching is performed case-sensitively and Dovecot only returns the upper-cased "INBOX". This change prevents confusing administrators that for some reason choose to use a different capitalization of that mailbox name. From noreply at github.com Sun Feb 12 16:37:27 2017 From: noreply at github.com (GitHub) Date: Sun, 12 Feb 2017 08:37:27 -0800 Subject: [dovecot/pigeonhole] 602326: lib-sieve: binary: Added means to obtain stat() in... Message-ID: <58a08f47866b1_10413ffac6599c409224d@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/pigeonhole Commit: 602326eeba22fea12cb4871f42cb6b8c37c3aa0f https://github.com/dovecot/pigeonhole/commit/602326eeba22fea12cb4871f42cb6b8c37c3aa0f Author: Stephan Bosch Date: 2017-02-12 (Sun, 12 Feb 2017) Changed paths: M src/lib-sieve/sieve-binary.c M src/lib-sieve/sieve-binary.h Log Message: ----------- lib-sieve: binary: Added means to obtain stat() information from loaded binary. Commit: 298b3410d4da910867487f96831e5f51e327da5d https://github.com/dovecot/pigeonhole/commit/298b3410d4da910867487f96831e5f51e327da5d Author: Stephan Bosch Date: 2017-02-12 (Sun, 12 Feb 2017) Changed paths: M src/lib-sieve/storage/file/sieve-file-script.c Log Message: ----------- lib-sieve: file storage: Amended the up-to-date timestamp comparison for on-disk binaries to include nanoseconds. This will fix problems occurring when both binary and script are saved within the same second. On older systems that have no support for nanoseconds in the stat() time stamps, this has no effect. Compare: https://github.com/dovecot/pigeonhole/compare/014df56e1efe...298b3410d4da From noreply at github.com Mon Feb 13 11:00:11 2017 From: noreply at github.com (GitHub) Date: Mon, 13 Feb 2017 03:00:11 -0800 Subject: [dovecot/core] 089624: doveadm director map: Fix checking if host paramet... Message-ID: <58a191bb7d424_20eb3fa7e14f1c3010742@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 0896246f4648151fe846215190ee92cefbcfb8b8 https://github.com/dovecot/core/commit/0896246f4648151fe846215190ee92cefbcfb8b8 Author: Timo Sirainen Date: 2017-02-10 (Fri, 10 Feb 2017) Changed paths: M src/doveadm/doveadm-director.c Log Message: ----------- doveadm director map: Fix checking if host parameter is required Commit: 66761ea6a8f00006f28743b4bd2f5339f78c10e0 https://github.com/dovecot/core/commit/66761ea6a8f00006f28743b4bd2f5339f78c10e0 Author: Timo Sirainen Date: 2017-02-10 (Fri, 10 Feb 2017) Changed paths: M src/lib-program-client/program-client.c Log Message: ----------- lib-program-client: Clarify dot_input/dot_output NULL checks. Helps to avoid static analyzer false positives about NULL pointer dereference. Commit: 52e31bbdd1080354b4f905b1cbaf8368e566b5e5 https://github.com/dovecot/core/commit/52e31bbdd1080354b4f905b1cbaf8368e566b5e5 Author: Timo Sirainen Date: 2017-02-10 (Fri, 10 Feb 2017) Changed paths: M src/plugins/mail-crypt/doveadm-mail-crypt.c Log Message: ----------- doveadm mailbox cryptokey generate: Fix memory leak dest_user was set to NULL, but never freed. Commit: 5202ed6f18f759b88f1e680eba1a7d0a07903e16 https://github.com/dovecot/core/commit/5202ed6f18f759b88f1e680eba1a7d0a07903e16 Author: Timo Sirainen Date: 2017-02-10 (Fri, 10 Feb 2017) Changed paths: M src/plugins/mail-crypt/doveadm-mail-crypt.c Log Message: ----------- doveadm mailbox cryptokey generate: Fix error handling Don't crash if mail_user creation failed. Commit: c1ab825edf003f5cfc6c31730442f36a17209101 https://github.com/dovecot/core/commit/c1ab825edf003f5cfc6c31730442f36a17209101 Author: Timo Sirainen Date: 2017-02-10 (Fri, 10 Feb 2017) Changed paths: M src/plugins/mail-crypt/mail-crypt-acl-plugin.c Log Message: ----------- mail-crypt-acl: Fix error handling Don't crash if mail_user creation failed. Commit: 4a48987ed0ba1632e90a50f2ba65393e07e9bcea https://github.com/dovecot/core/commit/4a48987ed0ba1632e90a50f2ba65393e07e9bcea Author: Timo Sirainen Date: 2017-02-10 (Fri, 10 Feb 2017) Changed paths: M src/doveadm/doveadm-mail-mailbox-metadata.c Log Message: ----------- doveadm mailbox metadata list: Fix listing all metadata. It was listing only private attributes, because key_type=0 happens to be MAIL_ATTRIBUTE_TYPE_PRIVATE and key was never NULL. Commit: 766ba3eed8b1c011a7a14c11cda6256ca2c25be4 https://github.com/dovecot/core/commit/766ba3eed8b1c011a7a14c11cda6256ca2c25be4 Author: Timo Sirainen Date: 2017-02-10 (Fri, 10 Feb 2017) Changed paths: M src/plugins/fts/fts-storage.c Log Message: ----------- fts: Fix crash using fts_autoexpunge_exclude = \Special-use crash It crashed whenever seeing a mailbox that didn't have any special-use flags. Commit: 7f51c1ad9118fa6860fd218aac3feee8e6ac6f0f https://github.com/dovecot/core/commit/7f51c1ad9118fa6860fd218aac3feee8e6ac6f0f Author: Timo Sirainen Date: 2017-02-10 (Fri, 10 Feb 2017) Changed paths: M src/plugins/mail-filter/istream-ext-filter.c Log Message: ----------- mail-filter: Handle handshake write() failure Commit: 963842c00ef1714db2855c8952f1b46d78cba1ca https://github.com/dovecot/core/commit/963842c00ef1714db2855c8952f1b46d78cba1ca Author: Timo Sirainen Date: 2017-02-10 (Fri, 10 Feb 2017) Changed paths: M src/imap-urlauth/imap-urlauth-worker.c M src/plugins/virtual/virtual-storage.c Log Message: ----------- global: Ignore unnecessary return values. Commit: fd013f9c6ab4485e7aa7609a26ae5163ecbb1d37 https://github.com/dovecot/core/commit/fd013f9c6ab4485e7aa7609a26ae5163ecbb1d37 Author: Timo Sirainen Date: 2017-02-10 (Fri, 10 Feb 2017) Changed paths: M src/pop3-login/client.c Log Message: ----------- pop3-login: Code cleanup - Make sure destroying client stops processing. It would currently do it in any case, but this makes it clearer. Commit: adea69875046ece77dc36abd3f88a241a3f17ad9 https://github.com/dovecot/core/commit/adea69875046ece77dc36abd3f88a241a3f17ad9 Author: Timo Sirainen Date: 2017-02-10 (Fri, 10 Feb 2017) Changed paths: M src/auth/db-ldap.c M src/doveadm/doveadm-mail-index.c M src/lib-auth/auth-master.c M src/lib-fs/fs-posix.c M src/lib-storage/index/mbox/mbox-save.c M src/lib-storage/mail-autoexpunge.c M src/lib/file-dotlock.c M src/lib/iostream-temp.c Log Message: ----------- global: Add asserts to make static analyzer happier. Commit: 4009eb0bbe343958c22772bc0be88d17ee1c33fe https://github.com/dovecot/core/commit/4009eb0bbe343958c22772bc0be88d17ee1c33fe Author: Timo Sirainen Date: 2017-02-13 (Mon, 13 Feb 2017) Changed paths: M src/plugins/quota/quota-private.h M src/plugins/quota/quota.c Log Message: ----------- quota: Remove quota_over_flag_* from quota_root. They are used only in one specific location and don't need to be stored permanently. Commit: b711a7fc74bb2d21e1e951d7ae2e8517c53bb24b https://github.com/dovecot/core/commit/b711a7fc74bb2d21e1e951d7ae2e8517c53bb24b Author: Timo Sirainen Date: 2017-02-13 (Mon, 13 Feb 2017) Changed paths: M src/plugins/quota/quota.c Log Message: ----------- quota: If quota_over_flag_value is unset, skip the quota_over check. Commit: 40edfbbb81b7a76cddac2b327ed547d4feeb5e88 https://github.com/dovecot/core/commit/40edfbbb81b7a76cddac2b327ed547d4feeb5e88 Author: Timo Sirainen Date: 2017-02-13 (Mon, 13 Feb 2017) Changed paths: M src/plugins/quota/quota.c Log Message: ----------- quota: If quota_over_script is unset, skip the quota_over check. Commit: bbe7af3946f071eaf3f81ac769dd1c735168b735 https://github.com/dovecot/core/commit/bbe7af3946f071eaf3f81ac769dd1c735168b735 Author: Timo Sirainen Date: 2017-02-13 (Mon, 13 Feb 2017) Changed paths: M src/plugins/quota/quota.c Log Message: ----------- quota: Log why quota_over_flag check is skipped if mail_debug=yes Compare: https://github.com/dovecot/core/compare/ae9c5dd89701...bbe7af3946f0 From noreply at github.com Mon Feb 13 14:30:10 2017 From: noreply at github.com (GitHub) Date: Mon, 13 Feb 2017 06:30:10 -0800 Subject: [dovecot/core] 9c7e81: lib-index: don't reset ioloop_time on mmap error Message-ID: <58a1c2f2cfd0b_1b873fb101cb3c381117f3@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 9c7e81a1f5e629efa2324c6c22ce02f6f6e9c792 https://github.com/dovecot/core/commit/9c7e81a1f5e629efa2324c6c22ce02f6f6e9c792 Author: Martti Rannanj?rvi Date: 2017-02-13 (Mon, 13 Feb 2017) Changed paths: M src/lib-index/mail-transaction-log-file.c Log Message: ----------- lib-index: don't reset ioloop_time on mmap error The variables seems to have been in the wrong order. Commit: 8e90ca575864d29d0ded6ea71cd9747aab0a38f4 https://github.com/dovecot/core/commit/8e90ca575864d29d0ded6ea71cd9747aab0a38f4 Author: Martti Rannanj?rvi Date: 2017-02-13 (Mon, 13 Feb 2017) Changed paths: M src/lib-index/mail-transaction-log-file.c Log Message: ----------- lib-index: clear file->mmap_size only after logging it Logging the error with size=0 loses information. Commit: 887c92aa9f171ab90e417de48ffa08d4909c809a https://github.com/dovecot/core/commit/887c92aa9f171ab90e417de48ffa08d4909c809a Author: Timo Sirainen Date: 2017-02-13 (Mon, 13 Feb 2017) Changed paths: M src/lib-http/http-client-request.c Log Message: ----------- lib-http: http_client_request_add_header() - Add key/value asserts These don't check that they're entirely correct as required by HTTP specifications. They're mainly there as a quick check that if the caller didn't validate the key/value in any way, we'll crash instead of creating a potential security hole. (Because with line feeds the attacker could add extra headers or even entirely new HTTP requests.) Compare: https://github.com/dovecot/core/compare/bbe7af3946f0...887c92aa9f17 From noreply at github.com Mon Feb 13 17:30:10 2017 From: noreply at github.com (GitHub) Date: Mon, 13 Feb 2017 09:30:10 -0800 Subject: [dovecot/core] d827cf: lib-compress: Fix assert-crash when .gz header siz... Message-ID: <58a1ed229c057_1fc23f96a00c5c3010072d@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: d827cffa4b59591ab2a5a710237e34839ed6a952 https://github.com/dovecot/core/commit/d827cffa4b59591ab2a5a710237e34839ed6a952 Author: Timo Sirainen Date: 2017-02-13 (Mon, 13 Feb 2017) Changed paths: M src/lib-compression/istream-zlib.c M src/lib-compression/test-compression.c Log Message: ----------- lib-compress: Fix assert-crash when .gz header size exceeds buffer max length Instead treat the stream as corrupted and return EINVAL. Fixes: Panic: file istream.c: line 182 (i_stream_read): assertion failed: (_stream->skip != _stream->pos) Commit: 3715e1d5cb8a85283ef9c88850a160791cb2499d https://github.com/dovecot/core/commit/3715e1d5cb8a85283ef9c88850a160791cb2499d Author: Timo Sirainen Date: 2017-02-13 (Mon, 13 Feb 2017) Changed paths: M src/lib-compression/istream-zlib.c Log Message: ----------- lib-compress: Fix missing .gz header error message Compare: https://github.com/dovecot/core/compare/887c92aa9f17...3715e1d5cb8a From noreply at github.com Mon Feb 13 18:00:09 2017 From: noreply at github.com (GitHub) Date: Mon, 13 Feb 2017 10:00:09 -0800 Subject: [dovecot/core] f9cf98: cassandra: Track query counts internally and inclu... Message-ID: <58a1f429cd8f6_1363fe670515c34103672@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f9cf9852b0338910f1a710297374943d66fea480 https://github.com/dovecot/core/commit/f9cf9852b0338910f1a710297374943d66fea480 Author: Timo Sirainen Date: 2017-02-13 (Mon, 13 Feb 2017) Changed paths: M src/lib-sql/driver-cassandra.c Log Message: ----------- cassandra: Track query counts internally and include them in metrics Commit: 945565e0c9cf979b5feeba6fbd4efce3bf4484ad https://github.com/dovecot/core/commit/945565e0c9cf979b5feeba6fbd4efce3bf4484ad Author: Timo Sirainen Date: 2017-02-13 (Mon, 13 Feb 2017) Changed paths: M src/lib-index/mail-index-sync-update.c M src/lib-index/mail-index-sync.c M src/lib-index/mail-index.h Log Message: ----------- lib-index: Add MAIL_INDEX_OPEN_FLAG_NO_DIRTY This way mailbox format backends that don't need dirty flags can use them for other purposes. Compare: https://github.com/dovecot/core/compare/3715e1d5cb8a...945565e0c9cf From noreply at github.com Mon Feb 13 18:30:09 2017 From: noreply at github.com (GitHub) Date: Mon, 13 Feb 2017 10:30:09 -0800 Subject: [dovecot/core] 07038d: driver-cassandra: Add support for speculative exec... Message-ID: <58a1fb318610c_1bd43fdd3a2c5c346027@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 07038d3a12a915e98f794566f56a0ed12e0653eb https://github.com/dovecot/core/commit/07038d3a12a915e98f794566f56a0ed12e0653eb Author: Aki Tuomi Date: 2017-02-13 (Mon, 13 Feb 2017) Changed paths: M m4/want_cassandra.m4 M src/lib-sql/driver-cassandra.c Log Message: ----------- driver-cassandra: Add support for speculative execution From noreply at github.com Mon Feb 13 21:00:09 2017 From: noreply at github.com (GitHub) Date: Mon, 13 Feb 2017 13:00:09 -0800 Subject: [dovecot/core] 0e9dc5: LAYOUT=index: Rename mailbox_list_index_node.corru... Message-ID: <58a21e5997d1a_148a3fa04f50dc30621d4@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 0e9dc599a312e1bd55ce2cb256535914a8295344 https://github.com/dovecot/core/commit/0e9dc599a312e1bd55ce2cb256535914a8295344 Author: Timo Sirainen Date: 2017-02-13 (Mon, 13 Feb 2017) Changed paths: M src/lib-storage/list/mailbox-list-index-sync.c M src/lib-storage/list/mailbox-list-index.c M src/lib-storage/list/mailbox-list-index.h Log Message: ----------- LAYOUT=index: Rename mailbox_list_index_node.corrupted_parent to corrupted_ext The code will be useful for other purposes also besides updating corrupted parents. Commit: d9cec8211f2620637d8b43de5e20719105eb0900 https://github.com/dovecot/core/commit/d9cec8211f2620637d8b43de5e20719105eb0900 Author: Timo Sirainen Date: 2017-02-13 (Mon, 13 Feb 2017) Changed paths: M src/lib-storage/list/mailbox-list-index.c Log Message: ----------- LAYOUT=index: Fix duplicate mailbox name renaming to actually work Compare: https://github.com/dovecot/core/compare/07038d3a12a9...d9cec8211f26 From noreply at github.com Tue Feb 14 08:00:11 2017 From: noreply at github.com (GitHub) Date: Tue, 14 Feb 2017 00:00:11 -0800 Subject: [dovecot/core] c26643: lib: Add pool_alloconly_create_clean() Message-ID: <58a2b90b94562_277d3fe82fc31c3c1124ed@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: c2664306fcea8bcaafd19a6d1b683ef0ad0ece91 https://github.com/dovecot/core/commit/c2664306fcea8bcaafd19a6d1b683ef0ad0ece91 Author: Timo Sirainen Date: 2017-02-13 (Mon, 13 Feb 2017) Changed paths: M src/lib/mempool-alloconly.c M src/lib/mempool.h Log Message: ----------- lib: Add pool_alloconly_create_clean() This partially reverts 2a2beae3a4c1e75b3aeff996781503138e6f24bc From noreply at github.com Tue Feb 14 09:30:10 2017 From: noreply at github.com (GitHub) Date: Tue, 14 Feb 2017 01:30:10 -0800 Subject: [dovecot/core] 833fd6: lib: Clarify *_strsplit_spaces() and add unit test Message-ID: <58a2ce2251f75_9633fa681db9c346419a@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 833fd67ffe6a1832d72b3d310e07345a42a7b6ab https://github.com/dovecot/core/commit/833fd67ffe6a1832d72b3d310e07345a42a7b6ab Author: Timo Sirainen Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M src/lib/strfuncs.h M src/lib/test-strfuncs.c Log Message: ----------- lib: Clarify *_strsplit_spaces() and add unit test From noreply at github.com Tue Feb 14 11:30:10 2017 From: noreply at github.com (GitHub) Date: Tue, 14 Feb 2017 03:30:10 -0800 Subject: [dovecot/core] 532bb6: mail-crypt: Do not restrict access in unit test Message-ID: <58a2ea42b0642_6513fa789a7bc30560ed@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 532bb6cdc2fc62ae39ed51a694528852c2da9e07 https://github.com/dovecot/core/commit/532bb6cdc2fc62ae39ed51a694528852c2da9e07 Author: Aki Tuomi Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M src/plugins/mail-crypt/test-mail-key.c Log Message: ----------- mail-crypt: Do not restrict access in unit test This works around problem with docker From noreply at github.com Tue Feb 14 12:00:10 2017 From: noreply at github.com (GitHub) Date: Tue, 14 Feb 2017 04:00:10 -0800 Subject: [dovecot/core] 7707c4: lib-index: zero mmap_length after logging error Message-ID: <58a2f14af0349_289493fbcdb10fc3450159@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 7707c4b35b868eda75b585c863d97726ff23f80f https://github.com/dovecot/core/commit/7707c4b35b868eda75b585c863d97726ff23f80f Author: Martti Rannanj?rvi Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M src/lib-index/mail-cache.c Log Message: ----------- lib-index: zero mmap_length after logging error Logging that mmap(size=0) failed looks suspicious. Commit: 9b08d9d9be3db241a92cc072feab21d1e0e24a58 https://github.com/dovecot/core/commit/9b08d9d9be3db241a92cc072feab21d1e0e24a58 Author: Timo Sirainen Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M src/lib-dict/dict-sql.c Log Message: ----------- dict-sql: Fix error handling in commit sql_dict_prev_inc_flush() or sql_dict_prev_set_flush() might set ctx->error, so they need to be done earlier. Compare: https://github.com/dovecot/core/compare/532bb6cdc2fc...9b08d9d9be3d From noreply at github.com Tue Feb 14 13:00:10 2017 From: noreply at github.com (GitHub) Date: Tue, 14 Feb 2017 05:00:10 -0800 Subject: [dovecot/core] 582893: lib-storage: Fix mailbox list index hook usage Message-ID: <58a2ff5ae4ef5_112b3fb83d48bc3411183d@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 58289301ce9f6aa7121891e33ef7e0a1b4559e8d https://github.com/dovecot/core/commit/58289301ce9f6aa7121891e33ef7e0a1b4559e8d Author: Timo Sirainen Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M src/lib-storage/list/mailbox-list-index-backend.c M src/lib-storage/list/mailbox-list-index-status.c M src/lib-storage/list/mailbox-list-index.c M src/lib-storage/list/mailbox-list-index.h Log Message: ----------- lib-storage: Fix mailbox list index hook usage The previous method appeared to work, but not if the internal hooks were used more than once. Commit: 897368f75a68f97e172ba76540759a10c557f1c3 https://github.com/dovecot/core/commit/897368f75a68f97e172ba76540759a10c557f1c3 Author: Timo Sirainen Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M src/lib-storage/index/index-transaction.c M src/lib-storage/mail-storage-private.h M src/lib-storage/mail-storage.c Log Message: ----------- lib-storage: Always create mail_save_context.dest_mail This allows removing similar mail_alloc() from storage backends and plugins that need it. As a side effect, this changes mbox code to always assign UIDs to saved mails. This shouldn't be much of a problem, since it happened practically always already. Commit: a825281071af96cc148e49c64ac36d8c5cf26f71 https://github.com/dovecot/core/commit/a825281071af96cc148e49c64ac36d8c5cf26f71 Author: Timo Sirainen Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M src/lib-storage/index/cydir/cydir-save.c M src/lib-storage/index/dbox-common/dbox-save.c M src/lib-storage/index/dbox-common/dbox-save.h M src/lib-storage/index/dbox-multi/mdbox-save.c M src/lib-storage/index/dbox-single/sdbox-copy.c M src/lib-storage/index/dbox-single/sdbox-save.c M src/lib-storage/index/imapc/imapc-save.c M src/lib-storage/index/index-mail.c M src/lib-storage/index/index-storage.c M src/lib-storage/index/maildir/maildir-save.c M src/lib-storage/index/mbox/mbox-save.c M src/lib-storage/index/mbox/mbox-sync-private.h M src/lib-storage/index/mbox/mbox-sync.c Log Message: ----------- lib-storage: Remove unnecessary mail_save_context.dest_mail==NULL checks It can never be NULL after the previous change: "lib-storage: Always create mail_save_context.dest_mail". The code removal in maildir_transaction_save_commit_pre() seemed potentially dangerous, but I don't think such code path is possible anymore. Also even if it is, it's probably fine since the mail_free() is called even earlier than before (although that itself might have been a problem). This also removes last traces of code that made it possible to save mails to mbox without assigning UID to the mail. The previous commit already caused this, so this is just removing dead code. Commit: 880f7a015f7dc2df2a06cec91dcecbbbe7e8dce3 https://github.com/dovecot/core/commit/880f7a015f7dc2df2a06cec91dcecbbbe7e8dce3 Author: Timo Sirainen Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M src/plugins/notify/notify-storage.c M src/plugins/quota/quota-storage.c M src/plugins/virtual/virtual-save.c M src/plugins/zlib/zlib-plugin.c Log Message: ----------- plugins: Remove unnecessary mail_save_context.dest_mail==NULL checks It can never be NULL after the previous change: "lib-storage: Always create mail_save_context.dest_mail". Commit: 8eba883232f80178b60fa416f73292bf5f990fec https://github.com/dovecot/core/commit/8eba883232f80178b60fa416f73292bf5f990fec Author: Timo Sirainen Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M src/plugins/virtual/virtual-mail.c M src/plugins/virtual/virtual-save.c M src/plugins/virtual/virtual-storage.h Log Message: ----------- virtual: Fix saving to a virtual mailbox to work again Previous changes broke it. Commit: 5f1f92d6f32dfe2cf04fac1d42c42a52aeff335b https://github.com/dovecot/core/commit/5f1f92d6f32dfe2cf04fac1d42c42a52aeff335b Author: Timo Sirainen Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c M src/lib-lda/mail-deliver.h Log Message: ----------- lib-lda: Remove unused mail_deliver_get_log_var_expand_table() Commit: df71146c7f68895abd435857a88d596dc52f8001 https://github.com/dovecot/core/commit/df71146c7f68895abd435857a88d596dc52f8001 Author: Timo Sirainen Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M src/lib-storage/mail-storage.c M src/lib-storage/mail-storage.h Log Message: ----------- lib-storage: Add mailbox_save_get_dest_mail() This marks mailbox_save_set_dest_mail deprecated. It's not efficient to use since it frees the already-created dest_mail. Commit: 4f210e191c869c71db13c5871f95d883c312b1f2 https://github.com/dovecot/core/commit/4f210e191c869c71db13c5871f95d883c312b1f2 Author: Timo Sirainen Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Avoid using mailbox_save_set_dest_mail() Commit: 12e28ffc2655b6d0efce628eb7d93fa74fbd345b https://github.com/dovecot/core/commit/12e28ffc2655b6d0efce628eb7d93fa74fbd345b Author: Timo Sirainen Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c M src/lib-lda/mail-deliver.h Log Message: ----------- lib-lda: Redesign mail_deliver_context.var_expand_table cache Commit: 796d1ca5e01126f1328ac4cdec0c23491d0e3f10 https://github.com/dovecot/core/commit/796d1ca5e01126f1328ac4cdec0c23491d0e3f10 Author: Timo Sirainen Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Remove %{storage_id} setting for now. It doesn't work with Sieve. The following patches add it back properly. Commit: a9791113953195d1ed52d9b5bf63f1869758742d https://github.com/dovecot/core/commit/a9791113953195d1ed52d9b5bf63f1869758742d Author: Timo Sirainen Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Code cleanup - mail_deliver_open_mail() now uses uid parameter Commit: eed56fe22f1fc61f2003d5e66373d03dacbc9aaa https://github.com/dovecot/core/commit/eed56fe22f1fc61f2003d5e66373d03dacbc9aaa Author: Timo Sirainen Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M src/lda/main.c M src/lib-lda/Makefile.am M src/lib-lda/mail-deliver.c M src/lib-lda/mail-deliver.h M src/lmtp/main.c Log Message: ----------- lib-lda: Fix deliver_log_format variables with Sieve With Sieve it was using src_mail for getting the values, which weren't correct especially if Sieve had modified the mail. Commit: b3523787a7c3b9e82fd9dfe9d1b4687a3b0000b0 https://github.com/dovecot/core/commit/b3523787a7c3b9e82fd9dfe9d1b4687a3b0000b0 Author: Timo Sirainen Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Implement %{storage_id} correctly Compare: https://github.com/dovecot/core/compare/9b08d9d9be3d...b3523787a7c3 From noreply at github.com Tue Feb 14 13:33:26 2017 From: noreply at github.com (GitHub) Date: Tue, 14 Feb 2017 05:33:26 -0800 Subject: [dovecot/pigeonhole] 85c9de: imapsieve: Remove unnecessary mail_save_context.de... Message-ID: <58a30726957f_14523f91c1af9c306273f@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/pigeonhole Commit: 85c9de0006971ca3770c3fc73cb41bfbf8c1716c https://github.com/dovecot/pigeonhole/commit/85c9de0006971ca3770c3fc73cb41bfbf8c1716c Author: Timo Sirainen Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M src/plugins/imapsieve/imap-sieve-storage.c Log Message: ----------- imapsieve: Remove unnecessary mail_save_context.dest_mail==NULL checks It can never be NULL after the "lib-storage: Always create mail_save_context.dest_mail" core change. Commit: a1dbf7a92a7efea74305f54c61245c95afa6f00e https://github.com/dovecot/pigeonhole/commit/a1dbf7a92a7efea74305f54c61245c95afa6f00e Author: Timo Sirainen Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M src/lib-sieve/sieve-actions.c M src/lib-sieve/sieve-actions.h Log Message: ----------- lib-sieve: Remove unnecessary mailbox_save_set_dest_mail() call Compare: https://github.com/dovecot/pigeonhole/compare/298b3410d4da...a1dbf7a92a7e From noreply at github.com Tue Feb 14 18:30:10 2017 From: noreply at github.com (GitHub) Date: Tue, 14 Feb 2017 10:30:10 -0800 Subject: [dovecot/core] 04ca05: lib-lda: Don't set mail_deliver_context.dest_mail ... Message-ID: <58a34cb2a417d_190f3fd275e5bc301327d@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 04ca05320ecb84008aa1886e27020a4423b246c0 https://github.com/dovecot/core/commit/04ca05320ecb84008aa1886e27020a4423b246c0 Author: Timo Sirainen Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Don't set mail_deliver_context.dest_mail too early. It must be NULL for the caller, unless save_dest_mail==TRUE Commit: 2a494f93f48424d391552a419ad8872fbc771eb5 https://github.com/dovecot/core/commit/2a494f93f48424d391552a419ad8872fbc771eb5 Author: Timo Sirainen Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Code cleanup - remove unnecessary dest_mail check Compare: https://github.com/dovecot/core/compare/b3523787a7c3...2a494f93f484 From noreply at github.com Wed Feb 15 07:30:10 2017 From: noreply at github.com (GitHub) Date: Tue, 14 Feb 2017 23:30:10 -0800 Subject: [dovecot/core] 209d29: doveadm: Added "mailbox path" command Message-ID: <58a4038243fe9_15883f8520b63c3c120241@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 209d29ccf7550b0731147c53a0419749270fc501 https://github.com/dovecot/core/commit/209d29ccf7550b0731147c53a0419749270fc501 Author: Timo Sirainen Date: 2017-02-15 (Wed, 15 Feb 2017) Changed paths: M src/doveadm/doveadm-mail-mailbox.c M src/doveadm/doveadm-mail.c M src/doveadm/doveadm-mail.h Log Message: ----------- doveadm: Added "mailbox path" command This allows easily printing a path for a mailbox, index, control dir, etc. From noreply at github.com Wed Feb 15 08:00:12 2017 From: noreply at github.com (GitHub) Date: Wed, 15 Feb 2017 00:00:12 -0800 Subject: [dovecot/core] 201ce6: lib-mail: Fix duplicate HEADER_FILTER_ADD_MISSING_... Message-ID: <58a40a8c1b910_17593f89136f3c3c141079@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 201ce62e1dc315e5dd5e59c24660ed0946343bbb https://github.com/dovecot/core/commit/201ce62e1dc315e5dd5e59c24660ed0946343bbb Author: Timo Sirainen Date: 2017-02-15 (Wed, 15 Feb 2017) Changed paths: M src/lib-mail/istream-header-filter.c M src/lib-mail/test-istream-header-filter.c Log Message: ----------- lib-mail: Fix duplicate HEADER_FILTER_ADD_MISSING_EOH callback call If headers weren't modified, the second reading of the istream shouldn't call any callbacks. From noreply at github.com Wed Feb 15 12:30:10 2017 From: noreply at github.com (GitHub) Date: Wed, 15 Feb 2017 04:30:10 -0800 Subject: [dovecot/core] 8b223f: lib-http: message parser: Don't create the connect... Message-ID: <58a449d258b7_13603f885ecabc3441848@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 8b223f08b8ab40fd4e6a65542aac9ab6afc6839d https://github.com/dovecot/core/commit/8b223f08b8ab40fd4e6a65542aac9ab6afc6839d Author: Stephan Bosch Date: 2017-02-15 (Wed, 15 Feb 2017) Changed paths: M src/lib-http/http-message-parser.c M src/lib-http/http-request.c Log Message: ----------- lib-http: message parser: Don't create the connection_options array, unless it is actually used. Commit: b04dfad6b03e3809ccbca7f504ba44c6ab7dfad5 https://github.com/dovecot/core/commit/b04dfad6b03e3809ccbca7f504ba44c6ab7dfad5 Author: Stephan Bosch Date: 2017-02-15 (Wed, 15 Feb 2017) Changed paths: M src/lib-http/http-message-parser.c Log Message: ----------- lib-http: message parser: Delay allocation of message header. Commit: 1ec26e0b70ac7f8a4e3dfbc59aa77f572651d5ae https://github.com/dovecot/core/commit/1ec26e0b70ac7f8a4e3dfbc59aa77f572651d5ae Author: Stephan Bosch Date: 2017-02-15 (Wed, 15 Feb 2017) Changed paths: M src/lib-http/http-message-parser.c M src/lib-http/http-message-parser.h M src/lib-http/http-request-parser.c M src/lib-http/http-response-parser.c Log Message: ----------- lib-http: message parser: Don't allocate a pool for the next message until it is needed. This prevents wasting memory when no message is being parsed. Commit: 5a7107476ff29592bcbf736d8a1ebb196a5c5726 https://github.com/dovecot/core/commit/5a7107476ff29592bcbf736d8a1ebb196a5c5726 Author: Stephan Bosch Date: 2017-02-15 (Wed, 15 Feb 2017) Changed paths: M src/lib-http/test-http-response-parser.c Log Message: ----------- lib-http: test-http-response-parse: Properly test multiple sequential responses. Commit: 88ead42eefcad4af0313f55275de196f96e8f002 https://github.com/dovecot/core/commit/88ead42eefcad4af0313f55275de196f96e8f002 Author: Stephan Bosch Date: 2017-02-15 (Wed, 15 Feb 2017) Changed paths: M src/lib-http/http-response-parser.c Log Message: ----------- lib-http: response parser: Always clear response to prevent referring to stale data. Commit: c177bc7c153dd4d00dfa719f8a93c81129c4235e https://github.com/dovecot/core/commit/c177bc7c153dd4d00dfa719f8a93c81129c4235e Author: Stephan Bosch Date: 2017-02-15 (Wed, 15 Feb 2017) Changed paths: M src/lib-http/http-response-parser.c Log Message: ----------- lib-http: response parser: Drop previous response's pool immediately when parsing continues. Prevously, it would only do that when the first byte of the next response was received. This prevents wasting memory when no response is being parsed. Compare: https://github.com/dovecot/core/compare/201ce62e1dc3...c177bc7c153d From noreply at github.com Wed Feb 15 15:30:12 2017 From: noreply at github.com (GitHub) Date: Wed, 15 Feb 2017 07:30:12 -0800 Subject: [dovecot/core] adb27e: lib-imap-client: centralize authentication failed ... Message-ID: <58a4740446a43_108e3f843992bc2c1085eb@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: adb27e42fb81b32ecb37193a3ce443181172ee99 https://github.com/dovecot/core/commit/adb27e42fb81b32ecb37193a3ce443181172ee99 Author: Josef 'Jeff' Sipek Date: 2017-02-15 (Wed, 15 Feb 2017) Changed paths: M src/lib-imap-client/imapc-connection.c M src/lib-storage/index/imapc/imapc-storage.c Log Message: ----------- lib-imap-client: centralize authentication failed error logging Commit: e883e4406713e4cd6a3c98029cee00c537415f17 https://github.com/dovecot/core/commit/e883e4406713e4cd6a3c98029cee00c537415f17 Author: Josef 'Jeff' Sipek Date: 2017-02-15 (Wed, 15 Feb 2017) Changed paths: M src/lib-imap-client/imapc-client-private.h M src/lib-imap-client/imapc-client.c M src/lib-imap-client/imapc-client.h M src/lib-imap-client/imapc-connection.c Log Message: ----------- lib-imap-client: add callback to notify consumers about state changes Add a callback to notify imapc users about failures. Currently, the only failure defined is "authentication failed". Commit: 7d8fe66fbc53ab28d4e06492ca5a897743c0ee9c https://github.com/dovecot/core/commit/7d8fe66fbc53ab28d4e06492ca5a897743c0ee9c Author: Josef 'Jeff' Sipek Date: 2017-02-15 (Wed, 15 Feb 2017) Changed paths: M src/lib-imap-client/imapc-client.h M src/lib-imap-client/imapc-connection.c Log Message: ----------- lib-imap-client: invoke state change callback on "authentication success" Compare: https://github.com/dovecot/core/compare/c177bc7c153d...7d8fe66fbc53 From noreply at github.com Wed Feb 15 19:30:11 2017 From: noreply at github.com (GitHub) Date: Wed, 15 Feb 2017 11:30:11 -0800 Subject: [dovecot/core] 65148a: lib-imap-client: pass the reply text to the auth-f... Message-ID: <58a4ac43788c_1ff83f9336f71c249768c@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 65148af5184cf08d854f539c28cf61d646f77d3a https://github.com/dovecot/core/commit/65148af5184cf08d854f539c28cf61d646f77d3a Author: Josef 'Jeff' Sipek Date: 2017-02-15 (Wed, 15 Feb 2017) Changed paths: M src/lib-imap-client/imapc-connection.c Log Message: ----------- lib-imap-client: pass the reply text to the auth-failed state change callback From noreply at github.com Wed Feb 15 20:37:26 2017 From: noreply at github.com (GitHub) Date: Wed, 15 Feb 2017 12:37:26 -0800 Subject: [dovecot/pigeonhole] 6dd99d: lib-sieve: file storage: Improve listing permissio... Message-ID: <58a4bc06bfc2b_10413ffac6599c4014069c@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-0.4 Home: https://github.com/dovecot/pigeonhole Commit: 6dd99df9a3af1e2b3e13d38f8dbcce840773160e https://github.com/dovecot/pigeonhole/commit/6dd99df9a3af1e2b3e13d38f8dbcce840773160e Author: Stephan Bosch Date: 2017-02-15 (Wed, 15 Feb 2017) Changed paths: M src/lib-sieve/storage/file/sieve-file-storage-list.c Log Message: ----------- lib-sieve: file storage: Improve listing permission error. Use eacces_error_get(), rather than just printing "Permission denied". Commit: f64de45c76dbe3f00309e1929cddcd806868a958 https://github.com/dovecot/pigeonhole/commit/f64de45c76dbe3f00309e1929cddcd806868a958 Author: Stephan Bosch Date: 2017-02-15 (Wed, 15 Feb 2017) Changed paths: M src/lib-sieve/storage/file/sieve-file-storage-save.c Log Message: ----------- lib-sieve: file storage: Improve save permission error. Use eacces_error_get(), rather than just printing "Permission denied". Commit: 9f7bbf7811fa885d95d793c3ad17056b68bdfc25 https://github.com/dovecot/pigeonhole/commit/9f7bbf7811fa885d95d793c3ad17056b68bdfc25 Author: Stephan Bosch Date: 2017-02-15 (Wed, 15 Feb 2017) Changed paths: M src/plugins/imapsieve/imap-sieve-storage.c Log Message: ----------- imapsieve plugin: Make sure "INBOX" is upper case in static mailbox rules. Otherwise, the mailbox name would never match, since matching is performed case-sensitively and Dovecot only returns the upper-cased "INBOX". This change prevents confusing administrators that for some reason choose to use a different capitalization of that mailbox name. Commit: 4f513558ddab04bcad66091c12838bbdebdd9f91 https://github.com/dovecot/pigeonhole/commit/4f513558ddab04bcad66091c12838bbdebdd9f91 Author: Stephan Bosch Date: 2017-02-15 (Wed, 15 Feb 2017) Changed paths: M src/lib-sieve/sieve-binary.c M src/lib-sieve/sieve-binary.h Log Message: ----------- lib-sieve: binary: Added means to obtain stat() information from loaded binary. Commit: 356dcd4988374ae36aef6bb1f957b9a813c1baf3 https://github.com/dovecot/pigeonhole/commit/356dcd4988374ae36aef6bb1f957b9a813c1baf3 Author: Stephan Bosch Date: 2017-02-15 (Wed, 15 Feb 2017) Changed paths: M src/lib-sieve/storage/file/sieve-file-script.c Log Message: ----------- lib-sieve: file storage: Amended the up-to-date timestamp comparison for on-disk binaries to include nanoseconds. This will fix problems occurring when both binary and script are saved within the same second. On older systems that have no support for nanoseconds in the stat() time stamps, this has no effect. Compare: https://github.com/dovecot/pigeonhole/compare/d0f4804d8789...356dcd498837 From noreply at github.com Thu Feb 16 07:30:11 2017 From: noreply at github.com (GitHub) Date: Wed, 15 Feb 2017 23:30:11 -0800 Subject: [dovecot/core] 86448b: mail-log: Add mail_log_cached_only setting. Message-ID: <58a555038e3c5_1c023ff45bcb1c38194780@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 86448bdb60ed69566bc1093dda824133448ed7a0 https://github.com/dovecot/core/commit/86448bdb60ed69566bc1093dda824133448ed7a0 Author: Timo Sirainen Date: 2017-02-15 (Wed, 15 Feb 2017) Changed paths: M src/plugins/mail-log/mail-log-plugin.c Log Message: ----------- mail-log: Add mail_log_cached_only setting. If enabled, everything except "save" event will log only the fields that can be looked up from cache. This improves performance if some of the fields aren't cached and it's not a strict requirement to log them. From noreply at github.com Thu Feb 16 12:00:09 2017 From: noreply at github.com (GitHub) Date: Thu, 16 Feb 2017 04:00:09 -0800 Subject: [dovecot/core] 3857e2: lib-storage: Make sure mailbox undeletion won't go... Message-ID: <58a59449a85f8_115f3ff101727c34139211@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 3857e2945a3b6744d603f0f5a656849ed8436ba3 https://github.com/dovecot/core/commit/3857e2945a3b6744d603f0f5a656849ed8436ba3 Author: Timo Sirainen Date: 2017-02-16 (Thu, 16 Feb 2017) Changed paths: M src/lib-storage/mail-storage-private.h M src/lib-storage/mail-storage.c Log Message: ----------- lib-storage: Make sure mailbox undeletion won't go to infinite loop Commit: 0b8282724fc88edd747c2d3a7bfec7dee64decdb https://github.com/dovecot/core/commit/0b8282724fc88edd747c2d3a7bfec7dee64decdb Author: Timo Sirainen Date: 2017-02-16 (Thu, 16 Feb 2017) Changed paths: M src/lib-storage/mail-storage.c Log Message: ----------- lib-storage: Don't sync mailbox after undeleting it. This is useful only when deleting it. With undeletion the syncing isn't useful and might actually be harmful with mailbox formats that didn't fully open the mailbox while it was undeleted. Commit: bb9065b1c34dafe68382f1f1d0d951e12a411c2d https://github.com/dovecot/core/commit/bb9065b1c34dafe68382f1f1d0d951e12a411c2d Author: Timo Sirainen Date: 2017-02-16 (Thu, 16 Feb 2017) Changed paths: M src/lib-storage/mail-storage.c Log Message: ----------- lib-storage: Re-open mailbox after it's undeleted. This is needed with mailbox formats that didn't fully open the mailbox while it was undeleted. Commit: d97f939b1c09e9f90b01b6f81bfb1c05da990148 https://github.com/dovecot/core/commit/d97f939b1c09e9f90b01b6f81bfb1c05da990148 Author: Timo Sirainen Date: 2017-02-16 (Thu, 16 Feb 2017) Changed paths: M src/lib-index/mail-index-transaction-finish.c M src/lib-index/mail-index-transaction-private.h M src/lib-index/mail-index-transaction-update.c M src/lib-index/test-mail-index-transaction-finish.c Log Message: ----------- lib-index: Add day_stamp parameter to mail_index_update_day_headers() This will help creating a unit test. Commit: dfa4b048ec9a174a42d6668e94501db2fb70793a https://github.com/dovecot/core/commit/dfa4b048ec9a174a42d6668e94501db2fb70793a Author: Timo Sirainen Date: 2017-02-16 (Thu, 16 Feb 2017) Changed paths: M src/lib-index/mail-index-transaction-update.c M src/lib-index/test-mail-index-transaction-update.c Log Message: ----------- lib-index: Fix updating mail_index_header.day_first_uid If user received a mail every day, the day_first_uid wasn't being updated. This caused wrong caching decisions to be made in dovecot.index.cache: - Accessing >1 week old emails should have changed caching decision from "tmp" to "yes". This might not have happened, although as long as day_first_uid[7] pointed to an existing mail and email client accessed all the mails, this wouldn't have changed anything. - Cache compression is supposed to drop >1 week old mails when caching decision is "tmp". Not enough mails were being dropped because day_first_uid[7] pointed to a much older than 1 week old mails. Also added a unit test to make sure this works. Broken by d9ee2f9fb3ef7b9391bfeeff1b374aead51667aa Compare: https://github.com/dovecot/core/compare/86448bdb60ed...dfa4b048ec9a From noreply at github.com Thu Feb 16 14:30:14 2017 From: noreply at github.com (GitHub) Date: Thu, 16 Feb 2017 06:30:14 -0800 Subject: [dovecot/core] 60c302: lib-oauth2: Add support library for OAUTH2 Message-ID: <58a5b7763f74c_1e9d3fc3fbb0dc3c1889a8@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 60c302a89ea286f0f2afff37c6e2d6649841d85f https://github.com/dovecot/core/commit/60c302a89ea286f0f2afff37c6e2d6649841d85f Author: Aki Tuomi Date: 2017-02-16 (Thu, 16 Feb 2017) Changed paths: M configure.ac M src/Makefile.am A src/lib-oauth2/Makefile.am A src/lib-oauth2/oauth2-introspect.c A src/lib-oauth2/oauth2-private.h A src/lib-oauth2/oauth2-refresh.c A src/lib-oauth2/oauth2-token-validate.c A src/lib-oauth2/oauth2.c A src/lib-oauth2/oauth2.h Log Message: ----------- lib-oauth2: Add support library for OAUTH2 Commit: edb35cb1acb3d270e32fc731c0573323da041f2c https://github.com/dovecot/core/commit/edb35cb1acb3d270e32fc731c0573323da041f2c Author: Aki Tuomi Date: 2017-02-16 (Thu, 16 Feb 2017) Changed paths: M src/auth/passdb-template.c M src/auth/passdb-template.h Log Message: ----------- auth: Add accessor for passdb template arguments Commit: 10f6f2224c897fc543973efd2f46b86a3ab1148d https://github.com/dovecot/core/commit/10f6f2224c897fc543973efd2f46b86a3ab1148d Author: Aki Tuomi Date: 2017-02-16 (Thu, 16 Feb 2017) Changed paths: M src/auth/auth-request.c M src/auth/auth-settings.c M src/auth/auth-settings.h M src/auth/passdb.c M src/auth/passdb.h Log Message: ----------- auth: Add mechanism filter for passdbs Commit: d1c565179ff8b17fe9ff21a3f1cb2f9c4d4f5836 https://github.com/dovecot/core/commit/d1c565179ff8b17fe9ff21a3f1cb2f9c4d4f5836 Author: Aki Tuomi Date: 2017-02-16 (Thu, 16 Feb 2017) Changed paths: M src/auth/Makefile.am A src/auth/mech-oauth2.c M src/auth/mech.c Log Message: ----------- auth: Add xoauth2 and oauthbearer mechanisms Commit: 9b670175445a75987a713ff899d1a945255b0b5b https://github.com/dovecot/core/commit/9b670175445a75987a713ff899d1a945255b0b5b Author: Aki Tuomi Date: 2017-02-16 (Thu, 16 Feb 2017) Changed paths: M src/auth/Makefile.am A src/auth/db-oauth2.c A src/auth/db-oauth2.h A src/auth/passdb-oauth2.c M src/auth/passdb.c Log Message: ----------- auth: Add oauth2 passdb Commit: 98d09d4454e93a202b8e2272e932b05b29e18028 https://github.com/dovecot/core/commit/98d09d4454e93a202b8e2272e932b05b29e18028 Author: Aki Tuomi Date: 2017-02-16 (Thu, 16 Feb 2017) Changed paths: M README.md Log Message: ----------- README: Add note that we support OAUTHBEARER and XOAUTH2 Compare: https://github.com/dovecot/core/compare/dfa4b048ec9a...98d09d4454e9 From noreply at github.com Thu Feb 16 15:30:10 2017 From: noreply at github.com (GitHub) Date: Thu, 16 Feb 2017 07:30:10 -0800 Subject: [dovecot/core] abc063: lib-storage: Don't stop vsize calculation on expun... Message-ID: <58a5c582ba793_64f3fc2fa70bc30166720@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: abc063522f0285b2fc5128f26f4e2e5172a00e5c https://github.com/dovecot/core/commit/abc063522f0285b2fc5128f26f4e2e5172a00e5c Author: Timo Sirainen Date: 2017-02-16 (Thu, 16 Feb 2017) Changed paths: M src/lib-storage/index/index-mailbox-size.c Log Message: ----------- lib-storage: Don't stop vsize calculation on expunged mails. I don't know why I added such logic there in the first place. If we just skip the expunged mails, the end result should still be correct and usable when cached. Commit: a758be690d736655ed7c1e3dfb46d3aaf4dd5db2 https://github.com/dovecot/core/commit/a758be690d736655ed7c1e3dfb46d3aaf4dd5db2 Author: Timo Sirainen Date: 2017-02-16 (Thu, 16 Feb 2017) Changed paths: M src/lib-storage/index/index-mailbox-size.c M src/lib-storage/mail-storage-settings.c M src/lib-storage/mail-storage-settings.h M src/plugins/quota/quota-count.c Log Message: ----------- lib-storage: Add mail_vsize_bg_after_count setting. If folder vsize calculation requires opening more than this many mails from disk (i.e. mail sizes aren't in cache already), return failure and finish the calculation via indexer process. This should be used like: protocol !indexer-worker { mail_vsize_bg_after_count = 10 } Commit: abd812f275c5366feea20f25081d1c9296e552ef https://github.com/dovecot/core/commit/abd812f275c5366feea20f25081d1c9296e552ef Author: Timo Sirainen Date: 2017-02-16 (Thu, 16 Feb 2017) Changed paths: M src/lib-storage/index/index-mailbox-size.c Log Message: ----------- lib-storage: Update vsize header after sync only if sizes are cached. The result isn't needed yet in that case, so if it's slow to get the sizes it might as well be delayd until later. This is especially useful when indexer-worker triggers FTS indexing. The vsizes can be added to index after the mail is already read for FTS. Without this change the vsize update would first open all the mails and then the FTS indexing would open all the mails a second time. Compare: https://github.com/dovecot/core/compare/98d09d4454e9...abd812f275c5 From noreply at github.com Fri Feb 17 10:00:17 2017 From: noreply at github.com (GitHub) Date: Fri, 17 Feb 2017 02:00:17 -0800 Subject: [dovecot/core] d1c780: fts-solr: Allow username/password for solr conncti... Message-ID: <58a6c9b1c5a13_1e1f3fc796027c341509f3@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: d1c780493d52ea00588a08fdc41179f56c725122 https://github.com/dovecot/core/commit/d1c780493d52ea00588a08fdc41179f56c725122 Author: J. Nick Koston Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/plugins/fts-solr/solr-connection.c Log Message: ----------- fts-solr: Allow username/password for solr connction Solr comes open to the world by default. For better security, we protect our solr installs with a user and password. This change allows dovecot to connect to these instances. Example usage in a fts.conf (permissions 0600) fts_solr = url=http://nick:pass at 127.0.0.1:8983/solr/dovecot/ Commit: 01672205411fc802f2e9436459706afc71dc2dd7 https://github.com/dovecot/core/commit/01672205411fc802f2e9436459706afc71dc2dd7 Author: johnkwoods Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-ldap/ldap-compare.c Log Message: ----------- lib-ldap: Remove extra return The ldap_connection_queue_request() function returns void. Trying to "return" something from a void function caused compiling issues on Solaris (Oracle Developer Studio 12.5). Commit: 77643f9f68929c7225c659227c24080e25292519 https://github.com/dovecot/core/commit/77643f9f68929c7225c659227c24080e25292519 Author: Stephan Bosch Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-storage/mail-user.c M src/lib-storage/mail-user.h Log Message: ----------- lib-storage: Added mail_user_init_ssl_client_settings(). Commit: 1cf6991dfb4fe2f3301782bddc337a76b187ed1e https://github.com/dovecot/core/commit/1cf6991dfb4fe2f3301782bddc337a76b187ed1e Author: Aki Tuomi Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib/connection.c Log Message: ----------- lib: Check that output max size is non-zero when version specified Otherwise we try to send version to non-existent output stream. Commit: 1e2f5bf8c2d2ec575f34ab72b6237b61dc2ab8f4 https://github.com/dovecot/core/commit/1e2f5bf8c2d2ec575f34ab72b6237b61dc2ab8f4 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/plugins/quota/quota-private.h M src/plugins/quota/quota-util.c M src/plugins/quota/quota.c Log Message: ----------- quota: When executing quota_warning/over_flag script, log the reason why. Commit: a3eb84689201b94d2c42ba3e28c30a735b6ec5c7 https://github.com/dovecot/core/commit/a3eb84689201b94d2c42ba3e28c30a735b6ec5c7 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/plugins/quota/quota.c Log Message: ----------- quota: Make sure quota_warning doesn't wrap "quota before" value. This could happen in some race conditions (and with bugs). Commit: aabb256a43c1a2c882c4871d0d140254e2b386cd https://github.com/dovecot/core/commit/aabb256a43c1a2c882c4871d0d140254e2b386cd Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/plugins/quota/quota-count.c M src/plugins/quota/quota-private.h Log Message: ----------- quota: Clarify quota_count() return value. Commit: df745bdb6559f10e9501ecd998e3e3f56b780359 https://github.com/dovecot/core/commit/df745bdb6559f10e9501ecd998e3e3f56b780359 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-storage/index/dbox-single/sdbox-storage.c Log Message: ----------- sdbox: Fix assert-crash on mailbox create race If another process created the mailbox at the same time, the mailbox_guid wasn't set and opening the mailbox assert-crashed: Panic: file mail-storage.c: line 1744 (mailbox_get_metadata): assertion failed: ((items & MAILBOX_METADATA_GUID) == 0 || !guid_128_is_empty(metadata_r->guid)) Commit: d3d515c933b09d3748426d684d35f85b65993d1a https://github.com/dovecot/core/commit/d3d515c933b09d3748426d684d35f85b65993d1a Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M TODO Log Message: ----------- TODO: Remove some of the implemented features Commit: 87c56d07369961411a9a5e448c2c4ee32e5697b5 https://github.com/dovecot/core/commit/87c56d07369961411a9a5e448c2c4ee32e5697b5 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib/malloc-overflow.h Log Message: ----------- lib: Avoid unnecessary Coverity warnings in MALLOC_*() There doesn't seem to be any other nice way of avoiding these without separately marking every instance. Commit: 2b467064287358345299be8609990f44725045b6 https://github.com/dovecot/core/commit/2b467064287358345299be8609990f44725045b6 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/doveadm/doveadm-director.c Log Message: ----------- doveadm director map: Fix checking if host parameter is required Commit: 247f01bdadd3a0bbc2e42793aedb39a51df11916 https://github.com/dovecot/core/commit/247f01bdadd3a0bbc2e42793aedb39a51df11916 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/plugins/mail-crypt/doveadm-mail-crypt.c Log Message: ----------- doveadm mailbox cryptokey generate: Fix memory leak dest_user was set to NULL, but never freed. Commit: 3a42316eeebc50ee4b42324cbfbf7c7d48ef46cb https://github.com/dovecot/core/commit/3a42316eeebc50ee4b42324cbfbf7c7d48ef46cb Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/plugins/mail-crypt/doveadm-mail-crypt.c Log Message: ----------- doveadm mailbox cryptokey generate: Fix error handling Don't crash if mail_user creation failed. Commit: a21568964277635bf8cea8416edec9b613e12160 https://github.com/dovecot/core/commit/a21568964277635bf8cea8416edec9b613e12160 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/plugins/mail-crypt/mail-crypt-acl-plugin.c Log Message: ----------- mail-crypt-acl: Fix error handling Don't crash if mail_user creation failed. Commit: b2a28aee65bc206b0103ea963c362b24464320a3 https://github.com/dovecot/core/commit/b2a28aee65bc206b0103ea963c362b24464320a3 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/doveadm/doveadm-mail-mailbox-metadata.c Log Message: ----------- doveadm mailbox metadata list: Fix listing all metadata. It was listing only private attributes, because key_type=0 happens to be MAIL_ATTRIBUTE_TYPE_PRIVATE and key was never NULL. Commit: edeae7ffe695a056ff5d6ed05a46a654708a7f53 https://github.com/dovecot/core/commit/edeae7ffe695a056ff5d6ed05a46a654708a7f53 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/plugins/fts/fts-storage.c Log Message: ----------- fts: Fix crash using fts_autoexpunge_exclude = \Special-use crash It crashed whenever seeing a mailbox that didn't have any special-use flags. Commit: 2ed6bdbbd2134b176cf3616a90a32927f6c54eb9 https://github.com/dovecot/core/commit/2ed6bdbbd2134b176cf3616a90a32927f6c54eb9 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/plugins/mail-filter/istream-ext-filter.c Log Message: ----------- mail-filter: Handle handshake write() failure Commit: 7abf8f2da4774fd3fd4e483e190f475e95ad5733 https://github.com/dovecot/core/commit/7abf8f2da4774fd3fd4e483e190f475e95ad5733 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/imap-urlauth/imap-urlauth-worker.c M src/plugins/virtual/virtual-storage.c Log Message: ----------- global: Ignore unnecessary return values. Commit: a3fbc77562ffc384d454609bac302e10f96f71ca https://github.com/dovecot/core/commit/a3fbc77562ffc384d454609bac302e10f96f71ca Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/pop3-login/client.c Log Message: ----------- pop3-login: Code cleanup - Make sure destroying client stops processing. It would currently do it in any case, but this makes it clearer. Commit: fe529b28ac636738294c6c787d4c569a49323f2a https://github.com/dovecot/core/commit/fe529b28ac636738294c6c787d4c569a49323f2a Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/auth/db-ldap.c M src/doveadm/doveadm-mail-index.c M src/lib-auth/auth-master.c M src/lib-fs/fs-posix.c M src/lib-storage/index/mbox/mbox-save.c M src/lib-storage/mail-autoexpunge.c M src/lib/file-dotlock.c M src/lib/iostream-temp.c Log Message: ----------- global: Add asserts to make static analyzer happier. Commit: da01950bef06bafc21af9d519377a4c8d37ac937 https://github.com/dovecot/core/commit/da01950bef06bafc21af9d519377a4c8d37ac937 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/plugins/quota/quota-private.h M src/plugins/quota/quota.c Log Message: ----------- quota: Remove quota_over_flag_* from quota_root. They are used only in one specific location and don't need to be stored permanently. Commit: 23a6d2decd9d377dc0b392b4762f7cddcd52de44 https://github.com/dovecot/core/commit/23a6d2decd9d377dc0b392b4762f7cddcd52de44 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/plugins/quota/quota.c Log Message: ----------- quota: If quota_over_flag_value is unset, skip the quota_over check. Commit: f51b1ce706d381b04cc71dc478bb29c5d1c6249a https://github.com/dovecot/core/commit/f51b1ce706d381b04cc71dc478bb29c5d1c6249a Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/plugins/quota/quota.c Log Message: ----------- quota: If quota_over_script is unset, skip the quota_over check. Commit: f2ecd4262187ae74f4377aa15dbca3d8862aac62 https://github.com/dovecot/core/commit/f2ecd4262187ae74f4377aa15dbca3d8862aac62 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/plugins/quota/quota.c Log Message: ----------- quota: Log why quota_over_flag check is skipped if mail_debug=yes Commit: bae12f8e00f17ae346a45005ab34959c8f362346 https://github.com/dovecot/core/commit/bae12f8e00f17ae346a45005ab34959c8f362346 Author: Martti Rannanj?rvi Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-index/mail-transaction-log-file.c Log Message: ----------- lib-index: don't reset ioloop_time on mmap error The variables seems to have been in the wrong order. Commit: 77486efb4f1dcded2ad1954eb288a1b9ec6b9e82 https://github.com/dovecot/core/commit/77486efb4f1dcded2ad1954eb288a1b9ec6b9e82 Author: Martti Rannanj?rvi Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-index/mail-transaction-log-file.c Log Message: ----------- lib-index: clear file->mmap_size only after logging it Logging the error with size=0 loses information. Commit: ea6a744d0931246e9d6356bc1723a7e38cb5fe4a https://github.com/dovecot/core/commit/ea6a744d0931246e9d6356bc1723a7e38cb5fe4a Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-http/http-client-request.c Log Message: ----------- lib-http: http_client_request_add_header() - Add key/value asserts These don't check that they're entirely correct as required by HTTP specifications. They're mainly there as a quick check that if the caller didn't validate the key/value in any way, we'll crash instead of creating a potential security hole. (Because with line feeds the attacker could add extra headers or even entirely new HTTP requests.) Commit: e72d13f3bec179b93d6dacf2fb44d68d8c5d1710 https://github.com/dovecot/core/commit/e72d13f3bec179b93d6dacf2fb44d68d8c5d1710 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-compression/istream-zlib.c M src/lib-compression/test-compression.c Log Message: ----------- lib-compress: Fix assert-crash when .gz header size exceeds buffer max length Instead treat the stream as corrupted and return EINVAL. Fixes: Panic: file istream.c: line 182 (i_stream_read): assertion failed: (_stream->skip != _stream->pos) Commit: 391e998096c5a821138495d5b8f873b21791aec4 https://github.com/dovecot/core/commit/391e998096c5a821138495d5b8f873b21791aec4 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-compression/istream-zlib.c Log Message: ----------- lib-compress: Fix missing .gz header error message Commit: c92338c67ffe69332d490d98ff43ccf005fd1765 https://github.com/dovecot/core/commit/c92338c67ffe69332d490d98ff43ccf005fd1765 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-sql/driver-cassandra.c Log Message: ----------- cassandra: Track query counts internally and include them in metrics Commit: 583320bd80c0f0052e654b8537df5fd1e1db73c5 https://github.com/dovecot/core/commit/583320bd80c0f0052e654b8537df5fd1e1db73c5 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-index/mail-index-sync-update.c M src/lib-index/mail-index-sync.c M src/lib-index/mail-index.h Log Message: ----------- lib-index: Add MAIL_INDEX_OPEN_FLAG_NO_DIRTY This way mailbox format backends that don't need dirty flags can use them for other purposes. Commit: cc42a09c50b1eb4eb6b4458f5cab1b750e95eadc https://github.com/dovecot/core/commit/cc42a09c50b1eb4eb6b4458f5cab1b750e95eadc Author: Aki Tuomi Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M configure.ac M src/lib-sql/driver-cassandra.c Log Message: ----------- driver-cassandra: Add support for speculative execution Commit: 27ec4694cc210edad3bd27d1f07606be589dc95f https://github.com/dovecot/core/commit/27ec4694cc210edad3bd27d1f07606be589dc95f Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-storage/list/mailbox-list-index-sync.c M src/lib-storage/list/mailbox-list-index.c M src/lib-storage/list/mailbox-list-index.h Log Message: ----------- LAYOUT=index: Rename mailbox_list_index_node.corrupted_parent to corrupted_ext The code will be useful for other purposes also besides updating corrupted parents. Commit: 9eb09dec6375f818f52e01c1eb840282ad370ce0 https://github.com/dovecot/core/commit/9eb09dec6375f818f52e01c1eb840282ad370ce0 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-storage/list/mailbox-list-index.c Log Message: ----------- LAYOUT=index: Fix duplicate mailbox name renaming to actually work Commit: a108b91f10c0013c1fe95d4656261f785951dd22 https://github.com/dovecot/core/commit/a108b91f10c0013c1fe95d4656261f785951dd22 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib/mempool-alloconly.c M src/lib/mempool.h Log Message: ----------- lib: Add pool_alloconly_create_clean() This partially reverts 2a2beae3a4c1e75b3aeff996781503138e6f24bc Commit: b627d2a108483252120ae0697740ac930263de1e https://github.com/dovecot/core/commit/b627d2a108483252120ae0697740ac930263de1e Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib/strfuncs.h M src/lib/test-strfuncs.c Log Message: ----------- lib: Clarify *_strsplit_spaces() and add unit test Commit: 2ffab546e929ad86b8ad8bd4f80af3d7e8650c2c https://github.com/dovecot/core/commit/2ffab546e929ad86b8ad8bd4f80af3d7e8650c2c Author: Aki Tuomi Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/plugins/mail-crypt/test-mail-key.c Log Message: ----------- mail-crypt: Do not restrict access in unit test This works around problem with docker Commit: 70bc7ec0cd965fcc0e2149b74a018abcb63752a3 https://github.com/dovecot/core/commit/70bc7ec0cd965fcc0e2149b74a018abcb63752a3 Author: Martti Rannanj?rvi Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-index/mail-cache.c Log Message: ----------- lib-index: zero mmap_length after logging error Logging that mmap(size=0) failed looks suspicious. Commit: 9fbca088270bbd901ae7264d20a6581be896e5d2 https://github.com/dovecot/core/commit/9fbca088270bbd901ae7264d20a6581be896e5d2 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-storage/list/mailbox-list-index-backend.c M src/lib-storage/list/mailbox-list-index-status.c M src/lib-storage/list/mailbox-list-index.c M src/lib-storage/list/mailbox-list-index.h Log Message: ----------- lib-storage: Fix mailbox list index hook usage The previous method appeared to work, but not if the internal hooks were used more than once. Commit: ef88cf8738d884d7d94cf3f6a719ca35fd5e759a https://github.com/dovecot/core/commit/ef88cf8738d884d7d94cf3f6a719ca35fd5e759a Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-storage/index/index-transaction.c M src/lib-storage/mail-storage-private.h M src/lib-storage/mail-storage.c Log Message: ----------- lib-storage: Always create mail_save_context.dest_mail This allows removing similar mail_alloc() from storage backends and plugins that need it. As a side effect, this changes mbox code to always assign UIDs to saved mails. This shouldn't be much of a problem, since it happened practically always already. Commit: 7c9cb6389fec12063b8829fd42698606825be3d3 https://github.com/dovecot/core/commit/7c9cb6389fec12063b8829fd42698606825be3d3 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-storage/index/cydir/cydir-save.c M src/lib-storage/index/dbox-common/dbox-save.c M src/lib-storage/index/dbox-common/dbox-save.h M src/lib-storage/index/dbox-multi/mdbox-save.c M src/lib-storage/index/dbox-single/sdbox-copy.c M src/lib-storage/index/dbox-single/sdbox-save.c M src/lib-storage/index/imapc/imapc-save.c M src/lib-storage/index/index-mail.c M src/lib-storage/index/index-storage.c M src/lib-storage/index/maildir/maildir-save.c M src/lib-storage/index/mbox/mbox-save.c M src/lib-storage/index/mbox/mbox-sync-private.h M src/lib-storage/index/mbox/mbox-sync.c Log Message: ----------- lib-storage: Remove unnecessary mail_save_context.dest_mail==NULL checks It can never be NULL after the previous change: "lib-storage: Always create mail_save_context.dest_mail". The code removal in maildir_transaction_save_commit_pre() seemed potentially dangerous, but I don't think such code path is possible anymore. Also even if it is, it's probably fine since the mail_free() is called even earlier than before (although that itself might have been a problem). This also removes last traces of code that made it possible to save mails to mbox without assigning UID to the mail. The previous commit already caused this, so this is just removing dead code. Commit: 18bfb2a5a84e14c3b1ab9129b7d9dc8d083558a7 https://github.com/dovecot/core/commit/18bfb2a5a84e14c3b1ab9129b7d9dc8d083558a7 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/plugins/notify/notify-storage.c M src/plugins/quota/quota-storage.c M src/plugins/virtual/virtual-save.c M src/plugins/zlib/zlib-plugin.c Log Message: ----------- plugins: Remove unnecessary mail_save_context.dest_mail==NULL checks It can never be NULL after the previous change: "lib-storage: Always create mail_save_context.dest_mail". Commit: 6816dcc048cb84d6675a480d5c69682b027eb651 https://github.com/dovecot/core/commit/6816dcc048cb84d6675a480d5c69682b027eb651 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/plugins/virtual/virtual-mail.c M src/plugins/virtual/virtual-save.c M src/plugins/virtual/virtual-storage.h Log Message: ----------- virtual: Fix saving to a virtual mailbox to work again Previous changes broke it. Commit: 4c3958af8840fac013ccc4a10fbe9579d447d95d https://github.com/dovecot/core/commit/4c3958af8840fac013ccc4a10fbe9579d447d95d Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-storage/mail-storage.c M src/lib-storage/mail-storage.h Log Message: ----------- lib-storage: Add mailbox_save_get_dest_mail() This marks mailbox_save_set_dest_mail deprecated. It's not efficient to use since it frees the already-created dest_mail. Commit: 99e60a23c0f287d32aa29d64261c9e792d124c41 https://github.com/dovecot/core/commit/99e60a23c0f287d32aa29d64261c9e792d124c41 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Avoid using mailbox_save_set_dest_mail() Commit: e9744a9bcaa1ae1ac9373d120907644a744f0716 https://github.com/dovecot/core/commit/e9744a9bcaa1ae1ac9373d120907644a744f0716 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Initialize var_expand_tab[] directly. This is a partially pick from acfda38b75d0f0e899ef692fef01593bd56ed85e to be able to cherry-pick the following patches more easily. Commit: 3c8711e32188d2a2368a43fafc2709dc57dc3d18 https://github.com/dovecot/core/commit/3c8711e32188d2a2368a43fafc2709dc57dc3d18 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c M src/lib-lda/mail-deliver.h Log Message: ----------- lib-lda: Remove unused mail_deliver_get_log_var_expand_table() Commit: 051cf2c837fbc80c5365228c34e2dcba34c728ad https://github.com/dovecot/core/commit/051cf2c837fbc80c5365228c34e2dcba34c728ad Author: Martti Rannanj?rvi Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: remove forced logging of session_id Commit: 603346248f2b329f611598a5e8f2c90c8b1c8dd5 https://github.com/dovecot/core/commit/603346248f2b329f611598a5e8f2c90c8b1c8dd5 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c M src/lib-lda/mail-deliver.h Log Message: ----------- lib-lda: Redesign mail_deliver_context.var_expand_table cache Commit: db8465fd09dc397b933af034c0aaa4229d516359 https://github.com/dovecot/core/commit/db8465fd09dc397b933af034c0aaa4229d516359 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Remove %{storage_id} setting for now. It doesn't work with Sieve. The following patches add it back properly. Commit: d19c4448687115ec0704e717c25368b7cddd3e82 https://github.com/dovecot/core/commit/d19c4448687115ec0704e717c25368b7cddd3e82 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Code cleanup - mail_deliver_open_mail() now uses uid parameter Commit: 0f196b4cf12ddba3ea6dac89602e4506817d9f41 https://github.com/dovecot/core/commit/0f196b4cf12ddba3ea6dac89602e4506817d9f41 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lda/main.c M src/lib-lda/Makefile.am M src/lib-lda/mail-deliver.c M src/lib-lda/mail-deliver.h M src/lmtp/main.c Log Message: ----------- lib-lda: Fix deliver_log_format variables with Sieve With Sieve it was using src_mail for getting the values, which weren't correct especially if Sieve had modified the mail. Commit: cacc4f84d7c77674f8af93a4ca3a250849ed2c3b https://github.com/dovecot/core/commit/cacc4f84d7c77674f8af93a4ca3a250849ed2c3b Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Implement %{storage_id} correctly Commit: a4806a6ddc283c5a6863a2bafd599084929a714e https://github.com/dovecot/core/commit/a4806a6ddc283c5a6863a2bafd599084929a714e Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Don't set mail_deliver_context.dest_mail too early. It must be NULL for the caller, unless save_dest_mail==TRUE Commit: 28f1862b3dd6496d447041bc079620ac70e3204a https://github.com/dovecot/core/commit/28f1862b3dd6496d447041bc079620ac70e3204a Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Code cleanup - remove unnecessary dest_mail check Commit: 708ff403287984fac0eafd11013ffeb54d714427 https://github.com/dovecot/core/commit/708ff403287984fac0eafd11013ffeb54d714427 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/doveadm/doveadm-mail-mailbox.c M src/doveadm/doveadm-mail.c M src/doveadm/doveadm-mail.h Log Message: ----------- doveadm: Added "mailbox path" command This allows easily printing a path for a mailbox, index, control dir, etc. Commit: bf70b41e8a81935c6237d2899a0ce4ebe8a66f19 https://github.com/dovecot/core/commit/bf70b41e8a81935c6237d2899a0ce4ebe8a66f19 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-mail/istream-header-filter.c M src/lib-mail/test-istream-header-filter.c Log Message: ----------- lib-mail: Fix duplicate HEADER_FILTER_ADD_MISSING_EOH callback call If headers weren't modified, the second reading of the istream shouldn't call any callbacks. Commit: b3bfde7048d613eb2f0e00ce4683232b11197d6f https://github.com/dovecot/core/commit/b3bfde7048d613eb2f0e00ce4683232b11197d6f Author: Stephan Bosch Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-http/http-message-parser.c M src/lib-http/http-request.c Log Message: ----------- lib-http: message parser: Don't create the connection_options array, unless it is actually used. Commit: 2a1e57bf923bdc1c331e5285ccfa63eb44429356 https://github.com/dovecot/core/commit/2a1e57bf923bdc1c331e5285ccfa63eb44429356 Author: Stephan Bosch Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-http/http-message-parser.c Log Message: ----------- lib-http: message parser: Delay allocation of message header. Commit: 6f56bdfdab7304c35ad63496af4839dbeecd5d0f https://github.com/dovecot/core/commit/6f56bdfdab7304c35ad63496af4839dbeecd5d0f Author: Stephan Bosch Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-http/http-message-parser.c M src/lib-http/http-message-parser.h M src/lib-http/http-request-parser.c M src/lib-http/http-response-parser.c Log Message: ----------- lib-http: message parser: Don't allocate a pool for the next message until it is needed. This prevents wasting memory when no message is being parsed. Commit: 968c7545264c73d8c69882511b663a1e9d243d6d https://github.com/dovecot/core/commit/968c7545264c73d8c69882511b663a1e9d243d6d Author: Stephan Bosch Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-http/http-response-parser.c Log Message: ----------- lib-http: response parser: Always clear response to prevent referring to stale data. Commit: 992657a910524e2f2abd15223b3818755e75b74a https://github.com/dovecot/core/commit/992657a910524e2f2abd15223b3818755e75b74a Author: Stephan Bosch Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-http/http-response-parser.c Log Message: ----------- lib-http: response parser: Drop previous response's pool immediately when parsing continues. Prevously, it would only do that when the first byte of the next response was received. This prevents wasting memory when no response is being parsed. Commit: 934dc5bf43d1082d2f0cf1f43bc95b4f619e78ef https://github.com/dovecot/core/commit/934dc5bf43d1082d2f0cf1f43bc95b4f619e78ef Author: Josef 'Jeff' Sipek Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-imap-client/imapc-connection.c M src/lib-storage/index/imapc/imapc-storage.c Log Message: ----------- lib-imap-client: centralize authentication failed error logging Commit: 42319578cd8e76d30802f9e92c3cf5ffbfd63953 https://github.com/dovecot/core/commit/42319578cd8e76d30802f9e92c3cf5ffbfd63953 Author: Josef 'Jeff' Sipek Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-imap-client/imapc-client-private.h M src/lib-imap-client/imapc-client.c M src/lib-imap-client/imapc-client.h M src/lib-imap-client/imapc-connection.c Log Message: ----------- lib-imap-client: add callback to notify consumers about state changes Add a callback to notify imapc users about failures. Currently, the only failure defined is "authentication failed". Commit: b9838d53171afd24162b2bc44daa52d478a420e9 https://github.com/dovecot/core/commit/b9838d53171afd24162b2bc44daa52d478a420e9 Author: Josef 'Jeff' Sipek Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-imap-client/imapc-client.h M src/lib-imap-client/imapc-connection.c Log Message: ----------- lib-imap-client: invoke state change callback on "authentication success" Commit: d177753e5f8d0650f33266d8420e6d35c99c88ec https://github.com/dovecot/core/commit/d177753e5f8d0650f33266d8420e6d35c99c88ec Author: Josef 'Jeff' Sipek Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-imap-client/imapc-connection.c Log Message: ----------- lib-imap-client: pass the reply text to the auth-failed state change callback Commit: 7bf7bc9c3cca0f6638f4d6d9310d60333e959fb1 https://github.com/dovecot/core/commit/7bf7bc9c3cca0f6638f4d6d9310d60333e959fb1 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/plugins/mail-log/mail-log-plugin.c Log Message: ----------- mail-log: Add mail_log_cached_only setting. If enabled, everything except "save" event will log only the fields that can be looked up from cache. This improves performance if some of the fields aren't cached and it's not a strict requirement to log them. Commit: 0f3f7325d5c0e3b3e86ebbd3d91c630d1ee88347 https://github.com/dovecot/core/commit/0f3f7325d5c0e3b3e86ebbd3d91c630d1ee88347 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-storage/mail-storage-private.h M src/lib-storage/mail-storage.c Log Message: ----------- lib-storage: Make sure mailbox undeletion won't go to infinite loop Commit: fdaba55b3da9e2708414c88552c94ca63609caad https://github.com/dovecot/core/commit/fdaba55b3da9e2708414c88552c94ca63609caad Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-storage/mail-storage.c Log Message: ----------- lib-storage: Don't sync mailbox after undeleting it. This is useful only when deleting it. With undeletion the syncing isn't useful and might actually be harmful with mailbox formats that didn't fully open the mailbox while it was undeleted. Commit: 4decb8ca5ce533715b4d2d2e8fb7d5f591f69983 https://github.com/dovecot/core/commit/4decb8ca5ce533715b4d2d2e8fb7d5f591f69983 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-storage/mail-storage.c Log Message: ----------- lib-storage: Re-open mailbox after it's undeleted. This is needed with mailbox formats that didn't fully open the mailbox while it was undeleted. Commit: fbfcbf39d93afc1f62d183479871a0eee687c70b https://github.com/dovecot/core/commit/fbfcbf39d93afc1f62d183479871a0eee687c70b Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-index/mail-index-transaction-finish.c M src/lib-index/mail-index-transaction-private.h M src/lib-index/mail-index-transaction-update.c M src/lib-index/test-mail-index-transaction-finish.c Log Message: ----------- lib-index: Add day_stamp parameter to mail_index_update_day_headers() This will help creating a unit test. Commit: 9d2f3c39584ff0e475577759f798c459ae95077c https://github.com/dovecot/core/commit/9d2f3c39584ff0e475577759f798c459ae95077c Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-index/mail-index-transaction-update.c M src/lib-index/test-mail-index-transaction-update.c Log Message: ----------- lib-index: Fix updating mail_index_header.day_first_uid If user received a mail every day, the day_first_uid wasn't being updated. This caused wrong caching decisions to be made in dovecot.index.cache: - Accessing >1 week old emails should have changed caching decision from "tmp" to "yes". This might not have happened, although as long as day_first_uid[7] pointed to an existing mail and email client accessed all the mails, this wouldn't have changed anything. - Cache compression is supposed to drop >1 week old mails when caching decision is "tmp". Not enough mails were being dropped because day_first_uid[7] pointed to a much older than 1 week old mails. Also added a unit test to make sure this works. Broken by d9ee2f9fb3ef7b9391bfeeff1b374aead51667aa Commit: 2dccf7ca288122001b7ea0204357fa8d2a245d61 https://github.com/dovecot/core/commit/2dccf7ca288122001b7ea0204357fa8d2a245d61 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-storage/index/index-mailbox-size.c Log Message: ----------- lib-storage: Don't stop vsize calculation on expunged mails. I don't know why I added such logic there in the first place. If we just skip the expunged mails, the end result should still be correct and usable when cached. Commit: e4a574f08a822a57929c54ea6ba6a23607d90706 https://github.com/dovecot/core/commit/e4a574f08a822a57929c54ea6ba6a23607d90706 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-storage/index/index-mailbox-size.c M src/lib-storage/mail-storage-settings.c M src/lib-storage/mail-storage-settings.h M src/plugins/quota/quota-count.c Log Message: ----------- lib-storage: Add mail_vsize_bg_after_count setting. If folder vsize calculation requires opening more than this many mails from disk (i.e. mail sizes aren't in cache already), return failure and finish the calculation via indexer process. This should be used like: protocol !indexer-worker { mail_vsize_bg_after_count = 10 } Commit: 678cbf47e7060154b769128c696c16bd4d5caac0 https://github.com/dovecot/core/commit/678cbf47e7060154b769128c696c16bd4d5caac0 Author: Timo Sirainen Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/lib-storage/index/index-mailbox-size.c Log Message: ----------- lib-storage: Update vsize header after sync only if sizes are cached. The result isn't needed yet in that case, so if it's slow to get the sizes it might as well be delayd until later. This is especially useful when indexer-worker triggers FTS indexing. The vsizes can be added to index after the mail is already read for FTS. Without this change the vsize update would first open all the mails and then the FTS indexing would open all the mails a second time. Commit: a5e22885eda23b502fc98f340196faea39b0a100 https://github.com/dovecot/core/commit/a5e22885eda23b502fc98f340196faea39b0a100 Author: Aki Tuomi Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M configure.ac M src/Makefile.am A src/lib-oauth2/Makefile.am A src/lib-oauth2/oauth2-introspect.c A src/lib-oauth2/oauth2-private.h A src/lib-oauth2/oauth2-refresh.c A src/lib-oauth2/oauth2-token-validate.c A src/lib-oauth2/oauth2.c A src/lib-oauth2/oauth2.h Log Message: ----------- lib-oauth2: Add support library for OAUTH2 Commit: cc52a2cb1007bfa29d14df0bb7da82316b478087 https://github.com/dovecot/core/commit/cc52a2cb1007bfa29d14df0bb7da82316b478087 Author: Aki Tuomi Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/auth/passdb-template.c M src/auth/passdb-template.h Log Message: ----------- auth: Add accessor for passdb template arguments Commit: cdf00f56f959c078dc5201d60e6bb88f3a7263af https://github.com/dovecot/core/commit/cdf00f56f959c078dc5201d60e6bb88f3a7263af Author: Aki Tuomi Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/auth/auth-request.c M src/auth/auth-settings.c M src/auth/auth-settings.h M src/auth/passdb.c M src/auth/passdb.h Log Message: ----------- auth: Add mechanism filter for passdbs Commit: 5bad9223e21db98bee7619dee9da74732e3a71ec https://github.com/dovecot/core/commit/5bad9223e21db98bee7619dee9da74732e3a71ec Author: Aki Tuomi Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/auth/Makefile.am A src/auth/mech-oauth2.c M src/auth/mech.c Log Message: ----------- auth: Add xoauth2 and oauthbearer mechanisms Commit: bf1f57d7608dc0659978bfcaffa4fc223973dcd6 https://github.com/dovecot/core/commit/bf1f57d7608dc0659978bfcaffa4fc223973dcd6 Author: Aki Tuomi Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/auth/Makefile.am A src/auth/db-oauth2.c A src/auth/db-oauth2.h A src/auth/passdb-oauth2.c M src/auth/passdb.c Log Message: ----------- auth: Add oauth2 passdb Compare: https://github.com/dovecot/core/compare/53a4f7fffc6d...bf1f57d7608d From noreply at github.com Fri Feb 17 14:30:10 2017 From: noreply at github.com (GitHub) Date: Fri, 17 Feb 2017 06:30:10 -0800 Subject: [dovecot/core] 8054b0: mech-oauth2: Fix gs2-header parsing Message-ID: <58a708f2617e1_28d0c3fca0559fc2c133522@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 8054b019bdca47df5676e40e19cbde7e68827640 https://github.com/dovecot/core/commit/8054b019bdca47df5676e40e19cbde7e68827640 Author: Aki Tuomi Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/auth/mech-oauth2.c Log Message: ----------- mech-oauth2: Fix gs2-header parsing Commit: ec87095cf79f20c693feff56fe0aa9c6b4c6450a https://github.com/dovecot/core/commit/ec87095cf79f20c693feff56fe0aa9c6b4c6450a Author: Aki Tuomi Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/auth/mech-oauth2.c Log Message: ----------- mech-oauth2: Set user_given=TRUE when username given in OAUTHBEARER Commit: aee9f241f3c2b2afab2262969e59df5ac8c6ccc2 https://github.com/dovecot/core/commit/aee9f241f3c2b2afab2262969e59df5ac8c6ccc2 Author: Aki Tuomi Date: 2017-02-17 (Fri, 17 Feb 2017) Changed paths: M src/auth/mech-oauth2.c Log Message: ----------- mech-oauth2: Clarify logging Compare: https://github.com/dovecot/core/compare/abd812f275c5...aee9f241f3c2 From noreply at github.com Sat Feb 18 23:00:13 2017 From: noreply at github.com (GitHub) Date: Sat, 18 Feb 2017 15:00:13 -0800 Subject: [dovecot/core] c16c05: lib: Fix assert-crash in unit test. Message-ID: <58a8d1fdb2122_27cad3f983da9dc3c169584@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: c16c05a2735f8a34fbdf7023f3ab479e709f7eac https://github.com/dovecot/core/commit/c16c05a2735f8a34fbdf7023f3ab479e709f7eac Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib/test-strfuncs.c Log Message: ----------- lib: Fix assert-crash in unit test. Messed up merging. From noreply at github.com Sun Feb 19 01:00:16 2017 From: noreply at github.com (GitHub) Date: Sat, 18 Feb 2017 17:00:16 -0800 Subject: [dovecot/core] 333c97: mech-oauth2: Fix gs2-header parsing Message-ID: <58a8ee20caf74_18803fbaa6295c341773d0@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 333c979081b9414b043091528366b924ad8fe9da https://github.com/dovecot/core/commit/333c979081b9414b043091528366b924ad8fe9da Author: Aki Tuomi Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/auth/mech-oauth2.c Log Message: ----------- mech-oauth2: Fix gs2-header parsing Commit: 3fa10ae460f1c3c36df30835197bce8792e7197f https://github.com/dovecot/core/commit/3fa10ae460f1c3c36df30835197bce8792e7197f Author: Aki Tuomi Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/auth/mech-oauth2.c Log Message: ----------- mech-oauth2: Set user_given=TRUE when username given in OAUTHBEARER Commit: 58282a7461d53627af5886953c4d80ebeb38c434 https://github.com/dovecot/core/commit/58282a7461d53627af5886953c4d80ebeb38c434 Author: Aki Tuomi Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/auth/mech-oauth2.c Log Message: ----------- mech-oauth2: Clarify logging Commit: 4e7a1d41b21e0b587382bb86b7d4e3c92c45ab57 https://github.com/dovecot/core/commit/4e7a1d41b21e0b587382bb86b7d4e3c92c45ab57 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/imap/imap-client.c M src/imap/imap-client.h M src/imap/imap-commands.c M src/imap/imap-sync.c Log Message: ----------- imap: Code cleanup - move command stats to struct client_command_stats Commit: f386c503785bf47eb0906064f52bd5dd5a866244 https://github.com/dovecot/core/commit/f386c503785bf47eb0906064f52bd5dd5a866244 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/imap/cmd-logout.c M src/imap/imap-client.h Log Message: ----------- imap: Add imap_client.logged_out at LOGOUT This is useful for determining if client did a clean logout Commit: 687ea5aa71b29fc4da4e3a94d99e804883b11eb3 https://github.com/dovecot/core/commit/687ea5aa71b29fc4da4e3a94d99e804883b11eb3 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/imap/imap-client.c Log Message: ----------- imap: Code cleanup - Move code to client_command_stats_append() Commit: f6f4ad6f59bf8a49d8f31a112149090a34e04731 https://github.com/dovecot/core/commit/f6f4ad6f59bf8a49d8f31a112149090a34e04731 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/imap/imap-client.c M src/imap/imap-client.h Log Message: ----------- imap: Include info about last command in disconnection log line. Only if LOGOUT isn't sent, because that's already visible. Compare: https://github.com/dovecot/core/compare/c16c05a2735f...f6f4ad6f59bf From noreply at github.com Sun Feb 19 01:00:12 2017 From: noreply at github.com (GitHub) Date: Sat, 18 Feb 2017 17:00:12 -0800 Subject: [dovecot/core] 567b56: imap: Code cleanup - move command stats to struct ... Message-ID: <58a8ee1c1303d_203b3fb054b65c3023584f@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 567b56c2d6a1063cad997c956f3ed1d9d735f14e https://github.com/dovecot/core/commit/567b56c2d6a1063cad997c956f3ed1d9d735f14e Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/imap/imap-client.c M src/imap/imap-client.h M src/imap/imap-commands.c M src/imap/imap-sync.c Log Message: ----------- imap: Code cleanup - move command stats to struct client_command_stats Commit: 5334234b155ced693feb925aeabd3a3cda07eacd https://github.com/dovecot/core/commit/5334234b155ced693feb925aeabd3a3cda07eacd Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/imap/cmd-logout.c M src/imap/imap-client.h Log Message: ----------- imap: Add imap_client.logged_out at LOGOUT This is useful for determining if client did a clean logout Commit: 0eba75a2f41586626b167f5eb01ca48a29451e52 https://github.com/dovecot/core/commit/0eba75a2f41586626b167f5eb01ca48a29451e52 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/imap/imap-client.c Log Message: ----------- imap: Code cleanup - Move code to client_command_stats_append() Commit: 9036b11c0f06193bfebab686d75982d7930cb517 https://github.com/dovecot/core/commit/9036b11c0f06193bfebab686d75982d7930cb517 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/imap/imap-client.c M src/imap/imap-client.h Log Message: ----------- imap: Include info about last command in disconnection log line. Only if LOGOUT isn't sent, because that's already visible. Compare: https://github.com/dovecot/core/compare/aee9f241f3c2...9036b11c0f06 From noreply at github.com Sun Feb 19 08:58:26 2017 From: noreply at github.com (GitHub) Date: Sun, 19 Feb 2017 00:58:26 -0800 Subject: [dovecot/pigeonhole] 3f5a70: imapsieve: Remove unnecessary mail_save_context.de... Message-ID: <58a95e32642bf_20f23fe6113bbc3021717@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-0.4 Home: https://github.com/dovecot/pigeonhole Commit: 3f5a70bf97747395ae30bfa194c6acf0e7f76487 https://github.com/dovecot/pigeonhole/commit/3f5a70bf97747395ae30bfa194c6acf0e7f76487 Author: Timo Sirainen Date: 2017-02-18 (Sat, 18 Feb 2017) Changed paths: M src/plugins/imapsieve/imap-sieve-storage.c Log Message: ----------- imapsieve: Remove unnecessary mail_save_context.dest_mail==NULL checks It can never be NULL after the "lib-storage: Always create mail_save_context.dest_mail" core change. Commit: 0d78a300177368f5934c589d69640c8c6fa6a1f2 https://github.com/dovecot/pigeonhole/commit/0d78a300177368f5934c589d69640c8c6fa6a1f2 Author: Timo Sirainen Date: 2017-02-18 (Sat, 18 Feb 2017) Changed paths: M src/lib-sieve/sieve-actions.c M src/lib-sieve/sieve-actions.h Log Message: ----------- lib-sieve: Remove unnecessary mailbox_save_set_dest_mail() call Compare: https://github.com/dovecot/pigeonhole/compare/356dcd498837...0d78a3001773 From noreply at github.com Sun Feb 19 08:58:52 2017 From: noreply at github.com (GitHub) Date: Sun, 19 Feb 2017 00:58:52 -0800 Subject: [dovecot/pigeonhole] 051cf4: doveadm-sieve: Fix crash when setting Sieve script... Message-ID: <58a95e4c76414_289653fd98b47dc3c143482@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/pigeonhole Commit: 051cf477ec2f98f3ff4d63765e733101714dabcc https://github.com/dovecot/pigeonhole/commit/051cf477ec2f98f3ff4d63765e733101714dabcc Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/plugins/doveadm-sieve/doveadm-sieve-sync.c Log Message: ----------- doveadm-sieve: Fix crash when setting Sieve script via attribute's string value. From noreply at github.com Sun Feb 19 14:30:10 2017 From: noreply at github.com (GitHub) Date: Sun, 19 Feb 2017 06:30:10 -0800 Subject: [dovecot/core] 905627: imap: Fix sending UID only when necessary on broke... Message-ID: <58a9abf21d334_38f3fd90cad7c38176566@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 905627a760ce8bf4141b361f72858a99975ded3c https://github.com/dovecot/core/commit/905627a760ce8bf4141b361f72858a99975ded3c Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/imap/imap-fetch.c M src/imap/imap-fetch.h Log Message: ----------- imap: Fix sending UID only when necessary on broken FETCHes. b748f91d0677fffaa2208b39ebb6db3aeb2e937b changed UID to be sent for most FETCH replies. There was also some existing code that attempted to do this, but didn't fully work. So now: 1) If there are no non-buffered replies, the entire FETCH response isn't sent. 2) If the buffer was already flushed and nothing else was sent, add UID to reply. The code paths for handling this are differently for imap_fetch_failure = disconnect-immediately vs others (depending on imap_fetch_cur_failed() return value). Commit: 46e17407ed48155ac7290a992216a11b2b2b3cf4 https://github.com/dovecot/core/commit/46e17407ed48155ac7290a992216a11b2b2b3cf4 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/imap/imap-fetch.c M src/imap/imap-fetch.h Log Message: ----------- imap: Code cleanup - Remove duplicate flags from imap_fetch_state All the cur_flushed, line_partial and line_finished were about the same thing. Commit: 43b95471c46f3d30b4c7e544acb5f0f2030ca2e0 https://github.com/dovecot/core/commit/43b95471c46f3d30b4c7e544acb5f0f2030ca2e0 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-fs/fs-posix.c Log Message: ----------- fs-posix: Add "no-fsync" parameter. This disables calling fdatasync() when fs_write() was done with FS_OPEN_FLAG_FSYNC. Useful for making tests faster. Commit: 798530867beda2d2d9a8ec194ea701adef74e737 https://github.com/dovecot/core/commit/798530867beda2d2d9a8ec194ea701adef74e737 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-storage/mail-storage-hooks.c Log Message: ----------- lib-storage: Assert-crash if duplicate internal hooks are added. Commit: 073353fe5b7ddbc44fd2b099e023b84254041083 https://github.com/dovecot/core/commit/073353fe5b7ddbc44fd2b099e023b84254041083 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-storage/mail-storage-service.c M src/lib-storage/mail-storage.c Log Message: ----------- lib-storage: mail_storage_init/deinit() is now reference counted. This allows calling them multiple times and only the final deinit frees the data. Commit: b4adb461ce12bf578d2d70806b205cf3cbf1a51d https://github.com/dovecot/core/commit/b4adb461ce12bf578d2d70806b205cf3cbf1a51d Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/doveadm/doveadm-mail.c Log Message: ----------- doveadm: Add explicit mail_storage_init/deinit() calls This mainly prevents losing hooks that were registered by doveadm plugins. Otherwise what happens is: - mail_plugins are unloaded and they unregister their hooks - doveadm plugins (e.g. doveadm_sieve) are NOT unloaded - mail_storage_deinit() frees all the registered hooks - next mail_storage_init() initializes all new hooks - All mail_plugins are loaded and they register again their hooks - doveadm plugins are NOT re-loaded or re-initialized, so their existing hooks were lost. Commit: b98f1ffc049e8c4c1677173ea65830aa07b3ef87 https://github.com/dovecot/core/commit/b98f1ffc049e8c4c1677173ea65830aa07b3ef87 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/imap/imap-client.c M src/imap/imap-client.h M src/imap/imap-commands.c M src/imap/imap-commands.h Log Message: ----------- imap: Fix running time in tagged command replies. The timing information was updated only after command_exec() returned. Most of the commands were handled within a single command_exec() though, so at the time when tagline was sent the running_usecs was still zero. The msecs in ioloop timing was correct though, because it relied only on the command start timing info. Compare: https://github.com/dovecot/core/compare/9036b11c0f06...b98f1ffc049e From noreply at github.com Sun Feb 19 16:00:13 2017 From: noreply at github.com (GitHub) Date: Sun, 19 Feb 2017 08:00:13 -0800 Subject: [dovecot/core] e42cd9: imap: Fix sending UID only when necessary on broke... Message-ID: <58a9c10dadd1d_a4f3f9988995c441109b8@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: e42cd9406f15140ba43a17d90385eecf0624aeac https://github.com/dovecot/core/commit/e42cd9406f15140ba43a17d90385eecf0624aeac Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/imap/imap-fetch.c M src/imap/imap-fetch.h Log Message: ----------- imap: Fix sending UID only when necessary on broken FETCHes. b748f91d0677fffaa2208b39ebb6db3aeb2e937b changed UID to be sent for most FETCH replies. There was also some existing code that attempted to do this, but didn't fully work. So now: 1) If there are no non-buffered replies, the entire FETCH response isn't sent. 2) If the buffer was already flushed and nothing else was sent, add UID to reply. The code paths for handling this are differently for imap_fetch_failure = disconnect-immediately vs others (depending on imap_fetch_cur_failed() return value). Commit: 099cd74264ca3bdb858fa508310c22268d166723 https://github.com/dovecot/core/commit/099cd74264ca3bdb858fa508310c22268d166723 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/imap/imap-fetch.c M src/imap/imap-fetch.h Log Message: ----------- imap: Code cleanup - Remove duplicate flags from imap_fetch_state All the cur_flushed, line_partial and line_finished were about the same thing. Commit: cd7d2946f356c78d4d73f9667c9342a111678d7e https://github.com/dovecot/core/commit/cd7d2946f356c78d4d73f9667c9342a111678d7e Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-fs/fs-posix.c Log Message: ----------- fs-posix: Add "no-fsync" parameter. This disables calling fdatasync() when fs_write() was done with FS_OPEN_FLAG_FSYNC. Useful for making tests faster. Commit: c72c40333dde84b09423abf49bcf89e8088c5898 https://github.com/dovecot/core/commit/c72c40333dde84b09423abf49bcf89e8088c5898 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-storage/mail-storage-hooks.c Log Message: ----------- lib-storage: Assert-crash if duplicate internal hooks are added. Commit: d670659283bb6e00ce306b116e3acda230530f29 https://github.com/dovecot/core/commit/d670659283bb6e00ce306b116e3acda230530f29 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-storage/mail-storage-service.c M src/lib-storage/mail-storage.c Log Message: ----------- lib-storage: mail_storage_init/deinit() is now reference counted. This allows calling them multiple times and only the final deinit frees the data. Commit: 3413b38df881a8c712ae4a88cfe72bbfed2a7b37 https://github.com/dovecot/core/commit/3413b38df881a8c712ae4a88cfe72bbfed2a7b37 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/doveadm/doveadm-mail.c Log Message: ----------- doveadm: Add explicit mail_storage_init/deinit() calls This mainly prevents losing hooks that were registered by doveadm plugins. Otherwise what happens is: - mail_plugins are unloaded and they unregister their hooks - doveadm plugins (e.g. doveadm_sieve) are NOT unloaded - mail_storage_deinit() frees all the registered hooks - next mail_storage_init() initializes all new hooks - All mail_plugins are loaded and they register again their hooks - doveadm plugins are NOT re-loaded or re-initialized, so their existing hooks were lost. Commit: bd612a097050665e8e5d72cb352ab3ac11c9a3b6 https://github.com/dovecot/core/commit/bd612a097050665e8e5d72cb352ab3ac11c9a3b6 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/imap/imap-client.c M src/imap/imap-client.h M src/imap/imap-commands.c M src/imap/imap-commands.h Log Message: ----------- imap: Fix running time in tagged command replies. The timing information was updated only after command_exec() returned. Most of the commands were handled within a single command_exec() though, so at the time when tagline was sent the running_usecs was still zero. The msecs in ioloop timing was correct though, because it relied only on the command start timing info. Compare: https://github.com/dovecot/core/compare/f6f4ad6f59bf...bd612a097050 From noreply at github.com Sun Feb 19 16:30:10 2017 From: noreply at github.com (GitHub) Date: Sun, 19 Feb 2017 08:30:10 -0800 Subject: [dovecot/core] 211c63: spelling fixes Message-ID: <58a9c812d25de_2583fd54a173c341710c9@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 211c638d81d382517d196ad47565e0d85012c927 https://github.com/dovecot/core/commit/211c638d81d382517d196ad47565e0d85012c927 Author: klemens Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M NEWS M doc/example-config/conf.d/auth-system.conf.ext M doc/example-config/dovecot-sql.conf.ext M doc/man/doveadm-exec.1.in M doc/securecoding.txt M m4/dovecot.m4 M m4/endian.m4 M src/auth/password-scheme.h M src/config/config-filter.c M src/doveadm/client-connection-http.c M src/imap-urlauth/imap-urlauth.c M src/imap/cmd-append.c M src/imap/cmd-thread.c M src/imap/main.c M src/lib-dcrypt/ostream-encrypt.c M src/lib-fts/fts-tokenizer-generic.c M src/lib-fts/fts-tokenizer.h M src/lib-http/http-client-queue.c M src/lib-imap/imap-base-subject.c M src/lib-index/mail-cache.c M src/lib-mail/message-part-data.h M src/lib-program-client/program-client-remote.c M src/lib-sasl/dsasl-client.h M src/lib-ssl-iostream/istream-openssl.c M src/lib-storage/index/index-sort-string.c M src/lib-storage/index/maildir/maildir-storage.c M src/lib-storage/index/maildir/maildir-uidlist.c M src/lib-storage/list/mailbox-list-fs-iter.c M src/lib-storage/mailbox-attribute.h M src/lib/fdatasync-path.c M src/lib/sha1.h M src/lib/sha3.c M src/lib/test-data-stack.c M src/log/log-connection.c Log Message: ----------- spelling fixes From noreply at github.com Sun Feb 19 18:00:10 2017 From: noreply at github.com (GitHub) Date: Sun, 19 Feb 2017 10:00:10 -0800 Subject: [dovecot/core] 2da176: dsync: Don't assert-crash if duplicate attributes ... Message-ID: <58a9dd2aba81c_6853f8def849c2c135171@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 2da176a0b105bc75a3289facb4b467e98bc04829 https://github.com/dovecot/core/commit/2da176a0b105bc75a3289facb4b467e98bc04829 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/doveadm/dsync/dsync-mailbox-export.c Log Message: ----------- dsync: Don't assert-crash if duplicate attributes are seen Just ignore the duplicates. Normally this shouldn't happen, but due to some bugs for example a Sieve script could be returned once by doveadm_sieve plugin and another time from mail_attribute_dict. From noreply at github.com Sun Feb 19 19:00:11 2017 From: noreply at github.com (GitHub) Date: Sun, 19 Feb 2017 11:00:11 -0800 Subject: [dovecot/core] 34f259: lib-storage: Clarify what MAIL_LOOKUP_ABORT_READ_M... Message-ID: <58a9eb3b2ec54_17c73fcf3f6bfc30102014@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 34f2590f3b5cd7c8a30379e9688cd3270e402099 https://github.com/dovecot/core/commit/34f2590f3b5cd7c8a30379e9688cd3270e402099 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-storage/mail-storage.h Log Message: ----------- lib-storage: Clarify what MAIL_LOOKUP_ABORT_READ_MAIL means. It should maybe even be renamed to something clearer. Commit: 7204b8112e005ff81dcf628f7880ef1feed1effe https://github.com/dovecot/core/commit/7204b8112e005ff81dcf628f7880ef1feed1effe Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-storage/index/cydir/cydir-mail.c M src/lib-storage/index/dbox-multi/mdbox-mail.c M src/lib-storage/index/dbox-single/sdbox-mail.c M src/lib-storage/index/imapc/imapc-mail-fetch.c M src/lib-storage/index/index-mail.c M src/lib-storage/index/maildir/maildir-mail.c M src/lib-storage/index/mbox/mbox-mail.c M src/lib-storage/index/raw/raw-mail.c M src/lib-storage/mail-storage.h Log Message: ----------- lib-storage: Add mail.mail_stream_opened and .mail_metadata_accessed These allow determining after mail_*() calls how efficiently they were performed. Commit: ca004511f36c090b07c6f097cf237ce836d8faf6 https://github.com/dovecot/core/commit/ca004511f36c090b07c6f097cf237ce836d8faf6 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-storage/index/index-mailbox-size.c Log Message: ----------- lib-storage: Change vsize calculation to use the new mail_stream_opened This avoids calling mail_get_virtual_size() twice and is a bit cleaner approach. Commit: 6cf18519f0804755385871d84384834465b2d68e https://github.com/dovecot/core/commit/6cf18519f0804755385871d84384834465b2d68e Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-storage/index/index-search.c M src/lib-storage/index/index-sort-private.h M src/lib-storage/index/index-sort-string.c M src/lib-storage/index/index-sort.c M src/lib-storage/index/index-sort.h Log Message: ----------- lib-storage: Fix error handling when sorting mails. All errors were treated the same as if message had been expunged. This caused potentially wrong results to be sent to the client without any indication that they're wrong. Commit: 7f93dd01f630d40ff81de471a437968f3dcfea87 https://github.com/dovecot/core/commit/7f93dd01f630d40ff81de471a437968f3dcfea87 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-storage/index/index-search.c Log Message: ----------- lib-storage: Search optimization - avoid parsing message_parts unnecessarily If they're not already cached, the mail is parsed twice: once to get the message_parts and again to perform the actual search. The searching can however do the message_parts parsing internally as well. Commit: 0796f4c0eebbc9a0eaf441c53053e3023543418e https://github.com/dovecot/core/commit/0796f4c0eebbc9a0eaf441c53053e3023543418e Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-storage/index/index-search.c Log Message: ----------- lib-storage: Fix error handling when searching mails Only expunge errors and failures caused by lookup_abort should be ignored. The rest of the mail errors mean that the search result might not be correct. We'll still run the search as fully as possible, but we just return an error at the end. Commit: be6bde0e1f40db97871b657603188fc9041f1d04 https://github.com/dovecot/core/commit/be6bde0e1f40db97871b657603188fc9041f1d04 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/imap/imap-search.c Log Message: ----------- imap: If SEARCH/SORT fails but returns some results, send them to client. The previous error handling fixes cause SEARCH/SORT to now fail if there are any problems reading mails. This change makes the commands still return the best known results, so the IMAP client can still use them, even though they may not be entirely correct. Commit: 2898ad0028a9b0c30df96dd6b68930fd4dc57527 https://github.com/dovecot/core/commit/2898ad0028a9b0c30df96dd6b68930fd4dc57527 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/doveadm/doveadm-mail.c M src/imap/imap-commands-util.c M src/lib-storage/index/dbox-multi/mdbox-map.c M src/lib-storage/index/imapc/imapc-storage.c M src/lib-storage/mail-error.h Log Message: ----------- lib-storage: Add MAIL_ERROR_LIMIT Commit: a85cf0bdd86ba36e6f1243e9b6848a335625185b https://github.com/dovecot/core/commit/a85cf0bdd86ba36e6f1243e9b6848a335625185b Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-storage/index/index-sort-private.h M src/lib-storage/index/index-sort-string.c M src/lib-storage/index/index-sort.c M src/lib-storage/mail-storage-settings.c M src/lib-storage/mail-storage-settings.h Log Message: ----------- lib-storage: Add mail_sort_max_read_count setting. This controls how many slow mail accesses sorting can perform before it fails: a NO [LIMIT] Requested sort would have taken too long The SORT reply is still returned, but it's likely not correct. Commit: dfaf420c473c810fee33f515d08b888826dd57bd https://github.com/dovecot/core/commit/dfaf420c473c810fee33f515d08b888826dd57bd Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-storage/index/index-search.c M src/lib-storage/index/index-sort.c M src/lib-storage/mail-storage.h Log Message: ----------- lib-storage: Add mail.access_type Commit: a0cd302bcb827678f9c9c2ca1d0a3f0d3c0b3563 https://github.com/dovecot/core/commit/a0cd302bcb827678f9c9c2ca1d0a3f0d3c0b3563 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/doveadm/doveadm-mail.c M src/imap/imap-commands-util.c M src/lib-storage/index/index-mailbox-size.c M src/lib-storage/index/index-search.c M src/lib-storage/index/index-sort.c M src/lib-storage/mail-error.h M src/lib-storage/mail.c M src/pop3/pop3-client.c Log Message: ----------- lib-storage: Add explicit MAIL_ERROR_LOOKUP_ABORT error The MAIL_ERROR_NOTPOSSIBLE was a bit too generic to assume to mean the same thing. It doesn't look like there are any external plugins that break because of this change. Compare: https://github.com/dovecot/core/compare/2da176a0b105...a0cd302bcb82 From noreply at github.com Sun Feb 19 20:30:13 2017 From: noreply at github.com (GitHub) Date: Sun, 19 Feb 2017 12:30:13 -0800 Subject: [dovecot/core] 143ef7: dsync: Don't assert-crash if duplicate attributes ... Message-ID: <58aa00554d4e5_3b6f3fd5b5901c242275e3@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 143ef74e136d3bc9310d7e68e5e4988330ed79d8 https://github.com/dovecot/core/commit/143ef74e136d3bc9310d7e68e5e4988330ed79d8 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/doveadm/dsync/dsync-mailbox-export.c Log Message: ----------- dsync: Don't assert-crash if duplicate attributes are seen Just ignore the duplicates. Normally this shouldn't happen, but due to some bugs for example a Sieve script could be returned once by doveadm_sieve plugin and another time from mail_attribute_dict. Commit: db102ed2b1c0019528d93f24488727fccc3d5d9b https://github.com/dovecot/core/commit/db102ed2b1c0019528d93f24488727fccc3d5d9b Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-storage/mail-storage.h Log Message: ----------- lib-storage: Clarify what MAIL_LOOKUP_ABORT_READ_MAIL means. It should maybe even be renamed to something clearer. Commit: 0d736be21e55c83da316241d70c539f26fbe73b0 https://github.com/dovecot/core/commit/0d736be21e55c83da316241d70c539f26fbe73b0 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-storage/index/cydir/cydir-mail.c M src/lib-storage/index/dbox-multi/mdbox-mail.c M src/lib-storage/index/dbox-single/sdbox-mail.c M src/lib-storage/index/imapc/imapc-mail-fetch.c M src/lib-storage/index/index-mail.c M src/lib-storage/index/maildir/maildir-mail.c M src/lib-storage/index/mbox/mbox-mail.c M src/lib-storage/index/raw/raw-mail.c M src/lib-storage/mail-storage.h Log Message: ----------- lib-storage: Add mail.mail_stream_opened and .mail_metadata_accessed These allow determining after mail_*() calls how efficiently they were performed. Commit: 75673aa9437c359a48d1375f7e746119be8dee5c https://github.com/dovecot/core/commit/75673aa9437c359a48d1375f7e746119be8dee5c Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-storage/index/index-mailbox-size.c Log Message: ----------- lib-storage: Change vsize calculation to use the new mail_stream_opened This avoids calling mail_get_virtual_size() twice and is a bit cleaner approach. Commit: af01d7cd4555ee3a65d9c3c168a77f8fcc752c6d https://github.com/dovecot/core/commit/af01d7cd4555ee3a65d9c3c168a77f8fcc752c6d Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-storage/index/index-search.c M src/lib-storage/index/index-sort-private.h M src/lib-storage/index/index-sort-string.c M src/lib-storage/index/index-sort.c M src/lib-storage/index/index-sort.h Log Message: ----------- lib-storage: Fix error handling when sorting mails. All errors were treated the same as if message had been expunged. This caused potentially wrong results to be sent to the client without any indication that they're wrong. Commit: 61b952ff05745db4e5fd1232af2d9c801064e4c6 https://github.com/dovecot/core/commit/61b952ff05745db4e5fd1232af2d9c801064e4c6 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-storage/index/index-search.c Log Message: ----------- lib-storage: Search optimization - avoid parsing message_parts unnecessarily If they're not already cached, the mail is parsed twice: once to get the message_parts and again to perform the actual search. The searching can however do the message_parts parsing internally as well. Commit: f565008869032a411ed7e58c24a0d6505613f009 https://github.com/dovecot/core/commit/f565008869032a411ed7e58c24a0d6505613f009 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-storage/index/index-search.c Log Message: ----------- lib-storage: Fix error handling when searching mails Only expunge errors and failures caused by lookup_abort should be ignored. The rest of the mail errors mean that the search result might not be correct. We'll still run the search as fully as possible, but we just return an error at the end. Commit: 808dfbe3471b19ae983093119976ff914bc2ae2e https://github.com/dovecot/core/commit/808dfbe3471b19ae983093119976ff914bc2ae2e Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/imap/imap-search.c Log Message: ----------- imap: If SEARCH/SORT fails but returns some results, send them to client. The previous error handling fixes cause SEARCH/SORT to now fail if there are any problems reading mails. This change makes the commands still return the best known results, so the IMAP client can still use them, even though they may not be entirely correct. Commit: 8c96c6d2814ddbebe62da9fdc7882feb759e5f61 https://github.com/dovecot/core/commit/8c96c6d2814ddbebe62da9fdc7882feb759e5f61 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/doveadm/doveadm-mail.c M src/imap/imap-commands-util.c M src/lib-storage/index/dbox-multi/mdbox-map.c M src/lib-storage/index/imapc/imapc-storage.c M src/lib-storage/mail-error.h Log Message: ----------- lib-storage: Add MAIL_ERROR_LIMIT Commit: 89aff52c75b012dd13492e622b5cd5ca49f8f5af https://github.com/dovecot/core/commit/89aff52c75b012dd13492e622b5cd5ca49f8f5af Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-storage/index/index-sort-private.h M src/lib-storage/index/index-sort-string.c M src/lib-storage/index/index-sort.c M src/lib-storage/mail-storage-settings.c M src/lib-storage/mail-storage-settings.h Log Message: ----------- lib-storage: Add mail_sort_max_read_count setting. This controls how many slow mail accesses sorting can perform before it fails: a NO [LIMIT] Requested sort would have taken too long The SORT reply is still returned, but it's likely not correct. Commit: da29d3a047e3e3164acc2e5b1bffb2d8874e73aa https://github.com/dovecot/core/commit/da29d3a047e3e3164acc2e5b1bffb2d8874e73aa Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-storage/index/index-search.c M src/lib-storage/index/index-sort.c M src/lib-storage/mail-storage.h Log Message: ----------- lib-storage: Add mail.access_type Commit: 37038df03954425d19bc1b3b1470e7b013b3f4b9 https://github.com/dovecot/core/commit/37038df03954425d19bc1b3b1470e7b013b3f4b9 Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/doveadm/doveadm-mail.c M src/imap/imap-commands-util.c M src/lib-storage/index/index-mailbox-size.c M src/lib-storage/index/index-search.c M src/lib-storage/index/index-sort.c M src/lib-storage/mail-error.h M src/lib-storage/mail.c M src/pop3/pop3-client.c Log Message: ----------- lib-storage: Add explicit MAIL_ERROR_LOOKUP_ABORT error The MAIL_ERROR_NOTPOSSIBLE was a bit too generic to assume to mean the same thing. It doesn't look like there are any external plugins that break because of this change. Compare: https://github.com/dovecot/core/compare/bd612a097050...37038df03954 From noreply at github.com Sun Feb 19 21:30:10 2017 From: noreply at github.com (GitHub) Date: Sun, 19 Feb 2017 13:30:10 -0800 Subject: [dovecot/core] 89f6c7: auth: oauth2 mechanism: Fixed implicit boolean exp... Message-ID: <58aa0e62c0abb_2b13fbb12555c3c1553ea@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 89f6c7c1fa06abb88596c9b403adc9c079386a54 https://github.com/dovecot/core/commit/89f6c7c1fa06abb88596c9b403adc9c079386a54 Author: Stephan Bosch Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/auth/mech-oauth2.c Log Message: ----------- auth: oauth2 mechanism: Fixed implicit boolean expression involving a pointer. Found with Clang -Wstrict-bool. From noreply at github.com Sun Feb 19 21:30:15 2017 From: noreply at github.com (GitHub) Date: Sun, 19 Feb 2017 13:30:15 -0800 Subject: [dovecot/core] 2eaabe: auth: oauth2 mechanism: Fixed implicit boolean exp... Message-ID: <58aa0e677c8c5_8713f91c6cb9c3c20213f@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 2eaabeb416ed4c477e7ed6319b208ffe5851dc5c https://github.com/dovecot/core/commit/2eaabeb416ed4c477e7ed6319b208ffe5851dc5c Author: Stephan Bosch Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/auth/mech-oauth2.c Log Message: ----------- auth: oauth2 mechanism: Fixed implicit boolean expression involving a pointer. Found with Clang -Wstrict-bool. From noreply at github.com Sun Feb 19 22:30:12 2017 From: noreply at github.com (GitHub) Date: Sun, 19 Feb 2017 14:30:12 -0800 Subject: [dovecot/core] f789d8: lib-http: test-http-response-parse: Properly test ... Message-ID: <58aa1c74a5f8b_28a983fe408379c3c1047dc@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: f789d8efd919e0fae074f5d116c5100768ba754e https://github.com/dovecot/core/commit/f789d8efd919e0fae074f5d116c5100768ba754e Author: Stephan Bosch Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/lib-http/test-http-response-parser.c Log Message: ----------- lib-http: test-http-response-parse: Properly test multiple sequential responses. Commit: a78382ae8b94c1abcdf1af2256827aefa4b97a7b https://github.com/dovecot/core/commit/a78382ae8b94c1abcdf1af2256827aefa4b97a7b Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M .gitignore Log Message: ----------- .gitignore: Fixed location of ignored m4 files. Probably got cherry-picked wrong from development branch. Commit: 2a63de62c8ca0a04ce8805b72919f129e20aab60 https://github.com/dovecot/core/commit/2a63de62c8ca0a04ce8805b72919f129e20aab60 Author: Timo Sirainen Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-mail/istream-header-filter.c Log Message: ----------- lib-mail: Fix matched-parameter in HEADER_FILTER_ADD_MISSING_EOH callback The matched-parameter in the regular EOH callback is the reverse of what it's in v2.3 tree. So preserve it here. Compare: https://github.com/dovecot/core/compare/2eaabeb416ed...2a63de62c8ca From noreply at github.com Mon Feb 20 00:00:09 2017 From: noreply at github.com (GitHub) Date: Sun, 19 Feb 2017 16:00:09 -0800 Subject: [dovecot/core] 263e42: example-config: Add imap_fetch_failure setting. Message-ID: <58aa31899fee3_28dbf3fd194e31c3c277181@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 263e4212e599da3e9aa8f6090112de889f81c021 https://github.com/dovecot/core/commit/263e4212e599da3e9aa8f6090112de889f81c021 Author: Timo Sirainen Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M doc/example-config/conf.d/20-imap.conf Log Message: ----------- example-config: Add imap_fetch_failure setting. Commit: e76721e637d1926e42d05c73377f1e61788c92cf https://github.com/dovecot/core/commit/e76721e637d1926e42d05c73377f1e61788c92cf Author: Timo Sirainen Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M doc/example-config/conf.d/10-mail.conf Log Message: ----------- example-config: Add mail_vsize_bg_after_count setting. Commit: d1ab4c39b19512a0a389bbab88e4cbf3dd89f2bd https://github.com/dovecot/core/commit/d1ab4c39b19512a0a389bbab88e4cbf3dd89f2bd Author: Timo Sirainen Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M doc/example-config/conf.d/10-mail.conf Log Message: ----------- example-config: Add mail_sort_max_read_count setting. Compare: https://github.com/dovecot/core/compare/89f6c7c1fa06...d1ab4c39b195 From noreply at github.com Mon Feb 20 00:00:14 2017 From: noreply at github.com (GitHub) Date: Sun, 19 Feb 2017 16:00:14 -0800 Subject: [dovecot/core] 9ba287: example-config: Add imap_fetch_failure setting. Message-ID: <58aa318e45224_196f3fe5261d5c2c13240@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 9ba287ff8b273ebea6d1dcfe5e00619dbaf7c400 https://github.com/dovecot/core/commit/9ba287ff8b273ebea6d1dcfe5e00619dbaf7c400 Author: Timo Sirainen Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M doc/example-config/conf.d/20-imap.conf Log Message: ----------- example-config: Add imap_fetch_failure setting. Commit: f6d5c0771fc60c413bae644dbbdef64c81328ca7 https://github.com/dovecot/core/commit/f6d5c0771fc60c413bae644dbbdef64c81328ca7 Author: Timo Sirainen Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M doc/example-config/conf.d/10-mail.conf Log Message: ----------- example-config: Add mail_vsize_bg_after_count setting. Commit: 8f42a894931f657a449ff7173b09d7c6d3f43c34 https://github.com/dovecot/core/commit/8f42a894931f657a449ff7173b09d7c6d3f43c34 Author: Timo Sirainen Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M doc/example-config/conf.d/10-mail.conf Log Message: ----------- example-config: Add mail_sort_max_read_count setting. Compare: https://github.com/dovecot/core/compare/2a63de62c8ca...8f42a894931f From noreply at github.com Mon Feb 20 09:30:10 2017 From: noreply at github.com (GitHub) Date: Mon, 20 Feb 2017 01:30:10 -0800 Subject: [dovecot/core] 74bc7e: Partially implemented IMAP SEARCH=X-MIMEPART capab... Message-ID: <58aab7225353b_16053fcdf558dc40226846@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 74bc7e646663255703e10e0c0b7242ad7ad52f94 https://github.com/dovecot/core/commit/74bc7e646663255703e10e0c0b7242ad7ad52f94 Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-storage/Makefile.am M src/lib-storage/index/Makefile.am M src/lib-storage/index/imapc/imapc-search.c A src/lib-storage/index/index-search-mime.c M src/lib-storage/index/index-search-private.h M src/lib-storage/index/index-search.c M src/lib-storage/mail-search-args-cmdline.c M src/lib-storage/mail-search-args-imap.c A src/lib-storage/mail-search-mime-build.c A src/lib-storage/mail-search-mime-build.h A src/lib-storage/mail-search-mime-register.c A src/lib-storage/mail-search-mime-register.h A src/lib-storage/mail-search-mime.c A src/lib-storage/mail-search-mime.h M src/lib-storage/mail-search-register-imap.c M src/lib-storage/mail-search.c M src/lib-storage/mail-search.h M src/lib-storage/mail-storage.c M src/lib-storage/test-mail-search-args-imap.c Log Message: ----------- Partially implemented IMAP SEARCH=X-MIMEPART capability. This capability is currently Dovecot-specific. From noreply at github.com Mon Feb 20 09:30:15 2017 From: noreply at github.com (GitHub) Date: Mon, 20 Feb 2017 01:30:15 -0800 Subject: [dovecot/core] d02959: lib-imap: imap-bodystructure: Fixed parse error me... Message-ID: <58aab7279a3a7_8713f91c6cb9c3c20459c@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: d02959f7619c798929c9bfc7257b948cc0e50906 https://github.com/dovecot/core/commit/d02959f7619c798929c9bfc7257b948cc0e50906 Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/imap-bodystructure.c Log Message: ----------- lib-imap: imap-bodystructure: Fixed parse error message about invalid Content-M5 field. Commit: f4b7f88d77e2ee96bc15906b3ee6425cbb4e4986 https://github.com/dovecot/core/commit/f4b7f88d77e2ee96bc15906b3ee6425cbb4e4986 Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/test-imap-bodystructure.c Log Message: ----------- lib-imap: test-imap-bodystructure: Added support for more than one test case. Commit: de68ecd1262ecf3a54fdab43b9e96d1ae448c217 https://github.com/dovecot/core/commit/de68ecd1262ecf3a54fdab43b9e96d1ae448c217 Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/test-imap-bodystructure.c Log Message: ----------- lib-imap: test-imap-bodystructure: Improved handing of parse errors. Actually show the parse error. Commit: c0e62470fcfc331fe6049c211a28adb79a1f1144 https://github.com/dovecot/core/commit/c0e62470fcfc331fe6049c211a28adb79a1f1144 Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/test-imap-bodystructure.c Log Message: ----------- lib-imap: test-imap-bodystructure: Added more tests. Commit: 78915da1044c189dfdcfb6267541e57256c7fe43 https://github.com/dovecot/core/commit/78915da1044c189dfdcfb6267541e57256c7fe43 Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/imap-bodystructure.c Log Message: ----------- lib-imap: imap-bodystructure: Allow alternative syntax and omitted optional elements in parser input. This makes the parser accept any RFC-compliant BODYSTRUCTURE syntax, instead of only what Dovecot itself produces. This way the parser could reliably be used in the lib-imap-client if ever needed. Commit: f507f8b3f98982343639b93d6985221d29452544 https://github.com/dovecot/core/commit/f507f8b3f98982343639b93d6985221d29452544 Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/test-imap-bodystructure.c Log Message: ----------- lib-imap: test-imap-bodystructure: Added normalization tests. Commit: 5dc17f032d0e3b1586a87c0762c3aab4562a2d18 https://github.com/dovecot/core/commit/5dc17f032d0e3b1586a87c0762c3aab4562a2d18 Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/imap-envelope.c M src/lib-imap/imap-envelope.h Log Message: ----------- lib-imap: Removed existing envelope parsing function. This is currently only used by imaptest. Alternative API is provided in later commit. Commit: d61ce13155d8adb7144a3e2dd972931c2f7d4e2d https://github.com/dovecot/core/commit/d61ce13155d8adb7144a3e2dd972931c2f7d4e2d Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/imap-bodystructure.c M src/lib-imap/imap-bodystructure.h M src/lib-storage/index/index-mail.c Log Message: ----------- lib-imap: imap-bodystructure: Renamed struct message_part_body_data to message_part_data. Commit: 50ace8c615b92679eac0e4002ce22f56b83e9a4b https://github.com/dovecot/core/commit/50ace8c615b92679eac0e4002ce22f56b83e9a4b Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/imap-bodystructure.c M src/lib-imap/imap-bodystructure.h M src/lib-mail/message-part.h M src/lib-storage/index/index-mail.c Log Message: ----------- lib-mail: Gave message_part_data its own field in struct message_part. Commit: 34d2e3c6161dc9e0bf65174c2dad0824305a643d https://github.com/dovecot/core/commit/34d2e3c6161dc9e0bf65174c2dad0824305a643d Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/imap-bodystructure.c M src/lib-imap/imap-bodystructure.h Log Message: ----------- lib-imap: imap-bodystructure: Removed useless pool field from struct message_part_data. Commit: ee7da9a084b67ef8172d55b7dd4cd7462b2f81e4 https://github.com/dovecot/core/commit/ee7da9a084b67ef8172d55b7dd4cd7462b2f81e4 Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/imap-envelope.c Log Message: ----------- lib-imap: imap-envelope: Removed useless pool field from struct message_part_envelope_data. Commit: d6790cf6f1a25fa2effda0139754437494c20971 https://github.com/dovecot/core/commit/d6790cf6f1a25fa2effda0139754437494c20971 Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/imap-bodystructure.c Log Message: ----------- lib-imap: imap-bodystructure: Renamed `d' parameter to `data' in parse_content_header() function. Commit: 3a39bcd37876306247376e56a44ad6e710469aaf https://github.com/dovecot/core/commit/3a39bcd37876306247376e56a44ad6e710469aaf Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/imap-envelope.c M src/lib-imap/imap-envelope.h Log Message: ----------- lib-imap: imap-envelope: Added function to parse struct message_part_envelope_data from parsed imap args. Commit: b1cb88c940de95a0f478aaab244e4cbe011b08f4 https://github.com/dovecot/core/commit/b1cb88c940de95a0f478aaab244e4cbe011b08f4 Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/imap-bodystructure.c M src/lib-imap/imap-bodystructure.h M src/lib-imap/imap-envelope.c M src/lib-storage/index/index-mail.c Log Message: ----------- lib-imap: imap-bodystructure: Changed struct message_part_body to contain fully decoded data. Contained unparsed IMAP string data before. Commit: edb00165e9c50cfc8f434795e86007812fea54c0 https://github.com/dovecot/core/commit/edb00165e9c50cfc8f434795e86007812fea54c0 Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/imap-bodystructure.c Log Message: ----------- lib-imap: imap-bodystructure: Grouped together functions relating to the conversion of BODYSTRUCTURE to BODY. This only moves code. Commit: 4861794616cc76b67281bec67a77718c8f1fe12a https://github.com/dovecot/core/commit/4861794616cc76b67281bec67a77718c8f1fe12a Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/imap-bodystructure.c M src/lib-imap/imap-bodystructure.h M src/lib-imap/test-imap-bodystructure.c M src/lib-storage/index/index-mail-headers.c M src/lib-storage/index/index-mail.c Log Message: ----------- lib-imap: imap-bodystructure: Renamed imap_bodystructure_parse_header() to message_part_data_parse_from_header(). Commit: b3fe91a5336bd78e5ba4a57cd8a0a3f83003910a https://github.com/dovecot/core/commit/b3fe91a5336bd78e5ba4a57cd8a0a3f83003910a Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/imap-envelope.c M src/lib-imap/imap-envelope.h Log Message: ----------- lib-imap: imap-evenvelope: Changed imap_envelope_get_field() into a private equivalent. Commit: ecc6feecadb2fb47bbc80d09b0c5c4083021a23c https://github.com/dovecot/core/commit/ecc6feecadb2fb47bbc80d09b0c5c4083021a23c Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/imap-bodystructure.c M src/lib-imap/imap-envelope.c M src/lib-imap/imap-envelope.h M src/lib-storage/index/index-mail-headers.c Log Message: ----------- lib-imap: imap-envelope: Renamed imap_envelope_parse_header() to message_part_envelope_parse_from_header(). Commit: efe512ef167a6a76435826fa9bad01a85a8e68e9 https://github.com/dovecot/core/commit/efe512ef167a6a76435826fa9bad01a85a8e68e9 Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/imap-bodystructure.c M src/lib-imap/imap-bodystructure.h M src/lib-storage/index/index-mail.c Log Message: ----------- lib-imap: imap-bodystructure: Renamed imap_bodystructure_is_plain_7bit() to message_part_data_is_plain_7bit(). Commit: 11b1d8cc8993fa54512cc4a29f698707e8be979b https://github.com/dovecot/core/commit/11b1d8cc8993fa54512cc4a29f698707e8be979b Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/imap-bodystructure.c M src/lib-imap/imap-bodystructure.h M src/lib-imap/imap-envelope.c M src/lib-imap/imap-envelope.h M src/lib-imap/test-imap-bodystructure.c M src/lib-mail/Makefile.am A src/lib-mail/message-part-data.c A src/lib-mail/message-part-data.h M src/lib-storage/index/index-mail-headers.c M src/lib-storage/index/index-mail.c Log Message: ----------- lib-imap: imap-bodystructure: Moved message_part_data header parsing and query functions to their own module in lib-mail. Moved code from imap-bodystructure and imap-envelope. Commit: e1ee210f9c7ca91eed72d7158d2b55f64e1eaef3 https://github.com/dovecot/core/commit/e1ee210f9c7ca91eed72d7158d2b55f64e1eaef3 Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/imap-envelope.c M src/lib-imap/imap-envelope.h M src/lib-mail/message-part-data.c M src/lib-mail/message-part-data.h M src/lib-storage/index/imapc/imapc-mail.c M src/lib-storage/index/index-mail-headers.c Log Message: ----------- lib-imap: imap-envelope: Moved imap_envelope_headers to lib-mail/message-part-data as message_part_envelope_headers. Commit: 353ee3a324d0bbd7d2cffc1c49f31305441ecf10 https://github.com/dovecot/core/commit/353ee3a324d0bbd7d2cffc1c49f31305441ecf10 Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/imap-bodystructure.c M src/lib-imap/imap-envelope.c M src/lib-imap/imap-envelope.h M src/lib-mail/message-part-data.c M src/lib-mail/message-part-data.h M src/lib-storage/index/index-mail-headers.c M src/lib-storage/index/index-mail.h Log Message: ----------- lib-mail: message-part-data: Renamed struct message_part_envelope_data to message_part_envelope. Commit: 40216e40c93a3f24e302083554589d7937cf4e74 https://github.com/dovecot/core/commit/40216e40c93a3f24e302083554589d7937cf4e74 Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-mail/message-part-data.c M src/lib-mail/message-part-data.h Log Message: ----------- lib-mail: message-part-data: Implemented message_part_data_get_filename(). Gets the message part's filename if it has any. Commit: d669f7624a89d1c49d91c6477e806f1d90ce70a2 https://github.com/dovecot/core/commit/d669f7624a89d1c49d91c6477e806f1d90ce70a2 Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/imap-bodystructure.c M src/lib-imap/imap-bodystructure.h M src/lib-imap/test-imap-bodystructure.c Log Message: ----------- lib-imap: imap-bodystructure: Added support for making imap_bodystructure_parse() work without a pre-existing message_part tree. It can now create the tree from the BODYSTRUCTURE string itself. Commit: e0837a5f0f21a03a85c103c817c01940ba594b4c https://github.com/dovecot/core/commit/e0837a5f0f21a03a85c103c817c01940ba594b4c Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/imap-bodystructure.c M src/lib-imap/imap-envelope.c Log Message: ----------- lib-imap: Added more comments to imap-bodystructure and imap-envelope. Commit: 097940bf9a03af7a2585ebbf9980aa81afb774b4 https://github.com/dovecot/core/commit/097940bf9a03af7a2585ebbf9980aa81afb774b4 Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/imap-envelope.c M src/lib-imap/imap-envelope.h Log Message: ----------- lib-imap: imap-envelope: Added function for parsing ENVELOPE from string. Commit: f884f1b00a7d6babe0f0e84361bd3297650f3c01 https://github.com/dovecot/core/commit/f884f1b00a7d6babe0f0e84361bd3297650f3c01 Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-imap/Makefile.am A src/lib-imap/test-imap-envelope.c Log Message: ----------- lib-imap: Created test-imap-envelope. Commit: 2b6a62144a3613cb833bfdc9129b10bac588a5ed https://github.com/dovecot/core/commit/2b6a62144a3613cb833bfdc9129b10bac588a5ed Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-storage/Makefile.am M src/lib-storage/index/Makefile.am M src/lib-storage/index/imapc/imapc-search.c A src/lib-storage/index/index-search-mime.c M src/lib-storage/index/index-search-private.h M src/lib-storage/index/index-search.c M src/lib-storage/mail-search-args-cmdline.c M src/lib-storage/mail-search-args-imap.c A src/lib-storage/mail-search-mime-build.c A src/lib-storage/mail-search-mime-build.h A src/lib-storage/mail-search-mime-register.c A src/lib-storage/mail-search-mime-register.h A src/lib-storage/mail-search-mime.c A src/lib-storage/mail-search-mime.h M src/lib-storage/mail-search-register-imap.c M src/lib-storage/mail-search.c M src/lib-storage/mail-search.h M src/lib-storage/mail-storage.c M src/lib-storage/test-mail-search-args-imap.c Log Message: ----------- Partially implemented IMAP SEARCH=X-MIMEPART capability. This capability is currently Dovecot-specific. Compare: https://github.com/dovecot/core/compare/8f42a894931f...2b6a62144a36 From noreply at github.com Mon Feb 20 09:34:33 2017 From: noreply at github.com (GitHub) Date: Mon, 20 Feb 2017 01:34:33 -0800 Subject: [dovecot/core] 9049fe: v2.2.28.rc1 released Message-ID: <58aab8299fa9e_10663fc6493edc401685ab@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/release-2.2.28 Home: https://github.com/dovecot/core Commit: 9049fe4442d693b9fb3b3aa56999ae372b98e496 https://github.com/dovecot/core/commit/9049fe4442d693b9fb3b3aa56999ae372b98e496 Author: Timo Sirainen Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M NEWS M configure.ac Log Message: ----------- v2.2.28.rc1 released From noreply at github.com Mon Feb 20 10:00:12 2017 From: noreply at github.com (GitHub) Date: Mon, 20 Feb 2017 02:00:12 -0800 Subject: [dovecot/core] ec3eb5: pop3c: Add no pipelining pop3c feature Message-ID: <58aabe2c7c6b3_17593f89136f3c3c216033@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: ec3eb53293a282b409fe128153038522c294dda3 https://github.com/dovecot/core/commit/ec3eb53293a282b409fe128153038522c294dda3 Author: Aki Tuomi Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-storage/index/pop3c/pop3c-client.c M src/lib-storage/index/pop3c/pop3c-client.h M src/lib-storage/index/pop3c/pop3c-mail.c M src/lib-storage/index/pop3c/pop3c-settings.c M src/lib-storage/index/pop3c/pop3c-settings.h M src/lib-storage/index/pop3c/pop3c-storage.c Log Message: ----------- pop3c: Add no pipelining pop3c feature This should help with certain broken pop3c servers that advertise that they support pipelining but they really don't. From noreply at github.com Mon Feb 20 10:00:17 2017 From: noreply at github.com (GitHub) Date: Mon, 20 Feb 2017 02:00:17 -0800 Subject: [dovecot/core] d49715: pop3c: Add no pipelining pop3c feature Message-ID: <58aabe3149a6f_20f23fe6113bbc30232110@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: d4971519118499b56c47a0a78ce199237e858dd8 https://github.com/dovecot/core/commit/d4971519118499b56c47a0a78ce199237e858dd8 Author: Aki Tuomi Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-storage/index/pop3c/pop3c-client.c M src/lib-storage/index/pop3c/pop3c-client.h M src/lib-storage/index/pop3c/pop3c-mail.c M src/lib-storage/index/pop3c/pop3c-settings.c M src/lib-storage/index/pop3c/pop3c-settings.h M src/lib-storage/index/pop3c/pop3c-storage.c Log Message: ----------- pop3c: Add no pipelining pop3c feature This should help with certain broken pop3c servers that advertise that they support pipelining but they really don't. From noreply at github.com Mon Feb 20 12:30:14 2017 From: noreply at github.com (GitHub) Date: Mon, 20 Feb 2017 04:30:14 -0800 Subject: [dovecot/core] fc036d: imap: Revert change to use [PARSE] in FETCH replie... Message-ID: <58aae156eb86b_1a903fc403bc7c382028d9@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: fc036db1a472d46671807283cc0d7661ec7e3914 https://github.com/dovecot/core/commit/fc036db1a472d46671807283cc0d7661ec7e3914 Author: Timo Sirainen Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/imap/cmd-fetch.c Log Message: ----------- imap: Revert change to use [PARSE] in FETCH replies. Lets leave this for v2.3. Apparently Roundcube has some workarounds that assume [UNKNOWNCTE]. Partially reverts 8fe64e2af5b6ce7b6ffa6453beaf569dca089e59 From noreply at github.com Mon Feb 20 13:00:12 2017 From: noreply at github.com (GitHub) Date: Mon, 20 Feb 2017 05:00:12 -0800 Subject: [dovecot/core] b31760: lib-compression: Fix test-compression to build wit... Message-ID: <58aae85c6c5d2_284af3fd9826ddc381873a4@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: b317602a1dd7588710bd004404cd68cf2d699361 https://github.com/dovecot/core/commit/b317602a1dd7588710bd004404cd68cf2d699361 Author: Timo Sirainen Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-compression/test-compression.c Log Message: ----------- lib-compression: Fix test-compression to build without zlib Commit: 2b8ff102f5117f917248f98ccbdc8e6a6af83c87 https://github.com/dovecot/core/commit/2b8ff102f5117f917248f98ccbdc8e6a6af83c87 Author: Aki Tuomi Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-index/mail-index-transaction-private.h M src/lib-index/mail-index-transaction.c Log Message: ----------- lib-index: Allow multiple hooks for transaction creation Compare: https://github.com/dovecot/core/compare/ec3eb53293a2...2b8ff102f511 From noreply at github.com Mon Feb 20 13:00:17 2017 From: noreply at github.com (GitHub) Date: Mon, 20 Feb 2017 05:00:17 -0800 Subject: [dovecot/core] e0a5e6: lib-compression: Fix test-compression to build wit... Message-ID: <58aae861543e9_8c03fd98f3c7c44245599@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: e0a5e6b35c573aea864194fa10da18e344e5fdbd https://github.com/dovecot/core/commit/e0a5e6b35c573aea864194fa10da18e344e5fdbd Author: Timo Sirainen Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-compression/test-compression.c Log Message: ----------- lib-compression: Fix test-compression to build without zlib From noreply at github.com Mon Feb 20 13:30:10 2017 From: noreply at github.com (GitHub) Date: Mon, 20 Feb 2017 05:30:10 -0800 Subject: [dovecot/core] 23070c: lib-lda: Do not involve mail-deliver plugin unnece... Message-ID: <58aaef622301a_28e873f8e8d1d9c402273c3@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 23070cb7c58e32af755dae0426493608a28a4209 https://github.com/dovecot/core/commit/23070cb7c58e32af755dae0426493608a28a4209 Author: Aki Tuomi Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Do not involve mail-deliver plugin unnecessarely If no mail delivery by LDA/LMTP is being done, do not hook into the process. Fixes signal 11 crash with lazy-expunge. From noreply at github.com Mon Feb 20 14:30:15 2017 From: noreply at github.com (GitHub) Date: Mon, 20 Feb 2017 06:30:15 -0800 Subject: [dovecot/core] 522951: lib-lda: Do not involve mail-deliver plugin unnece... Message-ID: <58aafd7728c57_1dc43fea04e01c342704da@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 522951a21d41ac283273b523d8c52403459cc2d1 https://github.com/dovecot/core/commit/522951a21d41ac283273b523d8c52403459cc2d1 Author: Aki Tuomi Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Do not involve mail-deliver plugin unnecessarely If no mail delivery by LDA/LMTP is being done, do not hook into the process. Fixes signal 11 crash with lazy-expunge. From noreply at github.com Mon Feb 20 18:00:10 2017 From: noreply at github.com (GitHub) Date: Mon, 20 Feb 2017 10:00:10 -0800 Subject: [dovecot/core] 6004fd: lib,lib-storage: Move hook building code to lib Message-ID: <58ab2eaab6ddc_1aec3fc0c12f7c241826f5@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 6004fdf3cc8fe87a6c35ce297d39ab68feb707b0 https://github.com/dovecot/core/commit/6004fdf3cc8fe87a6c35ce297d39ab68feb707b0 Author: Aki Tuomi Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-storage/mail-storage-hooks.c M src/lib/Makefile.am A src/lib/hook-build.c A src/lib/hook-build.h Log Message: ----------- lib,lib-storage: Move hook building code to lib This allows it to be reused elsewhere Commit: 26e5bdf37d7d0deed1e2e8483366c83631b9d251 https://github.com/dovecot/core/commit/26e5bdf37d7d0deed1e2e8483366c83631b9d251 Author: Aki Tuomi Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-index/mail-index-transaction-private.h M src/lib-index/mail-index-transaction.c Log Message: ----------- lib-index: Add missing initialization for chained hooks Commit: a102d189881a35d72ac3106a9e7e00577ae69310 https://github.com/dovecot/core/commit/a102d189881a35d72ac3106a9e7e00577ae69310 Author: Aki Tuomi Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-index/mail-index-transaction-private.h M src/lib-index/mail-index-transaction.c Log Message: ----------- lib-index: Unconstifty pointer array clang complained about the extra const. Compare: https://github.com/dovecot/core/compare/23070cb7c58e...a102d189881a From noreply at github.com Mon Feb 20 22:19:50 2017 From: noreply at github.com (GitHub) Date: Mon, 20 Feb 2017 14:19:50 -0800 Subject: [dovecot/pigeonhole] Message-ID: <58ab6b864741_6513fa789a7bc30138042@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/tags/0.4.17.rc1 Home: https://github.com/dovecot/pigeonhole From noreply at github.com Mon Feb 20 22:19:50 2017 From: noreply at github.com (GitHub) Date: Mon, 20 Feb 2017 14:19:50 -0800 Subject: [dovecot/pigeonhole] 38750f: imapsieve plugin: Removed spurious pool field from... Message-ID: <58ab6b8616b4f_2103fc18f471c3418141f@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/tags/dovecot-ee-2.2.25.5-12 Home: https://github.com/dovecot/pigeonhole Commit: 38750f9b5196da4891be304dae856bf522e12f29 https://github.com/dovecot/pigeonhole/commit/38750f9b5196da4891be304dae856bf522e12f29 Author: Stephan Bosch Date: 2016-08-10 (Wed, 10 Aug 2016) Changed paths: M src/plugins/imapsieve/imap-sieve-storage.c Log Message: ----------- imapsieve plugin: Removed spurious pool field from imap_sieve_user struct. Commit: 147a0eac2ca3c12760a447928a337e42f9a2eef8 https://github.com/dovecot/pigeonhole/commit/147a0eac2ca3c12760a447928a337e42f9a2eef8 Author: Stephan Bosch Date: 2016-08-10 (Wed, 10 Aug 2016) Changed paths: M src/plugins/imapsieve/imap-sieve-storage.c Log Message: ----------- imapsieve plugin: Fixed crash occurring when a mailbox is opened for a user before the imap client object is created. Commit: c3d763cbc98ba45ebb8ba7045e6e19a00a67a94e https://github.com/dovecot/pigeonhole/commit/c3d763cbc98ba45ebb8ba7045e6e19a00a67a94e Author: Stephan Bosch Date: 2016-08-23 (Tue, 23 Aug 2016) Changed paths: M src/sieve-tools/sieve-test.c Log Message: ----------- sieve-test: Forgot to disable error handling for dummy SMTP output stream. Commit: 145b2901bd00e5eeef565f262842a902cb9fc3a6 https://github.com/dovecot/pigeonhole/commit/145b2901bd00e5eeef565f262842a902cb9fc3a6 Author: Timo Sirainen Date: 2016-08-23 (Tue, 23 Aug 2016) Changed paths: M src/lib-sieve-tool/mail-raw.c M src/lib-sieve/storage/file/sieve-file-storage-active.c M src/lib-sieve/storage/file/sieve-file-storage-save.c M src/lib-sieve/util/program-client.c M src/sieve-tools/sieve-test.c Log Message: ----------- Use i_unlink() to improve unexpected unlink() error messages. Commit: 6f71a1fb4aa5d1052d2cc3c47f042c6a4bf1317e https://github.com/dovecot/pigeonhole/commit/6f71a1fb4aa5d1052d2cc3c47f042c6a4bf1317e Author: Stephan Bosch Date: 2016-08-23 (Tue, 23 Aug 2016) Changed paths: M src/lib-sieve/util/program-client.c Log Message: ----------- lib-sieve: util: program-client: Fixed position of the seekable stream for the output of remote programs. It would now make the output of the script service seekable, rather than the output of the program. This adds a '+' at the end of the data. This showed up for the extprograms filter command. Commit: 8bb051ee186b8c0ad2c5e676999a1a3c0900b102 https://github.com/dovecot/pigeonhole/commit/8bb051ee186b8c0ad2c5e676999a1a3c0900b102 Author: Stephan Bosch Date: 2016-08-30 (Tue, 30 Aug 2016) Changed paths: M src/plugins/doveadm-sieve/doveadm-sieve-sync.c Log Message: ----------- doveadm sieve plugin: sync: Fixed handling of unknown attribute timestamps. Compare: https://github.com/dovecot/pigeonhole/compare/38750f9b5196^...8bb051ee186b From noreply at github.com Mon Feb 20 22:19:49 2017 From: noreply at github.com (GitHub) Date: Mon, 20 Feb 2017 14:19:49 -0800 Subject: [dovecot/pigeonhole] 362f0a: doveadm-sieve: Fix crash when setting Sieve script... Message-ID: <58ab6b8579000_28dcd3ff9796d3c301897b9@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/release-0.4.17 Home: https://github.com/dovecot/pigeonhole Commit: 362f0a45e9b30bad4b601fd0ecbd3a141888719d https://github.com/dovecot/pigeonhole/commit/362f0a45e9b30bad4b601fd0ecbd3a141888719d Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/plugins/doveadm-sieve/doveadm-sieve-sync.c Log Message: ----------- doveadm-sieve: Fix crash when setting Sieve script via attribute's string value. Commit: 91ab251fd5563d8d87cb6435d71e9568232f933a https://github.com/dovecot/pigeonhole/commit/91ab251fd5563d8d87cb6435d71e9568232f933a Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M NEWS Log Message: ----------- Added v0.4.16 to NEWS. Commit: e1793786d87b6dafe46bfc44302815363d99e83a https://github.com/dovecot/pigeonhole/commit/e1793786d87b6dafe46bfc44302815363d99e83a Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M NEWS M configure.ac Log Message: ----------- Released v0.4.17.rc1 for Dovecot v2.2.28.rc1. Compare: https://github.com/dovecot/pigeonhole/compare/362f0a45e9b3^...e1793786d87b From noreply at github.com Tue Feb 21 10:30:13 2017 From: noreply at github.com (GitHub) Date: Tue, 21 Feb 2017 02:30:13 -0800 Subject: [dovecot/core] 177056: lib-oauth2: Support basic authorization Message-ID: <58ac16b588cd1_1fc23f96a00c5c30179311@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 177056ea9a79be1c782e4bb8558adf4dc87f2fec https://github.com/dovecot/core/commit/177056ea9a79be1c782e4bb8558adf4dc87f2fec Author: Aki Tuomi Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-oauth2/oauth2-introspect.c M src/lib-oauth2/oauth2-refresh.c M src/lib-oauth2/oauth2-token-validate.c Log Message: ----------- lib-oauth2: Support basic authorization Commit: 6a986052e4117b17ce5262fd17d5f129d6c110a1 https://github.com/dovecot/core/commit/6a986052e4117b17ce5262fd17d5f129d6c110a1 Author: Aki Tuomi Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- auth: Make tokeninfo optional It is not supported by all OAuth2 solutions Commit: 54cad0e500538268c18cd5c6d92834c1f6c61dcd https://github.com/dovecot/core/commit/54cad0e500538268c18cd5c6d92834c1f6c61dcd Author: Aki Tuomi Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- auth: Make sure tokeninfo or introspection URL is given Compare: https://github.com/dovecot/core/compare/a102d189881a...54cad0e50053 From noreply at github.com Tue Feb 21 11:00:11 2017 From: noreply at github.com (GitHub) Date: Tue, 21 Feb 2017 03:00:11 -0800 Subject: [dovecot/core] 4d690a: lib-storage, pop3-migration: Reset lookup_abort be... Message-ID: <58ac1dbb42063_253b3fb363e1bc3824245f@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 4d690a42c4dd10d6508e499c5bab58c45a49d1f3 https://github.com/dovecot/core/commit/4d690a42c4dd10d6508e499c5bab58c45a49d1f3 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-storage/index/index-mailbox-size.c M src/plugins/pop3-migration/pop3-migration-plugin.c Log Message: ----------- lib-storage, pop3-migration: Reset lookup_abort before continuing to search This doesn't really fix anything right now, but it'll allow adding the asserts in the following commit. Commit: bc315b1595bd49edf0e8acf46828999fe1153f92 https://github.com/dovecot/core/commit/bc315b1595bd49edf0e8acf46828999fe1153f92 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-storage/index/index-search.c M src/lib-storage/index/index-sort.c Log Message: ----------- lib-storage: Add asserts to make sure lookup_abort is being used correctly. Compare: https://github.com/dovecot/core/compare/54cad0e50053...bc315b1595bd From noreply at github.com Tue Feb 21 11:00:16 2017 From: noreply at github.com (GitHub) Date: Tue, 21 Feb 2017 03:00:16 -0800 Subject: [dovecot/core] 3fe1b9: lib-oauth2: Support basic authorization Message-ID: <58ac1dc064b56_28e873f8e8d1d9c4024697b@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 3fe1b915d8b62b6be828e7c2f224b926f2730c52 https://github.com/dovecot/core/commit/3fe1b915d8b62b6be828e7c2f224b926f2730c52 Author: Aki Tuomi Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-oauth2/oauth2-introspect.c M src/lib-oauth2/oauth2-refresh.c M src/lib-oauth2/oauth2-token-validate.c Log Message: ----------- lib-oauth2: Support basic authorization Commit: 7a5813e4e0c362eaa5e38575db931a924a7a828b https://github.com/dovecot/core/commit/7a5813e4e0c362eaa5e38575db931a924a7a828b Author: Aki Tuomi Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- auth: Make tokeninfo optional It is not supported by all OAuth2 solutions Commit: 7a765d42a29eead7e0323ebceedca644b857a599 https://github.com/dovecot/core/commit/7a765d42a29eead7e0323ebceedca644b857a599 Author: Aki Tuomi Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- auth: Make sure tokeninfo or introspection URL is given Compare: https://github.com/dovecot/core/compare/522951a21d41...7a765d42a29e From noreply at github.com Tue Feb 21 11:30:10 2017 From: noreply at github.com (GitHub) Date: Tue, 21 Feb 2017 03:30:10 -0800 Subject: [dovecot/core] 179099: lib-storage: Fix assert-crash on corrupted dovecot... Message-ID: <58ac24c2c44f9_253d3fcd4633bc44212947@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 17909931dcd1ba72ba223276901d4acd360b1038 https://github.com/dovecot/core/commit/17909931dcd1ba72ba223276901d4acd360b1038 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-storage/list/mailbox-list-index.c Log Message: ----------- lib-storage: Fix assert-crash on corrupted dovecot.list.index with name_id==0 Fixes: Panic: file hash.c: line 213 (hash_table_insert_node): assertion failed: (key != NULL) From noreply at github.com Tue Feb 21 12:00:11 2017 From: noreply at github.com (GitHub) Date: Tue, 21 Feb 2017 04:00:11 -0800 Subject: [dovecot/core] 7c04ed: cassandra: Don't use i_error() from non-main threa... Message-ID: <58ac2bcb37a33_10913fd544e75c4413098b@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 7c04ede0da5749691624a1fb962ac29cd0167050 https://github.com/dovecot/core/commit/7c04ede0da5749691624a1fb962ac29cd0167050 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-sql/driver-cassandra.c Log Message: ----------- cassandra: Don't use i_error() from non-main thread It will only cause crashes. This was done only if the internal communication pipe couldn't be written to, which was pretty unlikely to happen. From noreply at github.com Tue Feb 21 12:30:10 2017 From: noreply at github.com (GitHub) Date: Tue, 21 Feb 2017 04:30:10 -0800 Subject: [dovecot/core] d03980: lmtp: Fix lmtp_user_concurrency_limit when userdb ... Message-ID: <58ac32d2e4961_18523f8a7a183c30140292@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: d03980c62bca1d8501d67e5cf3b6f9904d166dd4 https://github.com/dovecot/core/commit/d03980c62bca1d8501d67e5cf3b6f9904d166dd4 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lmtp/commands.c Log Message: ----------- lmtp: Fix lmtp_user_concurrency_limit when userdb changes the username Anvil LOOKUP was done with the original username, while CONNECT/DISCONNECT was done with the changed username. So LOOKUP always thought that there were zero concurrent sessions for the user. From noreply at github.com Tue Feb 21 13:00:11 2017 From: noreply at github.com (GitHub) Date: Tue, 21 Feb 2017 05:00:11 -0800 Subject: [dovecot/core] f86436: lib-storage: Fix mail.access_type for search prefe... Message-ID: <58ac39db9d7aa_9603fceb5d7bc34223390@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f86436b30198ab9a1c9d86d02252ac269940711e https://github.com/dovecot/core/commit/f86436b30198ab9a1c9d86d02252ac269940711e Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-storage/index/index-search.c Log Message: ----------- lib-storage: Fix mail.access_type for search prefetches From noreply at github.com Tue Feb 21 13:00:16 2017 From: noreply at github.com (GitHub) Date: Tue, 21 Feb 2017 05:00:16 -0800 Subject: [dovecot/core] 228a8b: lib-storage, pop3-migration: Reset lookup_abort be... Message-ID: <58ac39e072a3b_ec53f82bac45c3024764d@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 228a8ba8a03d5d74f4697611b101ea505effcc27 https://github.com/dovecot/core/commit/228a8ba8a03d5d74f4697611b101ea505effcc27 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-storage/index/index-mailbox-size.c M src/plugins/pop3-migration/pop3-migration-plugin.c Log Message: ----------- lib-storage, pop3-migration: Reset lookup_abort before continuing to search This doesn't really fix anything right now, but it'll allow adding the asserts in the following commit. Commit: a79136b95f2d9d4081b63fec606e4a6b271cd735 https://github.com/dovecot/core/commit/a79136b95f2d9d4081b63fec606e4a6b271cd735 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-storage/index/index-search.c M src/lib-storage/index/index-sort.c Log Message: ----------- lib-storage: Add asserts to make sure lookup_abort is being used correctly. Commit: 08e9445940d166ee53c176e95d1278f4d8f129f8 https://github.com/dovecot/core/commit/08e9445940d166ee53c176e95d1278f4d8f129f8 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-storage/list/mailbox-list-index.c Log Message: ----------- lib-storage: Fix assert-crash on corrupted dovecot.list.index with name_id==0 Fixes: Panic: file hash.c: line 213 (hash_table_insert_node): assertion failed: (key != NULL) Commit: 9be49acfa4ee4d05b212d49064b7138f05a18296 https://github.com/dovecot/core/commit/9be49acfa4ee4d05b212d49064b7138f05a18296 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-sql/driver-cassandra.c Log Message: ----------- cassandra: Don't use i_error() from non-main thread It will only cause crashes. This was done only if the internal communication pipe couldn't be written to, which was pretty unlikely to happen. Commit: 3d0de6167661b7b01ce742cc09344dfeaf784b29 https://github.com/dovecot/core/commit/3d0de6167661b7b01ce742cc09344dfeaf784b29 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lmtp/commands.c Log Message: ----------- lmtp: Fix lmtp_user_concurrency_limit when userdb changes the username Anvil LOOKUP was done with the original username, while CONNECT/DISCONNECT was done with the changed username. So LOOKUP always thought that there were zero concurrent sessions for the user. Commit: b3443fcac414113f17b7348a049d18b0e0e6ed42 https://github.com/dovecot/core/commit/b3443fcac414113f17b7348a049d18b0e0e6ed42 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-storage/index/index-search.c Log Message: ----------- lib-storage: Fix mail.access_type for search prefetches Compare: https://github.com/dovecot/core/compare/7a765d42a29e...b3443fcac414 From noreply at github.com Tue Feb 21 14:30:12 2017 From: noreply at github.com (GitHub) Date: Tue, 21 Feb 2017 06:30:12 -0800 Subject: [dovecot/core] 1b0b44: imapc: Error handling wasn't setting storage error... Message-ID: <58ac4ef4ebe9_6e43ff950fd5c4411347f@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 1b0b44348d1f94f1f0e418d80323646e1e335c2b https://github.com/dovecot/core/commit/1b0b44348d1f94f1f0e418d80323646e1e335c2b Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-storage/index/imapc/imapc-mail-fetch.c Log Message: ----------- imapc: Error handling wasn't setting storage error everywhere. This would have used the previous error, which might not have been correct. From noreply at github.com Tue Feb 21 17:00:10 2017 From: noreply at github.com (GitHub) Date: Tue, 21 Feb 2017 09:00:10 -0800 Subject: [dovecot/core] 289bd9: imap: Fix error message in failed FETCH's NO reply... Message-ID: <58ac721a762bb_16053fcdf558dc40254891@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 289bd999f282a307b05e6f8beef33155a50fb837 https://github.com/dovecot/core/commit/289bd999f282a307b05e6f8beef33155a50fb837 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/imap/cmd-fetch.c M src/imap/imap-fetch.c M src/imap/imap-fetch.h Log Message: ----------- imap: Fix error message in failed FETCH's NO reply. This was broken only with the new imap_fetch_failure = no-after setting. From noreply at github.com Tue Feb 21 18:00:10 2017 From: noreply at github.com (GitHub) Date: Tue, 21 Feb 2017 10:00:10 -0800 Subject: [dovecot/core] ac3de4: lib: Accept leap second in utc_mktime Message-ID: <58ac802a7a808_ade3ff264ce9c30179559@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: ac3de45a2b7f7411f18bf3c0f0bc8dd54519944a https://github.com/dovecot/core/commit/ac3de45a2b7f7411f18bf3c0f0bc8dd54519944a Author: Martti Rannanj?rvi Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib/test-utc-mktime.c M src/lib/utc-mktime.c M src/lib/utc-mktime.h Log Message: ----------- lib: Accept leap second in utc_mktime Accept leap second at any time in utc_mktime since utc_mktime is being used before applying the timezone offset everywhere. Commit: 33e83879e02c82280c314c9dd4b891780811ebaf https://github.com/dovecot/core/commit/33e83879e02c82280c314c9dd4b891780811ebaf Author: Martti Rannanj?rvi Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib/test-utc-mktime.c Log Message: ----------- lib: Place input/output of utc_mktime tests in one struct Define both input and output of a utc_mktime test case in a single struct so it is easier to follow and less error prone. Commit: 5423c3086c372f3bcef7af5ca8a7a468dadbdcf8 https://github.com/dovecot/core/commit/5423c3086c372f3bcef7af5ca8a7a468dadbdcf8 Author: Martti Rannanj?rvi Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-mail/test-message-date.c Log Message: ----------- lib-mail: Place input/output of message-date tests in one struct Define both input and output of a message date test case in a single struct so it is easier to follow and less error prone. Also add some leap second tests. Compare: https://github.com/dovecot/core/compare/289bd999f282...5423c3086c37 From noreply at github.com Tue Feb 21 19:00:12 2017 From: noreply at github.com (GitHub) Date: Tue, 21 Feb 2017 11:00:12 -0800 Subject: [dovecot/core] 67905c: lib: Fix test-utc-mktime with 32bit time_t Message-ID: <58ac8e3c98c57_27ca13fda23009c30106292@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 67905cc9328270abbe5342b1e77d7ba4e8134552 https://github.com/dovecot/core/commit/67905cc9328270abbe5342b1e77d7ba4e8134552 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib/test-utc-mktime.c Log Message: ----------- lib: Fix test-utc-mktime with 32bit time_t From noreply at github.com Tue Feb 21 20:30:11 2017 From: noreply at github.com (GitHub) Date: Tue, 21 Feb 2017 12:30:11 -0800 Subject: [dovecot/core] 2e35ed: lib-lda: Refactor - Add struct mail_deliver_mailbo... Message-ID: <58aca35360889_21a93f9071441c2c197951@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 2e35ede0f3afa8b4528cc530a6efba239d77a022 https://github.com/dovecot/core/commit/2e35ede0f3afa8b4528cc530a6efba239d77a022 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Refactor - Add struct mail_deliver_mailbox Commit: d609c2ffca2b61556980b46e1de2303c662ad0f7 https://github.com/dovecot/core/commit/d609c2ffca2b61556980b46e1de2303c662ad0f7 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Refactor - mail_deliver_log_update_cache() doesn't need entire deliver_ctx Commit: 87dae9ffcd43023361019ca803709dbf5b8119bc https://github.com/dovecot/core/commit/87dae9ffcd43023361019ca803709dbf5b8119bc Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Fix delivery logging when Sieve performs multiple actions Previous code assumed that it would work like: - save/copy - transaction commit - mail_deliver_ctx_get_log_var_expand_table() - repeat for transaction 2 While it really works: - transaction 1: save/copy - transaction 2: save/copy - transaction 1: commit - mail_deliver_ctx_get_log_var_expand_table() - transaction 2: commit - mail_deliver_ctx_get_log_var_expand_table() So the cache needs to be stored per transaction. This code still wouldn't work correctly if Sieve saved mails multiple times within the same transaction, but that doesn't happen (at least currently). Compare: https://github.com/dovecot/core/compare/67905cc93282...87dae9ffcd43 From noreply at github.com Tue Feb 21 21:00:10 2017 From: noreply at github.com (GitHub) Date: Tue, 21 Feb 2017 13:00:10 -0800 Subject: [dovecot/core] 035e71: lib: Fix again test-utc-mktime with 32bit time_t Message-ID: <58acaa5a5564a_7023f9d5c8b1c381370a5@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 035e7193b4cf97bf7c6e89a2ca929825d82208fe https://github.com/dovecot/core/commit/035e7193b4cf97bf7c6e89a2ca929825d82208fe Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib/test-utc-mktime.c Log Message: ----------- lib: Fix again test-utc-mktime with 32bit time_t From noreply at github.com Tue Feb 21 21:00:15 2017 From: noreply at github.com (GitHub) Date: Tue, 21 Feb 2017 13:00:15 -0800 Subject: [dovecot/core] 0510f8: lib-index: Allow multiple hooks for transaction cr... Message-ID: <58acaa5f458b5_3f53fa07976bc3c100154@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 0510f81ff1f37ae77a02b6adf1b4225b14a56b90 https://github.com/dovecot/core/commit/0510f81ff1f37ae77a02b6adf1b4225b14a56b90 Author: Aki Tuomi Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-index/mail-index-transaction-private.h M src/lib-index/mail-index-transaction.c Log Message: ----------- lib-index: Allow multiple hooks for transaction creation Commit: 58e93ef5041a17e283f52cad8de01aacf272d6a6 https://github.com/dovecot/core/commit/58e93ef5041a17e283f52cad8de01aacf272d6a6 Author: Aki Tuomi Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-storage/mail-storage-hooks.c M src/lib/Makefile.am A src/lib/hook-build.c A src/lib/hook-build.h Log Message: ----------- lib,lib-storage: Move hook building code to lib This allows it to be reused elsewhere Commit: d7904f9a50efd8bd813ba3abc5e2fbba46fd44c1 https://github.com/dovecot/core/commit/d7904f9a50efd8bd813ba3abc5e2fbba46fd44c1 Author: Aki Tuomi Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-index/mail-index-transaction-private.h M src/lib-index/mail-index-transaction.c Log Message: ----------- lib-index: Add missing initialization for chained hooks Commit: 86f26deab557cda2b122e32c467be333f451644c https://github.com/dovecot/core/commit/86f26deab557cda2b122e32c467be333f451644c Author: Aki Tuomi Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-index/mail-index-transaction-private.h M src/lib-index/mail-index-transaction.c Log Message: ----------- lib-index: Unconstifty pointer array clang complained about the extra const. Commit: 95e2c9f27696f41ec9358bdef267f0ddcb842972 https://github.com/dovecot/core/commit/95e2c9f27696f41ec9358bdef267f0ddcb842972 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-storage/index/imapc/imapc-mail-fetch.c Log Message: ----------- imapc: Error handling wasn't setting storage error everywhere. This would have used the previous error, which might not have been correct. Commit: e69444414a97c3ad2d22fb6237b16f497a56663c https://github.com/dovecot/core/commit/e69444414a97c3ad2d22fb6237b16f497a56663c Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/imap/cmd-fetch.c M src/imap/imap-fetch.c M src/imap/imap-fetch.h Log Message: ----------- imap: Fix error message in failed FETCH's NO reply. This was broken only with the new imap_fetch_failure = no-after setting. Commit: fe7e8f48680ebf5e7f4fc4c12627169aecc01921 https://github.com/dovecot/core/commit/fe7e8f48680ebf5e7f4fc4c12627169aecc01921 Author: Martti Rannanj?rvi Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib/test-utc-mktime.c M src/lib/utc-mktime.c M src/lib/utc-mktime.h Log Message: ----------- lib: Accept leap second in utc_mktime Accept leap second at any time in utc_mktime since utc_mktime is being used before applying the timezone offset everywhere. Commit: bebf61818af198f68bf5f646f04dc62c0049c05f https://github.com/dovecot/core/commit/bebf61818af198f68bf5f646f04dc62c0049c05f Author: Martti Rannanj?rvi Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib/test-utc-mktime.c Log Message: ----------- lib: Place input/output of utc_mktime tests in one struct Define both input and output of a utc_mktime test case in a single struct so it is easier to follow and less error prone. Commit: 8aa80a36aadbd1cd4e2cbadb72c0aa29b9232980 https://github.com/dovecot/core/commit/8aa80a36aadbd1cd4e2cbadb72c0aa29b9232980 Author: Martti Rannanj?rvi Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-mail/test-message-date.c Log Message: ----------- lib-mail: Place input/output of message-date tests in one struct Define both input and output of a message date test case in a single struct so it is easier to follow and less error prone. Also add some leap second tests. Commit: 1b41f473cfae10d030a12a8fe1a75c383c81de7e https://github.com/dovecot/core/commit/1b41f473cfae10d030a12a8fe1a75c383c81de7e Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib/test-utc-mktime.c Log Message: ----------- lib: Fix test-utc-mktime with 32bit time_t Commit: 2d42ba728823b07da1e21fd9ab2f189e61e45a28 https://github.com/dovecot/core/commit/2d42ba728823b07da1e21fd9ab2f189e61e45a28 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Refactor - Add struct mail_deliver_mailbox Commit: 7c6a1def56059711b7379ac64bb888584d7735e6 https://github.com/dovecot/core/commit/7c6a1def56059711b7379ac64bb888584d7735e6 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Refactor - mail_deliver_log_update_cache() doesn't need entire deliver_ctx Commit: 87e4dd14aad473c1d3193edc1fc93b3e0cf39184 https://github.com/dovecot/core/commit/87e4dd14aad473c1d3193edc1fc93b3e0cf39184 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Fix delivery logging when Sieve performs multiple actions Previous code assumed that it would work like: - save/copy - transaction commit - mail_deliver_ctx_get_log_var_expand_table() - repeat for transaction 2 While it really works: - transaction 1: save/copy - transaction 2: save/copy - transaction 1: commit - mail_deliver_ctx_get_log_var_expand_table() - transaction 2: commit - mail_deliver_ctx_get_log_var_expand_table() So the cache needs to be stored per transaction. This code still wouldn't work correctly if Sieve saved mails multiple times within the same transaction, but that doesn't happen (at least currently). Commit: d89a40c345b3d3eef3af3af27c9ed934e34d4ec4 https://github.com/dovecot/core/commit/d89a40c345b3d3eef3af3af27c9ed934e34d4ec4 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib/test-utc-mktime.c Log Message: ----------- lib: Fix again test-utc-mktime with 32bit time_t Compare: https://github.com/dovecot/core/compare/b3443fcac414...d89a40c345b3 From noreply at github.com Wed Feb 22 09:30:11 2017 From: noreply at github.com (GitHub) Date: Wed, 22 Feb 2017 01:30:11 -0800 Subject: [dovecot/core] 6db1c8: lib-lda: Fix pigeonhole testsuite to not crash Message-ID: <58ad5a2352792_187e3fc06b6f1c2c219655@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 6db1c8a3b89f6cc5a30ec62d8e735505d0187516 https://github.com/dovecot/core/commit/6db1c8a3b89f6cc5a30ec62d8e735505d0187516 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Fix pigeonhole testsuite to not crash From noreply at github.com Wed Feb 22 09:30:16 2017 From: noreply at github.com (GitHub) Date: Wed, 22 Feb 2017 01:30:16 -0800 Subject: [dovecot/core] 544a39: lib-lda: Fix pigeonhole testsuite to not crash Message-ID: <58ad5a28a13e_1caf3f965e907c3c233562@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 544a3921f705f84b9f3b96c86ba9683c45dc3ee9 https://github.com/dovecot/core/commit/544a3921f705f84b9f3b96c86ba9683c45dc3ee9 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Fix pigeonhole testsuite to not crash From noreply at github.com Wed Feb 22 11:30:11 2017 From: noreply at github.com (GitHub) Date: Wed, 22 Feb 2017 03:30:11 -0800 Subject: [dovecot/core] 13f507: quota: Don't log "Internal quota calculation error... Message-ID: <58ad7643e1167_1c403fce4c26bc2c233361@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 13f507c0df27fee7b30cb965574e077a22606502 https://github.com/dovecot/core/commit/13f507c0df27fee7b30cb965574e077a22606502 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/plugins/quota/quota-storage.c Log Message: ----------- quota: Don't log "Internal quota calculation error" It's not very informative and we can't give a better error message without changing the APIs. The real error should have been logged already anyway, so this is just duplication of an error. I think originally this was added because some backend forgot to log an error. From noreply at github.com Wed Feb 22 12:00:11 2017 From: noreply at github.com (GitHub) Date: Wed, 22 Feb 2017 04:00:11 -0800 Subject: [dovecot/core] d1bf4a: lib-storage: Use refcounting for mail_storage_serv... Message-ID: <58ad7d4b85f72_27d123fcfa26c3c282093b7@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: d1bf4ae66b8bf3b9e28df1823d6d4adda2b923b6 https://github.com/dovecot/core/commit/d1bf4ae66b8bf3b9e28df1823d6d4adda2b923b6 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-storage/mail-storage-service.c M src/lib-storage/mail-storage-service.h M src/lib-storage/mail-user.c Log Message: ----------- lib-storage: Use refcounting for mail_storage_service_user doveadm import was freeing the user too early, which resulted mail_user._service_user pointing to freed memory. More importantly, after 34512eaad8b1b2f929e6d6e3a2f7252c29fba97b user->set was pointing to already freed memory. Commit: eb318ea05532d2e54ed3bfc89bc15dcf1adae838 https://github.com/dovecot/core/commit/eb318ea05532d2e54ed3bfc89bc15dcf1adae838 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/doveadm/doveadm-auth-server.c M src/doveadm/doveadm-auth.c M src/doveadm/doveadm-mail-copymove.c M src/doveadm/doveadm-mail-import.c M src/doveadm/doveadm-mail.c M src/imap-urlauth/imap-urlauth-worker.c M src/imap/imap-client.c M src/imap/main.c M src/indexer/master-connection.c M src/lda/main.c M src/lmtp/client.c M src/lmtp/commands.c M src/plugins/mail-crypt/doveadm-mail-crypt.c M src/plugins/mail-crypt/mail-crypt-acl-plugin.c M src/plugins/mail-crypt/test-mail-key.c M src/plugins/quota/quota-status.c M src/pop3/pop3-client.c Log Message: ----------- global: Replace mail_storage_service_user_free() with _unref() Commit: f6897616e0529b7bda2005d6cd42b06c826ed66f https://github.com/dovecot/core/commit/f6897616e0529b7bda2005d6cd42b06c826ed66f Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-storage/mail-storage-service.h Log Message: ----------- lib-storage: Removed mail_storage_service_user_free() backwards compatibility Used a separate commit so the macro can be left for v2.2 tree. Compare: https://github.com/dovecot/core/compare/13f507c0df27...f6897616e052 From noreply at github.com Wed Feb 22 12:00:16 2017 From: noreply at github.com (GitHub) Date: Wed, 22 Feb 2017 04:00:16 -0800 Subject: [dovecot/core] dc59f8: lib-storage: Use refcounting for mail_storage_serv... Message-ID: <58ad7d5075e0c_20eb3fa7e14f1c303849b5@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: dc59f8c55c4ea86d6aef542d5d8ed0ff6a8159fe https://github.com/dovecot/core/commit/dc59f8c55c4ea86d6aef542d5d8ed0ff6a8159fe Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-storage/mail-storage-service.c M src/lib-storage/mail-storage-service.h M src/lib-storage/mail-user.c Log Message: ----------- lib-storage: Use refcounting for mail_storage_service_user doveadm import was freeing the user too early, which resulted mail_user._service_user pointing to freed memory. More importantly, after 34512eaad8b1b2f929e6d6e3a2f7252c29fba97b user->set was pointing to already freed memory. Commit: 533b30023779e381ac0440b122b1791bf6679ed5 https://github.com/dovecot/core/commit/533b30023779e381ac0440b122b1791bf6679ed5 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/doveadm/doveadm-auth-server.c M src/doveadm/doveadm-auth.c M src/doveadm/doveadm-mail-copymove.c M src/doveadm/doveadm-mail-import.c M src/doveadm/doveadm-mail.c M src/imap-urlauth/imap-urlauth-worker.c M src/imap/imap-client.c M src/imap/main.c M src/indexer/master-connection.c M src/lda/main.c M src/lmtp/client.c M src/lmtp/commands.c M src/plugins/mail-crypt/doveadm-mail-crypt.c M src/plugins/mail-crypt/mail-crypt-acl-plugin.c M src/plugins/mail-crypt/test-mail-key.c M src/plugins/quota/quota-status.c M src/pop3/pop3-client.c Log Message: ----------- global: Replace mail_storage_service_user_free() with _unref() Commit: b61798c072511ffa91d433d425fd48fa0e940968 https://github.com/dovecot/core/commit/b61798c072511ffa91d433d425fd48fa0e940968 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/plugins/quota/quota-storage.c Log Message: ----------- quota: Don't log "Internal quota calculation error" It's not very informative and we can't give a better error message without changing the APIs. The real error should have been logged already anyway, so this is just duplication of an error. I think originally this was added because some backend forgot to log an error. Compare: https://github.com/dovecot/core/compare/544a3921f705...b61798c07251 From noreply at github.com Wed Feb 22 14:30:13 2017 From: noreply at github.com (GitHub) Date: Wed, 22 Feb 2017 06:30:13 -0800 Subject: [dovecot/core] d09be2: lib-storage: Add missing service_user ref when cre... Message-ID: <58ada0753c158_6e43ff950fd5c4412746c@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: d09be27cc4d98d23ba6ae78f13248945a28f9090 https://github.com/dovecot/core/commit/d09be27cc4d98d23ba6ae78f13248945a28f9090 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-storage/index/shared/shared-storage.c Log Message: ----------- lib-storage: Add missing service_user ref when creating shared mailbox's user. Was forgotten from d1bf4ae66b8bf3b9e28df1823d6d4adda2b923b6 Fixes: Panic: file mail-storage-service.c: line 1513 (mail_storage_service_user_unref): assertion failed: (user->refcount > 0) From noreply at github.com Wed Feb 22 15:30:14 2017 From: noreply at github.com (GitHub) Date: Wed, 22 Feb 2017 07:30:14 -0800 Subject: [dovecot/core] e591a3: lib-mail: Fix message_part_data_is_plain_7bit() Message-ID: <58adae86bff2e_19b33fcf7e66fc3c16195b@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: e591a396fb59b147ea5828e271512cb7af483a8e https://github.com/dovecot/core/commit/e591a396fb59b147ea5828e271512cb7af483a8e Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-mail/message-part-data.c Log Message: ----------- lib-mail: Fix message_part_data_is_plain_7bit() Content-Type parameters weren't handled exactly right. Broken by recent changes. From noreply at github.com Wed Feb 22 18:00:11 2017 From: noreply at github.com (GitHub) Date: Wed, 22 Feb 2017 10:00:11 -0800 Subject: [dovecot/core] 06c559: lazy-expunge: Fix error handling for GUID lookups Message-ID: <58add1abebaf1_21a93f9071441c2c2245eb@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 06c55920c133602d6347f574b4149a083935cca8 https://github.com/dovecot/core/commit/06c55920c133602d6347f574b4149a083935cca8 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/plugins/lazy-expunge/lazy-expunge-plugin.c Log Message: ----------- lazy-expunge: Fix error handling for GUID lookups If the mail is already expunged, the error should be ignored. In other situations the original error string should be preserved as part of the logged error message. From noreply at github.com Wed Feb 22 18:30:12 2017 From: noreply at github.com (GitHub) Date: Wed, 22 Feb 2017 10:30:12 -0800 Subject: [dovecot/core] 17ac26: expire plugin: Use correct hook for overriding mai... Message-ID: <58add8b485b5f_27fcc3ff425c4bc34143242@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 17ac264fe7efd383f10c67548cadcc5aca505b92 https://github.com/dovecot/core/commit/17ac264fe7efd383f10c67548cadcc5aca505b92 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/plugins/expire/expire-plugin.c Log Message: ----------- expire plugin: Use correct hook for overriding mail_user vfuncs This was always wrong to do, and it crashes after f32382d2da479a4371e08c443679528db37ea988 Commit: dd38c9e81463c63dd965c1a039bf68c9272447be https://github.com/dovecot/core/commit/dd38c9e81463c63dd965c1a039bf68c9272447be Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/plugins/trash/trash-plugin.c Log Message: ----------- trash plugin: Use correct hook for overriding mail_user vfuncs This was always wrong to do, and it crashes after f32382d2da479a4371e08c443679528db37ea988 Commit: c3c423426093ffc01fa9967573a9b9e39f42c461 https://github.com/dovecot/core/commit/c3c423426093ffc01fa9967573a9b9e39f42c461 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib/istream-sized.c M src/lib/istream-sized.h Log Message: ----------- lib: Added i_stream_create_sized_range() This is just a small wrapper to i_stream_create_sized() to specify stream's start offset. Commit: 422df9158f9e3a2d21060f0fee2a9588e925f20e https://github.com/dovecot/core/commit/422df9158f9e3a2d21060f0fee2a9588e925f20e Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib/istream-sized.c M src/lib/istream-sized.h M src/lib/test-istream-sized.c Log Message: ----------- lib: Added i_stream_create_min_sized*() Commit: 24d6fd2b8e2c327ae2a20a0c4be8af2ef7b3b468 https://github.com/dovecot/core/commit/24d6fd2b8e2c327ae2a20a0c4be8af2ef7b3b468 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-mail/istream-attachment-connector.c M src/lib-mail/test-istream-attachment.c Log Message: ----------- lib-mail: Make sure istream-attachment-connector detects wrong mail size. Commit: 075081e25ef07989be10f7c9cf85f833f90be46f https://github.com/dovecot/core/commit/075081e25ef07989be10f7c9cf85f833f90be46f Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-mail/istream-attachment-connector.c M src/lib-mail/istream-attachment-connector.h M src/lib-mail/test-istream-attachment.c Log Message: ----------- lib-mail: istream-attachment-connector now allows msg_size=-1 for "unknown". Commit: dc7a24adeabfc9372a9d5fe34e7f8761e325ed68 https://github.com/dovecot/core/commit/dc7a24adeabfc9372a9d5fe34e7f8761e325ed68 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-storage/index/pop3c/pop3c-mail.c Log Message: ----------- pop3c: Prefetched streams didn't call istream_opened() or set virtual_size Commit: cee43a7b0fe3934efc863f533428989173682e0b https://github.com/dovecot/core/commit/cee43a7b0fe3934efc863f533428989173682e0b Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-storage/index/pop3c/pop3c-mail.c Log Message: ----------- pop3c: Remove unnecessarily duplicated code setting vsize to cache This is important now that the vsize can be added also to index's vsize extension. Commit: fdb838ec8774e41004461b7f76ab409774af06c4 https://github.com/dovecot/core/commit/fdb838ec8774e41004461b7f76ab409774af06c4 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-storage/index/maildir/maildir-mail.c Log Message: ----------- maildir: Fix checking vsize caching decision in "is this pop3 user?" If vsize extension is used, it's practically the same as if vsize's caching decision was YES. Compare: https://github.com/dovecot/core/compare/06c55920c133...fdb838ec8774 From noreply at github.com Wed Feb 22 18:30:17 2017 From: noreply at github.com (GitHub) Date: Wed, 22 Feb 2017 10:30:17 -0800 Subject: [dovecot/core] a44239: lib-storage: Add missing service_user ref when cre... Message-ID: <58add8b9c8ce8_19ff3fc4efdf7c2818645d@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: a442399049eb392758a249b6657b1ef491270789 https://github.com/dovecot/core/commit/a442399049eb392758a249b6657b1ef491270789 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-storage/index/shared/shared-storage.c Log Message: ----------- lib-storage: Add missing service_user ref when creating shared mailbox's user. Was forgotten from d1bf4ae66b8bf3b9e28df1823d6d4adda2b923b6 Fixes: Panic: file mail-storage-service.c: line 1513 (mail_storage_service_user_unref): assertion failed: (user->refcount > 0) Commit: 5a6d3f5ea9f2724447d7672acff8fce425c16d21 https://github.com/dovecot/core/commit/5a6d3f5ea9f2724447d7672acff8fce425c16d21 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/plugins/lazy-expunge/lazy-expunge-plugin.c Log Message: ----------- lazy-expunge: Fix error handling for GUID lookups If the mail is already expunged, the error should be ignored. In other situations the original error string should be preserved as part of the logged error message. Commit: 570fb4d055eed7b10ed0713aa522e8154408eba9 https://github.com/dovecot/core/commit/570fb4d055eed7b10ed0713aa522e8154408eba9 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/plugins/expire/expire-plugin.c Log Message: ----------- expire plugin: Use correct hook for overriding mail_user vfuncs This was always wrong to do, and it crashes after f32382d2da479a4371e08c443679528db37ea988 Commit: 27b2e8b87c89b29001d3dc1ec8859f074cd2c12b https://github.com/dovecot/core/commit/27b2e8b87c89b29001d3dc1ec8859f074cd2c12b Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/plugins/trash/trash-plugin.c Log Message: ----------- trash plugin: Use correct hook for overriding mail_user vfuncs This was always wrong to do, and it crashes after f32382d2da479a4371e08c443679528db37ea988 Commit: 6d520eebd977f3a236aab3debd30b4699ae686a0 https://github.com/dovecot/core/commit/6d520eebd977f3a236aab3debd30b4699ae686a0 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-storage/index/pop3c/pop3c-mail.c Log Message: ----------- pop3c: Prefetched streams didn't call istream_opened() or set virtual_size Commit: 45cf4aca28ece729003b5658d1c804ce66668f65 https://github.com/dovecot/core/commit/45cf4aca28ece729003b5658d1c804ce66668f65 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-storage/index/pop3c/pop3c-mail.c Log Message: ----------- pop3c: Remove unnecessarily duplicated code setting vsize to cache This is important now that the vsize can be added also to index's vsize extension. Commit: b0cd8e156a993865439c16cad4adcb373552a365 https://github.com/dovecot/core/commit/b0cd8e156a993865439c16cad4adcb373552a365 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-storage/index/maildir/maildir-mail.c Log Message: ----------- maildir: Fix checking vsize caching decision in "is this pop3 user?" If vsize extension is used, it's practically the same as if vsize's caching decision was YES. Compare: https://github.com/dovecot/core/compare/e591a396fb59...b0cd8e156a99 From noreply at github.com Wed Feb 22 23:00:12 2017 From: noreply at github.com (GitHub) Date: Wed, 22 Feb 2017 15:00:12 -0800 Subject: [dovecot/core] e2fd3f: lib-storage: Allow mail_storage_set_error() to use... Message-ID: <58ae17fc72acf_1cf33fce5090bc2c326774@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: e2fd3f13fff682498ad58fec7c11f20f9890c657 https://github.com/dovecot/core/commit/e2fd3f13fff682498ad58fec7c11f20f9890c657 Author: Timo Sirainen Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/lib-storage/mail-storage.c Log Message: ----------- lib-storage: Allow mail_storage_set_error() to use existing error_string Fixes some code that may be attempting to copy an error from one storage to another, but actually ends up trying to copy within the same storage. From noreply at github.com Thu Feb 23 01:14:36 2017 From: noreply at github.com (GitHub) Date: Wed, 22 Feb 2017 17:14:36 -0800 Subject: [dovecot/pigeonhole] 25a5a4: lib-sieve: Implemented means to abort SMTP message... Message-ID: <58ae377c4ad7f_fd33fe8acdc9c342951c2@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/pigeonhole Commit: 25a5a493cdab093b1f71ceb07253ca4962528db7 https://github.com/dovecot/pigeonhole/commit/25a5a493cdab093b1f71ceb07253ca4962528db7 Author: Stephan Bosch Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-sieve/sieve-smtp.c M src/lib-sieve/sieve-smtp.h M src/lib-sieve/sieve-types.h M src/plugins/imapsieve/imap-sieve.c M src/plugins/lda-sieve/lda-sieve-plugin.c M src/sieve-tools/sieve-test.c M src/testsuite/testsuite-smtp.c M src/testsuite/testsuite-smtp.h M src/testsuite/testsuite.c Log Message: ----------- lib-sieve: Implemented means to abort SMTP message submission after it is started. This adds a new callback to the Sieve script execution environment. Commit: c4df3317bcf48503c942f18c8bbeac4a96475f3f https://github.com/dovecot/pigeonhole/commit/c4df3317bcf48503c942f18c8bbeac4a96475f3f Author: Stephan Bosch Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-sieve/cmd-redirect.c M src/lib-sieve/sieve-actions.c M src/lib-sieve/sieve-actions.h Log Message: ----------- lib-sieve: Made public function for adding a redirect action to the result. Commit: 92f3d3238a6deedb8015227f18df9f0e574b5200 https://github.com/dovecot/pigeonhole/commit/92f3d3238a6deedb8015227f18df9f0e574b5200 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-sieve-tool/sieve-tool.c M src/managesieve/main.c M src/managesieve/managesieve-client.c Log Message: ----------- global: Replace mail_storage_service_user_free() with _unref() Compare: https://github.com/dovecot/pigeonhole/compare/051cf477ec2f...92f3d3238a6d From noreply at github.com Thu Feb 23 10:30:11 2017 From: noreply at github.com (GitHub) Date: Thu, 23 Feb 2017 02:30:11 -0800 Subject: [dovecot/core] d95c7d: virtual: Include virtual mailbox name in "Mailbox ... Message-ID: <58aeb9b38184_119a3fb297795c3c24138f@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: d95c7dbfa4c7b02850c7816ccd5f203dd5647689 https://github.com/dovecot/core/commit/d95c7dbfa4c7b02850c7816ccd5f203dd5647689 Author: Timo Sirainen Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/plugins/virtual/virtual-sync.c Log Message: ----------- virtual: Include virtual mailbox name in "Mailbox ID unexpectedly lost" error Commit: 38424b8081a75be3ef93729fed4d30dbafca5885 https://github.com/dovecot/core/commit/38424b8081a75be3ef93729fed4d30dbafca5885 Author: Aki Tuomi Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/lib-ssl-iostream/iostream-openssl-context.c Log Message: ----------- lib-ssl-iostream: Fix ambiguity with SSL settings - lib-ssl-iostream as client: Use only allow_invalid_cert. If it's not set, verify the server cert. - lib-ssl-iostream as server: If verify_client_cert=FALSE, don't ask for the client cert. Otherwise, ask for client cert but still allow it if allow_invalid_cert=TRUE. Commit: b3c095d1fb0bb86695d92c2045eb09e985623934 https://github.com/dovecot/core/commit/b3c095d1fb0bb86695d92c2045eb09e985623934 Author: Aki Tuomi Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/auth/db-oauth2.c M src/doveadm/doveadm-dsync.c M src/doveadm/server-connection.c M src/lib-http/http-client-connection.c M src/lib-imap-client/imapc-client.c M src/lib-imap-client/imapc-connection.c M src/lib-storage/index/pop3c/pop3c-client.c Log Message: ----------- global: Fix ssl_set usage Remove verify_remote_cert, as it's always TRUE now. Set allow_invalid_cert to TRUE if verification is not required. Compare: https://github.com/dovecot/core/compare/e2fd3f13fff6...b3c095d1fb0b From noreply at github.com Thu Feb 23 11:00:10 2017 From: noreply at github.com (GitHub) Date: Thu, 23 Feb 2017 03:00:10 -0800 Subject: [dovecot/core] 7a727b: pop3c: Fix compiling due to typo in previous commi... Message-ID: <58aec0ba74af_108e3f843992bc2c231385@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 7a727b88fdfccf74466041c17ebb34c1da663567 https://github.com/dovecot/core/commit/7a727b88fdfccf74466041c17ebb34c1da663567 Author: Timo Sirainen Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/lib-storage/index/pop3c/pop3c-client.c Log Message: ----------- pop3c: Fix compiling due to typo in previous commit From noreply at github.com Thu Feb 23 11:00:15 2017 From: noreply at github.com (GitHub) Date: Thu, 23 Feb 2017 03:00:15 -0800 Subject: [dovecot/core] 043ee6: lib: Added i_stream_create_sized_range() Message-ID: <58aec0bf8ac3f_20eb3fa7e14f1c30419723@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 043ee67696d8544db1dfb9698882c85afff8dc74 https://github.com/dovecot/core/commit/043ee67696d8544db1dfb9698882c85afff8dc74 Author: Timo Sirainen Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/lib/istream-sized.c M src/lib/istream-sized.h Log Message: ----------- lib: Added i_stream_create_sized_range() This is just a small wrapper to i_stream_create_sized() to specify stream's start offset. Commit: 3d304f67d92013655fbf5f29d056835eaff3b388 https://github.com/dovecot/core/commit/3d304f67d92013655fbf5f29d056835eaff3b388 Author: Martti Rannanj?rvi Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/lib/istream-sized.c Log Message: ----------- lib: remove failed bool from sized_istream struct This is no longer needed as we are now checking for stream_errno also in istream.c Commit: f43f9f5b0e7070445bb053a73cf1c77d2999ef3f https://github.com/dovecot/core/commit/f43f9f5b0e7070445bb053a73cf1c77d2999ef3f Author: Timo Sirainen Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/lib/istream-sized.c Log Message: ----------- lib: istream-sized should log errors with its own name, not parent's name Commit: 6f287dc05a76deee6686390fd24794dc802aa17d https://github.com/dovecot/core/commit/6f287dc05a76deee6686390fd24794dc802aa17d Author: Timo Sirainen Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/lib/istream-sized.c Log Message: ----------- lib: istream-sized - remove explicit i_error() logging The stream_errno is set, so it's the caller's responsibility to log the error. There's no need to log it twice. Commit: 19d66fec1b3650122abdcdc6b683a9fa7ced8f1f https://github.com/dovecot/core/commit/19d66fec1b3650122abdcdc6b683a9fa7ced8f1f Author: Timo Sirainen Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/lib/istream-sized.c M src/lib/istream-sized.h A src/lib/test-istream-sized.c Log Message: ----------- lib: istream-sized - set stream_errno=EPIPE if stream is too small Commit: a7ce88361c69c2a5b8968029427ad32134da14db https://github.com/dovecot/core/commit/a7ce88361c69c2a5b8968029427ad32134da14db Author: Timo Sirainen Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/lib/istream-sized.c Log Message: ----------- lib: istream-sized - consistently set stream_errno=EINVAL if stream is too large Earlier it was sometimes done and sometimes not, depending on whether the parent istream happened to stop at the expected boundary. Commit: f981b71773b76e95285dd719368716cdab948075 https://github.com/dovecot/core/commit/f981b71773b76e95285dd719368716cdab948075 Author: Timo Sirainen Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/lib/istream-sized.c M src/lib/istream-sized.h M src/lib/test-istream-sized.c Log Message: ----------- lib: Added i_stream_create_min_sized*() Commit: 7e6a434ec9abb0bf252af25fd5f10bff8f1521b3 https://github.com/dovecot/core/commit/7e6a434ec9abb0bf252af25fd5f10bff8f1521b3 Author: Timo Sirainen Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/lib-mail/istream-attachment-extractor.c Log Message: ----------- lib-mail: istream-attachment-extractor - remove unnecessary code It's enough to set the stream_errno. Commit: e5e1659ec22447d8869922426e23f60f0816f885 https://github.com/dovecot/core/commit/e5e1659ec22447d8869922426e23f60f0816f885 Author: Timo Sirainen Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/lib-mail/istream-attachment-extractor.c Log Message: ----------- lib-mail: istream-attachment-extractor - use EIO for internal errors These happen only if the attachment writing failed for some reason. The input stream itself can't have any errors, so EINVAL isn't proper. Commit: a540d9ca59eab432db1ef659b52a1a391a7d3f27 https://github.com/dovecot/core/commit/a540d9ca59eab432db1ef659b52a1a391a7d3f27 Author: Timo Sirainen Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/lib-mail/test-istream-attachment.c Log Message: ----------- lib-mail: Improve istream-attachment-extractor unit test for EIO errors Commit: a427bf499d15a07b9f0c566c7475e157011a24d4 https://github.com/dovecot/core/commit/a427bf499d15a07b9f0c566c7475e157011a24d4 Author: Timo Sirainen Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/lib-mail/test-istream-attachment.c Log Message: ----------- lib-mail: Fix memory leak in test-istream-attachment Commit: 83ba28bcdbfbbcbdc6d8c1d882f67e5608f113c5 https://github.com/dovecot/core/commit/83ba28bcdbfbbcbdc6d8c1d882f67e5608f113c5 Author: Timo Sirainen Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/lib-mail/istream-attachment-connector.c M src/lib-mail/test-istream-attachment.c Log Message: ----------- lib-mail: Make sure istream-attachment-connector detects wrong mail size. Commit: 9a19e1594d13e97cb1e0677a432de9ddf620ee73 https://github.com/dovecot/core/commit/9a19e1594d13e97cb1e0677a432de9ddf620ee73 Author: Timo Sirainen Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/lib-mail/istream-attachment-connector.c M src/lib-mail/istream-attachment-connector.h M src/lib-mail/test-istream-attachment.c Log Message: ----------- lib-mail: istream-attachment-connector now allows msg_size=-1 for "unknown". Commit: d02348d8257faacdca8706a427489532262c96d7 https://github.com/dovecot/core/commit/d02348d8257faacdca8706a427489532262c96d7 Author: Timo Sirainen Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/lib-storage/mail-storage.c Log Message: ----------- lib-storage: Allow mail_storage_set_error() to use existing error_string Fixes some code that may be attempting to copy an error from one storage to another, but actually ends up trying to copy within the same storage. Commit: 7e525eb504c643e8cffcb7a62cbd57a1b877aa6f https://github.com/dovecot/core/commit/7e525eb504c643e8cffcb7a62cbd57a1b877aa6f Author: Timo Sirainen Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/plugins/virtual/virtual-sync.c Log Message: ----------- virtual: Include virtual mailbox name in "Mailbox ID unexpectedly lost" error Compare: https://github.com/dovecot/core/compare/b0cd8e156a99...7e525eb504c6 From noreply at github.com Thu Feb 23 11:30:11 2017 From: noreply at github.com (GitHub) Date: Thu, 23 Feb 2017 03:30:11 -0800 Subject: [dovecot/core] d85468: auth: Export oauth2 pass_attrs to passdb reply Message-ID: <58aec7c38fcad_14523f91c1af9c30199468@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: d85468c0084b7eecee6226c5db43891a19d3710b https://github.com/dovecot/core/commit/d85468c0084b7eecee6226c5db43891a19d3710b Author: Aki Tuomi Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- auth: Export oauth2 pass_attrs to passdb reply From noreply at github.com Thu Feb 23 19:30:12 2017 From: noreply at github.com (GitHub) Date: Thu, 23 Feb 2017 11:30:12 -0800 Subject: [dovecot/core] 97a8fd: lib-http: client: Fixed i_unreached() failure occu... Message-ID: <58af38441012b_183e3fd593ce3c3811737d@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 97a8fde13ea33b09163c45d978a4949043f189c5 https://github.com/dovecot/core/commit/97a8fde13ea33b09163c45d978a4949043f189c5 Author: Stephan Bosch Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/lib-http/http-client-private.h M src/lib-http/http-client-queue.c Log Message: ----------- lib-http: client: Fixed i_unreached() failure occurring when a host's list of IPs changes while a connection is still pending. In that case, the IP of the pending connection may no longer be associated with that host. If the IP was not found anymore, the i_unreached() error occurred. From noreply at github.com Thu Feb 23 19:30:16 2017 From: noreply at github.com (GitHub) Date: Thu, 23 Feb 2017 11:30:16 -0800 Subject: [dovecot/core] 770b0c: auth: Export oauth2 pass_attrs to passdb reply Message-ID: <58af3848c478d_10ce3f9ba2f35c2824037c@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 770b0c36b97f9adc1f726758c03c58c20978983b https://github.com/dovecot/core/commit/770b0c36b97f9adc1f726758c03c58c20978983b Author: Aki Tuomi Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- auth: Export oauth2 pass_attrs to passdb reply Commit: 8c173f2c50b0de5a3db5cc7921b7e7b8783c31f2 https://github.com/dovecot/core/commit/8c173f2c50b0de5a3db5cc7921b7e7b8783c31f2 Author: Stephan Bosch Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/lib-http/http-client-private.h M src/lib-http/http-client-queue.c Log Message: ----------- lib-http: client: Fixed i_unreached() failure occurring when a host's list of IPs changes while a connection is still pending. In that case, the IP of the pending connection may no longer be associated with that host. If the IP was not found anymore, the i_unreached() error occurred. Compare: https://github.com/dovecot/core/compare/7e525eb504c6...8c173f2c50b0 From noreply at github.com Fri Feb 24 11:00:12 2017 From: noreply at github.com (GitHub) Date: Fri, 24 Feb 2017 03:00:12 -0800 Subject: [dovecot/core] 930765: acl plugin: Fix Coverity warning Message-ID: <58b0123c4a501_f873fca5c335c3c2875eb@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 93076575071edeb3fe0666588f0222fc300ec2c4 https://github.com/dovecot/core/commit/93076575071edeb3fe0666588f0222fc300ec2c4 Author: Timo Sirainen Date: 2017-02-24 (Fri, 24 Feb 2017) Changed paths: M src/plugins/acl/acl-cache.h Log Message: ----------- acl plugin: Fix Coverity warning Just switch the MALLOC_ADD() parameters, so that arithmetic doesn't get inside a sizeof(). Commit: 850778e1fcd78aa0f91c53ecbab77e17d7e744a4 https://github.com/dovecot/core/commit/850778e1fcd78aa0f91c53ecbab77e17d7e744a4 Author: Timo Sirainen Date: 2017-02-24 (Fri, 24 Feb 2017) Changed paths: M src/auth/mech-oauth2.c Log Message: ----------- auth: Removed dead code from oauth2 mechanism Commit: f64f2d4b76128edcd05331fe23e2fac86e9bd9a3 https://github.com/dovecot/core/commit/f64f2d4b76128edcd05331fe23e2fac86e9bd9a3 Author: Timo Sirainen Date: 2017-02-24 (Fri, 24 Feb 2017) Changed paths: M src/plugins/mail-filter/ostream-ext-filter.c Log Message: ----------- mail-filter: Add missing error handling in ostream-ext-filter Compare: https://github.com/dovecot/core/compare/97a8fde13ea3...f64f2d4b7612 From noreply at github.com Fri Feb 24 13:35:36 2017 From: noreply at github.com (GitHub) Date: Fri, 24 Feb 2017 05:35:36 -0800 Subject: [dovecot/core] 20ce57: pop3c: Add no pipelining pop3c feature Message-ID: <58b036a8b5f60_d483ffbe54a7c2c1709b2@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/release-2.2.28 Home: https://github.com/dovecot/core Commit: 20ce57938537938aed7dd41dc274377849258921 https://github.com/dovecot/core/commit/20ce57938537938aed7dd41dc274377849258921 Author: Aki Tuomi Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-storage/index/pop3c/pop3c-client.c M src/lib-storage/index/pop3c/pop3c-client.h M src/lib-storage/index/pop3c/pop3c-mail.c M src/lib-storage/index/pop3c/pop3c-settings.c M src/lib-storage/index/pop3c/pop3c-settings.h M src/lib-storage/index/pop3c/pop3c-storage.c Log Message: ----------- pop3c: Add no pipelining pop3c feature This should help with certain broken pop3c servers that advertise that they support pipelining but they really don't. Commit: 5978243e3c1f44cbb3e55e204f00b5ad9986a9dc https://github.com/dovecot/core/commit/5978243e3c1f44cbb3e55e204f00b5ad9986a9dc Author: Timo Sirainen Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/imap/cmd-fetch.c Log Message: ----------- imap: Revert change to use [PARSE] in FETCH replies. Lets leave this for v2.3. Apparently Roundcube has some workarounds that assume [UNKNOWNCTE]. Partially reverts 8fe64e2af5b6ce7b6ffa6453beaf569dca089e59 Commit: 18abea86df39f1d0d3752debad19d6183e3bc824 https://github.com/dovecot/core/commit/18abea86df39f1d0d3752debad19d6183e3bc824 Author: Timo Sirainen Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-compression/test-compression.c Log Message: ----------- lib-compression: Fix test-compression to build without zlib Commit: 8609bf3875e8b10bce5c7f71c6f714887cea33af https://github.com/dovecot/core/commit/8609bf3875e8b10bce5c7f71c6f714887cea33af Author: Aki Tuomi Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Do not involve mail-deliver plugin unnecessarely If no mail delivery by LDA/LMTP is being done, do not hook into the process. Fixes signal 11 crash with lazy-expunge. Commit: 21fa11e96edc07d22f7c9d3d1873652788061757 https://github.com/dovecot/core/commit/21fa11e96edc07d22f7c9d3d1873652788061757 Author: Aki Tuomi Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-oauth2/oauth2-introspect.c M src/lib-oauth2/oauth2-refresh.c M src/lib-oauth2/oauth2-token-validate.c Log Message: ----------- lib-oauth2: Support basic authorization Commit: 555eef384077b2ae7bf1d1778ad5fb1195b06616 https://github.com/dovecot/core/commit/555eef384077b2ae7bf1d1778ad5fb1195b06616 Author: Aki Tuomi Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- auth: Make tokeninfo optional It is not supported by all OAuth2 solutions Commit: 7de696768fa04cd0ba2fcf617ae74f764615f580 https://github.com/dovecot/core/commit/7de696768fa04cd0ba2fcf617ae74f764615f580 Author: Aki Tuomi Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- auth: Make sure tokeninfo or introspection URL is given Commit: 5de01bc575b2e01eba293ebb1551c33feb0fce26 https://github.com/dovecot/core/commit/5de01bc575b2e01eba293ebb1551c33feb0fce26 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-storage/index/index-mailbox-size.c M src/plugins/pop3-migration/pop3-migration-plugin.c Log Message: ----------- lib-storage, pop3-migration: Reset lookup_abort before continuing to search This doesn't really fix anything right now, but it'll allow adding the asserts in the following commit. Commit: f398b7365449c698ac2d6e43f80483a293ac01cc https://github.com/dovecot/core/commit/f398b7365449c698ac2d6e43f80483a293ac01cc Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-storage/index/index-search.c M src/lib-storage/index/index-sort.c Log Message: ----------- lib-storage: Add asserts to make sure lookup_abort is being used correctly. Commit: 95d26b400d9ca27136d9237d1903fd36868e83e1 https://github.com/dovecot/core/commit/95d26b400d9ca27136d9237d1903fd36868e83e1 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-storage/list/mailbox-list-index.c Log Message: ----------- lib-storage: Fix assert-crash on corrupted dovecot.list.index with name_id==0 Fixes: Panic: file hash.c: line 213 (hash_table_insert_node): assertion failed: (key != NULL) Commit: d9343f584b9d925c22c0f8ae1f641d8e2681af27 https://github.com/dovecot/core/commit/d9343f584b9d925c22c0f8ae1f641d8e2681af27 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-sql/driver-cassandra.c Log Message: ----------- cassandra: Don't use i_error() from non-main thread It will only cause crashes. This was done only if the internal communication pipe couldn't be written to, which was pretty unlikely to happen. Commit: 40e985b4d3bd1ab232c90ef9133131b04104b526 https://github.com/dovecot/core/commit/40e985b4d3bd1ab232c90ef9133131b04104b526 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lmtp/commands.c Log Message: ----------- lmtp: Fix lmtp_user_concurrency_limit when userdb changes the username Anvil LOOKUP was done with the original username, while CONNECT/DISCONNECT was done with the changed username. So LOOKUP always thought that there were zero concurrent sessions for the user. Commit: 3f613b364d4e3c608c406b068b0bb8cefe9b9210 https://github.com/dovecot/core/commit/3f613b364d4e3c608c406b068b0bb8cefe9b9210 Author: Timo Sirainen Date: 2017-02-21 (Tue, 21 Feb 2017) Changed paths: M src/lib-storage/index/index-search.c Log Message: ----------- lib-storage: Fix mail.access_type for search prefetches Commit: 7db846a87ab1226c72a27952b8af14427b6d0d12 https://github.com/dovecot/core/commit/7db846a87ab1226c72a27952b8af14427b6d0d12 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-storage/index/imapc/imapc-mail-fetch.c Log Message: ----------- imapc: Error handling wasn't setting storage error everywhere. This would have used the previous error, which might not have been correct. Commit: 560f734b8c336bf5891630e5a361d683cdf8f5bd https://github.com/dovecot/core/commit/560f734b8c336bf5891630e5a361d683cdf8f5bd Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/imap/cmd-fetch.c M src/imap/imap-fetch.c M src/imap/imap-fetch.h Log Message: ----------- imap: Fix error message in failed FETCH's NO reply. This was broken only with the new imap_fetch_failure = no-after setting. Commit: b5b8b48b5550618aaacc464233724b581e3d1313 https://github.com/dovecot/core/commit/b5b8b48b5550618aaacc464233724b581e3d1313 Author: Martti Rannanj?rvi Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib/test-utc-mktime.c M src/lib/utc-mktime.c M src/lib/utc-mktime.h Log Message: ----------- lib: Accept leap second in utc_mktime Accept leap second at any time in utc_mktime since utc_mktime is being used before applying the timezone offset everywhere. Commit: c0ee6549dc2a191d745aae31b6b41a9c1b8f0055 https://github.com/dovecot/core/commit/c0ee6549dc2a191d745aae31b6b41a9c1b8f0055 Author: Martti Rannanj?rvi Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib/test-utc-mktime.c Log Message: ----------- lib: Place input/output of utc_mktime tests in one struct Define both input and output of a utc_mktime test case in a single struct so it is easier to follow and less error prone. Commit: ed083a3cec391ee078e6aec5534d109d202494fe https://github.com/dovecot/core/commit/ed083a3cec391ee078e6aec5534d109d202494fe Author: Martti Rannanj?rvi Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-mail/test-message-date.c Log Message: ----------- lib-mail: Place input/output of message-date tests in one struct Define both input and output of a message date test case in a single struct so it is easier to follow and less error prone. Also add some leap second tests. Commit: 511e9526553ff5019b0a6573e736e09c5d744e0d https://github.com/dovecot/core/commit/511e9526553ff5019b0a6573e736e09c5d744e0d Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib/test-utc-mktime.c Log Message: ----------- lib: Fix test-utc-mktime with 32bit time_t Commit: 8e2e0028c19d8441867b241bb8e3df172808bbba https://github.com/dovecot/core/commit/8e2e0028c19d8441867b241bb8e3df172808bbba Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Refactor - Add struct mail_deliver_mailbox Commit: 9737f57f49e1acf3c2469b9af2d36592220be64b https://github.com/dovecot/core/commit/9737f57f49e1acf3c2469b9af2d36592220be64b Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Refactor - mail_deliver_log_update_cache() doesn't need entire deliver_ctx Commit: 181b3d6834619b9b9104e2ae16dbd44fb3e1f8a6 https://github.com/dovecot/core/commit/181b3d6834619b9b9104e2ae16dbd44fb3e1f8a6 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Fix delivery logging when Sieve performs multiple actions Previous code assumed that it would work like: - save/copy - transaction commit - mail_deliver_ctx_get_log_var_expand_table() - repeat for transaction 2 While it really works: - transaction 1: save/copy - transaction 2: save/copy - transaction 1: commit - mail_deliver_ctx_get_log_var_expand_table() - transaction 2: commit - mail_deliver_ctx_get_log_var_expand_table() So the cache needs to be stored per transaction. This code still wouldn't work correctly if Sieve saved mails multiple times within the same transaction, but that doesn't happen (at least currently). Commit: 220afa092f5fa6112b087474d3eaf7fb48fe3c30 https://github.com/dovecot/core/commit/220afa092f5fa6112b087474d3eaf7fb48fe3c30 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib/test-utc-mktime.c Log Message: ----------- lib: Fix again test-utc-mktime with 32bit time_t Commit: 7d58e42153761ce05f3219e977ae13856562a3b7 https://github.com/dovecot/core/commit/7d58e42153761ce05f3219e977ae13856562a3b7 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-lda/mail-deliver.c Log Message: ----------- lib-lda: Fix pigeonhole testsuite to not crash Commit: 036e524dd9aa750ad3f41ca8c5973c9cc146ee75 https://github.com/dovecot/core/commit/036e524dd9aa750ad3f41ca8c5973c9cc146ee75 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-storage/mail-storage-service.c M src/lib-storage/mail-storage-service.h M src/lib-storage/mail-user.c Log Message: ----------- lib-storage: Use refcounting for mail_storage_service_user doveadm import was freeing the user too early, which resulted mail_user._service_user pointing to freed memory. More importantly, after 34512eaad8b1b2f929e6d6e3a2f7252c29fba97b user->set was pointing to already freed memory. Commit: d5b90378b94e3bd16357db7896434715a232765d https://github.com/dovecot/core/commit/d5b90378b94e3bd16357db7896434715a232765d Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/doveadm/doveadm-auth-server.c M src/doveadm/doveadm-auth.c M src/doveadm/doveadm-mail-copymove.c M src/doveadm/doveadm-mail-import.c M src/doveadm/doveadm-mail.c M src/imap-urlauth/imap-urlauth-worker.c M src/imap/imap-client.c M src/imap/main.c M src/indexer/master-connection.c M src/lda/main.c M src/lmtp/client.c M src/lmtp/commands.c M src/plugins/mail-crypt/doveadm-mail-crypt.c M src/plugins/mail-crypt/mail-crypt-acl-plugin.c M src/plugins/mail-crypt/test-mail-key.c M src/plugins/quota/quota-status.c M src/pop3/pop3-client.c Log Message: ----------- global: Replace mail_storage_service_user_free() with _unref() Commit: 5d5f9da2865c2857ffe86e4cfef65ef36dbd214e https://github.com/dovecot/core/commit/5d5f9da2865c2857ffe86e4cfef65ef36dbd214e Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/plugins/quota/quota-storage.c Log Message: ----------- quota: Don't log "Internal quota calculation error" It's not very informative and we can't give a better error message without changing the APIs. The real error should have been logged already anyway, so this is just duplication of an error. I think originally this was added because some backend forgot to log an error. Commit: f1e81f70e0b4c6f1194d07a1eb1471253b7cec70 https://github.com/dovecot/core/commit/f1e81f70e0b4c6f1194d07a1eb1471253b7cec70 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-mail/message-part-data.c Log Message: ----------- lib-mail: Fix message_part_data_is_plain_7bit() Content-Type parameters weren't handled exactly right. Broken by recent changes. Commit: c0431a37c29763ba3e0e964c30f25140c536b19e https://github.com/dovecot/core/commit/c0431a37c29763ba3e0e964c30f25140c536b19e Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-storage/index/shared/shared-storage.c Log Message: ----------- lib-storage: Add missing service_user ref when creating shared mailbox's user. Was forgotten from d1bf4ae66b8bf3b9e28df1823d6d4adda2b923b6 Fixes: Panic: file mail-storage-service.c: line 1513 (mail_storage_service_user_unref): assertion failed: (user->refcount > 0) Commit: 759fbc38776844474c32061f7fcdb7310786f716 https://github.com/dovecot/core/commit/759fbc38776844474c32061f7fcdb7310786f716 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/plugins/lazy-expunge/lazy-expunge-plugin.c Log Message: ----------- lazy-expunge: Fix error handling for GUID lookups If the mail is already expunged, the error should be ignored. In other situations the original error string should be preserved as part of the logged error message. Commit: 81196773d98e1b525cd6b29a666b6b646d6ac04e https://github.com/dovecot/core/commit/81196773d98e1b525cd6b29a666b6b646d6ac04e Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/plugins/expire/expire-plugin.c Log Message: ----------- expire plugin: Use correct hook for overriding mail_user vfuncs This was always wrong to do, and it crashes after f32382d2da479a4371e08c443679528db37ea988 Commit: 1ec93ed22322870cff660cf369c07edd96a1b90c https://github.com/dovecot/core/commit/1ec93ed22322870cff660cf369c07edd96a1b90c Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/plugins/trash/trash-plugin.c Log Message: ----------- trash plugin: Use correct hook for overriding mail_user vfuncs This was always wrong to do, and it crashes after f32382d2da479a4371e08c443679528db37ea988 Commit: 923c50bf552ec2febbc35095d8c37749fb55b9dc https://github.com/dovecot/core/commit/923c50bf552ec2febbc35095d8c37749fb55b9dc Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-storage/index/pop3c/pop3c-mail.c Log Message: ----------- pop3c: Prefetched streams didn't call istream_opened() or set virtual_size Commit: 252e82b81f2f87148b1459eb1ab782f92707b3cf https://github.com/dovecot/core/commit/252e82b81f2f87148b1459eb1ab782f92707b3cf Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-storage/index/pop3c/pop3c-mail.c Log Message: ----------- pop3c: Remove unnecessarily duplicated code setting vsize to cache This is important now that the vsize can be added also to index's vsize extension. Commit: bc978f4fe7fd3b08a7d402e9a03bc52bbb5338fd https://github.com/dovecot/core/commit/bc978f4fe7fd3b08a7d402e9a03bc52bbb5338fd Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M src/lib-storage/index/maildir/maildir-mail.c Log Message: ----------- maildir: Fix checking vsize caching decision in "is this pop3 user?" If vsize extension is used, it's practically the same as if vsize's caching decision was YES. Commit: 8dedd4c665f721ae45eadf7ee87f7dd6d068c260 https://github.com/dovecot/core/commit/8dedd4c665f721ae45eadf7ee87f7dd6d068c260 Author: Timo Sirainen Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M NEWS M configure.ac Log Message: ----------- v2.2.28.rc2 released Commit: 00d19e75dc9c4a9702ff5d1f9ee8037f157cc6d4 https://github.com/dovecot/core/commit/00d19e75dc9c4a9702ff5d1f9ee8037f157cc6d4 Author: Timo Sirainen Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/plugins/virtual/virtual-sync.c Log Message: ----------- virtual: Include virtual mailbox name in "Mailbox ID unexpectedly lost" error Commit: 5b2d58c347818e26bb3ebd7e904d8ce4c3803f16 https://github.com/dovecot/core/commit/5b2d58c347818e26bb3ebd7e904d8ce4c3803f16 Author: Aki Tuomi Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- auth: Export oauth2 pass_attrs to passdb reply Commit: bc35deed5cb7e89258521a0c00aa386ee029431d https://github.com/dovecot/core/commit/bc35deed5cb7e89258521a0c00aa386ee029431d Author: Stephan Bosch Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M src/lib-http/http-client-private.h M src/lib-http/http-client-queue.c Log Message: ----------- lib-http: client: Fixed i_unreached() failure occurring when a host's list of IPs changes while a connection is still pending. In that case, the IP of the pending connection may no longer be associated with that host. If the IP was not found anymore, the i_unreached() error occurred. Compare: https://github.com/dovecot/core/compare/9049fe4442d6...bc35deed5cb7 From noreply at github.com Fri Feb 24 13:41:02 2017 From: noreply at github.com (GitHub) Date: Fri, 24 Feb 2017 05:41:02 -0800 Subject: [dovecot/core] bed843: Released v2.2.28. Message-ID: <58b037ee7649a_10703fef6246dc3c207390@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/release-2.2.28 Home: https://github.com/dovecot/core Commit: bed84341d457ca12b3ffc2789f5ce5a50f473c17 https://github.com/dovecot/core/commit/bed84341d457ca12b3ffc2789f5ce5a50f473c17 Author: Timo Sirainen Date: 2017-02-24 (Fri, 24 Feb 2017) Changed paths: M NEWS M configure.ac Log Message: ----------- Released v2.2.28. From noreply at github.com Sat Feb 25 21:00:10 2017 From: noreply at github.com (GitHub) Date: Sat, 25 Feb 2017 13:00:10 -0800 Subject: [dovecot/core] e47cfc: lib-dcrypt: Move most of the OpenSSL #if handling ... Message-ID: <58b1f05a53c23_27f743fbf70c4bc28283050@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: e47cfc3022ce0cf6e158bb39b83e3a57e7d3130e https://github.com/dovecot/core/commit/e47cfc3022ce0cf6e158bb39b83e3a57e7d3130e Author: Timo Sirainen Date: 2017-02-25 (Sat, 25 Feb 2017) Changed paths: M src/lib-dcrypt/dcrypt-openssl.c Log Message: ----------- lib-dcrypt: Move most of the OpenSSL #if handling to macros This avoids #if calls being littered all over the file. This change can cause HMAC_CTX_free(NULL) to be called, but that seems to work fine without crashing. Commit: 061801f2b390700a18cbefa468a7bab003f4cc8d https://github.com/dovecot/core/commit/061801f2b390700a18cbefa468a7bab003f4cc8d Author: Timo Sirainen Date: 2017-02-25 (Sat, 25 Feb 2017) Changed paths: M m4/ssl.m4 M src/lib-dcrypt/dcrypt-openssl.c Log Message: ----------- lib-dcrypt: Replace #if OPENSSL_VERSION_NUMBER with more explicit checks Compare: https://github.com/dovecot/core/compare/f64f2d4b7612...061801f2b390 From noreply at github.com Sun Feb 26 13:00:13 2017 From: noreply at github.com (GitHub) Date: Sun, 26 Feb 2017 05:00:13 -0800 Subject: [dovecot/core] e7b2e5: acl plugin: Fix Coverity warning Message-ID: <58b2d15d9722c_74e93f8f13bf7c3c2321d@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: e7b2e59360809444fac12ba09481bd52becf3d9a https://github.com/dovecot/core/commit/e7b2e59360809444fac12ba09481bd52becf3d9a Author: Timo Sirainen Date: 2017-02-26 (Sun, 26 Feb 2017) Changed paths: M src/plugins/acl/acl-cache.h Log Message: ----------- acl plugin: Fix Coverity warning Just switch the MALLOC_ADD() parameters, so that arithmetic doesn't get inside a sizeof(). Commit: 996155202f9b2d94382ad19b468a84c1f161e04f https://github.com/dovecot/core/commit/996155202f9b2d94382ad19b468a84c1f161e04f Author: Timo Sirainen Date: 2017-02-26 (Sun, 26 Feb 2017) Changed paths: M src/auth/mech-oauth2.c Log Message: ----------- auth: Removed dead code from oauth2 mechanism Commit: 972576585e5758b86d0d9a59e4c6a8f852585c5d https://github.com/dovecot/core/commit/972576585e5758b86d0d9a59e4c6a8f852585c5d Author: Timo Sirainen Date: 2017-02-26 (Sun, 26 Feb 2017) Changed paths: M src/plugins/mail-filter/ostream-ext-filter.c Log Message: ----------- mail-filter: Add missing error handling in ostream-ext-filter Compare: https://github.com/dovecot/core/compare/8c173f2c50b0...972576585e57 From noreply at github.com Sun Feb 26 13:30:10 2017 From: noreply at github.com (GitHub) Date: Sun, 26 Feb 2017 05:30:10 -0800 Subject: [dovecot/core] f05d01: lazy-expunge: Use mailbox_move() instead of mailbo... Message-ID: <58b2d862a7d22_65883f8dd17dfc3c1000c5@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f05d013c67c9af853c3258d59403da13e1d4307b https://github.com/dovecot/core/commit/f05d013c67c9af853c3258d59403da13e1d4307b Author: Timo Sirainen Date: 2017-02-26 (Sun, 26 Feb 2017) Changed paths: M src/plugins/lazy-expunge/lazy-expunge-plugin.c Log Message: ----------- lazy-expunge: Use mailbox_move() instead of mailbox_copy() This allows some optimizations to be performed that are only possible when moving messages. It's slightly strange now that mail_expunge() is triggered twice for the same source mail, but lazy_expunge plugin is called very early so most plugins won't see it called twice. Currently only acl plugin sees it, and it doesn't care. From noreply at github.com Sun Feb 26 13:30:15 2017 From: noreply at github.com (GitHub) Date: Sun, 26 Feb 2017 05:30:15 -0800 Subject: [dovecot/core] 39f751: lazy-expunge: Use mailbox_move() instead of mailbo... Message-ID: <58b2d8676d16b_23ca13fe454511c242345@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 39f751de9bdc0f39d94016ffd9aedb9f06d7a8a8 https://github.com/dovecot/core/commit/39f751de9bdc0f39d94016ffd9aedb9f06d7a8a8 Author: Timo Sirainen Date: 2017-02-26 (Sun, 26 Feb 2017) Changed paths: M src/plugins/lazy-expunge/lazy-expunge-plugin.c Log Message: ----------- lazy-expunge: Use mailbox_move() instead of mailbox_copy() This allows some optimizations to be performed that are only possible when moving messages. It's slightly strange now that mail_expunge() is triggered twice for the same source mail, but lazy_expunge plugin is called very early so most plugins won't see it called twice. Currently only acl plugin sees it, and it doesn't care. From noreply at github.com Sun Feb 26 13:44:59 2017 From: noreply at github.com (GitHub) Date: Sun, 26 Feb 2017 05:44:59 -0800 Subject: [dovecot/core] 27ccbb: dsync: Fix syncing attributes with large values. Message-ID: <58b2dbdbbf7b2_77683ffba4b99c2433558@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 27ccbb0f36e07141785db94557afb63a2aa9eeba https://github.com/dovecot/core/commit/27ccbb0f36e07141785db94557afb63a2aa9eeba Author: Timo Sirainen Date: 2017-02-26 (Sun, 26 Feb 2017) Changed paths: M src/doveadm/dsync/dsync-ibc-stream.c Log Message: ----------- dsync: Fix syncing attributes with large values. This mainly meant that large Sieve scripts weren't synced properly, because their last_change field was never deserialized, so it was set to 0. From noreply at github.com Sun Feb 26 13:45:02 2017 From: noreply at github.com (GitHub) Date: Sun, 26 Feb 2017 05:45:02 -0800 Subject: [dovecot/core] 4d884c: dsync: Fix syncing attributes with large values. Message-ID: <58b2dbde616a6_71253fb90548fc4480539@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 4d884cb9a8781166d013affdd1987912b1a44462 https://github.com/dovecot/core/commit/4d884cb9a8781166d013affdd1987912b1a44462 Author: Timo Sirainen Date: 2017-02-26 (Sun, 26 Feb 2017) Changed paths: M src/doveadm/dsync/dsync-ibc-stream.c Log Message: ----------- dsync: Fix syncing attributes with large values. This mainly meant that large Sieve scripts weren't synced properly, because their last_change field was never deserialized, so it was set to 0. From noreply at github.com Sun Feb 26 13:46:36 2017 From: noreply at github.com (GitHub) Date: Sun, 26 Feb 2017 05:46:36 -0800 Subject: [dovecot/core] 3e6f1c: lib: Fix t_strf*time() unit tests Message-ID: <58b2dc3c86fc9_72f83fe297693c3c55387@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 3e6f1c0a999cc0abfc05d817dd89f39fb9337e76 https://github.com/dovecot/core/commit/3e6f1c0a999cc0abfc05d817dd89f39fb9337e76 Author: Timo Sirainen Date: 2017-02-26 (Sun, 26 Feb 2017) Changed paths: M src/lib/test-time-util.c Log Message: ----------- lib: Fix t_strf*time() unit tests Timezone isn't part of the standard struct tm, so %z doesn't necessarily expand as expected outside Linux. From noreply at github.com Sun Feb 26 13:46:41 2017 From: noreply at github.com (GitHub) Date: Sun, 26 Feb 2017 05:46:41 -0800 Subject: [dovecot/core] 316fb8: lib: Fix t_strf*time() unit tests Message-ID: <58b2dc41af58a_67323f947e093c4032839@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 316fb8bb4d10c5e770b0a9ad07c842e88004100d https://github.com/dovecot/core/commit/316fb8bb4d10c5e770b0a9ad07c842e88004100d Author: Timo Sirainen Date: 2017-02-26 (Sun, 26 Feb 2017) Changed paths: M src/lib/test-time-util.c Log Message: ----------- lib: Fix t_strf*time() unit tests Timezone isn't part of the standard struct tm, so %z doesn't necessarily expand as expected outside Linux. From noreply at github.com Sun Feb 26 22:27:08 2017 From: noreply at github.com (GitHub) Date: Sun, 26 Feb 2017 14:27:08 -0800 Subject: [dovecot/pigeonhole] 38750f: imapsieve plugin: Removed spurious pool field from... Message-ID: <58b3563ced7f0_69133fb02d681c2c191eb@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/tags/dovecot-ee-2.2.25.5-12 Home: https://github.com/dovecot/pigeonhole Commit: 38750f9b5196da4891be304dae856bf522e12f29 https://github.com/dovecot/pigeonhole/commit/38750f9b5196da4891be304dae856bf522e12f29 Author: Stephan Bosch Date: 2016-08-10 (Wed, 10 Aug 2016) Changed paths: M src/plugins/imapsieve/imap-sieve-storage.c Log Message: ----------- imapsieve plugin: Removed spurious pool field from imap_sieve_user struct. Commit: 147a0eac2ca3c12760a447928a337e42f9a2eef8 https://github.com/dovecot/pigeonhole/commit/147a0eac2ca3c12760a447928a337e42f9a2eef8 Author: Stephan Bosch Date: 2016-08-10 (Wed, 10 Aug 2016) Changed paths: M src/plugins/imapsieve/imap-sieve-storage.c Log Message: ----------- imapsieve plugin: Fixed crash occurring when a mailbox is opened for a user before the imap client object is created. Commit: c3d763cbc98ba45ebb8ba7045e6e19a00a67a94e https://github.com/dovecot/pigeonhole/commit/c3d763cbc98ba45ebb8ba7045e6e19a00a67a94e Author: Stephan Bosch Date: 2016-08-23 (Tue, 23 Aug 2016) Changed paths: M src/sieve-tools/sieve-test.c Log Message: ----------- sieve-test: Forgot to disable error handling for dummy SMTP output stream. Commit: 145b2901bd00e5eeef565f262842a902cb9fc3a6 https://github.com/dovecot/pigeonhole/commit/145b2901bd00e5eeef565f262842a902cb9fc3a6 Author: Timo Sirainen Date: 2016-08-23 (Tue, 23 Aug 2016) Changed paths: M src/lib-sieve-tool/mail-raw.c M src/lib-sieve/storage/file/sieve-file-storage-active.c M src/lib-sieve/storage/file/sieve-file-storage-save.c M src/lib-sieve/util/program-client.c M src/sieve-tools/sieve-test.c Log Message: ----------- Use i_unlink() to improve unexpected unlink() error messages. Commit: 6f71a1fb4aa5d1052d2cc3c47f042c6a4bf1317e https://github.com/dovecot/pigeonhole/commit/6f71a1fb4aa5d1052d2cc3c47f042c6a4bf1317e Author: Stephan Bosch Date: 2016-08-23 (Tue, 23 Aug 2016) Changed paths: M src/lib-sieve/util/program-client.c Log Message: ----------- lib-sieve: util: program-client: Fixed position of the seekable stream for the output of remote programs. It would now make the output of the script service seekable, rather than the output of the program. This adds a '+' at the end of the data. This showed up for the extprograms filter command. Commit: 8bb051ee186b8c0ad2c5e676999a1a3c0900b102 https://github.com/dovecot/pigeonhole/commit/8bb051ee186b8c0ad2c5e676999a1a3c0900b102 Author: Stephan Bosch Date: 2016-08-30 (Tue, 30 Aug 2016) Changed paths: M src/plugins/doveadm-sieve/doveadm-sieve-sync.c Log Message: ----------- doveadm sieve plugin: sync: Fixed handling of unknown attribute timestamps. Compare: https://github.com/dovecot/pigeonhole/compare/38750f9b5196^...8bb051ee186b From noreply at github.com Sun Feb 26 22:27:09 2017 From: noreply at github.com (GitHub) Date: Sun, 26 Feb 2017 14:27:09 -0800 Subject: [dovecot/pigeonhole] 7cc102: Released v0.4.17 for Dovecot v2.2.28. Message-ID: <58b3563d4af0f_61c33fb1bc02fc30969f9@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/release-0.4.17 Home: https://github.com/dovecot/pigeonhole Commit: 7cc102e51edf791fe9df8a7da7f6d13ff30d16d7 https://github.com/dovecot/pigeonhole/commit/7cc102e51edf791fe9df8a7da7f6d13ff30d16d7 Author: Stephan Bosch Date: 2017-02-26 (Sun, 26 Feb 2017) Changed paths: M NEWS M configure.ac Log Message: ----------- Released v0.4.17 for Dovecot v2.2.28. From noreply at github.com Mon Feb 27 10:00:11 2017 From: noreply at github.com (GitHub) Date: Mon, 27 Feb 2017 02:00:11 -0800 Subject: [dovecot/core] e5d065: master: add cassandra to printed build options Message-ID: <58b3f8abdc7b3_605a3fb619c53c3077023@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: e5d0656cb24c50b731d6cbb229875b9960a478f5 https://github.com/dovecot/core/commit/e5d0656cb24c50b731d6cbb229875b9960a478f5 Author: Martti Rannanj?rvi Date: 2017-02-27 (Mon, 27 Feb 2017) Changed paths: M src/master/main.c Log Message: ----------- master: add cassandra to printed build options From noreply at github.com Mon Feb 27 13:00:11 2017 From: noreply at github.com (GitHub) Date: Mon, 27 Feb 2017 05:00:11 -0800 Subject: [dovecot/core] 6ebe7a: doveadm move: Use mailbox_move() instead of copy+e... Message-ID: <58b422db13116_6a223fba60ab1c385119d@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 6ebe7a974a5b32dd3f2d5f4f08d22aa993283e65 https://github.com/dovecot/core/commit/6ebe7a974a5b32dd3f2d5f4f08d22aa993283e65 Author: Timo Sirainen Date: 2017-02-27 (Mon, 27 Feb 2017) Changed paths: M src/doveadm/doveadm-mail-copymove.c Log Message: ----------- doveadm move: Use mailbox_move() instead of copy+expunge This allows for some optimizations to be done. From noreply at github.com Mon Feb 27 13:30:15 2017 From: noreply at github.com (GitHub) Date: Mon, 27 Feb 2017 05:30:15 -0800 Subject: [dovecot/core] 9a1695: lib-dcrypt: Move most of the OpenSSL #if handling ... Message-ID: <58b429e72ea4_638f3fe259639c349124d@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 9a1695882a5bfd8dd899cad85445b11266f356e0 https://github.com/dovecot/core/commit/9a1695882a5bfd8dd899cad85445b11266f356e0 Author: Timo Sirainen Date: 2017-02-27 (Mon, 27 Feb 2017) Changed paths: M src/lib-dcrypt/dcrypt-openssl.c Log Message: ----------- lib-dcrypt: Move most of the OpenSSL #if handling to macros This avoids #if calls being littered all over the file. This change can cause HMAC_CTX_free(NULL) to be called, but that seems to work fine without crashing. Commit: 8825f7a883ecc6aeda8a17376a87a46ae9193fc7 https://github.com/dovecot/core/commit/8825f7a883ecc6aeda8a17376a87a46ae9193fc7 Author: Timo Sirainen Date: 2017-02-27 (Mon, 27 Feb 2017) Changed paths: M configure.ac M src/lib-dcrypt/dcrypt-openssl.c Log Message: ----------- lib-dcrypt: Replace #if OPENSSL_VERSION_NUMBER with more explicit checks Commit: 5cd4c53efc629dc85c3a23c654b6ad4ff44b7106 https://github.com/dovecot/core/commit/5cd4c53efc629dc85c3a23c654b6ad4ff44b7106 Author: Martti Rannanj?rvi Date: 2017-02-27 (Mon, 27 Feb 2017) Changed paths: M src/master/main.c Log Message: ----------- master: add cassandra to printed build options Commit: 649b00f4a7759267dcffd05b244512b628388725 https://github.com/dovecot/core/commit/649b00f4a7759267dcffd05b244512b628388725 Author: Timo Sirainen Date: 2017-02-27 (Mon, 27 Feb 2017) Changed paths: M src/doveadm/doveadm-mail-copymove.c Log Message: ----------- doveadm move: Use mailbox_move() instead of copy+expunge This allows for some optimizations to be done. Compare: https://github.com/dovecot/core/compare/316fb8bb4d10...649b00f4a775 From noreply at github.com Mon Feb 27 18:00:16 2017 From: noreply at github.com (GitHub) Date: Mon, 27 Feb 2017 10:00:16 -0800 Subject: [dovecot/core] fcbeb4: doveadm: Fix allow-empty-mailbox-name handling Message-ID: <58b46930b11cb_6d733fd9400e7c3064652@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: fcbeb4fc58cb6981e114dd6486cde6a4039c364d https://github.com/dovecot/core/commit/fcbeb4fc58cb6981e114dd6486cde6a4039c364d Author: Aki Tuomi Date: 2017-02-27 (Mon, 27 Feb 2017) Changed paths: M src/doveadm/doveadm-mail-mailbox-metadata.c M src/doveadm/doveadm-mail.c M src/doveadm/doveadm-mail.h Log Message: ----------- doveadm: Fix allow-empty-mailbox-name handling It was supposed to be handled for metadata commands only. Broken in 26c41874cf6019c3e39f0ed630b2a07a92b2635f Commit: d466d48bda68cb8c368ca88527e86f1bfa245ab9 https://github.com/dovecot/core/commit/d466d48bda68cb8c368ca88527e86f1bfa245ab9 Author: Aki Tuomi Date: 2017-02-27 (Mon, 27 Feb 2017) Changed paths: M src/doveadm/doveadm-mail.c Log Message: ----------- doveadm: Ensure -- is added to command line before positional arguments This prevents parser from choking on dash. Compare: https://github.com/dovecot/core/compare/649b00f4a775...d466d48bda68 From noreply at github.com Mon Feb 27 18:00:11 2017 From: noreply at github.com (GitHub) Date: Mon, 27 Feb 2017 10:00:11 -0800 Subject: [dovecot/core] 9384ef: doveadm: Fix allow-empty-mailbox-name handling Message-ID: <58b4692bdc772_22c5c3fbd08963c3c100547@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 9384ef699a57687ce6dbdae7d686181f4791b1e5 https://github.com/dovecot/core/commit/9384ef699a57687ce6dbdae7d686181f4791b1e5 Author: Aki Tuomi Date: 2017-02-27 (Mon, 27 Feb 2017) Changed paths: M src/doveadm/doveadm-mail-mailbox-metadata.c M src/doveadm/doveadm-mail.c M src/doveadm/doveadm-mail.h Log Message: ----------- doveadm: Fix allow-empty-mailbox-name handling It was supposed to be handled for metadata commands only. Broken in 26c41874cf6019c3e39f0ed630b2a07a92b2635f Commit: 967efe37d1f10a28c0a086cc5919d4ce8917bed8 https://github.com/dovecot/core/commit/967efe37d1f10a28c0a086cc5919d4ce8917bed8 Author: Aki Tuomi Date: 2017-02-27 (Mon, 27 Feb 2017) Changed paths: M src/doveadm/doveadm-mail.c Log Message: ----------- doveadm: Ensure -- is added to command line before positional arguments This prevents parser from choking on dash. Compare: https://github.com/dovecot/core/compare/6ebe7a974a5b...967efe37d1f1 From noreply at github.com Mon Feb 27 19:30:10 2017 From: noreply at github.com (GitHub) Date: Mon, 27 Feb 2017 11:30:10 -0800 Subject: [dovecot/core] 235ef8: doveadm: Ensure -- is added to command line before... Message-ID: <58b47e42ead50_652b3fb0629bdc44445d0@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 235ef8cd3865984cc27f88a18d14ea98adb53f09 https://github.com/dovecot/core/commit/235ef8cd3865984cc27f88a18d14ea98adb53f09 Author: Aki Tuomi Date: 2017-02-27 (Mon, 27 Feb 2017) Changed paths: M src/doveadm/doveadm-cmd.c Log Message: ----------- doveadm: Ensure -- is added to command line before positional arguments for non-mails commands as well Was forgotten from 967efe37d1f10a28c0a086cc5919d4ce8917bed8 Commit: 1f58bee818868d7261224766b66182c8eaf31ba8 https://github.com/dovecot/core/commit/1f58bee818868d7261224766b66182c8eaf31ba8 Author: Aki Tuomi Date: 2017-02-27 (Mon, 27 Feb 2017) Changed paths: M src/doveadm/doveadm-proxy.c Log Message: ----------- doveadm: Add missing newline to proxy kick output Compare: https://github.com/dovecot/core/compare/967efe37d1f1...1f58bee81886 From noreply at github.com Mon Feb 27 19:30:16 2017 From: noreply at github.com (GitHub) Date: Mon, 27 Feb 2017 11:30:16 -0800 Subject: [dovecot/core] 67c6ef: doveadm: Ensure -- is added to command line before... Message-ID: <58b47e48f8ca_60773ff66b2d1c388364c@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 67c6ef1488a9fd1e87b5891665c700c122e50316 https://github.com/dovecot/core/commit/67c6ef1488a9fd1e87b5891665c700c122e50316 Author: Aki Tuomi Date: 2017-02-27 (Mon, 27 Feb 2017) Changed paths: M src/doveadm/doveadm-cmd.c Log Message: ----------- doveadm: Ensure -- is added to command line before positional arguments for non-mails commands as well Was forgotten from 967efe37d1f10a28c0a086cc5919d4ce8917bed8 Commit: de93e9557850f39b1b7d3cd99586dc4ee5d59ac1 https://github.com/dovecot/core/commit/de93e9557850f39b1b7d3cd99586dc4ee5d59ac1 Author: Aki Tuomi Date: 2017-02-27 (Mon, 27 Feb 2017) Changed paths: M src/doveadm/doveadm-proxy.c Log Message: ----------- doveadm: Add missing newline to proxy kick output Compare: https://github.com/dovecot/core/compare/d466d48bda68...de93e9557850 From noreply at github.com Tue Feb 28 07:30:09 2017 From: noreply at github.com (GitHub) Date: Mon, 27 Feb 2017 23:30:09 -0800 Subject: [dovecot/core] 71cb0c: imap-hibernate: Support userdb in var_expand Message-ID: <58b527019d29a_3e243fd54baa3c2c1054d0@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 71cb0c74694b7c73116423c961b2effd9c22f284 https://github.com/dovecot/core/commit/71cb0c74694b7c73116423c961b2effd9c22f284 Author: Aki Tuomi Date: 2017-02-28 (Tue, 28 Feb 2017) Changed paths: M src/imap-hibernate/imap-client.c Log Message: ----------- imap-hibernate: Support userdb in var_expand