[dovecot/core] 9c7e81: lib-index: don't reset ioloop_time on mmap error

GitHub noreply at github.com
Mon Feb 13 14:30:10 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 9c7e81a1f5e629efa2324c6c22ce02f6f6e9c792
      https://github.com/dovecot/core/commit/9c7e81a1f5e629efa2324c6c22ce02f6f6e9c792
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M src/lib-index/mail-transaction-log-file.c

  Log Message:
  -----------
  lib-index: don't reset ioloop_time on mmap error

The variables seems to have been in the wrong order.


  Commit: 8e90ca575864d29d0ded6ea71cd9747aab0a38f4
      https://github.com/dovecot/core/commit/8e90ca575864d29d0ded6ea71cd9747aab0a38f4
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M src/lib-index/mail-transaction-log-file.c

  Log Message:
  -----------
  lib-index: clear file->mmap_size only after logging it

Logging the error with size=0 loses information.


  Commit: 887c92aa9f171ab90e417de48ffa08d4909c809a
      https://github.com/dovecot/core/commit/887c92aa9f171ab90e417de48ffa08d4909c809a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M src/lib-http/http-client-request.c

  Log Message:
  -----------
  lib-http: http_client_request_add_header() - Add key/value asserts

These don't check that they're entirely correct as required by HTTP
specifications. They're mainly there as a quick check that if the caller
didn't validate the key/value in any way, we'll crash instead of creating
a potential security hole. (Because with line feeds the attacker could
add extra headers or even entirely new HTTP requests.)


Compare: https://github.com/dovecot/core/compare/bbe7af3946f0...887c92aa9f17


More information about the dovecot-cvs mailing list