[dovecot/core] d1c780: fts-solr: Allow username/password for solr conncti...

GitHub noreply at github.com
Fri Feb 17 10:00:17 UTC 2017


  Branch: refs/heads/master-2.2
  Home:   https://github.com/dovecot/core
  Commit: d1c780493d52ea00588a08fdc41179f56c725122
      https://github.com/dovecot/core/commit/d1c780493d52ea00588a08fdc41179f56c725122
  Author: J. Nick Koston <nick at cpanel.net>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/plugins/fts-solr/solr-connection.c

  Log Message:
  -----------
  fts-solr: Allow username/password for solr connction

Solr comes open to the world by default. For better
security, we protect our solr installs with a user
and password.  This change allows dovecot to connect
to these instances.

Example usage in a fts.conf (permissions 0600)
 fts_solr = url=http://nick:pass@127.0.0.1:8983/solr/dovecot/


  Commit: 01672205411fc802f2e9436459706afc71dc2dd7
      https://github.com/dovecot/core/commit/01672205411fc802f2e9436459706afc71dc2dd7
  Author: johnkwoods <john.woods at greatplainsmfg.com>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-ldap/ldap-compare.c

  Log Message:
  -----------
  lib-ldap: Remove extra return

The ldap_connection_queue_request() function returns void. Trying to
"return" something from a void function caused compiling issues on
Solaris (Oracle Developer Studio 12.5).


  Commit: 77643f9f68929c7225c659227c24080e25292519
      https://github.com/dovecot/core/commit/77643f9f68929c7225c659227c24080e25292519
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-storage/mail-user.c
    M src/lib-storage/mail-user.h

  Log Message:
  -----------
  lib-storage: Added mail_user_init_ssl_client_settings().


  Commit: 1cf6991dfb4fe2f3301782bddc337a76b187ed1e
      https://github.com/dovecot/core/commit/1cf6991dfb4fe2f3301782bddc337a76b187ed1e
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib/connection.c

  Log Message:
  -----------
  lib: Check that output max size is non-zero when version specified

Otherwise we try to send version to non-existent output
stream.


  Commit: 1e2f5bf8c2d2ec575f34ab72b6237b61dc2ab8f4
      https://github.com/dovecot/core/commit/1e2f5bf8c2d2ec575f34ab72b6237b61dc2ab8f4
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/plugins/quota/quota-private.h
    M src/plugins/quota/quota-util.c
    M src/plugins/quota/quota.c

  Log Message:
  -----------
  quota: When executing quota_warning/over_flag script, log the reason why.


  Commit: a3eb84689201b94d2c42ba3e28c30a735b6ec5c7
      https://github.com/dovecot/core/commit/a3eb84689201b94d2c42ba3e28c30a735b6ec5c7
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/plugins/quota/quota.c

  Log Message:
  -----------
  quota: Make sure quota_warning doesn't wrap "quota before" value.

This could happen in some race conditions (and with bugs).


  Commit: aabb256a43c1a2c882c4871d0d140254e2b386cd
      https://github.com/dovecot/core/commit/aabb256a43c1a2c882c4871d0d140254e2b386cd
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/plugins/quota/quota-count.c
    M src/plugins/quota/quota-private.h

  Log Message:
  -----------
  quota: Clarify quota_count() return value.


  Commit: df745bdb6559f10e9501ecd998e3e3f56b780359
      https://github.com/dovecot/core/commit/df745bdb6559f10e9501ecd998e3e3f56b780359
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-storage/index/dbox-single/sdbox-storage.c

  Log Message:
  -----------
  sdbox: Fix assert-crash on mailbox create race

If another process created the mailbox at the same time, the mailbox_guid
wasn't set and opening the mailbox assert-crashed:

Panic: file mail-storage.c: line 1744 (mailbox_get_metadata): assertion failed: ((items & MAILBOX_METADATA_GUID) == 0 || !guid_128_is_empty(metadata_r->guid))


  Commit: d3d515c933b09d3748426d684d35f85b65993d1a
      https://github.com/dovecot/core/commit/d3d515c933b09d3748426d684d35f85b65993d1a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M TODO

  Log Message:
  -----------
  TODO: Remove some of the implemented features


  Commit: 87c56d07369961411a9a5e448c2c4ee32e5697b5
      https://github.com/dovecot/core/commit/87c56d07369961411a9a5e448c2c4ee32e5697b5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib/malloc-overflow.h

  Log Message:
  -----------
  lib: Avoid unnecessary Coverity warnings in MALLOC_*()

There doesn't seem to be any other nice way of avoiding these without
separately marking every instance.


  Commit: 2b467064287358345299be8609990f44725045b6
      https://github.com/dovecot/core/commit/2b467064287358345299be8609990f44725045b6
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/doveadm/doveadm-director.c

  Log Message:
  -----------
  doveadm director map: Fix checking if host parameter is required


  Commit: 247f01bdadd3a0bbc2e42793aedb39a51df11916
      https://github.com/dovecot/core/commit/247f01bdadd3a0bbc2e42793aedb39a51df11916
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/plugins/mail-crypt/doveadm-mail-crypt.c

  Log Message:
  -----------
  doveadm mailbox cryptokey generate: Fix memory leak

dest_user was set to NULL, but never freed.


  Commit: 3a42316eeebc50ee4b42324cbfbf7c7d48ef46cb
      https://github.com/dovecot/core/commit/3a42316eeebc50ee4b42324cbfbf7c7d48ef46cb
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/plugins/mail-crypt/doveadm-mail-crypt.c

  Log Message:
  -----------
  doveadm mailbox cryptokey generate: Fix error handling

Don't crash if mail_user creation failed.


  Commit: a21568964277635bf8cea8416edec9b613e12160
      https://github.com/dovecot/core/commit/a21568964277635bf8cea8416edec9b613e12160
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/plugins/mail-crypt/mail-crypt-acl-plugin.c

  Log Message:
  -----------
  mail-crypt-acl: Fix error handling

Don't crash if mail_user creation failed.


  Commit: b2a28aee65bc206b0103ea963c362b24464320a3
      https://github.com/dovecot/core/commit/b2a28aee65bc206b0103ea963c362b24464320a3
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/doveadm/doveadm-mail-mailbox-metadata.c

  Log Message:
  -----------
  doveadm mailbox metadata list: Fix listing all metadata.

It was listing only private attributes, because key_type=0 happens to be
MAIL_ATTRIBUTE_TYPE_PRIVATE and key was never NULL.


  Commit: edeae7ffe695a056ff5d6ed05a46a654708a7f53
      https://github.com/dovecot/core/commit/edeae7ffe695a056ff5d6ed05a46a654708a7f53
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/plugins/fts/fts-storage.c

  Log Message:
  -----------
  fts: Fix crash using fts_autoexpunge_exclude = \Special-use crash

It crashed whenever seeing a mailbox that didn't have any special-use flags.


  Commit: 2ed6bdbbd2134b176cf3616a90a32927f6c54eb9
      https://github.com/dovecot/core/commit/2ed6bdbbd2134b176cf3616a90a32927f6c54eb9
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/plugins/mail-filter/istream-ext-filter.c

  Log Message:
  -----------
  mail-filter: Handle handshake write() failure


  Commit: 7abf8f2da4774fd3fd4e483e190f475e95ad5733
      https://github.com/dovecot/core/commit/7abf8f2da4774fd3fd4e483e190f475e95ad5733
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/imap-urlauth/imap-urlauth-worker.c
    M src/plugins/virtual/virtual-storage.c

  Log Message:
  -----------
  global: Ignore unnecessary return values.


  Commit: a3fbc77562ffc384d454609bac302e10f96f71ca
      https://github.com/dovecot/core/commit/a3fbc77562ffc384d454609bac302e10f96f71ca
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/pop3-login/client.c

  Log Message:
  -----------
  pop3-login: Code cleanup - Make sure destroying client stops processing.

It would currently do it in any case, but this makes it clearer.


  Commit: fe529b28ac636738294c6c787d4c569a49323f2a
      https://github.com/dovecot/core/commit/fe529b28ac636738294c6c787d4c569a49323f2a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/auth/db-ldap.c
    M src/doveadm/doveadm-mail-index.c
    M src/lib-auth/auth-master.c
    M src/lib-fs/fs-posix.c
    M src/lib-storage/index/mbox/mbox-save.c
    M src/lib-storage/mail-autoexpunge.c
    M src/lib/file-dotlock.c
    M src/lib/iostream-temp.c

  Log Message:
  -----------
  global: Add asserts to make static analyzer happier.


  Commit: da01950bef06bafc21af9d519377a4c8d37ac937
      https://github.com/dovecot/core/commit/da01950bef06bafc21af9d519377a4c8d37ac937
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/plugins/quota/quota-private.h
    M src/plugins/quota/quota.c

  Log Message:
  -----------
  quota: Remove quota_over_flag_* from quota_root.

They are used only in one specific location and don't need to be stored
permanently.


  Commit: 23a6d2decd9d377dc0b392b4762f7cddcd52de44
      https://github.com/dovecot/core/commit/23a6d2decd9d377dc0b392b4762f7cddcd52de44
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/plugins/quota/quota.c

  Log Message:
  -----------
  quota: If quota_over_flag_value is unset, skip the quota_over check.


  Commit: f51b1ce706d381b04cc71dc478bb29c5d1c6249a
      https://github.com/dovecot/core/commit/f51b1ce706d381b04cc71dc478bb29c5d1c6249a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/plugins/quota/quota.c

  Log Message:
  -----------
  quota: If quota_over_script is unset, skip the quota_over check.


  Commit: f2ecd4262187ae74f4377aa15dbca3d8862aac62
      https://github.com/dovecot/core/commit/f2ecd4262187ae74f4377aa15dbca3d8862aac62
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/plugins/quota/quota.c

  Log Message:
  -----------
  quota: Log why quota_over_flag check is skipped if mail_debug=yes


  Commit: bae12f8e00f17ae346a45005ab34959c8f362346
      https://github.com/dovecot/core/commit/bae12f8e00f17ae346a45005ab34959c8f362346
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-index/mail-transaction-log-file.c

  Log Message:
  -----------
  lib-index: don't reset ioloop_time on mmap error

The variables seems to have been in the wrong order.


  Commit: 77486efb4f1dcded2ad1954eb288a1b9ec6b9e82
      https://github.com/dovecot/core/commit/77486efb4f1dcded2ad1954eb288a1b9ec6b9e82
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-index/mail-transaction-log-file.c

  Log Message:
  -----------
  lib-index: clear file->mmap_size only after logging it

Logging the error with size=0 loses information.


  Commit: ea6a744d0931246e9d6356bc1723a7e38cb5fe4a
      https://github.com/dovecot/core/commit/ea6a744d0931246e9d6356bc1723a7e38cb5fe4a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-http/http-client-request.c

  Log Message:
  -----------
  lib-http: http_client_request_add_header() - Add key/value asserts

These don't check that they're entirely correct as required by HTTP
specifications. They're mainly there as a quick check that if the caller
didn't validate the key/value in any way, we'll crash instead of creating
a potential security hole. (Because with line feeds the attacker could
add extra headers or even entirely new HTTP requests.)


  Commit: e72d13f3bec179b93d6dacf2fb44d68d8c5d1710
      https://github.com/dovecot/core/commit/e72d13f3bec179b93d6dacf2fb44d68d8c5d1710
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-compression/istream-zlib.c
    M src/lib-compression/test-compression.c

  Log Message:
  -----------
  lib-compress: Fix assert-crash when .gz header size exceeds buffer max length

Instead treat the stream as corrupted and return EINVAL.

Fixes:
Panic: file istream.c: line 182 (i_stream_read): assertion failed: (_stream->skip != _stream->pos)


  Commit: 391e998096c5a821138495d5b8f873b21791aec4
      https://github.com/dovecot/core/commit/391e998096c5a821138495d5b8f873b21791aec4
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-compression/istream-zlib.c

  Log Message:
  -----------
  lib-compress: Fix missing .gz header error message


  Commit: c92338c67ffe69332d490d98ff43ccf005fd1765
      https://github.com/dovecot/core/commit/c92338c67ffe69332d490d98ff43ccf005fd1765
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-sql/driver-cassandra.c

  Log Message:
  -----------
  cassandra: Track query counts internally and include them in metrics


  Commit: 583320bd80c0f0052e654b8537df5fd1e1db73c5
      https://github.com/dovecot/core/commit/583320bd80c0f0052e654b8537df5fd1e1db73c5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-index/mail-index-sync-update.c
    M src/lib-index/mail-index-sync.c
    M src/lib-index/mail-index.h

  Log Message:
  -----------
  lib-index: Add MAIL_INDEX_OPEN_FLAG_NO_DIRTY

This way mailbox format backends that don't need dirty flags can use them
for other purposes.


  Commit: cc42a09c50b1eb4eb6b4458f5cab1b750e95eadc
      https://github.com/dovecot/core/commit/cc42a09c50b1eb4eb6b4458f5cab1b750e95eadc
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M configure.ac
    M src/lib-sql/driver-cassandra.c

  Log Message:
  -----------
  driver-cassandra: Add support for speculative execution


  Commit: 27ec4694cc210edad3bd27d1f07606be589dc95f
      https://github.com/dovecot/core/commit/27ec4694cc210edad3bd27d1f07606be589dc95f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-storage/list/mailbox-list-index-sync.c
    M src/lib-storage/list/mailbox-list-index.c
    M src/lib-storage/list/mailbox-list-index.h

  Log Message:
  -----------
  LAYOUT=index: Rename mailbox_list_index_node.corrupted_parent to corrupted_ext

The code will be useful for other purposes also besides updating corrupted
parents.


  Commit: 9eb09dec6375f818f52e01c1eb840282ad370ce0
      https://github.com/dovecot/core/commit/9eb09dec6375f818f52e01c1eb840282ad370ce0
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-storage/list/mailbox-list-index.c

  Log Message:
  -----------
  LAYOUT=index: Fix duplicate mailbox name renaming to actually work


  Commit: a108b91f10c0013c1fe95d4656261f785951dd22
      https://github.com/dovecot/core/commit/a108b91f10c0013c1fe95d4656261f785951dd22
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib/mempool-alloconly.c
    M src/lib/mempool.h

  Log Message:
  -----------
  lib: Add pool_alloconly_create_clean()

This partially reverts 2a2beae3a4c1e75b3aeff996781503138e6f24bc


  Commit: b627d2a108483252120ae0697740ac930263de1e
      https://github.com/dovecot/core/commit/b627d2a108483252120ae0697740ac930263de1e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib/strfuncs.h
    M src/lib/test-strfuncs.c

  Log Message:
  -----------
  lib: Clarify *_strsplit_spaces() and add unit test


  Commit: 2ffab546e929ad86b8ad8bd4f80af3d7e8650c2c
      https://github.com/dovecot/core/commit/2ffab546e929ad86b8ad8bd4f80af3d7e8650c2c
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/plugins/mail-crypt/test-mail-key.c

  Log Message:
  -----------
  mail-crypt: Do not restrict access in unit test

This works around problem with docker


  Commit: 70bc7ec0cd965fcc0e2149b74a018abcb63752a3
      https://github.com/dovecot/core/commit/70bc7ec0cd965fcc0e2149b74a018abcb63752a3
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-index/mail-cache.c

  Log Message:
  -----------
  lib-index: zero mmap_length after logging error

Logging that mmap(size=0) failed looks suspicious.


  Commit: 9fbca088270bbd901ae7264d20a6581be896e5d2
      https://github.com/dovecot/core/commit/9fbca088270bbd901ae7264d20a6581be896e5d2
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-storage/list/mailbox-list-index-backend.c
    M src/lib-storage/list/mailbox-list-index-status.c
    M src/lib-storage/list/mailbox-list-index.c
    M src/lib-storage/list/mailbox-list-index.h

  Log Message:
  -----------
  lib-storage: Fix mailbox list index hook usage

The previous method appeared to work, but not if the internal hooks were
used more than once.


  Commit: ef88cf8738d884d7d94cf3f6a719ca35fd5e759a
      https://github.com/dovecot/core/commit/ef88cf8738d884d7d94cf3f6a719ca35fd5e759a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-storage/index/index-transaction.c
    M src/lib-storage/mail-storage-private.h
    M src/lib-storage/mail-storage.c

  Log Message:
  -----------
  lib-storage: Always create mail_save_context.dest_mail

This allows removing similar mail_alloc() from storage backends and plugins
that need it.

As a side effect, this changes mbox code to always assign UIDs to saved
mails. This shouldn't be much of a problem, since it happened practically
always already.


  Commit: 7c9cb6389fec12063b8829fd42698606825be3d3
      https://github.com/dovecot/core/commit/7c9cb6389fec12063b8829fd42698606825be3d3
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-storage/index/cydir/cydir-save.c
    M src/lib-storage/index/dbox-common/dbox-save.c
    M src/lib-storage/index/dbox-common/dbox-save.h
    M src/lib-storage/index/dbox-multi/mdbox-save.c
    M src/lib-storage/index/dbox-single/sdbox-copy.c
    M src/lib-storage/index/dbox-single/sdbox-save.c
    M src/lib-storage/index/imapc/imapc-save.c
    M src/lib-storage/index/index-mail.c
    M src/lib-storage/index/index-storage.c
    M src/lib-storage/index/maildir/maildir-save.c
    M src/lib-storage/index/mbox/mbox-save.c
    M src/lib-storage/index/mbox/mbox-sync-private.h
    M src/lib-storage/index/mbox/mbox-sync.c

  Log Message:
  -----------
  lib-storage: Remove unnecessary mail_save_context.dest_mail==NULL checks

It can never be NULL after the previous change: "lib-storage: Always create
mail_save_context.dest_mail".

The code removal in maildir_transaction_save_commit_pre() seemed
potentially dangerous, but I don't think such code path is possible
anymore. Also even if it is, it's probably fine since the mail_free()
is called even earlier than before (although that itself might have
been a problem).

This also removes last traces of code that made it possible to save mails to
mbox without assigning UID to the mail. The previous commit already caused
this, so this is just removing dead code.


  Commit: 18bfb2a5a84e14c3b1ab9129b7d9dc8d083558a7
      https://github.com/dovecot/core/commit/18bfb2a5a84e14c3b1ab9129b7d9dc8d083558a7
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/plugins/notify/notify-storage.c
    M src/plugins/quota/quota-storage.c
    M src/plugins/virtual/virtual-save.c
    M src/plugins/zlib/zlib-plugin.c

  Log Message:
  -----------
  plugins: Remove unnecessary mail_save_context.dest_mail==NULL checks

It can never be NULL after the previous change: "lib-storage: Always create
mail_save_context.dest_mail".


  Commit: 6816dcc048cb84d6675a480d5c69682b027eb651
      https://github.com/dovecot/core/commit/6816dcc048cb84d6675a480d5c69682b027eb651
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/plugins/virtual/virtual-mail.c
    M src/plugins/virtual/virtual-save.c
    M src/plugins/virtual/virtual-storage.h

  Log Message:
  -----------
  virtual: Fix saving to a virtual mailbox to work again

Previous changes broke it.


  Commit: 4c3958af8840fac013ccc4a10fbe9579d447d95d
      https://github.com/dovecot/core/commit/4c3958af8840fac013ccc4a10fbe9579d447d95d
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-storage/mail-storage.c
    M src/lib-storage/mail-storage.h

  Log Message:
  -----------
  lib-storage: Add mailbox_save_get_dest_mail()

This marks mailbox_save_set_dest_mail deprecated. It's not efficient to use
since it frees the already-created dest_mail.


  Commit: 99e60a23c0f287d32aa29d64261c9e792d124c41
      https://github.com/dovecot/core/commit/99e60a23c0f287d32aa29d64261c9e792d124c41
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-lda/mail-deliver.c

  Log Message:
  -----------
  lib-lda: Avoid using mailbox_save_set_dest_mail()


  Commit: e9744a9bcaa1ae1ac9373d120907644a744f0716
      https://github.com/dovecot/core/commit/e9744a9bcaa1ae1ac9373d120907644a744f0716
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-lda/mail-deliver.c

  Log Message:
  -----------
  lib-lda: Initialize var_expand_tab[] directly.

This is a partially pick from acfda38b75d0f0e899ef692fef01593bd56ed85e
to be able to cherry-pick the following patches more easily.


  Commit: 3c8711e32188d2a2368a43fafc2709dc57dc3d18
      https://github.com/dovecot/core/commit/3c8711e32188d2a2368a43fafc2709dc57dc3d18
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-lda/mail-deliver.c
    M src/lib-lda/mail-deliver.h

  Log Message:
  -----------
  lib-lda: Remove unused mail_deliver_get_log_var_expand_table()


  Commit: 051cf2c837fbc80c5365228c34e2dcba34c728ad
      https://github.com/dovecot/core/commit/051cf2c837fbc80c5365228c34e2dcba34c728ad
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-lda/mail-deliver.c

  Log Message:
  -----------
  lib-lda: remove forced logging of session_id


  Commit: 603346248f2b329f611598a5e8f2c90c8b1c8dd5
      https://github.com/dovecot/core/commit/603346248f2b329f611598a5e8f2c90c8b1c8dd5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-lda/mail-deliver.c
    M src/lib-lda/mail-deliver.h

  Log Message:
  -----------
  lib-lda: Redesign mail_deliver_context.var_expand_table cache


  Commit: db8465fd09dc397b933af034c0aaa4229d516359
      https://github.com/dovecot/core/commit/db8465fd09dc397b933af034c0aaa4229d516359
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-lda/mail-deliver.c

  Log Message:
  -----------
  lib-lda: Remove %{storage_id} setting for now.

It doesn't work with Sieve. The following patches add it back properly.


  Commit: d19c4448687115ec0704e717c25368b7cddd3e82
      https://github.com/dovecot/core/commit/d19c4448687115ec0704e717c25368b7cddd3e82
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-lda/mail-deliver.c

  Log Message:
  -----------
  lib-lda: Code cleanup - mail_deliver_open_mail() now uses uid parameter


  Commit: 0f196b4cf12ddba3ea6dac89602e4506817d9f41
      https://github.com/dovecot/core/commit/0f196b4cf12ddba3ea6dac89602e4506817d9f41
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lda/main.c
    M src/lib-lda/Makefile.am
    M src/lib-lda/mail-deliver.c
    M src/lib-lda/mail-deliver.h
    M src/lmtp/main.c

  Log Message:
  -----------
  lib-lda: Fix deliver_log_format variables with Sieve

With Sieve it was using src_mail for getting the values, which weren't
correct especially if Sieve had modified the mail.


  Commit: cacc4f84d7c77674f8af93a4ca3a250849ed2c3b
      https://github.com/dovecot/core/commit/cacc4f84d7c77674f8af93a4ca3a250849ed2c3b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-lda/mail-deliver.c

  Log Message:
  -----------
  lib-lda: Implement %{storage_id} correctly


  Commit: a4806a6ddc283c5a6863a2bafd599084929a714e
      https://github.com/dovecot/core/commit/a4806a6ddc283c5a6863a2bafd599084929a714e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-lda/mail-deliver.c

  Log Message:
  -----------
  lib-lda: Don't set mail_deliver_context.dest_mail too early.

It must be NULL for the caller, unless save_dest_mail==TRUE


  Commit: 28f1862b3dd6496d447041bc079620ac70e3204a
      https://github.com/dovecot/core/commit/28f1862b3dd6496d447041bc079620ac70e3204a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-lda/mail-deliver.c

  Log Message:
  -----------
  lib-lda: Code cleanup - remove unnecessary dest_mail check


  Commit: 708ff403287984fac0eafd11013ffeb54d714427
      https://github.com/dovecot/core/commit/708ff403287984fac0eafd11013ffeb54d714427
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/doveadm/doveadm-mail-mailbox.c
    M src/doveadm/doveadm-mail.c
    M src/doveadm/doveadm-mail.h

  Log Message:
  -----------
  doveadm: Added "mailbox path" command

This allows easily printing a path for a mailbox, index, control dir, etc.


  Commit: bf70b41e8a81935c6237d2899a0ce4ebe8a66f19
      https://github.com/dovecot/core/commit/bf70b41e8a81935c6237d2899a0ce4ebe8a66f19
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-mail/istream-header-filter.c
    M src/lib-mail/test-istream-header-filter.c

  Log Message:
  -----------
  lib-mail: Fix duplicate HEADER_FILTER_ADD_MISSING_EOH callback call

If headers weren't modified, the second reading of the istream shouldn't
call any callbacks.


  Commit: b3bfde7048d613eb2f0e00ce4683232b11197d6f
      https://github.com/dovecot/core/commit/b3bfde7048d613eb2f0e00ce4683232b11197d6f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-http/http-message-parser.c
    M src/lib-http/http-request.c

  Log Message:
  -----------
  lib-http: message parser: Don't create the connection_options array, unless it is actually used.


  Commit: 2a1e57bf923bdc1c331e5285ccfa63eb44429356
      https://github.com/dovecot/core/commit/2a1e57bf923bdc1c331e5285ccfa63eb44429356
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-http/http-message-parser.c

  Log Message:
  -----------
  lib-http: message parser: Delay allocation of message header.


  Commit: 6f56bdfdab7304c35ad63496af4839dbeecd5d0f
      https://github.com/dovecot/core/commit/6f56bdfdab7304c35ad63496af4839dbeecd5d0f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-http/http-message-parser.c
    M src/lib-http/http-message-parser.h
    M src/lib-http/http-request-parser.c
    M src/lib-http/http-response-parser.c

  Log Message:
  -----------
  lib-http: message parser: Don't allocate a pool for the next message until it is needed.

This prevents wasting memory when no message is being parsed.


  Commit: 968c7545264c73d8c69882511b663a1e9d243d6d
      https://github.com/dovecot/core/commit/968c7545264c73d8c69882511b663a1e9d243d6d
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-http/http-response-parser.c

  Log Message:
  -----------
  lib-http: response parser: Always clear response to prevent referring to stale data.


  Commit: 992657a910524e2f2abd15223b3818755e75b74a
      https://github.com/dovecot/core/commit/992657a910524e2f2abd15223b3818755e75b74a
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-http/http-response-parser.c

  Log Message:
  -----------
  lib-http: response parser: Drop previous response's pool immediately when parsing continues.

Prevously, it would only do that when the first byte of the next response was received.
This prevents wasting memory when no response is being parsed.


  Commit: 934dc5bf43d1082d2f0cf1f43bc95b4f619e78ef
      https://github.com/dovecot/core/commit/934dc5bf43d1082d2f0cf1f43bc95b4f619e78ef
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-imap-client/imapc-connection.c
    M src/lib-storage/index/imapc/imapc-storage.c

  Log Message:
  -----------
  lib-imap-client: centralize authentication failed error logging


  Commit: 42319578cd8e76d30802f9e92c3cf5ffbfd63953
      https://github.com/dovecot/core/commit/42319578cd8e76d30802f9e92c3cf5ffbfd63953
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-imap-client/imapc-client-private.h
    M src/lib-imap-client/imapc-client.c
    M src/lib-imap-client/imapc-client.h
    M src/lib-imap-client/imapc-connection.c

  Log Message:
  -----------
  lib-imap-client: add callback to notify consumers about state changes

Add a callback to notify imapc users about failures.  Currently, the only
failure defined is "authentication failed".


  Commit: b9838d53171afd24162b2bc44daa52d478a420e9
      https://github.com/dovecot/core/commit/b9838d53171afd24162b2bc44daa52d478a420e9
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-imap-client/imapc-client.h
    M src/lib-imap-client/imapc-connection.c

  Log Message:
  -----------
  lib-imap-client: invoke state change callback on "authentication success"


  Commit: d177753e5f8d0650f33266d8420e6d35c99c88ec
      https://github.com/dovecot/core/commit/d177753e5f8d0650f33266d8420e6d35c99c88ec
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-imap-client/imapc-connection.c

  Log Message:
  -----------
  lib-imap-client: pass the reply text to the auth-failed state change callback


  Commit: 7bf7bc9c3cca0f6638f4d6d9310d60333e959fb1
      https://github.com/dovecot/core/commit/7bf7bc9c3cca0f6638f4d6d9310d60333e959fb1
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/plugins/mail-log/mail-log-plugin.c

  Log Message:
  -----------
  mail-log: Add mail_log_cached_only setting.

If enabled, everything except "save" event will log only the fields that can
be looked up from cache. This improves performance if some of the fields
aren't cached and it's not a strict requirement to log them.


  Commit: 0f3f7325d5c0e3b3e86ebbd3d91c630d1ee88347
      https://github.com/dovecot/core/commit/0f3f7325d5c0e3b3e86ebbd3d91c630d1ee88347
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-storage/mail-storage-private.h
    M src/lib-storage/mail-storage.c

  Log Message:
  -----------
  lib-storage: Make sure mailbox undeletion won't go to infinite loop


  Commit: fdaba55b3da9e2708414c88552c94ca63609caad
      https://github.com/dovecot/core/commit/fdaba55b3da9e2708414c88552c94ca63609caad
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-storage/mail-storage.c

  Log Message:
  -----------
  lib-storage: Don't sync mailbox after undeleting it.

This is useful only when deleting it. With undeletion the syncing isn't
useful and might actually be harmful with mailbox formats that didn't
fully open the mailbox while it was undeleted.


  Commit: 4decb8ca5ce533715b4d2d2e8fb7d5f591f69983
      https://github.com/dovecot/core/commit/4decb8ca5ce533715b4d2d2e8fb7d5f591f69983
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-storage/mail-storage.c

  Log Message:
  -----------
  lib-storage: Re-open mailbox after it's undeleted.

This is needed with mailbox formats that didn't fully open the mailbox while
it was undeleted.


  Commit: fbfcbf39d93afc1f62d183479871a0eee687c70b
      https://github.com/dovecot/core/commit/fbfcbf39d93afc1f62d183479871a0eee687c70b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-index/mail-index-transaction-finish.c
    M src/lib-index/mail-index-transaction-private.h
    M src/lib-index/mail-index-transaction-update.c
    M src/lib-index/test-mail-index-transaction-finish.c

  Log Message:
  -----------
  lib-index: Add day_stamp parameter to mail_index_update_day_headers()

This will help creating a unit test.


  Commit: 9d2f3c39584ff0e475577759f798c459ae95077c
      https://github.com/dovecot/core/commit/9d2f3c39584ff0e475577759f798c459ae95077c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-index/mail-index-transaction-update.c
    M src/lib-index/test-mail-index-transaction-update.c

  Log Message:
  -----------
  lib-index: Fix updating mail_index_header.day_first_uid

If user received a mail every day, the day_first_uid wasn't being updated.
This caused wrong caching decisions to be made in dovecot.index.cache:

 - Accessing >1 week old emails should have changed caching decision from
"tmp" to "yes". This might not have happened, although as long as
day_first_uid[7] pointed to an existing mail and email client accessed
all the mails, this wouldn't have changed anything.

 - Cache compression is supposed to drop >1 week old mails when caching
decision is "tmp". Not enough mails were being dropped because
day_first_uid[7] pointed to a much older than 1 week old mails.

Also added a unit test to make sure this works.

Broken by d9ee2f9fb3ef7b9391bfeeff1b374aead51667aa


  Commit: 2dccf7ca288122001b7ea0204357fa8d2a245d61
      https://github.com/dovecot/core/commit/2dccf7ca288122001b7ea0204357fa8d2a245d61
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-storage/index/index-mailbox-size.c

  Log Message:
  -----------
  lib-storage: Don't stop vsize calculation on expunged mails.

I don't know why I added such logic there in the first place. If we just
skip the expunged mails, the end result should still be correct and
usable when cached.


  Commit: e4a574f08a822a57929c54ea6ba6a23607d90706
      https://github.com/dovecot/core/commit/e4a574f08a822a57929c54ea6ba6a23607d90706
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-storage/index/index-mailbox-size.c
    M src/lib-storage/mail-storage-settings.c
    M src/lib-storage/mail-storage-settings.h
    M src/plugins/quota/quota-count.c

  Log Message:
  -----------
  lib-storage: Add mail_vsize_bg_after_count setting.

If folder vsize calculation requires opening more than this many mails from
disk (i.e. mail sizes aren't in cache already), return failure and finish
the calculation via indexer process.

This should be used like:

protocol !indexer-worker {
  mail_vsize_bg_after_count = 10
}


  Commit: 678cbf47e7060154b769128c696c16bd4d5caac0
      https://github.com/dovecot/core/commit/678cbf47e7060154b769128c696c16bd4d5caac0
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/lib-storage/index/index-mailbox-size.c

  Log Message:
  -----------
  lib-storage: Update vsize header after sync only if sizes are cached.

The result isn't needed yet in that case, so if it's slow to get the sizes
it might as well be delayd until later. This is especially useful when
indexer-worker triggers FTS indexing. The vsizes can be added to index
after the mail is already read for FTS. Without this change the vsize
update would first open all the mails and then the FTS indexing would
open all the mails a second time.


  Commit: a5e22885eda23b502fc98f340196faea39b0a100
      https://github.com/dovecot/core/commit/a5e22885eda23b502fc98f340196faea39b0a100
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M configure.ac
    M src/Makefile.am
    A src/lib-oauth2/Makefile.am
    A src/lib-oauth2/oauth2-introspect.c
    A src/lib-oauth2/oauth2-private.h
    A src/lib-oauth2/oauth2-refresh.c
    A src/lib-oauth2/oauth2-token-validate.c
    A src/lib-oauth2/oauth2.c
    A src/lib-oauth2/oauth2.h

  Log Message:
  -----------
  lib-oauth2: Add support library for OAUTH2


  Commit: cc52a2cb1007bfa29d14df0bb7da82316b478087
      https://github.com/dovecot/core/commit/cc52a2cb1007bfa29d14df0bb7da82316b478087
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/auth/passdb-template.c
    M src/auth/passdb-template.h

  Log Message:
  -----------
  auth: Add accessor for passdb template arguments


  Commit: cdf00f56f959c078dc5201d60e6bb88f3a7263af
      https://github.com/dovecot/core/commit/cdf00f56f959c078dc5201d60e6bb88f3a7263af
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/auth/auth-request.c
    M src/auth/auth-settings.c
    M src/auth/auth-settings.h
    M src/auth/passdb.c
    M src/auth/passdb.h

  Log Message:
  -----------
  auth: Add mechanism filter for passdbs


  Commit: 5bad9223e21db98bee7619dee9da74732e3a71ec
      https://github.com/dovecot/core/commit/5bad9223e21db98bee7619dee9da74732e3a71ec
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/auth/Makefile.am
    A src/auth/mech-oauth2.c
    M src/auth/mech.c

  Log Message:
  -----------
  auth: Add xoauth2 and oauthbearer mechanisms


  Commit: bf1f57d7608dc0659978bfcaffa4fc223973dcd6
      https://github.com/dovecot/core/commit/bf1f57d7608dc0659978bfcaffa4fc223973dcd6
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-02-17 (Fri, 17 Feb 2017)

  Changed paths:
    M src/auth/Makefile.am
    A src/auth/db-oauth2.c
    A src/auth/db-oauth2.h
    A src/auth/passdb-oauth2.c
    M src/auth/passdb.c

  Log Message:
  -----------
  auth: Add oauth2 passdb


Compare: https://github.com/dovecot/core/compare/53a4f7fffc6d...bf1f57d7608d


More information about the dovecot-cvs mailing list