[dovecot/core] 2e35ed: lib-lda: Refactor - Add struct mail_deliver_mailbo...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 2e35ede0f3afa8b4528cc530a6efba239d77a022
      https://github.com/dovecot/core/commit/2e35ede0f3afa8b4528cc530a6efba239d77a022
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-21 (Tue, 21 Feb 2017)

  Changed paths:
    M src/lib-lda/mail-deliver.c

  Log Message:
  -----------
  lib-lda: Refactor - Add struct mail_deliver_mailbox


  Commit: d609c2ffca2b61556980b46e1de2303c662ad0f7
      https://github.com/dovecot/core/commit/d609c2ffca2b61556980b46e1de2303c662ad0f7
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-21 (Tue, 21 Feb 2017)

  Changed paths:
    M src/lib-lda/mail-deliver.c

  Log Message:
  -----------
  lib-lda: Refactor - mail_deliver_log_update_cache() doesn't need entire deliver_ctx


  Commit: 87dae9ffcd43023361019ca803709dbf5b8119bc
      https://github.com/dovecot/core/commit/87dae9ffcd43023361019ca803709dbf5b8119bc
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-21 (Tue, 21 Feb 2017)

  Changed paths:
    M src/lib-lda/mail-deliver.c

  Log Message:
  -----------
  lib-lda: Fix delivery logging when Sieve performs multiple actions

Previous code assumed that it would work like:
 - save/copy
 - transaction commit
 - mail_deliver_ctx_get_log_var_expand_table()
 - repeat for transaction 2

While it really works:
 - transaction 1: save/copy
 - transaction 2: save/copy
 - transaction 1: commit
 - mail_deliver_ctx_get_log_var_expand_table()
 - transaction 2: commit
 - mail_deliver_ctx_get_log_var_expand_table()

So the cache needs to be stored per transaction. This code still wouldn't
work correctly if Sieve saved mails multiple times within the same
transaction, but that doesn't happen (at least currently).


Compare: https://github.com/dovecot/core/compare/67905cc93282...87dae9ffcd43