[dovecot/core] d1bf4a: lib-storage: Use refcounting for mail_storage_serv...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: d1bf4ae66b8bf3b9e28df1823d6d4adda2b923b6
      https://github.com/dovecot/core/commit/d1bf4ae66b8bf3b9e28df1823d6d4adda2b923b6
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/lib-storage/mail-storage-service.c
    M src/lib-storage/mail-storage-service.h
    M src/lib-storage/mail-user.c

  Log Message:
  -----------
  lib-storage: Use refcounting for mail_storage_service_user

doveadm import was freeing the user too early, which resulted
mail_user._service_user pointing to freed memory. More importantly,
after 34512eaad8b1b2f929e6d6e3a2f7252c29fba97b user->set was pointing
to already freed memory.


  Commit: eb318ea05532d2e54ed3bfc89bc15dcf1adae838
      https://github.com/dovecot/core/commit/eb318ea05532d2e54ed3bfc89bc15dcf1adae838
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/doveadm/doveadm-auth-server.c
    M src/doveadm/doveadm-auth.c
    M src/doveadm/doveadm-mail-copymove.c
    M src/doveadm/doveadm-mail-import.c
    M src/doveadm/doveadm-mail.c
    M src/imap-urlauth/imap-urlauth-worker.c
    M src/imap/imap-client.c
    M src/imap/main.c
    M src/indexer/master-connection.c
    M src/lda/main.c
    M src/lmtp/client.c
    M src/lmtp/commands.c
    M src/plugins/mail-crypt/doveadm-mail-crypt.c
    M src/plugins/mail-crypt/mail-crypt-acl-plugin.c
    M src/plugins/mail-crypt/test-mail-key.c
    M src/plugins/quota/quota-status.c
    M src/pop3/pop3-client.c

  Log Message:
  -----------
  global: Replace mail_storage_service_user_free() with _unref()


  Commit: f6897616e0529b7bda2005d6cd42b06c826ed66f
      https://github.com/dovecot/core/commit/f6897616e0529b7bda2005d6cd42b06c826ed66f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/lib-storage/mail-storage-service.h

  Log Message:
  -----------
  lib-storage: Removed mail_storage_service_user_free() backwards compatibility

Used a separate commit so the macro can be left for v2.2 tree.


Compare: https://github.com/dovecot/core/compare/13f507c0df27...f6897616e052