[dovecot-cvs] dovecot/src/auth passdb-ldap.c, 1.46, 1.47 passdb-sql.c, 1.28, 1.29

[tss at dovecot.org]

Update of /var/lib/cvs/dovecot/src/auth
In directory talvi:/tmp/cvs-serv9764

Modified Files:
	passdb-ldap.c passdb-sql.c 
Log Message:
Non-plaintext authentication didn't work with sql as passdb. Cleaned up the
same code for LDAP also.



Index: passdb-ldap.c
===================================================================
RCS file: /var/lib/cvs/dovecot/src/auth/passdb-ldap.c,v
retrieving revision 1.46
retrieving revision 1.47
diff -u -d -r1.46 -r1.47
--- passdb-ldap.c	10 Aug 2006 19:44:19 -0000	1.46
+++ passdb-ldap.c	2 Nov 2006 21:19:44 -0000	1.47
@@ -180,7 +180,9 @@
 		auth_request_log_error(auth_request, "ldap",
 				       "Multiple password replies");
 	} else {
-		password = p_strdup(auth_request->pool, auth_request->passdb_password);
+		/* passdb_password may change on the way,
+		   so we'll need to strdup. */
+		password = t_strdup(auth_request->passdb_password);
 		if (password == NULL)
 			auth_request->no_password = TRUE;
 		passdb_result = PASSDB_RESULT_OK;

Index: passdb-sql.c
===================================================================
RCS file: /var/lib/cvs/dovecot/src/auth/passdb-sql.c,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -d -r1.28 -r1.29
--- passdb-sql.c	31 May 2006 11:03:53 -0000	1.28
+++ passdb-sql.c	2 Nov 2006 21:19:45 -0000	1.29
@@ -85,7 +85,9 @@
 			auth_request_log_error(auth_request, "sql",
 				"Password query returned multiple matches");
 		} else {
-			password = auth_request->passdb_password;
+			/* passdb_password may change on the way,
+			   so we'll need to strdup. */
+			password = t_strdup(auth_request->passdb_password);
 			if (password == NULL)
 				auth_request->no_password = TRUE;
 			passdb_result = PASSDB_RESULT_OK;