[dovecot-cvs] dovecot/src/lib file-cache.c,1.14,1.15

[tss at dovecot.org]

Update of /var/lib/cvs/dovecot/src/lib
In directory talvi:/tmp/cvs-serv9556

Modified Files:
	file-cache.c 
Log Message:
And another off-by-one buffer overflow fix.



Index: file-cache.c
===================================================================
RCS file: /var/lib/cvs/dovecot/src/lib/file-cache.c,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -d -r1.14 -r1.15
--- file-cache.c	18 Nov 2006 23:15:02 -0000	1.14
+++ file-cache.c	18 Nov 2006 23:26:19 -0000	1.15
@@ -128,8 +128,8 @@
 	i_assert(psize > 0);
 
 	bits = buffer_get_space_unsafe(cache->page_bitmask, 0,
-				       (poffset + psize + CHAR_BIT - 1) /
-				       CHAR_BIT);
+				       poffset / CHAR_BIT +
+				       (psize + CHAR_BIT - 1) / CHAR_BIT);
 
 	dest_offset = poffset * page_size;
 	dest = PTR_OFFSET(cache->mmap_base, dest_offset);
@@ -282,7 +282,7 @@
 	}
 
 	bits = buffer_get_space_unsafe(cache->page_bitmask, offset / CHAR_BIT,
-				       (size + CHAR_BIT - 1) / CHAR_BIT);
+				       1 + (size + CHAR_BIT - 1) / CHAR_BIT);
 
 	/* set the first byte */
 	for (i = offset % CHAR_BIT, mask = 0; i < CHAR_BIT && size > 0; i++) {