[dovecot-cvs] dovecot/src/pop3-login client-authenticate.c, 1.58, 1.59

[tss at dovecot.org]

Update of /var/lib/cvs/dovecot/src/pop3-login
In directory talvi:/tmp/cvs-serv16802/pop3-login

Modified Files:
	client-authenticate.c 
Log Message:
Potential crashfix


Index: client-authenticate.c
===================================================================
RCS file: /var/lib/cvs/dovecot/src/pop3-login/client-authenticate.c,v
retrieving revision 1.58
retrieving revision 1.59
diff -u -d -r1.58 -r1.59
--- client-authenticate.c	20 Feb 2007 11:51:13 -0000	1.58
+++ client-authenticate.c	26 Mar 2007 22:20:07 -0000	1.59
@@ -73,19 +73,16 @@
 	if (strcmp(line, "*") == 0) {
 		sasl_server_auth_client_error(&client->common,
 					      "Authentication aborted");
-		return;
-	}
-
-	if (client->common.waiting_auth_reply) {
+	} else if (client->common.waiting_auth_reply) {
 		sasl_server_auth_client_error(&client->common,
 					      "Don't send unrequested data");
 	} else {
 		auth_client_request_continue(client->common.auth_request, line);
 		client->common.waiting_auth_reply = TRUE;
-	}
 
-	/* clear sensitive data */
-	safe_memset(line, 0, strlen(line));
+		/* clear sensitive data */
+		safe_memset(line, 0, strlen(line));
+	}
 }
 
 static bool client_handle_args(struct pop3_client *client,