dovecot-1.1: mail_index_lookup_seq*() could have returned wrong ...

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot-1.1/rev/8cc0eaec7d0f
changeset: 7835:8cc0eaec7d0f
user:      Timo Sirainen <tss at iki.fi>
date:      Thu Aug 28 09:33:13 2008 +0300
description:
mail_index_lookup_seq*() could have returned wrong sequences with transaction views.
This caused assert-crashes in recent flag handling for mbox and maildir.

diffstat:

1 file changed, 1 insertion(+), 1 deletion(-)
src/lib-index/mail-index-transaction-view.c |    2 +-

diffs (14 lines):

diff -r e024baa42a4f -r 8cc0eaec7d0f src/lib-index/mail-index-transaction-view.c
--- a/src/lib-index/mail-index-transaction-view.c	Wed Aug 27 19:21:12 2008 +0300
+++ b/src/lib-index/mail-index-transaction-view.c	Thu Aug 28 09:33:13 2008 +0300
@@ -127,9 +127,9 @@ static void tview_lookup_seq_range(struc
 	if (*first_seq_r == 0) {
 		seq = tview->t->first_new_seq;
 		for (; seq <= tview->t->last_new_seq; seq++) {
+			rec = mail_index_transaction_lookup(tview->t, seq);
 			if (first_uid <= rec->uid)
 				break;
-			rec = mail_index_transaction_lookup(tview->t, seq);
 		}
 		if (seq > tview->t->last_new_seq) {
 			/* no messages in range */