dovecot-1.3: Settings parser: !included files without absolute p...

dovecot at dovecot.org dovecot at dovecot.org
Tue Apr 21 20:35:13 EEST 2009


details:   http://hg.dovecot.org/dovecot-1.3/rev/92825cc9a59c
changeset: 9150:92825cc9a59c
user:      Timo Sirainen <tss at iki.fi>
date:      Tue Apr 21 13:35:08 2009 -0400
description:
Settings parser: !included files without absolute paths are relative to their parent config file.

diffstat:

1 file changed, 21 insertions(+), 4 deletions(-)
src/config/config-parser.c |   25 +++++++++++++++++++++----

diffs (49 lines):

diff -r 6d374fc3ae1d -r 92825cc9a59c src/config/config-parser.c
--- a/src/config/config-parser.c	Mon Apr 20 19:33:41 2009 -0400
+++ b/src/config/config-parser.c	Tue Apr 21 13:35:08 2009 -0400
@@ -244,6 +244,21 @@ static const char *info_type_name_find(c
 	}
 	i_panic("setting parser: Invalid type_offset value");
 	return NULL;
+}
+
+static const char *
+fix_relative_path(const char *path, struct input_stack *input)
+{
+	const char *p;
+
+	if (*path == '/')
+		return path;
+
+	p = strrchr(input->path, '/');
+	if (p == NULL)
+		return path;
+
+	return t_strconcat(t_strdup_until(input->path, p+1), path, NULL);
 }
 
 void config_parse_file(pool_t dest_pool, ARRAY_TYPE(const_string) *dest,
@@ -347,17 +362,19 @@ prevfile:
 		if (strcmp(key, "!include_try") == 0 ||
 		    strcmp(key, "!include") == 0) {
 			struct input_stack *tmp;
-
+			const char *path;
+
+			path = fix_relative_path(line, input);
 			for (tmp = input; tmp != NULL; tmp = tmp->prev) {
-				if (strcmp(tmp->path, line) == 0)
+				if (strcmp(tmp->path, path) == 0)
 					break;
 			}
 			if (tmp != NULL) {
 				errormsg = "Recursive include";
-			} else if ((fd = open(line, O_RDONLY)) != -1) {
+			} else if ((fd = open(path, O_RDONLY)) != -1) {
 				new_input = t_new(struct input_stack, 1);
 				new_input->prev = input;
-				new_input->path = t_strdup(line);
+				new_input->path = t_strdup(path);
 				input = new_input;
 				goto newfile;
 			} else {


More information about the dovecot-cvs mailing list