dovecot-2.0: settings_parser_check() return value was checked wr...

dovecot at dovecot.org dovecot at dovecot.org
Tue May 5 01:11:24 EEST 2009


details:   http://hg.dovecot.org/dovecot-2.0/rev/189a92535cc7
changeset: 9210:189a92535cc7
user:      Timo Sirainen <tss at iki.fi>
date:      Mon May 04 18:10:03 2009 -0400
description:
settings_parser_check() return value was checked wrong.

diffstat:

2 files changed, 2 insertions(+), 2 deletions(-)
src/dict/dict-settings.c                 |    2 +-
src/lib-master/master-service-settings.c |    2 +-

diffs (24 lines):

diff -r 419b35be0823 -r 189a92535cc7 src/dict/dict-settings.c
--- a/src/dict/dict-settings.c	Mon May 04 17:54:19 2009 -0400
+++ b/src/dict/dict-settings.c	Mon May 04 18:10:03 2009 -0400
@@ -56,7 +56,7 @@ struct dict_settings *dict_settings_read
 			settings_parser_get_error(parser));
 	}
 
-	if (settings_parser_check(parser, settings_pool, &error) < 0)
+	if (!settings_parser_check(parser, settings_pool, &error))
 		i_fatal("Invalid settings: %s", error);
 
 	set = settings_parser_get(parser);
diff -r 419b35be0823 -r 189a92535cc7 src/lib-master/master-service-settings.c
--- a/src/lib-master/master-service-settings.c	Mon May 04 17:54:19 2009 -0400
+++ b/src/lib-master/master-service-settings.c	Mon May 04 18:10:03 2009 -0400
@@ -187,7 +187,7 @@ int master_service_settings_read(struct 
 						   keys);
 	}
 
-	if (settings_parser_check(parser, service->set_pool, &error) < 0) {
+	if (!settings_parser_check(parser, service->set_pool, &error)) {
 		*error_r = t_strdup_printf("Invalid settings: %s", error);
 		return -1;
 	}


More information about the dovecot-cvs mailing list