dovecot-2.0: lib-storage: Fix to previous change: Don't access f...

dovecot at dovecot.org dovecot at dovecot.org
Sat Mar 27 05:03:59 EET 2010


details:   http://hg.dovecot.org/dovecot-2.0/rev/f4ff6c7cdafe
changeset: 11010:f4ff6c7cdafe
user:      Timo Sirainen <tss at iki.fi>
date:      Sat Mar 27 05:03:57 2010 +0200
description:
lib-storage: Fix to previous change: Don't access freed memory.

diffstat:

 src/lib-storage/mail-storage.c |  12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diffs (30 lines):

diff -r 0f0b8e1a2c55 -r f4ff6c7cdafe src/lib-storage/mail-storage.c
--- a/src/lib-storage/mail-storage.c	Sat Mar 27 05:01:17 2010 +0200
+++ b/src/lib-storage/mail-storage.c	Sat Mar 27 05:03:57 2010 +0200
@@ -865,7 +865,7 @@
 			struct mailbox_sync_status *status_r)
 {
 	struct mailbox_sync_context *ctx = *_ctx;
-	struct mail_storage *storage = ctx->box->storage;
+	struct mailbox *box = ctx->box;
 	const char *errormsg;
 	enum mail_error error;
 	int ret;
@@ -873,12 +873,12 @@
 	*_ctx = NULL;
 
 	memset(status_r, 0, sizeof(*status_r));
-	ret = ctx->box->v.sync_deinit(ctx, status_r);
-	if (ret < 0 && ctx->box->inbox &&
-	    !storage->user->inbox_open_error_logged) {
-		errormsg = mail_storage_get_last_error(storage, &error);
+	ret = box->v.sync_deinit(ctx, status_r);
+	if (ret < 0 && box->inbox &&
+	    !box->storage->user->inbox_open_error_logged) {
+		errormsg = mail_storage_get_last_error(box->storage, &error);
 		if (error == MAIL_ERROR_NOTPOSSIBLE) {
-			storage->user->inbox_open_error_logged = TRUE;
+			box->storage->user->inbox_open_error_logged = TRUE;
 			i_error("Syncing INBOX failed: %s", errormsg);
 		}
 	}


More information about the dovecot-cvs mailing list