dovecot-2.0: lib-master: If auth master login fails, make sure e...

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot-2.0/rev/aec1f1614028
changeset: 12436:aec1f1614028
user:      Timo Sirainen <tss at iki.fi>
date:      Wed Nov 17 17:52:52 2010 +0000
description:
lib-master: If auth master login fails, make sure error message is logged.

diffstat:

 src/lib-master/master-login-auth.c |  6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diffs (24 lines):

diff -r 666fd046ab7f -r aec1f1614028 src/lib-master/master-login-auth.c
--- a/src/lib-master/master-login-auth.c	Wed Nov 17 16:55:56 2010 +0000
+++ b/src/lib-master/master-login-auth.c	Wed Nov 17 17:52:52 2010 +0000
@@ -79,6 +79,8 @@
 {
 	struct master_login_auth_request *request;
 
+	if (auth->request_head != NULL)
+		i_error("Disconnected from auth server, aborting requests");
 	while (auth->request_head != NULL) {
 		request = auth->request_head;
 		DLLIST2_REMOVE(&auth->request_head,
@@ -272,8 +274,10 @@
 
 	request = master_login_auth_lookup_request(auth, id);
 	if (request != NULL) {
-		if (error != NULL)
+		if (error == NULL)
 			i_error("Internal auth failure");
+		else
+			i_error("Internal auth failure: %s", error);
 		request->callback(NULL, error != NULL ? error :
 				  MASTER_AUTH_ERRMSG_INTERNAL_FAILURE,
 				  request->context);