dovecot-2.1: stats: Don't increase session stats based on comman...

dovecot at dovecot.org dovecot at dovecot.org
Sun Sep 4 11:30:18 EEST 2011


details:   http://hg.dovecot.org/dovecot-2.1/rev/9434093229aa
changeset: 13373:9434093229aa
user:      Timo Sirainen <tss at iki.fi>
date:      Sun Sep 04 10:25:39 2011 +0300
description:
stats: Don't increase session stats based on command stats.
This was buggy because the session stats were now increased twice. It could
have been possible to keep doing this and on UPDATE-SESSION simply replace
the old session stats, but that might still have caused the session stats to
temporarily go too high and then drop down.

diffstat:

 src/stats/mail-command.c |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diffs (21 lines):

diff -r 66453d942761 -r 9434093229aa src/stats/mail-command.c
--- a/src/stats/mail-command.c	Sun Sep 04 10:15:16 2011 +0300
+++ b/src/stats/mail-command.c	Sun Sep 04 10:25:39 2011 +0300
@@ -137,7 +137,7 @@
 	} else {
 		if (!mail_stats_diff(&cmd->stats, &stats, &diff_stats,
 				     &error)) {
-			*error_r = t_strconcat("UPDATE-SESSION: stats shrank: ",
+			*error_r = t_strconcat("UPDATE-CMD: stats shrank: ",
 					       error, NULL);
 			return -1;
 		}
@@ -148,7 +148,7 @@
 		cmd->id = 0;
 		mail_command_unref(&cmd);
 	}
-	mail_session_refresh(session, &diff_stats);
+	mail_session_refresh(session, NULL);
 	return 0;
 }
 


More information about the dovecot-cvs mailing list