dovecot-2.1: lib-storage: Code cleanup to mail_storage_set_criti...

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot-2.1/rev/84bce2c8626f
changeset: 13430:84bce2c8626f
user:      Timo Sirainen <tss at iki.fi>
date:      Thu Sep 08 11:39:00 2011 +0300
description:
lib-storage: Code cleanup to mail_storage_set_critical()

diffstat:

 src/lib-storage/mail-storage.c |  17 +++++++----------
 1 files changed, 7 insertions(+), 10 deletions(-)

diffs (28 lines):

diff -r bba92468b051 -r 84bce2c8626f src/lib-storage/mail-storage.c
--- a/src/lib-storage/mail-storage.c	Thu Sep 08 11:16:55 2011 +0300
+++ b/src/lib-storage/mail-storage.c	Thu Sep 08 11:39:00 2011 +0300
@@ -448,17 +448,14 @@
 {
 	va_list va;
 
-	mail_storage_clear_error(storage);
-	if (fmt != NULL) {
-		va_start(va, fmt);
-		i_error("%s", t_strdup_vprintf(fmt, va));
-		va_end(va);
+	va_start(va, fmt);
+	i_error("%s", t_strdup_vprintf(fmt, va));
+	va_end(va);
 
-		/* critical errors may contain sensitive data, so let user
-		   see only "Internal error" with a timestamp to make it
-		   easier to look from log files the actual error message. */
-		mail_storage_set_internal_error(storage);
-	}
+	/* critical errors may contain sensitive data, so let user
+	   see only "Internal error" with a timestamp to make it
+	   easier to look from log files the actual error message. */
+	mail_storage_set_internal_error(storage);
 }
 
 void mail_storage_copy_list_error(struct mail_storage *storage,