dovecot-2.1: lib-storage: "Invalid userdb input" showed wrong in...

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot-2.1/rev/731d9f2cd25d
changeset: 14127:731d9f2cd25d
user:      Timo Sirainen <tss at iki.fi>
date:      Sun Feb 12 06:59:32 2012 +0200
description:
lib-storage: "Invalid userdb input" showed wrong input in the error message.

diffstat:

 src/lib-storage/mail-storage-service.c |  4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diffs (21 lines):

diff -r 7517c752f2f5 -r 731d9f2cd25d src/lib-storage/mail-storage-service.c
--- a/src/lib-storage/mail-storage-service.c	Sun Feb 12 06:51:05 2012 +0200
+++ b/src/lib-storage/mail-storage-service.c	Sun Feb 12 06:59:32 2012 +0200
@@ -253,7 +253,7 @@
 	}
 
 	str = array_get(&reply->extra_fields, &count);
-	for (i = 0; i < count && ret >= 0; i++) {
+	for (i = 0; i < count; i++) {
 		line = str[i];
 		if (strncmp(line, "system_groups_user=", 19) == 0) {
 			user->system_groups_user =
@@ -270,6 +270,8 @@
 		} else T_BEGIN {
 			ret = set_line(ctx, user, line);
 		} T_END;
+		if (ret < 0)
+			break;
 	}
 
 	if (ret < 0) {