dovecot-2.0: Make static analyzer happier.

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot-2.0/rev/cb23eb573b50
changeset: 13054:cb23eb573b50
user:      Timo Sirainen <tss at iki.fi>
date:      Sun Feb 12 23:29:53 2012 +0200
description:
Make static analyzer happier.

diffstat:

 src/lib-storage/index/index-thread-finish.c |  8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diffs (18 lines):

diff -r 0b5076a69909 -r cb23eb573b50 src/lib-storage/index/index-thread-finish.c
--- a/src/lib-storage/index/index-thread-finish.c	Sun Feb 12 23:06:52 2012 +0200
+++ b/src/lib-storage/index/index-thread-finish.c	Sun Feb 12 23:29:53 2012 +0200
@@ -650,11 +650,9 @@
 		return NULL;
 
 	child = &children[iter->next_idx++];
-	if (child_iter_r != NULL) {
-		shadow = array_idx(&iter->ctx->shadow_nodes, child->idx);
-		*child_iter_r = shadow->first_child_idx == 0 ? NULL :
-			mail_thread_iterate_children(iter, child->idx);
-	}
+	shadow = array_idx(&iter->ctx->shadow_nodes, child->idx);
+	*child_iter_r = shadow->first_child_idx == 0 ? NULL :
+		mail_thread_iterate_children(iter, child->idx);
 	if (child->uid == 0 && *child_iter_r == NULL) {
 		/* this is a dummy node without children,
 		   there's no point in returning it */