dovecot-2.2: lib-storage: Mailbox list index updating didn't che...

dovecot at dovecot.org dovecot at dovecot.org
Fri Jun 6 13:33:21 UTC 2014


details:   http://hg.dovecot.org/dovecot-2.2/rev/feea8645c4d7
changeset: 17439:feea8645c4d7
user:      Timo Sirainen <tss at iki.fi>
date:      Thu Jun 05 13:43:11 2014 +0300
description:
lib-storage: Mailbox list index updating didn't check properly if modseq tracking is enabled.
mail_index_modseq_enable() can be enabled (e.g. by virtual plugin) without
enabling MAILBOX_FEATURE_CONDSTORE.

(Actually the MAILBOX_FEATURE_* probably should be removed from lib-storage
entirely. They're too much of an IMAP feature.)

diffstat:

 src/lib-storage/list/mailbox-list-index-status.c |  3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diffs (13 lines):

diff -r 6b9699ab7576 -r feea8645c4d7 src/lib-storage/list/mailbox-list-index-status.c
--- a/src/lib-storage/list/mailbox-list-index-status.c	Thu Jun 05 13:38:36 2014 +0300
+++ b/src/lib-storage/list/mailbox-list-index-status.c	Thu Jun 05 13:43:11 2014 +0300
@@ -313,8 +313,7 @@
 	/* update highest-modseq only if they're ever been used */
 	if (old_status.highest_modseq == changes->status.highest_modseq) {
 		changes->hmodseq_changed = FALSE;
-	} else if ((box->enabled_features & MAILBOX_FEATURE_CONDSTORE) != 0 ||
-		   old_status.highest_modseq != 0) {
+	} else if (mail_index_have_modseq_tracking(box->index)) {
 		changes->hmodseq_changed = TRUE;
 	} else {
 		const void *data;


More information about the dovecot-cvs mailing list