dovecot-2.2: Added "fall through" comments to switch statements ...
dovecot at dovecot.org
dovecot at dovecot.org
Thu Jun 12 23:20:43 UTC 2014
details: http://hg.dovecot.org/dovecot-2.2/rev/1aca4e8811dc
changeset: 17474:1aca4e8811dc
user: Timo Sirainen <tss at iki.fi>
date: Fri Jun 13 01:35:13 2014 +0300
description:
Added "fall through" comments to switch statements where break is intentionally missing.
This should make Coverity quiet about these..
diffstat:
src/doveadm/doveadm-dump-index.c | 1 +
src/lib-http/http-request-parser.c | 1 +
src/lib/iso8601-date.c | 2 +-
3 files changed, 3 insertions(+), 1 deletions(-)
diffs (34 lines):
diff -r 69fe8462ec21 -r 1aca4e8811dc src/doveadm/doveadm-dump-index.c
--- a/src/doveadm/doveadm-dump-index.c Fri Jun 13 01:30:14 2014 +0300
+++ b/src/doveadm/doveadm-dump-index.c Fri Jun 13 01:35:13 2014 +0300
@@ -477,6 +477,7 @@
memcpy(&value, data, sizeof(value));
str_printfa(str, "%llu ", (unsigned long long)value);
}
+ /* fall through */
case MAIL_CACHE_FIELD_VARIABLE_SIZE:
case MAIL_CACHE_FIELD_BITMASK:
str_printfa(str, "(%s)", binary_to_hex(data, size));
diff -r 69fe8462ec21 -r 1aca4e8811dc src/lib-http/http-request-parser.c
--- a/src/lib-http/http-request-parser.c Fri Jun 13 01:30:14 2014 +0300
+++ b/src/lib-http/http-request-parser.c Fri Jun 13 01:35:13 2014 +0300
@@ -168,6 +168,7 @@
parser->state = HTTP_REQUEST_PARSE_STATE_SKIP_LINE;
if (_parser->cur == _parser->end)
return 0;
+ /* fall through */
case HTTP_REQUEST_PARSE_STATE_SKIP_LINE:
if (*_parser->cur == '\r' || *_parser->cur == '\n') {
if (parser->skipping_line) {
diff -r 69fe8462ec21 -r 1aca4e8811dc src/lib/iso8601-date.c
--- a/src/lib/iso8601-date.c Fri Jun 13 01:30:14 2014 +0300
+++ b/src/lib/iso8601-date.c Fri Jun 13 01:35:13 2014 +0300
@@ -97,7 +97,7 @@
switch (parser->cur[0]) {
case '-':
tz_sign = -1;
-
+ /* fall through */
case '+':
parser->cur++;
More information about the dovecot-cvs
mailing list