dovecot-2.2: lib-lda: smtp client may have crashed if remote ret...

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot-2.2/rev/bc0629daf4d4
changeset: 17873:bc0629daf4d4
user:      Timo Sirainen <tss at iki.fi>
date:      Fri Oct 03 22:39:53 2014 +0300
description:
lib-lda: smtp client may have crashed if remote returned a permanent error.

diffstat:

 src/lib-lda/smtp-client.c |  5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diffs (16 lines):

diff -r a7b885c94295 -r bc0629daf4d4 src/lib-lda/smtp-client.c
--- a/src/lib-lda/smtp-client.c	Fri Oct 03 18:18:44 2014 +0300
+++ b/src/lib-lda/smtp-client.c	Fri Oct 03 22:39:53 2014 +0300
@@ -317,8 +317,11 @@
 		i_assert(smtp_client->error != NULL);
 		*error_r = t_strdup(smtp_client->error);
 		return -1;
-	} else
+	} else {
+		i_assert(smtp_client->error != NULL);
+		*error_r = t_strdup(smtp_client->error);
 		return 0;
+	}
 }
 
 int smtp_client_deinit(struct smtp_client *client, const char **error_r)