dovecot-2.2: dsync: Removed in/out state from debugging.

dovecot at dovecot.org dovecot at dovecot.org
Fri Oct 24 00:59:29 UTC 2014


details:   http://hg.dovecot.org/dovecot-2.2/rev/2c8d458f120f
changeset: 17992:2c8d458f120f
user:      Timo Sirainen <tss at iki.fi>
date:      Fri Oct 24 03:58:35 2014 +0300
description:
dsync: Removed in/out state from debugging.
This was initially added for debugging hangs, but those haven't existed for
a long time now. Maybe we should eventually make debug categories
configurable, but for now nobody wants to see these messages.

diffstat:

 src/doveadm/dsync/dsync-brain-mails.c |  14 --------------
 src/doveadm/dsync/dsync-brain.c       |   9 ---------
 2 files changed, 0 insertions(+), 23 deletions(-)

diffs (56 lines):

diff -r 52ad54b23e24 -r 2c8d458f120f src/doveadm/dsync/dsync-brain-mails.c
--- a/src/doveadm/dsync/dsync-brain-mails.c	Fri Oct 24 03:54:21 2014 +0300
+++ b/src/doveadm/dsync/dsync-brain-mails.c	Fri Oct 24 03:58:35 2014 +0300
@@ -315,13 +315,6 @@
 
 	i_assert(brain->box != NULL);
 
-	if (brain->debug) {
-		i_debug("brain %c: in box '%s' recv_state=%s send_state=%s",
-			brain->master_brain ? 'M' : 'S',
-			mailbox_get_vname(brain->box),
-			dsync_box_state_names[brain->box_recv_state],
-			dsync_box_state_names[brain->box_send_state]);
-	}
 	switch (brain->box_recv_state) {
 	case DSYNC_BOX_STATE_MAILBOX:
 		changed = dsync_brain_master_sync_recv_mailbox(brain);
@@ -372,12 +365,5 @@
 			break;
 		}
 	}
-	if (brain->debug) {
-		i_debug("brain %c: out box '%s' recv_state=%s send_state=%s changed=%d",
-			brain->master_brain ? 'M' : 'S',
-			brain->box == NULL ? "" : mailbox_get_vname(brain->box),
-			dsync_box_state_names[brain->box_recv_state],
-			dsync_box_state_names[brain->box_send_state], changed);
-	}
 	return changed;
 }
diff -r 52ad54b23e24 -r 2c8d458f120f src/doveadm/dsync/dsync-brain.c
--- a/src/doveadm/dsync/dsync-brain.c	Fri Oct 24 03:54:21 2014 +0300
+++ b/src/doveadm/dsync/dsync-brain.c	Fri Oct 24 03:58:35 2014 +0300
@@ -539,10 +539,6 @@
 	if (brain->failed)
 		return FALSE;
 
-	if (brain->debug) {
-		i_debug("brain %c: in state=%s", brain->master_brain ? 'M' : 'S',
-			dsync_state_names[brain->state]);
-	}
 	switch (brain->state) {
 	case DSYNC_STATE_MASTER_RECV_HANDSHAKE:
 		changed = dsync_brain_master_recv_handshake(brain);
@@ -586,11 +582,6 @@
 		ret = FALSE;
 		break;
 	}
-	if (brain->debug) {
-		i_debug("brain %c: out state=%s changed=%d",
-			brain->master_brain ? 'M' : 'S',
-			dsync_state_names[brain->state], changed);
-	}
 	if (brain->verbose_proctitle) {
 		if (orig_state != brain->state ||
 		    orig_box_recv_state != brain->box_recv_state ||


More information about the dovecot-cvs mailing list