dovecot-2.2: lib-http: client: Tunnel connection failure would c...

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot-2.2/rev/bf371c4fed6e
changeset: 17773:bf371c4fed6e
user:      Stephan Bosch <stephan at rename-it.nl>
date:      Wed Sep 10 13:39:37 2014 +0300
description:
lib-http: client: Tunnel connection failure would cause segfault.
That happened because it tried to retry waiting requests, which makes no sense for a CONNECT tunnel.

diffstat:

 src/lib-http/http-client-connection.c |  3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diffs (13 lines):

diff -r 5ab0ab678497 -r bf371c4fed6e src/lib-http/http-client-connection.c
--- a/src/lib-http/http-client-connection.c	Wed Sep 10 13:39:37 2014 +0300
+++ b/src/lib-http/http-client-connection.c	Wed Sep 10 13:39:37 2014 +0300
@@ -77,6 +77,9 @@
 {
 	struct http_client_request **req;
 
+	if (!array_is_created(&conn->request_wait_list))
+		return;
+
 	array_foreach_modifiable(&conn->request_wait_list, req) {
 		if ((*req)->state < HTTP_REQUEST_STATE_FINISHED)
 			http_client_request_retry(*req, status, error);