dovecot-2.2: director: Log error if auth sends invalid lip/lport...

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot-2.2/rev/333533e2d231
changeset: 18503:333533e2d231
user:      Timo Sirainen <tss at iki.fi>
date:      Wed Apr 29 17:45:30 2015 +0200
description:
director: Log error if auth sends invalid lip/lport/port parameter.
This also fixes compiler warnings.

diffstat:

 src/director/login-connection.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (20 lines):

diff -r 009648acd7fb -r 333533e2d231 src/director/login-connection.c
--- a/src/director/login-connection.c	Wed Apr 29 17:43:13 2015 +0200
+++ b/src/director/login-connection.c	Wed Apr 29 17:45:30 2015 +0200
@@ -162,13 +162,13 @@
 			host = TRUE;
 		else if (strncmp(*args, "lip=", 4) == 0) {
 			if (net_addr2ip((*args) + 4, &temp_request.local_ip) < 0)
-				;
+				i_error("auth sent invalid lip field: %s", (*args) + 6);
 		} else if (strncmp(*args, "lport=", 6) == 0) {
 			if (str_to_uint((*args) + 6, &temp_request.local_port) < 0)
-				;
+				i_error("auth sent invalid lport field: %s", (*args) + 6);
 		} else if (strncmp(*args, "port=", 5) == 0) {
 			if (str_to_uint((*args) + 5, &temp_request.dest_port) < 0)
-				;
+				i_error("auth sent invalid port field: %s", (*args) + 6);
 		} else if (strncmp(*args, "destuser=", 9) == 0)
 			username = *args + 9;
 		else if (strncmp(*args, "director_tag=", 13) == 0)