dovecot-2.2: lib-http: Removed "pure" attribute from http_header...

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot-2.2/rev/5e18e1386600
changeset: 19221:5e18e1386600
user:      Timo Sirainen <tss at iki.fi>
date:      Sun Sep 27 18:58:08 2015 +0300
description:
lib-http: Removed "pure" attribute from http_header_field_find_unique().
It's a bit questionable if returning a pointer via parameter is allowed for
a pure function. Also having this attribute seems to confuse clang static
analyzer, because it gives false positives for code using
http_header_field_find_unique(). It's not important for performance anyway,
so better to avoid using it.

diffstat:

 src/lib-http/http-header.h |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diffs (11 lines):

diff -r fbff1e801300 -r 5e18e1386600 src/lib-http/http-header.h
--- a/src/lib-http/http-header.h	Fri Sep 25 18:16:56 2015 +0300
+++ b/src/lib-http/http-header.h	Sun Sep 27 18:58:08 2015 +0300
@@ -40,6 +40,6 @@
 http_header_field_get(const struct http_header *header, const char *name)
 	ATTR_PURE;
 int http_header_field_find_unique(const struct http_header *header,
-	const char *name, const struct http_header_field **hfield_r) ATTR_PURE;
+	const char *name, const struct http_header_field **hfield_r);
 
 #endif