[dovecot/core] fe9459: lib-storage: If mailbox_move() fails, reset mail_s...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: fe9459ab43300c912dc4b16b8872411337f3a25f
      https://github.com/dovecot/core/commit/fe9459ab43300c912dc4b16b8872411337f3a25f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-09-29 (Thu, 29 Sep 2016)

  Changed paths:
    M src/lib-storage/mail-storage.c

  Log Message:
  -----------
  lib-storage: If mailbox_move() fails, reset mail_save_context.moving==FALSE


  Commit: 05150df8fbda6b8fdfafcfb0aa9003f1da4ecaca
      https://github.com/dovecot/core/commit/05150df8fbda6b8fdfafcfb0aa9003f1da4ecaca
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-09-29 (Thu, 29 Sep 2016)

  Changed paths:
    M src/lib-storage/mail-copy.c
    M src/lib-storage/mail-storage-private.h
    M src/lib-storage/mail-storage.c

  Log Message:
  -----------
  lib-storage: Don't reset mail_save_context.saving too early.

If mailbox_save_using_mail() ended up in mail_storage_copy(), saving was set
to FALSE before the copy() method was finished running. This caused e.g.
notify plugin to think that this was a copy event instead of a save event.

Added comments and asserts to clarify how the logic should work between
all the different copying/moving/saving flags.


Compare: https://github.com/dovecot/core/compare/042c55b2fd8c...05150df8fbda