[dovecot/core] cbf8b2: var-expand-crypt: Do not free dcrypt context twice

Mon Apr 3 14:30:13 EEST 2017

  Branch: refs/heads/master-2.2
  Home:   https://github.com/dovecot/core
  Commit: cbf8b2a12fa6f1c705aed2c7caaf999dd3518829
      https://github.com/dovecot/core/commit/cbf8b2a12fa6f1c705aed2c7caaf999dd3518829
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-04-03 (Mon, 03 Apr 2017)

  Changed paths:
    M src/plugins/var-expand-crypt/var-expand-crypt-plugin.c

  Log Message:
  -----------
  var-expand-crypt: Do not free dcrypt context twice

Found by coverity

  Commit: ba0aa2d1b71829a760d21e23ec847a479ef08023
      https://github.com/dovecot/core/commit/ba0aa2d1b71829a760d21e23ec847a479ef08023
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-04-03 (Mon, 03 Apr 2017)

  Changed paths:
    M src/plugins/var-expand-crypt/var-expand-crypt-plugin.c

  Log Message:
  -----------
  var-expand-crypt: Add error handling for initialization

  Commit: bb8b63efcd303af12e86341ebf7612c0c3f4bf91
      https://github.com/dovecot/core/commit/bb8b63efcd303af12e86341ebf7612c0c3f4bf91
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-04-03 (Mon, 03 Apr 2017)

  Changed paths:
    M src/plugins/var-expand-crypt/var-expand-crypt-plugin.c

  Log Message:
  -----------
  var-expand-crypt: Fix data decryption

  Commit: 0545e6b8c0d5864b3473f0636f977b954934b496
      https://github.com/dovecot/core/commit/0545e6b8c0d5864b3473f0636f977b954934b496
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-03 (Mon, 03 Apr 2017)

  Changed paths:
    M src/imap/cmd-idle.c

  Log Message:
  -----------
  imap: Fix assert-crash when hibernation triggers during IDLE syncing

Fixes:
Panic: file cmd-idle.c: line 182 (idle_hibernate_timeout): assertion failed: (ctx->sync_ctx == NULL)

  Commit: 549888de08e03ae4e4649ebf9f5fe6f8647d5840
      https://github.com/dovecot/core/commit/549888de08e03ae4e4649ebf9f5fe6f8647d5840
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-03 (Mon, 03 Apr 2017)

  Changed paths:
    M src/lib-fs/fs-api.c

  Log Message:
  -----------
  lib-fs: Allow fs_set_metadata() to update already added metadata.

Previously we were just appending the metadata multiple times with different
values, which could have caused problems.

  Commit: 738f09fb1323ebfe268432b0cf730241e0054809
      https://github.com/dovecot/core/commit/738f09fb1323ebfe268432b0cf730241e0054809
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-03 (Mon, 03 Apr 2017)

  Changed paths:
    M src/lib-fs/fs-api.c
    M src/lib-fs/fs-api.h

  Log Message:
  -----------
  lib-fs: Add FS_METADATA_ORIG_PATH

This allows fs backends to keep track of the original filename and use it
for logging purposes and such.

  Commit: f2ed4eff7a2baa4924e361ce021c8d76c37898ca
      https://github.com/dovecot/core/commit/f2ed4eff7a2baa4924e361ce021c8d76c37898ca
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-03 (Mon, 03 Apr 2017)

  Changed paths:
    M src/lib-index/mail-index-transaction-update.c

  Log Message:
  -----------
  lib-index: Assert in mail_index_append_finish_uids() to prevent UID wrapping

This should be handled better eventually, but it's better to crash earlier
now than later. This avoids a later assert:

Panic: file mail-index-transaction-finish.c: line 187 (mail_index_transaction_get_uid): assertion failed: (rec->uid != 0)

  Commit: b73b1f9e24f4bfa29eeb6b731f99eedc9c3d9580
      https://github.com/dovecot/core/commit/b73b1f9e24f4bfa29eeb6b731f99eedc9c3d9580
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-03 (Mon, 03 Apr 2017)

  Changed paths:
    M src/lmtp/main.c

  Log Message:
  -----------
  lmtp: Die at startup if config reading fails.

Although most of the time it's not strictly required for config to be read here,
one exception is SSL server settings. If this config reading fails, the SSL
initialization just crashes. So this gives a better error message than a crash.
Also config reading really isn't supposed to fail anyway.

  Commit: d4b3a9bae2d28a2d5df19887cb304f8e715eb978
      https://github.com/dovecot/core/commit/d4b3a9bae2d28a2d5df19887cb304f8e715eb978
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-04-03 (Mon, 03 Apr 2017)

  Changed paths:
    M src/lib/var-expand.c

  Log Message:
  -----------
  lib: Fix strcasecmp mistake in var-expand

  Commit: c8379b41835b3605e293ba9d2dd6b54c9b0d5edd
      https://github.com/dovecot/core/commit/c8379b41835b3605e293ba9d2dd6b54c9b0d5edd
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-04-03 (Mon, 03 Apr 2017)

  Changed paths:
    M src/lib-http/http-client-connection.c
    M src/lib-http/http-client-request.c
    M src/lib-http/http-client.h

  Log Message:
  -----------
  lib-http: client: Implemented means to obtain request statistics.

  Commit: 0713b92ce320d7c3768793fa4d67c340c66de0de
      https://github.com/dovecot/core/commit/0713b92ce320d7c3768793fa4d67c340c66de0de
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-03 (Mon, 03 Apr 2017)

  Changed paths:
    M src/lib-index/mail-transaction-log-file.c
    M src/lib-index/mail-transaction-log.h

  Log Message:
  -----------
  lib-index: Add macros to check if transaction log file version is new enough.

The version numbers are 8bit, so we can generate a single 16bit number out
of them.

  Commit: b6a369a3dc1ceb4e9f328e642df35f55cbc6ccbc
      https://github.com/dovecot/core/commit/b6a369a3dc1ceb4e9f328e642df35f55cbc6ccbc
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-03 (Mon, 03 Apr 2017)

  Changed paths:
    M src/doveadm/doveadm-dump-log.c
    M src/lib-index/mail-index-transaction-export.c
    M src/lib-index/mail-transaction-log-append.c
    M src/lib-index/mail-transaction-log-file.c
    M src/lib-index/mail-transaction-log-private.h
    M src/lib-index/mail-transaction-log-view.c
    M src/lib-index/mail-transaction-log.c
    M src/lib-index/mail-transaction-log.h
    M src/lib-index/test-mail-transaction-log-append.c
    M src/lib-index/test-mail-transaction-log-view.c

  Log Message:
  -----------
  lib-index: Don't increase modseq for backend/dirty flag changes

These flags are used only for internal changes and they shouldn't be
triggering any modseq changes.

To avoid modseqs from unexpectedly shrinking, the new modseq counting
behavior is enabled only for newly rotated transaction log files that have
a new minor_version.

  Commit: b6726aea8504847e9eb73cfb1af22a63931b42b8
      https://github.com/dovecot/core/commit/b6726aea8504847e9eb73cfb1af22a63931b42b8
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-03 (Mon, 03 Apr 2017)

  Changed paths:
    M src/lib-storage/mail-storage-private.h
    M src/lib-storage/mail-storage.c
    M src/lib-storage/mail-storage.h

  Log Message:
  -----------
  lib-storage: Add mailbox_set_reason()

Use it to log a debug message when mailbox is being opened.

  Commit: 1365792365880f1db3c882f7ab0ebe2bee2cb00f
      https://github.com/dovecot/core/commit/1365792365880f1db3c882f7ab0ebe2bee2cb00f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-03 (Mon, 03 Apr 2017)

  Changed paths:
    M src/doveadm/doveadm-mail-copymove.c
    M src/doveadm/doveadm-mail-import.c
    M src/doveadm/doveadm-mail-index.c
    M src/doveadm/doveadm-mail-iter.c
    M src/doveadm/doveadm-mail-mailbox-metadata.c
    M src/doveadm/doveadm-mail-mailbox-status.c
    M src/doveadm/doveadm-mail-mailbox.c
    M src/doveadm/doveadm-mail-save.c
    M src/doveadm/doveadm-mail.c
    M src/imap/cmd-create.c
    M src/imap/cmd-delete.c
    M src/imap/cmd-getmetadata.c
    M src/imap/cmd-notify.c
    M src/imap/cmd-rename.c
    M src/imap/cmd-resetkey.c
    M src/imap/cmd-select.c
    M src/imap/cmd-setmetadata.c
    M src/imap/cmd-subscribe.c
    M src/imap/imap-commands-util.c
    M src/imap/imap-notify.c
    M src/imap/imap-state.c
    M src/imap/imap-status.c
    M src/indexer/master-connection.c
    M src/lib-imap-storage/imap-metadata.c
    M src/lib-imap-storage/imap-msgpart-url.c
    M src/lib-imap-urlauth/imap-urlauth-backend.c
    M src/lib-lda/mail-deliver.c
    M src/lib-storage/index/dbox-multi/mdbox-storage-rebuild.c
    M src/lib-storage/mail-autoexpunge.c
    M src/lib-storage/mail-storage.c
    M src/lmtp/commands.c
    M src/plugins/lazy-expunge/lazy-expunge-plugin.c
    M src/plugins/pop3-migration/pop3-migration-plugin.c
    M src/plugins/quota/quota-count.c
    M src/plugins/quota/quota-status.c
    M src/plugins/trash/trash-plugin.c
    M src/plugins/virtual/virtual-config.c
    M src/plugins/virtual/virtual-storage.c
    M src/pop3/pop3-client.c

  Log Message:
  -----------
  global: Add mailbox_set_reason() calls

Added to the most important places.

  Commit: d28d40b18c2e0105502cd67ac8f8be981fc02f24
      https://github.com/dovecot/core/commit/d28d40b18c2e0105502cd67ac8f8be981fc02f24
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-03 (Mon, 03 Apr 2017)

  Changed paths:
    M src/lib-storage/index/index-transaction.c
    M src/lib-storage/mail-storage-private.h
    M src/lib-storage/mail-storage.c
    M src/lib-storage/mail-storage.h

  Log Message:
  -----------
  lib-storage: Add mailbox_transaction_set_reason()

  Commit: cbe889f7623b337c2996007a11fdf0bfe175764e
      https://github.com/dovecot/core/commit/cbe889f7623b337c2996007a11fdf0bfe175764e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-03 (Mon, 03 Apr 2017)

  Changed paths:
    M src/imap/cmd-append.c
    M src/imap/cmd-copy.c
    M src/imap/cmd-fetch.c
    M src/imap/cmd-select.c
    M src/imap/cmd-store.c
    M src/imap/cmd-thread.c
    M src/imap/imap-commands-util.c
    M src/imap/imap-commands-util.h
    M src/imap/imap-expunge.c
    M src/imap/imap-fetch.c
    M src/imap/imap-fetch.h
    M src/imap/imap-search.c
    M src/imap/imap-state.c
    M src/imap/imap-sync.c
    M src/indexer/master-connection.c
    M src/lib-storage/index/index-mailbox-size.c
    M src/lib-storage/mail-autoexpunge.c
    M src/plugins/quota/quota-storage.c

  Log Message:
  -----------
  global: Add mailbox_transaction_set_reason() calls

Added to the most important places.

  Commit: 9ddb3f76fccc7e2a56d6cddff535a7490c64a876
      https://github.com/dovecot/core/commit/9ddb3f76fccc7e2a56d6cddff535a7490c64a876
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2017-04-03 (Mon, 03 Apr 2017)

  Changed paths:
    M src/doveadm/doveadm-mail-import.c

  Log Message:
  -----------
  doveadm: Call mailbox_set_reason with initialized mailbox

  Commit: dbed1a0ffeaae2a4691969bbdbf1e24adaa6576d
      https://github.com/dovecot/core/commit/dbed1a0ffeaae2a4691969bbdbf1e24adaa6576d
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-03 (Mon, 03 Apr 2017)

  Changed paths:
    M src/director/mail-host.c

  Log Message:
  -----------
  director: Fix mail_hosts_dup() to duplicate tags correctly.

The host->tag pointed to the old hosts list. Also the new hosts list's tags
array wasn't filled.

This fixes USER-LOOKUP to return host with default configuration, which fixes
doveadm director status <user> to not show "Initial config" as empty.

Compare: https://github.com/dovecot/core/compare/c2f200c78720...dbed1a0ffeaa