[dovecot/core] a846e6: push-notification: Switch to main ioloop while cal...

GitHub noreply at github.com
Wed Aug 9 16:00:10 EEST 2017


  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: a846e6d6b4f1e9fcef4c07a5982b243a274f0a42
      https://github.com/dovecot/core/commit/a846e6d6b4f1e9fcef4c07a5982b243a274f0a42
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-08-09 (Wed, 09 Aug 2017)

  Changed paths:
    M src/plugins/push-notification/push-notification-plugin.c

  Log Message:
  -----------
  push-notification: Switch to main ioloop while calling drivers' deinit/cleanup callbacks

Continues a44595f7b1afc7ccbd8653598753b32899d01c76 to other functions.
For example the OX backend would call http_client_wait(), which would move
the I/Os and timeouts to the current ioloop, which might not be main_ioloop
always. When that ioloop gets destroyed, I/O and timeout leaks are logged
and eventually the process crashes when calling http_client_deinit() in
cleanup() (this would happen later for another mail_user).


  Commit: c0c346d0e6a76137ba5006857ed03b1227804170
      https://github.com/dovecot/core/commit/c0c346d0e6a76137ba5006857ed03b1227804170
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-08-09 (Wed, 09 Aug 2017)

  Changed paths:
    M src/lib-storage/mail-storage-private.h
    M src/lib-storage/mail-storage.c
    M src/lib-storage/mailbox-attribute.c

  Log Message:
  -----------
  lib-storage: Panic if at mailbox_free() there are open attribute iterators.


  Commit: db19aa0cec905a84d2b5e63d5f46bbf930ae0f28
      https://github.com/dovecot/core/commit/db19aa0cec905a84d2b5e63d5f46bbf930ae0f28
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-08-09 (Wed, 09 Aug 2017)

  Changed paths:
    M src/lib/ioloop.c

  Log Message:
  -----------
  lib: When logging I/O or timeout leak, log also raw backtrace

This can be useful when trying to figure out where the io_loop_destroy() was
called from.


  Commit: b0ead8fffe8dfdee92fca875b91fadf3f3f2262b
      https://github.com/dovecot/core/commit/b0ead8fffe8dfdee92fca875b91fadf3f3f2262b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-08-09 (Wed, 09 Aug 2017)

  Changed paths:
    M src/doveadm/dsync/dsync-mailbox-import.c

  Log Message:
  -----------
  dsync: Add missing transaction flags when performing UID renumbering

The transaction didn't have MAILBOX_TRANSACTION_FLAG_SYNC or
MAILBOX_TRANSACTION_FLAG_NO_NOTIFY (with DSYNC_BRAIN_FLAG_NO_NOTIFY).

This caused replication-dsync to unnecessarily trigger another dsync
replication notification.


Compare: https://github.com/dovecot/core/compare/65b82c99b1db...b0ead8fffe8d


More information about the dovecot-cvs mailing list