[dovecot/core] a9a011: lib-master: Allow userdb to return postlogin socke...

[GitHub]

  Branch: refs/heads/master-2.2
  Home:   https://github.com/dovecot/core
  Commit: a9a011b6bf5307ce506bb0ceb5e36f70ab3e77a6
      https://github.com/dovecot/core/commit/a9a011b6bf5307ce506bb0ceb5e36f70ab3e77a6
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-08-14 (Mon, 14 Aug 2017)

  Changed paths:
    M src/lib-master/master-login.c

  Log Message:
  -----------
  lib-master: Allow userdb to return postlogin socket path.

Returning "postlogin=socketpath" as userdb extra field overrides the
postlogin socket path in the service { executable } parameter.


  Commit: ad10830805ebf6a087255fb929312a51b1eb29e9
      https://github.com/dovecot/core/commit/ad10830805ebf6a087255fb929312a51b1eb29e9
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-08-14 (Mon, 14 Aug 2017)

  Changed paths:
    M src/lib-index/mail-transaction-log-file.c

  Log Message:
  -----------
  lib-index: Fix modseq tracking for MAIL_INDEX_MAIL_FLAG_UPDATE_MODSEQ

This is used to increase modseq for mails when their private flags change.
Use an already existing MAIL_TRANSACTION_FLAG_UPDATE_IS_INTERNAL() that
does this properly.

(This change preserves another bug, which is fixed in the next commit.)


  Commit: 6dc9d7d1843fc66040768845772a4f8ccf4f6c51
      https://github.com/dovecot/core/commit/6dc9d7d1843fc66040768845772a4f8ccf4f6c51
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-08-14 (Mon, 14 Aug 2017)

  Changed paths:
    M src/lib-index/mail-transaction-log-file.c

  Log Message:
  -----------
  lib-index: Fix modseq tracking with multiple flag updates

The earlier code was checking only the first flag record update. If the
first one had only internal flag changes but (some of) the rest didn't,
the modseq wasn't counted correctly. This was probably pretty rare.


  Commit: 670ac7454247ab25a27410fba542f3a21ea20b6d
      https://github.com/dovecot/core/commit/670ac7454247ab25a27410fba542f3a21ea20b6d
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-08-14 (Mon, 14 Aug 2017)

  Changed paths:
    M src/lib-index/mail-index-modseq.c

  Log Message:
  -----------
  lib-index: Fix checking if modseq header is up-to-date

We were almost always assuming that it is.


  Commit: 6eb78e38ab27737cdaa59cae4009d87837925882
      https://github.com/dovecot/core/commit/6eb78e38ab27737cdaa59cae4009d87837925882
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-08-14 (Mon, 14 Aug 2017)

  Changed paths:
    M src/lib-index/mail-index-modseq.c

  Log Message:
  -----------
  lib-index: Update per-flag modseq value a bit more correctly.

This changes the code to be similar to the per-mail modseq updating in
mail_index_modseq_update(). It probably wasn't exactly wrong previously
either, but this change is required for the following commits.


  Commit: 85d78d5db6049ee1ed29d835ff2050f2ae39ffa2
      https://github.com/dovecot/core/commit/85d78d5db6049ee1ed29d835ff2050f2ae39ffa2
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-08-14 (Mon, 14 Aug 2017)

  Changed paths:
    M src/lib-index/mail-index-modseq.c

  Log Message:
  -----------
  lib-index: Fix setting highest_modseq correctly in mail_index_modseq_header

The internally counted ctx->highest_modseq wasn't correct if all of the
records weren't synced. This could have happened for various reasons.
Since the view's current log seq/offset is used for the header, we can
also use the current highest_modseq from the view as well and it's
guaranteed to be correct.

This fixes various potential problems with using QRESYNC and CONDSTORE
extensions. It also fixes potential errors with unhibernating imap
clients, including:

Error: .../dovecot.index.log: Transaction log changed unexpectedly, can't get modseq


  Commit: b31ba3c2601a3f25410c93c8152f903bd0ee0386
      https://github.com/dovecot/core/commit/b31ba3c2601a3f25410c93c8152f903bd0ee0386
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-08-14 (Mon, 14 Aug 2017)

  Changed paths:
    M src/lib-index/mail-index-modseq.c
    M src/lib-index/mail-index-modseq.h
    M src/lib-index/mail-index-sync-update.c

  Log Message:
  -----------
  lib-index: Remove tracking of mail_index_modseq_sync.highest_modseq

It's no longer necessary after the previous changes.


  Commit: 83877003162463d32f11744584a4dcb7004e53f2
      https://github.com/dovecot/core/commit/83877003162463d32f11744584a4dcb7004e53f2
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-08-14 (Mon, 14 Aug 2017)

  Changed paths:
    M src/lib-index/Makefile.am
    A src/lib-index/test-mail-transaction-log-file.c

  Log Message:
  -----------
  lib-index: Add unit test to mail_transaction_update_modseq()


  Commit: d9cfad23ba7e0fdffeca0c5ff96f03d5413f627a
      https://github.com/dovecot/core/commit/d9cfad23ba7e0fdffeca0c5ff96f03d5413f627a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-08-14 (Mon, 14 Aug 2017)

  Changed paths:
    M src/lib-index/test-mail-transaction-log-file.c

  Log Message:
  -----------
  lib-index: Add unit tests to mail_transaction_log_file_get_modseq_next_offset() and _get_highest_modseq_at()


  Commit: 7197306fce3dff0fd8b23765d62c3335ba101b0f
      https://github.com/dovecot/core/commit/7197306fce3dff0fd8b23765d62c3335ba101b0f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-08-14 (Mon, 14 Aug 2017)

  Changed paths:
    M src/lib-index/mail-transaction-log-file.c

  Log Message:
  -----------
  lib-index: Code cleanup - move code to get_modseq_next_offset_at()

In preparation for making the next commit smaller.


  Commit: f39bde1e1fb00905b71a4f2a793faea4b915e27b
      https://github.com/dovecot/core/commit/f39bde1e1fb00905b71a4f2a793faea4b915e27b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-08-14 (Mon, 14 Aug 2017)

  Changed paths:
    M src/lib-index/mail-index-sync.c
    M src/lib-index/mail-transaction-log-file.c
    M src/lib-index/mail-transaction-log-private.h
    M src/lib-index/mail-transaction-log.c
    M src/lib-index/test-mail-transaction-log-file.c

  Log Message:
  -----------
  lib-index: Fix wrong mail_index_modseq_header automatically

It happens only on the next sync, although that isn't actually guaranteed to
happen. Still, it happens almost always so this should be good enough.


Compare: https://github.com/dovecot/core/compare/586c11a1bb17...f39bde1e1fb0