[dovecot/core] 89b020: dict: Fix error logging if TIMESTAMP parameters ar...

[GitHub]

  Branch: refs/heads/master-2.2
  Home:   https://github.com/dovecot/core
  Commit: 89b0207307899cdc69a7a287aaf667dea3ad7217
      https://github.com/dovecot/core/commit/89b0207307899cdc69a7a287aaf667dea3ad7217
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-03 (Fri, 03 Feb 2017)

  Changed paths:
    M src/dict/dict-commands.c

  Log Message:
  -----------
  dict: Fix error logging if TIMESTAMP parameters are wrong.


  Commit: 504701e3a4fab2aa22da153c11f7461e7f705778
      https://github.com/dovecot/core/commit/504701e3a4fab2aa22da153c11f7461e7f705778
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-02-03 (Fri, 03 Feb 2017)

  Changed paths:
    M src/lib-http/http-client-peer.c

  Log Message:
  -----------
  lib-http: client: Respect the connection idle timeout, even when all queues have unlinked from a peer.

Otherwise, the DNS TTL timeout dictates the connection idle timeout in some situations.


  Commit: 2444e6039fa17e1cec42f5b874a88fa0eb638f60
      https://github.com/dovecot/core/commit/2444e6039fa17e1cec42f5b874a88fa0eb638f60
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-02-03 (Fri, 03 Feb 2017)

  Changed paths:
    M src/lib-http/http-client-queue.c
    M src/lib-http/test-http-client-errors.c

  Log Message:
  -----------
  lib-http: client: Fixed peer reconnection failure handling.

The addressed problem occurs in a very specific situation in which the original successful connection is dropped, yet a new connection fails.
It manifests as an assertion failure or panic:

Panic: file ioloop-epoll.c: line 189 (io_loop_handler_run_internal): assertion failed: (msecs >= 0)
Panic: BUG: No IOs or timeouts set. Not waiting for infinity.

The timing is very critical. However, this doesn't mean that the occurrence of this problem is very unlikely; it can happen frequently under high load.


  Commit: 3145333a5bde75c9d5b43c85661046fff2959aeb
      https://github.com/dovecot/core/commit/3145333a5bde75c9d5b43c85661046fff2959aeb
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-03 (Fri, 03 Feb 2017)

  Changed paths:
    M src/lib-storage/index/index-mail-headers.c

  Log Message:
  -----------
  lib-storage: Add assert to make sure header parsing isn't recursed


Compare: https://github.com/dovecot/core/compare/eb4f49379143...3145333a5bde