[dovecot/core] 90e417: auth: Code cleanup - Move userdb extra fields expo...

Mon Feb 6 08:30:11 UTC 2017

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 90e417d32e964691781c9b6423ab2966f4e48cf5
      https://github.com/dovecot/core/commit/90e417d32e964691781c9b6423ab2966f4e48cf5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M src/auth/auth-request.c

  Log Message:
  -----------
  auth: Code cleanup - Move userdb extra fields exporting to its own function

  Commit: ea7f7e1a7f428aff99404d68f989b8accc5d7c8a
      https://github.com/dovecot/core/commit/ea7f7e1a7f428aff99404d68f989b8accc5d7c8a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M src/auth/auth-request.c

  Log Message:
  -----------
  auth: Pass through passdb extra fields to auth-worker requests

  Commit: f6fd135d156e8af8178599e56744d0ab763749b1
      https://github.com/dovecot/core/commit/f6fd135d156e8af8178599e56744d0ab763749b1
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M src/lib-dict/dict-sql.c

  Log Message:
  -----------
  dict-sql: Move USING TIMESTAMP to correct location for INSERTs

  Commit: 74feb39854e50b644a070b27e952037353722932
      https://github.com/dovecot/core/commit/74feb39854e50b644a070b27e952037353722932
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M m4/ssl.m4
    M src/lib-ssl-iostream/iostream-openssl-context.c

  Log Message:
  -----------
  lib-ssl-iostream: Use RSA_generate_key_ex() if it exists

This avoids deprecation warnings about RSA_generate_key() in OpenSSL v1.1.

  Commit: 13479101da29577f7789d6f61faa1da3e2f7434a
      https://github.com/dovecot/core/commit/13479101da29577f7789d6f61faa1da3e2f7434a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M m4/ssl.m4
    M src/lib-ssl-iostream/iostream-openssl-common.c
    M src/lib-ssl-iostream/iostream-openssl.h

  Log Message:
  -----------
  lib-ssl-iostream: Use ASN1_STRING_get0_data() if it exists

This avoids deprecation warnings about ASN1_STRING_data() in OpenSSL v1.1.

  Commit: 803d5e00922fd90af4bb5d529eed7af37ea8174a
      https://github.com/dovecot/core/commit/803d5e00922fd90af4bb5d529eed7af37ea8174a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M m4/ssl.m4
    M src/lib-ssl-iostream/dovecot-openssl-common.c

  Log Message:
  -----------
  lib-ssl-iostream: Detect OpenSSL memory functions' parameters via configure

The version number check doesn't work correctly for LibreSSL.

  Commit: b91659702c83b8f144e369ad5fa82724242c210c
      https://github.com/dovecot/core/commit/b91659702c83b8f144e369ad5fa82724242c210c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M m4/ssl.m4
    M src/lib-ssl-iostream/dovecot-openssl-common.c

  Log Message:
  -----------
  lib-ssl-iostream: Detect OPENSSL_cleanup() via configure

It's ugly to have both OpenSSL version number check and a special LibreSSL
check.

  Commit: 04b6c66afd1aa12ff9bded2747a543dde39d6f9c
      https://github.com/dovecot/core/commit/04b6c66afd1aa12ff9bded2747a543dde39d6f9c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M src/lib-ssl-iostream/dovecot-openssl-common.c

  Log Message:
  -----------
  lib-ssl-iostream: Call OBJ_cleanup() for all OpenSSL versions

Just to reduce the #if checks that uglify the code.

  Commit: e93dc99f2b89533c4bc6af9d0d2852f83f0d5b9a
      https://github.com/dovecot/core/commit/e93dc99f2b89533c4bc6af9d0d2852f83f0d5b9a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M m4/ssl.m4
    M src/lib-ssl-iostream/dovecot-openssl-common.c

  Log Message:
  -----------
  lib-ssl-iostream: Detect whether to call ERR_remove_[thread_]state() via configure

  Commit: 5fc85eac8aa8b5663e62e3321c6617c27d670630
      https://github.com/dovecot/core/commit/5fc85eac8aa8b5663e62e3321c6617c27d670630
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M src/lib-dcrypt/test-crypto.c
    M src/lib-dcrypt/test-stream.c

  Log Message:
  -----------
  lib-dcrypt: If dcrypt can't be initialized, log also the reason.

This is very helpful when debugging linking issues.

  Commit: d7d1fec9fa3799aaa4c3339d26c610c043d59360
      https://github.com/dovecot/core/commit/d7d1fec9fa3799aaa4c3339d26c610c043d59360
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M src/lib-dcrypt/Makefile.am

  Log Message:
  -----------
  lib-dcrypt: Don't link liblib.la to libdcrypt_openssl.so

At best this does nothing, at worst (like with OSX) it duplicates the
entire liblib and creates split state between the two instances.

  Commit: fb8e12a317f617ebb5085c641b4b8025689274ab
      https://github.com/dovecot/core/commit/fb8e12a317f617ebb5085c641b4b8025689274ab
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M src/lib-dcrypt/Makefile.am

  Log Message:
  -----------
  lib-dcrypt: Remove unnecessary -shared link flag

Not sure if this is harmful, but since no other plugin uses this it's not
needed either.

  Commit: f089a10e4816e772992346c9837ec10db3894c65
      https://github.com/dovecot/core/commit/f089a10e4816e772992346c9837ec10db3894c65
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M src/lib-dcrypt/Makefile.am

  Log Message:
  -----------
  lib-dcrypt: Link unit tests with libssl_iostream.la

libssl_iostream_openssl.so requires this, and it doesn't get added from
anywhere automatically.

  Commit: 84e69f2ae895e8eaaee436fcdb82dfa5b67a88f8
      https://github.com/dovecot/core/commit/84e69f2ae895e8eaaee436fcdb82dfa5b67a88f8
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M src/lib-ssl-iostream/Makefile.am

  Log Message:
  -----------
  lib-ssl-iostream: Remove empty $(ssl_sources) from Makefile

  Commit: c6108c1bfa10d5fcd1def9c6a23ebcd5204d1775
      https://github.com/dovecot/core/commit/c6108c1bfa10d5fcd1def9c6a23ebcd5204d1775
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M src/lib-dcrypt/Makefile.am
    M src/lib-ssl-iostream/Makefile.am

  Log Message:
  -----------
  lib-ssl-iostream: Remove libdovecot_openssl_common.la

Using such a library results in the same code being duplicated (in OSX) in
both libssl_iostream_openssl.so and libdcrypt_openssl.so.  This breaks the
idea of openssl_init_refcount, because each one will have their own one.

libdcrypt_openssl.so now links to libssl_iostream_openssl.so, which
shouldn't really be a problem, because lib-ssl-iostream is part of the core
libdovecot.so already. It would have been possible to also install
libdovecot_openssl_common.so and link it to both libssl_iostream_openssl.so
and libdcrypt_openssl.so, but that seems unnecessarily complicated.

  Commit: 3c2e763ab035567b2081a805648537b27e7cbbcf
      https://github.com/dovecot/core/commit/3c2e763ab035567b2081a805648537b27e7cbbcf
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M src/lib-storage/mail-user.c

  Log Message:
  -----------
  lib-storage: Don't unnecessarily duplicate user's all setting strings

user->unexpanded_set and user->set have the same life-time, so they can
point to same strings.

  Commit: 34512eaad8b1b2f929e6d6e3a2f7252c29fba97b
      https://github.com/dovecot/core/commit/34512eaad8b1b2f929e6d6e3a2f7252c29fba97b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M src/lib-storage/mail-storage-service.c
    M src/lib-storage/mail-user.c
    M src/lib-storage/mail-user.h

  Log Message:
  -----------
  lib-storage: Don't duplicate service user's settings into mail_user

The mail_storage_service_user.user_set isn't used afterwards, so it can be
directly used to avoid wasting memory.

Compare: https://github.com/dovecot/core/compare/da61fd89fa06...34512eaad8b1