[dovecot/core] dc59f8: lib-storage: Use refcounting for mail_storage_serv...

[GitHub]

  Branch: refs/heads/master-2.2
  Home:   https://github.com/dovecot/core
  Commit: dc59f8c55c4ea86d6aef542d5d8ed0ff6a8159fe
      https://github.com/dovecot/core/commit/dc59f8c55c4ea86d6aef542d5d8ed0ff6a8159fe
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/lib-storage/mail-storage-service.c
    M src/lib-storage/mail-storage-service.h
    M src/lib-storage/mail-user.c

  Log Message:
  -----------
  lib-storage: Use refcounting for mail_storage_service_user

doveadm import was freeing the user too early, which resulted
mail_user._service_user pointing to freed memory. More importantly,
after 34512eaad8b1b2f929e6d6e3a2f7252c29fba97b user->set was pointing
to already freed memory.


  Commit: 533b30023779e381ac0440b122b1791bf6679ed5
      https://github.com/dovecot/core/commit/533b30023779e381ac0440b122b1791bf6679ed5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/doveadm/doveadm-auth-server.c
    M src/doveadm/doveadm-auth.c
    M src/doveadm/doveadm-mail-copymove.c
    M src/doveadm/doveadm-mail-import.c
    M src/doveadm/doveadm-mail.c
    M src/imap-urlauth/imap-urlauth-worker.c
    M src/imap/imap-client.c
    M src/imap/main.c
    M src/indexer/master-connection.c
    M src/lda/main.c
    M src/lmtp/client.c
    M src/lmtp/commands.c
    M src/plugins/mail-crypt/doveadm-mail-crypt.c
    M src/plugins/mail-crypt/mail-crypt-acl-plugin.c
    M src/plugins/mail-crypt/test-mail-key.c
    M src/plugins/quota/quota-status.c
    M src/pop3/pop3-client.c

  Log Message:
  -----------
  global: Replace mail_storage_service_user_free() with _unref()


  Commit: b61798c072511ffa91d433d425fd48fa0e940968
      https://github.com/dovecot/core/commit/b61798c072511ffa91d433d425fd48fa0e940968
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/plugins/quota/quota-storage.c

  Log Message:
  -----------
  quota: Don't log "Internal quota calculation error"

It's not very informative and we can't give a better error message without
changing the APIs. The real error should have been logged already anyway,
so this is just duplication of an error. I think originally this was added
because some backend forgot to log an error.


Compare: https://github.com/dovecot/core/compare/544a3921f705...b61798c07251