[dovecot/core] 20ce57: pop3c: Add no pipelining pop3c feature

Fri Feb 24 13:35:36 UTC 2017

  Branch: refs/heads/release-2.2.28
  Home:   https://github.com/dovecot/core
  Commit: 20ce57938537938aed7dd41dc274377849258921
      https://github.com/dovecot/core/commit/20ce57938537938aed7dd41dc274377849258921
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-02-20 (Mon, 20 Feb 2017)

  Changed paths:
    M src/lib-storage/index/pop3c/pop3c-client.c
    M src/lib-storage/index/pop3c/pop3c-client.h
    M src/lib-storage/index/pop3c/pop3c-mail.c
    M src/lib-storage/index/pop3c/pop3c-settings.c
    M src/lib-storage/index/pop3c/pop3c-settings.h
    M src/lib-storage/index/pop3c/pop3c-storage.c

  Log Message:
  -----------
  pop3c: Add no pipelining pop3c feature

This should help with certain broken pop3c
servers that advertise that they support pipelining
but they really don't.

  Commit: 5978243e3c1f44cbb3e55e204f00b5ad9986a9dc
      https://github.com/dovecot/core/commit/5978243e3c1f44cbb3e55e204f00b5ad9986a9dc
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-20 (Mon, 20 Feb 2017)

  Changed paths:
    M src/imap/cmd-fetch.c

  Log Message:
  -----------
  imap: Revert change to use [PARSE] in FETCH replies.

Lets leave this for v2.3. Apparently Roundcube has some workarounds that
assume [UNKNOWNCTE].

Partially reverts 8fe64e2af5b6ce7b6ffa6453beaf569dca089e59

  Commit: 18abea86df39f1d0d3752debad19d6183e3bc824
      https://github.com/dovecot/core/commit/18abea86df39f1d0d3752debad19d6183e3bc824
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-20 (Mon, 20 Feb 2017)

  Changed paths:
    M src/lib-compression/test-compression.c

  Log Message:
  -----------
  lib-compression: Fix test-compression to build without zlib

  Commit: 8609bf3875e8b10bce5c7f71c6f714887cea33af
      https://github.com/dovecot/core/commit/8609bf3875e8b10bce5c7f71c6f714887cea33af
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-02-20 (Mon, 20 Feb 2017)

  Changed paths:
    M src/lib-lda/mail-deliver.c

  Log Message:
  -----------
  lib-lda: Do not involve mail-deliver plugin unnecessarely

If no mail delivery by LDA/LMTP is being done, do not
hook into the process.

Fixes signal 11 crash with lazy-expunge.

  Commit: 21fa11e96edc07d22f7c9d3d1873652788061757
      https://github.com/dovecot/core/commit/21fa11e96edc07d22f7c9d3d1873652788061757
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-02-21 (Tue, 21 Feb 2017)

  Changed paths:
    M src/lib-oauth2/oauth2-introspect.c
    M src/lib-oauth2/oauth2-refresh.c
    M src/lib-oauth2/oauth2-token-validate.c

  Log Message:
  -----------
  lib-oauth2: Support basic authorization

  Commit: 555eef384077b2ae7bf1d1778ad5fb1195b06616
      https://github.com/dovecot/core/commit/555eef384077b2ae7bf1d1778ad5fb1195b06616
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-02-21 (Tue, 21 Feb 2017)

  Changed paths:
    M src/auth/db-oauth2.c

  Log Message:
  -----------
  auth: Make tokeninfo optional

It is not supported by all OAuth2 solutions

  Commit: 7de696768fa04cd0ba2fcf617ae74f764615f580
      https://github.com/dovecot/core/commit/7de696768fa04cd0ba2fcf617ae74f764615f580
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-02-21 (Tue, 21 Feb 2017)

  Changed paths:
    M src/auth/db-oauth2.c

  Log Message:
  -----------
  auth: Make sure tokeninfo or introspection URL is given

  Commit: 5de01bc575b2e01eba293ebb1551c33feb0fce26
      https://github.com/dovecot/core/commit/5de01bc575b2e01eba293ebb1551c33feb0fce26
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-21 (Tue, 21 Feb 2017)

  Changed paths:
    M src/lib-storage/index/index-mailbox-size.c
    M src/plugins/pop3-migration/pop3-migration-plugin.c

  Log Message:
  -----------
  lib-storage, pop3-migration: Reset lookup_abort before continuing to search

This doesn't really fix anything right now, but it'll allow adding the
asserts in the following commit.

  Commit: f398b7365449c698ac2d6e43f80483a293ac01cc
      https://github.com/dovecot/core/commit/f398b7365449c698ac2d6e43f80483a293ac01cc
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-21 (Tue, 21 Feb 2017)

  Changed paths:
    M src/lib-storage/index/index-search.c
    M src/lib-storage/index/index-sort.c

  Log Message:
  -----------
  lib-storage: Add asserts to make sure lookup_abort is being used correctly.

  Commit: 95d26b400d9ca27136d9237d1903fd36868e83e1
      https://github.com/dovecot/core/commit/95d26b400d9ca27136d9237d1903fd36868e83e1
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-21 (Tue, 21 Feb 2017)

  Changed paths:
    M src/lib-storage/list/mailbox-list-index.c

  Log Message:
  -----------
  lib-storage: Fix assert-crash on corrupted dovecot.list.index with name_id==0

Fixes:
Panic: file hash.c: line 213 (hash_table_insert_node): assertion failed: (key != NULL)

  Commit: d9343f584b9d925c22c0f8ae1f641d8e2681af27
      https://github.com/dovecot/core/commit/d9343f584b9d925c22c0f8ae1f641d8e2681af27
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-21 (Tue, 21 Feb 2017)

  Changed paths:
    M src/lib-sql/driver-cassandra.c

  Log Message:
  -----------
  cassandra: Don't use i_error() from non-main thread

It will only cause crashes. This was done only if the internal
communication pipe couldn't be written to, which was pretty unlikely
to happen.

  Commit: 40e985b4d3bd1ab232c90ef9133131b04104b526
      https://github.com/dovecot/core/commit/40e985b4d3bd1ab232c90ef9133131b04104b526
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-21 (Tue, 21 Feb 2017)

  Changed paths:
    M src/lmtp/commands.c

  Log Message:
  -----------
  lmtp: Fix lmtp_user_concurrency_limit when userdb changes the username

Anvil LOOKUP was done with the original username, while CONNECT/DISCONNECT
was done with the changed username. So LOOKUP always thought that there
were zero concurrent sessions for the user.

  Commit: 3f613b364d4e3c608c406b068b0bb8cefe9b9210
      https://github.com/dovecot/core/commit/3f613b364d4e3c608c406b068b0bb8cefe9b9210
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-21 (Tue, 21 Feb 2017)

  Changed paths:
    M src/lib-storage/index/index-search.c

  Log Message:
  -----------
  lib-storage: Fix mail.access_type for search prefetches

  Commit: 7db846a87ab1226c72a27952b8af14427b6d0d12
      https://github.com/dovecot/core/commit/7db846a87ab1226c72a27952b8af14427b6d0d12
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-mail-fetch.c

  Log Message:
  -----------
  imapc: Error handling wasn't setting storage error everywhere.

This would have used the previous error, which might not have been correct.

  Commit: 560f734b8c336bf5891630e5a361d683cdf8f5bd
      https://github.com/dovecot/core/commit/560f734b8c336bf5891630e5a361d683cdf8f5bd
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/imap/cmd-fetch.c
    M src/imap/imap-fetch.c
    M src/imap/imap-fetch.h

  Log Message:
  -----------
  imap: Fix error message in failed FETCH's NO reply.

This was broken only with the new imap_fetch_failure = no-after setting.

  Commit: b5b8b48b5550618aaacc464233724b581e3d1313
      https://github.com/dovecot/core/commit/b5b8b48b5550618aaacc464233724b581e3d1313
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/lib/test-utc-mktime.c
    M src/lib/utc-mktime.c
    M src/lib/utc-mktime.h

  Log Message:
  -----------
  lib: Accept leap second in utc_mktime

Accept leap second at any time in utc_mktime since utc_mktime is being
used before applying the timezone offset everywhere.

  Commit: c0ee6549dc2a191d745aae31b6b41a9c1b8f0055
      https://github.com/dovecot/core/commit/c0ee6549dc2a191d745aae31b6b41a9c1b8f0055
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/lib/test-utc-mktime.c

  Log Message:
  -----------
  lib: Place input/output of utc_mktime tests in one struct

Define both input and output of a utc_mktime test case in a single
struct so it is easier to follow and less error prone.

  Commit: ed083a3cec391ee078e6aec5534d109d202494fe
      https://github.com/dovecot/core/commit/ed083a3cec391ee078e6aec5534d109d202494fe
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/lib-mail/test-message-date.c

  Log Message:
  -----------
  lib-mail: Place input/output of message-date tests in one struct

Define both input and output of a message date test case in a single
struct so it is easier to follow and less error prone. Also add some
leap second tests.

  Commit: 511e9526553ff5019b0a6573e736e09c5d744e0d
      https://github.com/dovecot/core/commit/511e9526553ff5019b0a6573e736e09c5d744e0d
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/lib/test-utc-mktime.c

  Log Message:
  -----------
  lib: Fix test-utc-mktime with 32bit time_t

  Commit: 8e2e0028c19d8441867b241bb8e3df172808bbba
      https://github.com/dovecot/core/commit/8e2e0028c19d8441867b241bb8e3df172808bbba
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/lib-lda/mail-deliver.c

  Log Message:
  -----------
  lib-lda: Refactor - Add struct mail_deliver_mailbox

  Commit: 9737f57f49e1acf3c2469b9af2d36592220be64b
      https://github.com/dovecot/core/commit/9737f57f49e1acf3c2469b9af2d36592220be64b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/lib-lda/mail-deliver.c

  Log Message:
  -----------
  lib-lda: Refactor - mail_deliver_log_update_cache() doesn't need entire deliver_ctx

  Commit: 181b3d6834619b9b9104e2ae16dbd44fb3e1f8a6
      https://github.com/dovecot/core/commit/181b3d6834619b9b9104e2ae16dbd44fb3e1f8a6
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/lib-lda/mail-deliver.c

  Log Message:
  -----------
  lib-lda: Fix delivery logging when Sieve performs multiple actions

Previous code assumed that it would work like:
 - save/copy
 - transaction commit
 - mail_deliver_ctx_get_log_var_expand_table()
 - repeat for transaction 2

While it really works:
 - transaction 1: save/copy
 - transaction 2: save/copy
 - transaction 1: commit
 - mail_deliver_ctx_get_log_var_expand_table()
 - transaction 2: commit
 - mail_deliver_ctx_get_log_var_expand_table()

So the cache needs to be stored per transaction. This code still wouldn't
work correctly if Sieve saved mails multiple times within the same
transaction, but that doesn't happen (at least currently).

  Commit: 220afa092f5fa6112b087474d3eaf7fb48fe3c30
      https://github.com/dovecot/core/commit/220afa092f5fa6112b087474d3eaf7fb48fe3c30
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/lib/test-utc-mktime.c

  Log Message:
  -----------
  lib: Fix again test-utc-mktime with 32bit time_t

  Commit: 7d58e42153761ce05f3219e977ae13856562a3b7
      https://github.com/dovecot/core/commit/7d58e42153761ce05f3219e977ae13856562a3b7
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/lib-lda/mail-deliver.c

  Log Message:
  -----------
  lib-lda: Fix pigeonhole testsuite to not crash

  Commit: 036e524dd9aa750ad3f41ca8c5973c9cc146ee75
      https://github.com/dovecot/core/commit/036e524dd9aa750ad3f41ca8c5973c9cc146ee75
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/lib-storage/mail-storage-service.c
    M src/lib-storage/mail-storage-service.h
    M src/lib-storage/mail-user.c

  Log Message:
  -----------
  lib-storage: Use refcounting for mail_storage_service_user

doveadm import was freeing the user too early, which resulted
mail_user._service_user pointing to freed memory. More importantly,
after 34512eaad8b1b2f929e6d6e3a2f7252c29fba97b user->set was pointing
to already freed memory.

  Commit: d5b90378b94e3bd16357db7896434715a232765d
      https://github.com/dovecot/core/commit/d5b90378b94e3bd16357db7896434715a232765d
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/doveadm/doveadm-auth-server.c
    M src/doveadm/doveadm-auth.c
    M src/doveadm/doveadm-mail-copymove.c
    M src/doveadm/doveadm-mail-import.c
    M src/doveadm/doveadm-mail.c
    M src/imap-urlauth/imap-urlauth-worker.c
    M src/imap/imap-client.c
    M src/imap/main.c
    M src/indexer/master-connection.c
    M src/lda/main.c
    M src/lmtp/client.c
    M src/lmtp/commands.c
    M src/plugins/mail-crypt/doveadm-mail-crypt.c
    M src/plugins/mail-crypt/mail-crypt-acl-plugin.c
    M src/plugins/mail-crypt/test-mail-key.c
    M src/plugins/quota/quota-status.c
    M src/pop3/pop3-client.c

  Log Message:
  -----------
  global: Replace mail_storage_service_user_free() with _unref()

  Commit: 5d5f9da2865c2857ffe86e4cfef65ef36dbd214e
      https://github.com/dovecot/core/commit/5d5f9da2865c2857ffe86e4cfef65ef36dbd214e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/plugins/quota/quota-storage.c

  Log Message:
  -----------
  quota: Don't log "Internal quota calculation error"

It's not very informative and we can't give a better error message without
changing the APIs. The real error should have been logged already anyway,
so this is just duplication of an error. I think originally this was added
because some backend forgot to log an error.

  Commit: f1e81f70e0b4c6f1194d07a1eb1471253b7cec70
      https://github.com/dovecot/core/commit/f1e81f70e0b4c6f1194d07a1eb1471253b7cec70
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/lib-mail/message-part-data.c

  Log Message:
  -----------
  lib-mail: Fix message_part_data_is_plain_7bit()

Content-Type parameters weren't handled exactly right.
Broken by recent changes.

  Commit: c0431a37c29763ba3e0e964c30f25140c536b19e
      https://github.com/dovecot/core/commit/c0431a37c29763ba3e0e964c30f25140c536b19e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/lib-storage/index/shared/shared-storage.c

  Log Message:
  -----------
  lib-storage: Add missing service_user ref when creating shared mailbox's user.

Was forgotten from d1bf4ae66b8bf3b9e28df1823d6d4adda2b923b6

Fixes:
Panic: file mail-storage-service.c: line 1513 (mail_storage_service_user_unref): assertion failed: (user->refcount > 0)

  Commit: 759fbc38776844474c32061f7fcdb7310786f716
      https://github.com/dovecot/core/commit/759fbc38776844474c32061f7fcdb7310786f716
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/plugins/lazy-expunge/lazy-expunge-plugin.c

  Log Message:
  -----------
  lazy-expunge: Fix error handling for GUID lookups

If the mail is already expunged, the error should be ignored.
In other situations the original error string should be preserved as
part of the logged error message.

  Commit: 81196773d98e1b525cd6b29a666b6b646d6ac04e
      https://github.com/dovecot/core/commit/81196773d98e1b525cd6b29a666b6b646d6ac04e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/plugins/expire/expire-plugin.c

  Log Message:
  -----------
  expire plugin: Use correct hook for overriding mail_user vfuncs

This was always wrong to do, and it crashes after
f32382d2da479a4371e08c443679528db37ea988

  Commit: 1ec93ed22322870cff660cf369c07edd96a1b90c
      https://github.com/dovecot/core/commit/1ec93ed22322870cff660cf369c07edd96a1b90c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/plugins/trash/trash-plugin.c

  Log Message:
  -----------
  trash plugin: Use correct hook for overriding mail_user vfuncs

This was always wrong to do, and it crashes after
f32382d2da479a4371e08c443679528db37ea988

  Commit: 923c50bf552ec2febbc35095d8c37749fb55b9dc
      https://github.com/dovecot/core/commit/923c50bf552ec2febbc35095d8c37749fb55b9dc
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/lib-storage/index/pop3c/pop3c-mail.c

  Log Message:
  -----------
  pop3c: Prefetched streams didn't call istream_opened() or set virtual_size

  Commit: 252e82b81f2f87148b1459eb1ab782f92707b3cf
      https://github.com/dovecot/core/commit/252e82b81f2f87148b1459eb1ab782f92707b3cf
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/lib-storage/index/pop3c/pop3c-mail.c

  Log Message:
  -----------
  pop3c: Remove unnecessarily duplicated code setting vsize to cache

This is important now that the vsize can be added also to index's vsize
extension.

  Commit: bc978f4fe7fd3b08a7d402e9a03bc52bbb5338fd
      https://github.com/dovecot/core/commit/bc978f4fe7fd3b08a7d402e9a03bc52bbb5338fd
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M src/lib-storage/index/maildir/maildir-mail.c

  Log Message:
  -----------
  maildir: Fix checking vsize caching decision in "is this pop3 user?"

If vsize extension is used, it's practically the same as if vsize's caching
decision was YES.

  Commit: 8dedd4c665f721ae45eadf7ee87f7dd6d068c260
      https://github.com/dovecot/core/commit/8dedd4c665f721ae45eadf7ee87f7dd6d068c260
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M NEWS
    M configure.ac

  Log Message:
  -----------
  v2.2.28.rc2 released

  Commit: 00d19e75dc9c4a9702ff5d1f9ee8037f157cc6d4
      https://github.com/dovecot/core/commit/00d19e75dc9c4a9702ff5d1f9ee8037f157cc6d4
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-02-23 (Thu, 23 Feb 2017)

  Changed paths:
    M src/plugins/virtual/virtual-sync.c

  Log Message:
  -----------
  virtual: Include virtual mailbox name in "Mailbox ID unexpectedly lost" error

  Commit: 5b2d58c347818e26bb3ebd7e904d8ce4c3803f16
      https://github.com/dovecot/core/commit/5b2d58c347818e26bb3ebd7e904d8ce4c3803f16
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-02-23 (Thu, 23 Feb 2017)

  Changed paths:
    M src/auth/db-oauth2.c

  Log Message:
  -----------
  auth: Export oauth2 pass_attrs to passdb reply

  Commit: bc35deed5cb7e89258521a0c00aa386ee029431d
      https://github.com/dovecot/core/commit/bc35deed5cb7e89258521a0c00aa386ee029431d
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-02-23 (Thu, 23 Feb 2017)

  Changed paths:
    M src/lib-http/http-client-private.h
    M src/lib-http/http-client-queue.c

  Log Message:
  -----------
  lib-http: client: Fixed i_unreached() failure occurring when a host's list of IPs changes while a connection is still pending.

In that case, the IP of the pending connection may no longer be associated with that host.
If the IP was not found anymore, the i_unreached() error occurred.

Compare: https://github.com/dovecot/core/compare/9049fe4442d6...bc35deed5cb7